cb268075c2
1) Added option to ignore the whitespaces while comparing objects in schema diff. Fixes #5468
...
2) Added server group name while selecting servers in schema diff. Fixes #5500
3) Fixed an issue where two identical tables showing different by schema diff tool. Fixes #5584
2020-06-17 16:27:51 +05:30
d43518cb3c
Fixed following issues reported by SonarQube:
...
1) Replace this if-then-else statement by a single return statement. (clumsy)
2) 'switch' statements should have at least 3 'case' clauses. (bad practice)
2020-06-16 15:00:51 +05:30
3e00fe2b0f
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation. Reported by SonarQube
2020-06-16 11:14:57 +05:30
697f4aec95
Fixed issue related to shadowing variables reported by SonarQube.
2020-06-16 10:47:40 +05:30
a21e6448ce
Fixed RESQL test cases, regression of RLS policy.
2020-06-15 17:10:25 +05:30
eb1b17b636
Fix 'expressions evaluated to true/false always' issue reported by SonarQube.
2020-06-15 16:50:07 +05:30
38cd3327f3
Ensure that pgadmin should be able to connect to the server which has password more than 1000 characters. Fixes #5592
2020-06-15 16:50:07 +05:30
8ab358ccec
Fix following issues reported by SonarQube:
...
1) Properties of variables with "null" or "undefined" values should not be accessed
2) Variables should not be self-assigned
3) "in" should not be used with primitive types
2020-06-15 16:50:07 +05:30
641f7bbe9d
Some clumsy coding related fixes reported by SonarQube.
2020-06-15 16:50:07 +05:30
18277543b6
Added support of Row Security Policies. Fixes #5516
2020-06-15 15:44:59 +05:30
8c20f0c0d2
Some clumsy coding related fixes reported by SonarQube.
2020-06-12 15:24:17 +05:30
ee1ea47e88
Fixed issue 'expects 4 arguments, but 5 were provided' reported by SonarQube.
2020-06-12 15:15:07 +05:30
82c4a4a03e
Improve code coverage and API test cases for Collations. Fixes #5325
2020-06-11 11:12:41 +05:30
5c60dcd501
Remove blank line at EOF.
2020-06-10 17:02:39 +01:00
85e89c869a
Cleanup some code smells identified by SonarQube.
2020-06-10 16:42:59 +01:00
726ecd79e6
Fixed import statements.
...
refs #3669
2020-06-03 12:49:05 +05:30
d22e276586
Ensure that proper error should be displayed for the deleted node. Fixes #3669
2020-06-03 11:26:26 +05:30
9b8902dfb8
Fixed the SQL help issue for EDB Postgres Advanced Server. Fixes #4099
2020-05-22 14:11:58 +05:30
7b1cac6914
Fixed an issue where clicking on Select All button, not selecting all the options in pgAgent job scheduler. Fixes #5496
2020-05-19 13:54:21 +05:30
9f445dc052
Improve code coverage and API test cases for Indexes. Fixes #5333
2020-05-18 12:29:33 +05:30
6d6cd19b37
Improve code coverage and API test cases for Triggers and Compound Triggers. Fixes #5335
2020-05-15 12:50:50 +05:30
073d90c4a6
Fixed internal server error when clicking on Triggers -> 'Enable All' for partitions. Fixes #5052
2020-05-11 15:18:39 +05:30
1294c089a8
Implement Selenium Grid to run multiple tests across different browsers, operating systems, and machines in parallel. Fixes #5255
2020-05-11 12:11:31 +05:30
b64896f558
Fixed generated SQL issue for auto vacuum options. Fixes #5398
...
Fixed some more issues:
1) pgAdmin allows only true or false values for autovacuum_enabled,
and there is no way to reset it individually without disabling a custom auto vacuum.
To fix this, the control is changed from the switch to three state buttons.
2) Setting any vacuum options to zero made the option disappear from the SQL.
3) Right-click on a table with vacuum options set and create a new table.
4) The parameters tab will have the options prefilled.
5) Changed the UI a bit to remove unnecessary space around. Added "Autovacuum" before enabled.
The SQL generated was appending a ".0" to decimal vacuum options. Changed to remove the leading ".0".
2020-05-08 14:30:30 +05:30
e73e2d2502
Fixed the errors, and warnings reported by pylama.
...
TODO::
- Don't use unicode in Python 3 for removing the support of Python 2 (
psycopg2 driver - __init__.py, server_manager.py).
- Merge the lastest pgcli (version: 3.0.0) for SQL autocompletion.
2020-05-08 14:13:38 +05:30
057a2b2312
Improve code coverage and API test cases for the Rules module. Fixes #5334
2020-05-07 16:27:58 +05:30
6ad46e1860
Fixed invalid literal issue when removing the connection limit for the existing role. Fixes #5001
2020-05-07 13:14:45 +05:30
a0940fd145
Typecast the object to 'text' before using it in length() function, so that correct length function gets called.
2020-05-06 17:34:18 +05:30
5fe7813f9f
Fixed an issue where select2 hover is inconsistent for the SSL field in create server dialog. Fixes #5469
2020-05-04 13:19:13 +05:30
d61b8eb1b3
Gracefully informed the user that the database is already connected when they click on 'Connect Database...'. Fixes #3694
2020-05-04 13:08:56 +05:30
0fc2afb829
Add Reverse Engineered and Modified SQL tests for Column and Type.
2020-05-04 12:48:24 +05:30
5656f756e6
Ensure that the dependencies tab shows correct information for Synonyms. Fixes #5422
2020-05-04 12:23:18 +05:30
ad80217593
Remove Python2 references from the source code.
...
refs #5443
Initial patch: Neel Patel
2020-04-30 17:22:48 +05:30
86afec860f
Remove Python 2 support from the Python tests.
...
refs #5443
2020-04-30 12:56:45 +05:30
88aebb64f9
Fixed failed to fetch utility error when click on refresh(any option) materialized view. Fixes #5447
...
It's a regression of #5213
2020-04-28 11:00:23 +05:30
18748846ef
Fixed the regression where initial changes make the Save button enabled when the table dialog is opened. Fixes #4504
2020-04-27 18:48:44 +05:30
76eb3e9b67
Fixed an issue when the user performs refresh on a large size materialized view. Fixes #5213
2020-04-27 17:30:23 +05:30
ef58d277ca
Fixed an issue where like options should be disabled if the relation is not selected while creating a table. Fixes #4504
2020-04-24 18:22:11 +05:30
aec64aa582
Fixed following issues for 1257:
...
1. For synonyms, the property is shown as "Public Synonym".
2. For system procedure, the flag should be True but it is displaying as False.
3. For both views and materialized views, the property is "System View".
4. For FTS templates, the property is showing as "System FTS Parser".
Fixes #1257
2020-04-24 16:35:59 +05:30
dfb74904ed
Ensure all object types have a System XXX? property. Fixes #1257
2020-04-23 17:31:40 +05:30
2b5c90e379
A warning message will be displayed only when the package header is changed for EPAS packages. Fixes #5410
2020-04-23 17:14:01 +05:30
6e5dbf7beb
Added multiple drop/delete functionality for the table constraints. Fixes #3900
2020-04-22 18:47:13 +05:30
858294f36e
Fixed validation errors in view/materialized view javascript to
...
determine the number columns chagned. It was trying to execute
'replace' and 'includes' function on undefined values instead of
string value.
Also - changed the warning message, and separated the 'Do you want to
continue?' syntax in separate line for better user experience.
Fixes #5053
2020-04-22 17:19:18 +05:30
4c616f32eb
1) Fixed feature test and API test cases.
...
2) Added logic to exclude RESQL test cases.
2020-04-22 13:57:32 +05:30
07f72252d7
Added job step and job schedule disable icons to identify it quickly within the browser tree. Fixes #4636
...
Add Reverse Engineered and Modified SQL tests for pgAgent jobs. Fixes #4623
Fixed modified SQL issue while adding an exception in pgAgent job schedule. Fixes #5356
2020-04-21 17:00:21 +05:30
f289dfb762
Fixed following issues for packages:
...
1) Removing the package header removes the body as well.
2) Schema is not visible on the properties dialog.
3) Reverse engineering SQL and Create script not showing schema-qualified packages.
Fixes #5410
2020-04-21 16:49:23 +05:30
4692b21bcf
Fixed an issue where schema diff marks an identical table as different. Fixes #5350
...
Fixed an issue where schema diff showing changes in the identical domain constraints. Fixes #5315
Ignore the keys from the source and target list and also sort both the lists.
2020-04-20 18:04:16 +05:30
36a3d4e53b
Some more gettext() usage fixes:
...
- fixed `%` vs. `.format()`
- unified texts and usage `%s` vs. `{}`/`{0}`
- improved text sentences for translate
- added gettext for next texts
2020-04-20 11:19:09 +05:30
d8ad0b8faf
Fixed validation issue in Synonyms node. Fixes #5409
2020-04-17 14:50:38 +05:30
c6deb9393c
Fixed an issue while removing the package body showing wrong modified SQL. Fixes #5410
2020-04-17 13:06:07 +05:30
dc1e32a632
Fixed internal server error when the database server is logged in with non-super user. Fixes #5400
2020-04-16 15:05:17 +05:30
eec2cfd5dd
Fixed an issue where the Mode cell of argument grid does not appear completely in the Functions dialog. Fixes #5375
2020-04-16 13:16:07 +05:30
d6cab7b421
Ensure the DROP statements in reverse engineered SQL are properly quoted for all objects. Fixes #4440
2020-04-16 13:06:50 +05:30
8254e9f030
Some minor gettext and format fixes.
2020-04-16 12:55:19 +05:30
7493649893
Added schema-qualified dictionary names in FTS configuration to avoid confusion of duplicate names. Fixes #4709
2020-04-16 12:47:00 +05:30
738c421edf
Ensure that Constraint Trigger, Deferrable, Deferred option should be disabled when the user selects EDB-SPL function for the trigger. Fixes #4957
2020-04-16 12:38:20 +05:30
31a929388b
Make changes to use gettext() function correctly.
2020-04-15 16:23:17 +05:30
0424f7d962
Fixed following issues for Procedures:
...
1) Change comments on the procedure with arguments as a procedure can be overloaded.
Note that on EPAS servers, procedure overloading works only for v11+.
2) The save button of a procedure dialog is enabled without any change.
3) Fixed formatting of the reverse-engineered SQL.
4) On EPAS servers, the parameters set were not displayed in the SQL generated.
They are visible only if set to edbsql.
5) Changing the volatility option of any existing procedure was not working.
6) Changing the parallel option (EPAS v9.6+) was not working.
7) Added RE-SQL test cases for procedures.
Fixes #4620 , Fixes #4873
2020-04-15 13:54:17 +05:30
8654d6cf43
Fixed an issue where the mode is not shown in the properties dialog of functions/procedures if all the arguments are IN arguments. Fixes #5387
2020-04-15 12:33:54 +05:30
3a4641889c
Using 'is_valid_ipaddress' utility function everywhere
2020-04-14 18:51:48 +05:30
6c5883bce0
We don't need to pass gettext for inline CSS transforation
2020-04-14 18:43:04 +05:30
d226ffbd1f
[Foreign Key] Removed 1 unexpected arguments; 'get_node_list' expects
...
5 positional arguments.
Also,
- Using 'gettext' instead of '_'.
- Using constant string for 'foreign_key not found' error message.
2020-04-14 18:40:15 +05:30
12530cd973
Ensure index dropdown should have existing indexes while creating unique constraints. Fixes #5007
2020-04-14 14:02:33 +05:30
a0fcb38e68
Fixed syntax error while refreshing the existing synonyms. Fixes #5383
2020-04-14 13:43:56 +05:30
a05acb4f99
Fixed tab key navigation for some dialogs. Fixes #5371
2020-04-14 13:32:03 +05:30
41521a9b98
Ensure all object names in the title line of the reverse-engineered SQL are not quoted. Fixes #4445
2020-04-14 13:02:58 +05:30
781b766ac4
Fixed an issue where difference SQL is not seen in the schema diff tool for Types. Fixes #5302
2020-04-13 20:24:12 +05:30
df11f28593
Fixed an issue where the identical packages and sequences visible as different in the schema diff tool. Fixes #5362
2020-04-13 18:06:20 +05:30
030741bba5
Modified some logic for the EPAS server as the user can change the view definition without dropping it. Fixes #5053
2020-04-13 16:00:01 +05:30
4de6b93ba8
Ensure that the password prompt should not be visible if the database server is in trust authentication mode. Fixes #2813
2020-04-10 17:03:04 +05:30
6a9af07f7a
Fixed gettext usage:
...
- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in the dialog.
- improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js,
word 'cancel' needs to be translated in the Czech language as 'zrušit' but in another sentence as 'zrušení')
- added gettext for text translations.
2020-04-10 14:52:41 +05:30
e238ecf182
Ensure that OID should be shown in properties for Synonyms. Fixes #5270
2020-04-10 13:19:52 +05:30
31f255b541
Added support of Foreign Tables to the Schema Diff. Fixes #5263
2020-04-09 21:03:28 +05:30
fecf3915c5
Fixed API/RESQL test cases for View/MView failed due to #5053 commit.
2020-04-09 21:03:28 +05:30
8a550b569f
Fixed expected output status code, as 410 should be the status code
...
for the object (CAST) not exists in the database server.
2020-04-08 16:51:53 +05:30
1a34f61b24
Moved the ip-address check functionality to a separate file to improve
...
the maintainability of the code.
2020-04-08 16:50:14 +05:30
775e61c248
Fixed pep8 issue
2020-04-08 14:34:34 +05:30
d9f6baac72
Various misc fixes:
...
- Using the 'gettext' as oppose to '_', which is not defined
- Define missing variables
- Fixed escape character in string with double quote
- Removed some dead code in a test case
- Removed unnecessary self assignment
Includes some fixes for Accessibility improvements
- Use semantic markup to mark emphasized or special text
- Added hidden legend in <fieldset> for better screen reader support
2020-04-08 14:14:25 +05:30
8fe687eb55
[Rules] Removing unnecessary 'if' condition
2020-04-08 13:14:14 +05:30
6c693d158e
[Exclusion Constraint] Fixed an typo - it should have been assignment
2020-04-08 13:05:28 +05:30
6b3e1f1e65
[TABLES] Do not assign the paramter values, use separate variable for new value
2020-04-08 13:04:24 +05:30
8fe344c268
[EDB Package Functions] [Functions] Fixed typos:
...
- 'gettext' should be used as '_' is not defined
- Identical expressions should not be used on both sides of a binary operator.
2020-04-08 13:02:37 +05:30
c7afa30d0c
[Packages] Fixed a typo
2020-04-08 13:00:49 +05:30
14f21921bb
[Functions] Fixed typos:
...
- 'gettext' should be used as '_' is not defined
- Identical expressions should not be used on both sides of a binary operator.
2020-04-08 13:00:01 +05:30
29ae6dfbf6
[FTS Configuration] Fixed an typo - it should have been assignment
2020-04-08 12:56:51 +05:30
a6c03a6b75
[Domain] Existing expression will expression will always result into false
2020-04-08 12:54:37 +05:30
068b812245
[COLLATIONS] Do not assign the paramter values, use separate variable for new value
2020-04-08 12:53:48 +05:30
a84a62def8
Using the 'gettext' as oppose to '_', which is not defined in these
...
files.
2020-04-08 12:34:57 +05:30
7f0847b95d
Using the 'gettext' as oppose to '_', which is not defined in the file
2020-04-08 12:29:11 +05:30
073e310a5a
[Accessibility] Use semantic markup to mark emphasized or special text.
...
Reference: https://www.w3.org/TR/WCAG20-TECHS/H49.html
2020-04-08 12:27:18 +05:30
f4607885e1
Fixed an issue where changing the columns in the existing view throws an error. Fixes #5053
...
PostgreSQL doesn't allow to change the view columns. So the view should be dropped first
and then recreate it and also the user will get a warning first.
2020-04-08 11:29:03 +05:30
e1f990190e
Added search object functionality. Fixes #2172
2020-04-06 17:33:07 +05:30
8ceeb39268
Fixed tab key navigation issue for parameters in table dialog. Fixes #5275
2020-04-06 13:13:21 +05:30
99e4c3350f
Fixed RESQL test cases for Packages.
2020-04-03 19:15:40 +05:30
ce89ae3c1d
Added support of Packages, Sequences and Synonyms to the Schema Diff. Fixes #5264
2020-04-03 16:52:45 +05:30
358c5d0a0f
Added support for parameter toast_tuple_target and parallel_workers of the table. Fixes #5181
...
Fixed an issue where the autovacuum_enabled parameter is added automatically in the RE-SQL
when the table has been created using the WITH clause. Fixes #5180
2020-04-01 18:19:55 +05:30
88a1e03314
Fixed generated SQL when any token in FTS Configuration or any option in FTS Dictionary is changed. Fixes #5268
2020-04-01 15:03:30 +05:30
86e4a88201
Added 'oid-2' to the ignore list of schema diff for all supported nodes. Fixes #5297
2020-03-27 15:27:48 +05:30
c002881f66
Added conkey and indkey to the ignore list for schema diff.
2020-03-27 14:41:18 +05:30
94a76cc9e0
Added support of Domain, Domain Constraints and Types to the Schema Diff. Fixes #5262
2020-03-26 14:30:09 +05:30
Akshay Joshi
Satish V
Aditya Toshniwal
Yogesh Mahajan
Mishika Singh
Khushboo Vashi
Pradip Parkale
Dave Page
Yogesh Jain
Ashesh Vashi
Ganesh Jaybhay
Murtuza Zabuawala
Neel Patel
Libor M
Shubham Agarwal