5a253f9053
Change the following to replace Python 2 code with Python 3:
...
1) Replace the deprecated unit test method.
2) Wraps filter usage in a list call.
3) Converts the old metaclass syntax to new.
4) Use range instead of xrange method.
5) Change Unicode to str.
6) Several other transformations.
7) Fixed change password test cases.
8) Use simplejson instead of plain JSON.
2020-08-31 16:45:31 +05:30
11d5613866
Fixed RESQL test cases for Roles module.
2020-08-28 18:22:25 +05:30
3984544bdb
Fixed code smell 'String literals should not be duplicated'.
2020-08-28 18:17:27 +05:30
e226b2fa75
Adjusted the height of jobstep code block to use maximum space. Fixes #5426 .
2020-08-28 14:00:49 +05:30
28b637c99c
Fixed RE-SQL test cases failed due to the previous commit.
...
Introduces a new key - replace_regex_pattern to synchronize the
expected SQL with the backend SQL based on the regex string
2020-08-27 19:08:00 +05:30
53a5410337
Fixed cognitive complexity issues and added some more RESQL test cases for roles module.
2020-08-27 13:09:22 +05:30
f3bde7b5f1
Ensure that schema names starting with 'pg' should be visible in browser tree when standard_conforming_strings is set to off. Fixes #4216
2020-08-26 18:16:16 +05:30
8fcf527632
Improve code coverage and API test cases for Columns and Constraints (Index, Foreign Key, Check, Exclusion). Fixes #5332
2020-08-26 12:35:22 +05:30
4eb17afe4e
Warn the user when connecting to a server that is older than pgAdmin supports. Fixes #5772
2020-08-25 17:18:43 +01:00
d2577e32e6
Fixed cognitive complexity issues reported by SonarQube.
2020-08-25 18:13:01 +05:30
e2ac6187dc
Fixed Jenkins build failure due to API test case failed.
2020-08-25 14:14:48 +05:30
df9aaf19c2
Fixed string indices must be integers issue for PostgreSQL < 9.3. Fixes #5766
2020-08-25 13:38:24 +05:30
275c671576
Fixed cognitive complexity issues reported by SonarQube.
2020-08-25 12:39:14 +05:30
86bbc3a9e8
Ensure that the user should be able to drop the database even if it is connected. Fixes #5722
2020-08-25 12:37:50 +05:30
b3d49c61a5
Fixed incorrect reverse engineering SQL for Foreign key when creating a table. Fixes #5748
2020-08-25 12:31:58 +05:30
7f947f146c
Fixed cognitive complexity issues reported by SonarQube.
2020-08-25 12:28:55 +05:30
52d0241a17
Fixed an issue where schema diff is not working when providing the options to Foreign Data Wrapper, Foreign Server, and User Mapping. Fixes #5754
2020-08-24 12:11:09 +05:30
b53de0c31d
Updated some more font awesome icons for v5
2020-08-21 14:15:18 +05:30
19491d79a5
Fixed cognitive complexity issues reported by SonarQube.
2020-08-21 13:52:05 +05:30
fbbbc36221
Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-08-20 20:26:51 +05:30
7f3e8596e3
Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-08-20 18:34:49 +05:30
103b08c9c5
Define constants for preferences label to fix SonarQube issues.
2020-08-20 17:58:37 +05:30
cc5a7ea334
Fixed code smell 'String literals should not be duplicated'.
...
Create a constant.py file which contains the common Constants.
2020-08-19 14:16:02 +05:30
4b56962c1b
Fixed cognitive complexity issues reported by SonarQube.
2020-08-19 13:41:53 +05:30
63df19ee1c
Fixed following schema diff issues:
...
1) Avoid template databases from the Database drop-down list.
2) Exclude system schemas while comparing two databases.
3) Escape group name for XSS.
2020-08-13 14:12:37 +05:30
93adf6884f
Upgrade font awesome from v4 to v5. Fixes #5731
2020-08-13 12:04:00 +05:30
36574b25b6
The 'str' object never has attribute decode in Python3, so remove the dead code.
2020-08-12 18:55:35 +05:30
7dd313f5fc
Fixed an issue where debugger doesn't work if the search path is set other than 'public'. Fixes #4123
2020-08-12 14:24:40 +05:30
8129df42da
Fixed cognitive complexity issues reported by SonarQube.
2020-08-11 15:13:35 +05:30
082b968bbc
Fixed following schema diff issues:
...
1) Wrong SQL generated for the columns having different data type.
2) Added 'castfunc' in the ignore list.
2020-08-11 14:42:32 +05:30
2907a79dd7
Added missing comments in reverse engineering SQL for each column of a View. Fixes #3791
2020-08-11 11:30:47 +05:30
46af290b85
Fixed API test cases for packages.
2020-08-10 18:13:00 +05:30
9d006d0ec5
Fixed cognitive complexity issues reported by SonarQube.
2020-08-10 16:30:07 +05:30
7a0bfecfc5
Use Python3 'ipaddress' module to validate the IPv4 and IPv6 addresses.
2020-08-10 15:57:25 +05:30
604937cf66
Fixed an issue where 'ALTER VIEW' statement is missing when the user sets the default value of a column for View. Fixes #5664
2020-08-10 15:27:57 +05:30
4f74609ecf
Modified schema diff tool to compare two databases instead of two schemas. Fixes #5126
2020-08-10 15:13:34 +05:30
9ad7476a34
Corrected DROP SQL syntax for catalog. Fixes #5713
2020-08-07 16:58:38 +05:30
518b13c779
Added the 'ORDER BY' clause for the privileges type to fix schema diff issue. Fixes #5689
2020-08-07 16:30:03 +05:30
d6400bbcae
Replace the generic exception class with a more specific one.
2020-08-07 12:37:00 +05:30
1122e06f48
Fixed cognitive complexity issues reported by SonarQube.
2020-08-06 12:38:35 +05:30
6a406f466d
Fixed cognitive complexity issues reported by SonarQube.
2020-08-05 13:00:44 +05:30
aa679e06b2
Replace the generic exception class with a more specific one to fix SonarQube issues.
2020-08-05 12:41:28 +05:30
5ce2773658
Ensure that the Dictionaries drop-down shows all the dictionaries in the FTS configuration dialog. Fixes #5429
2020-08-04 15:48:20 +05:30
87d08de3a0
Corrected the syntax as per jinja standards. refs #5632
2020-08-03 13:08:29 +05:30
536593bf8a
Fixed following SonarQube issues:
...
- Remove this assignment to the local variable, the value is never used.
- Rename local variables to match the regular expression
- Add logic to this except clause or eliminate it and rethrow the exception automatically.
- Rename fields to match the regular expression
- Extract this nested conditional expression into an independent statement.
- Change this default value to "None" and initialize this parameter inside the function/method.
- Update this function so that its implementation is not identical to __repr__
- Refactor this method to not always return the same value
- Reraise this exception to stop the application as the user expects
- Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
- Remove this redundant continue.
- Remove this unused function declaration
- Remove this identity check; it will always be False.
2020-08-03 12:59:51 +05:30
318d712c4f
Improve code coverage and API test cases for Schemas. Fixes #5327
2020-08-03 12:38:38 +05:30
56cf64ad22
Fixed following SonarQube issues:
...
- Refactor functions to not always return the same value.
- Rename "cls" to "self" or add the missing "self" parameter.
- Remove useless assignment to variables.
2020-07-30 14:04:22 +05:30
dd7eb54e90
Fixed an issue when comparing the table with a trigger throwing error in schema diff. Fixes #5710
2020-07-30 13:57:00 +05:30
89fa85d650
Fixed cognitive complexity issues reported by SonarQube.
2020-07-29 18:29:04 +05:30
74fd5dfe96
Ensure that the user will be able to modify the start value of the Identity column. Fixes #5632
2020-07-29 16:22:11 +05:30
287a6628ed
Improve code coverage and API test cases for Types. Fixes #5336
2020-07-29 15:41:04 +05:30
a0893fe43b
Fixed code smell 'variable shadows a builtin' reported by SonarQube.
2020-07-28 16:20:26 +05:30
fb0bc65ced
Fixed following SonarQube issues:
...
1) Define a constant instead of duplicating this literal.
2) Reduce cognitive complexity (Patch by Aditya)
2020-07-27 16:31:03 +05:30
f93cfe8c4c
Remove old Python 2 compatibility code. Fixes #5700
2020-07-27 11:03:13 +01:00
7a22cff28c
Fixed 'cannot unpack non-iterable Response object' issue.
2020-07-24 14:59:50 +05:30
4cf8c2f300
Improve code coverage and API test cases for Foreign Servers and User Mappings. Fixes #5324
2020-07-24 14:14:13 +05:30
937877e841
Ensure that RLS Policy node should be searchable using search object. Fixes #5646
2020-07-24 13:47:39 +05:30
dd27e08a98
Fixed code smell 'Unused local variables should be removed'.
2020-07-24 12:15:29 +05:30
1fbf298d30
Fixed cognitive complexity issues reported by SonarQube.
2020-07-24 12:03:05 +05:30
505a3ac960
1) Fixed cognitive complexity issues reported by SonarQube.
...
2) Fixed code smell 'Add a nested comment explaining why this method is
empty, or complete the implementation'.
2020-07-24 11:46:30 +05:30
28a4359020
Fixed issue where the user was not able to update policy if the policy is created with space. Fixes #5686
2020-07-21 18:14:49 +05:30
f177d54f21
Fixed AttributeError while creating the server group. Fixes #5688
2020-07-21 18:02:51 +05:30
7edcca9b07
Added High Contrast theme support. Fixes #5653
...
Fixed text color issue in explain analyze for the Dark theme. Fixes #5677
2020-07-20 11:51:21 +05:30
4e2c4b0498
Fixed cognitive complexity issues reported by SonarQube.
2020-07-17 15:31:04 +05:30
703faf3b15
Fixed following SoanrQube issues
...
1) Rename field "node_type" to prevent any misunderstanding/clash with field "NODE_TYPE" defined.
2) Define a constant instead of duplicating this literal.
Solution:
1) Rename the field "NODE_TYPE" and "COLLECTION_LABEL" to "_NODE_TYPE" and "_COLLECTION_LABEL"
2) Declare the constant in PGChildNodeView for SQL files.
2020-07-16 19:39:55 +05:30
5d8c79da38
Added docstrings for some newly created functions.
2020-07-15 18:07:54 +05:30
11c4877859
Fixed an issue where difference DDL is showing the wrong SQL when changing the policy owner. Fixes #5647
2020-07-15 14:52:14 +05:30
d6893f9d8a
Fixed reverse engineered SQL for partitions when storage parameters are specified. Fixes #5569 .
2020-07-14 19:16:33 +05:30
4f34bc0f0e
Added missing dependencies/dependent and corrected some wrongly identified. Fixes #5666
2020-07-14 18:34:50 +05:30
a91e4d8a7f
Improve code coverage and API test cases for Foreign Data Wrapper. Fixes #5323 .
2020-07-14 15:58:22 +05:30
0013a3b047
Fixed cognitive complexity issues reported by SonarQube.
2020-07-14 15:33:54 +05:30
d3eaac8609
Reverted fix for #5569 due to a couple of issues.
2020-07-11 20:32:57 +05:30
29175d7ec4
Fixed reverse engineered SQL for partitions when storage parameters are specified. Fixes #5569
2020-07-11 16:23:31 +05:30
e8b81db977
Fixed cognitive complexity issues reported by SonarQube.
2020-07-10 11:44:33 +05:30
7420673a0f
Improve code coverage and API test cases for FTS Configuration, FTS Parser, FTS Dictionaries, and FTS Template. Fixes #5329 .
2020-07-10 11:40:08 +05:30
e1168f8de0
Fixed code smell to reduce cognitive complexity.
2020-07-09 18:41:13 +05:30
916182f80f
Fixed code smell for variable naming convention.
2020-07-09 18:28:08 +05:30
c58fda0a70
Ensure that create RLS Policy menu should not be visible for catalog objects. Fixes #5633
2020-07-09 18:04:32 +05:30
b4c25bdc0a
Fixed code smell 'Functions, methods, and lambdas should not have too many parameters' reported by SonarQube.
2020-07-07 19:39:06 +05:30
36a2c073bd
Added support for permissive/restricted policy type while creating RLS Policy. Fixes #5622
2020-07-07 17:55:05 +05:30
aee6bac5ef
Fixed cognitive complexity code smell reported by SonarQube.
2020-07-07 15:19:47 +05:30
45a03dd663
Fixed 'convention' related code smell reported by SonarQube.
2020-07-06 11:48:23 +05:30
cb1cdd1b23
Modified EPAS templates to support schema restriction.
2020-07-03 18:42:17 +05:30
0d92059155
Fixed code smells having rule 'Functions, methods and lambdas should not have too many parameters'.
2020-07-03 18:37:37 +05:30
80ab596992
Fixed the SoanrQube code smell 'Variables should not be shadowed'.
2020-07-03 14:33:30 +05:30
b5f0190799
Fixed the SonarQube Code smells having Rule 'Functions, methods and lambdas should not have too many parameters'.
2020-07-03 14:24:54 +05:30
341c3aded6
Fixed dark theme-related CSS and modify the color codes. Fixes #5287
...
Fixed backgrid row hover issue where on hover background color is set for edit and delete cell only. Fixes #5470
2020-07-03 11:47:40 +05:30
1ab257d512
Fixed Cognitive Complexity code smell reproted by SonarQube.
2020-07-03 11:15:41 +05:30
1802f8a3f8
Ensure that the referenced table should be displayed on foreign key constraints. Fixes #5530
2020-07-02 16:21:56 +05:30
8b10315e2a
Added hints for 'Using' and 'With check' options of RLS Policy node.
2020-07-02 16:21:56 +05:30
0850db2a9b
Fixed database connection issue, regression of SonarQube fixes.
2020-07-01 17:32:22 +05:30
a881e4e3f8
Fix PEP8
2020-07-01 15:33:51 +05:30
192a446131
Fixed API test cases failing due to updating the server manager instance.
2020-07-01 15:29:59 +05:30
b30c590866
Fixed SonarQube code smell 'Rename function and variable name to match the regular expression'.
2020-07-01 13:50:51 +05:30
6dd3ca31be
Fixed SonarQube code smell 'Variables should not be shadowed'.
2020-07-01 13:43:00 +05:30
979f806161
1) Added RLS Policy support in Schema Diff. Fixes #5601
...
2) Fixed 'cant execute empty query' issue when remove the value of
'USING' or 'WITH CHECK' option of RLS Policy. Fixes #5631
2020-07-01 12:44:28 +05:30
21d57b1f10
Do not let browser autocomplete the password field while connecting a
...
database server.
Set the autocomplete attribute of the password field to 'new-password'
to let browser know, we require a new password for the password, and do
not autocomplete it.
2020-07-01 11:26:52 +05:30
c873218c32
Added support for schema level restriction. Fixes #5583
...
Allow user to edit the connection properties when the database server
is already connected.
2020-06-30 19:15:23 +05:30
6713bc068b
Fixed SonarQube code smells 'Refactor this function to reduce its Cognitive Complexity'.
2020-06-30 17:06:55 +05:30
46d26cd029
Remove extra brackets from reverse engineering SQL of RLS Policy. Fixes #5621
2020-06-30 16:11:02 +05:30
Cyril Jouve
Aditya Toshniwal
Yogesh Mahajan
Dave Page
Nikhil Mohite
Akshay Joshi
Pradip Parkale
Neel Patel
Rahul Shirsat
Khushboo Vashi
Satish V
Murtuza Zabuawala
Ashesh Vashi