Satish V
2e29f3fd6d
Fixed an issue where columns names should be visible in the order of their creation in the browser tree. Fixes #5043
2020-04-23 16:42:42 +05:30
Ashesh Vashi
637c80c38b
Recreate the node item in the tree, when 'id' has been changed of the node.
...
Fixes #5053
2020-04-23 11:11:15 +05:30
navnath gadakh
c76732e3e7
Ensure that default sort order should be using the primary key in View/Edit data. Fixes #5157
2020-04-22 18:47:13 +05:30
Khushboo Vashi
b0464500ca
Ensure that the user should not be able to change the authentication source. Fixes #5419
...
Ensure error should be handled properly when LDAP user is created with the same name. Fixes #5420
Fixed an issue where an internal user is not created if the authentication source is set to internal and ldap. Fixes #5432
2020-04-22 18:47:13 +05:30
Nagesh Dhope
5e91ed2bb1
Fixed slider jump issue by making an API call to fetch the next batch of rows only after a user stops scrolling down. Fixes #3269
2020-04-22 18:47:13 +05:30
Khushboo Vashi
6e5dbf7beb
Added multiple drop/delete functionality for the table constraints. Fixes #3900
2020-04-22 18:47:13 +05:30
Yogesh Jain
553eeb034d
Fixed tooltip crop issue for the large complex query with zoom factor. Fixes #5352
2020-04-22 18:47:13 +05:30
Ashesh Vashi
858294f36e
Fixed validation errors in view/materialized view javascript to
...
determine the number columns chagned. It was trying to execute
'replace' and 'includes' function on undefined values instead of
string value.
Also - changed the warning message, and separated the 'Do you want to
continue?' syntax in separate line for better user experience.
Fixes #5053
2020-04-22 17:19:18 +05:30
Akshay Joshi
4c616f32eb
1) Fixed feature test and API test cases.
...
2) Added logic to exclude RESQL test cases.
2020-04-22 13:57:32 +05:30
Nagesh Dhope
b29bc6868c
Fixed an issue where [null] and [default] values are not get copied. Part of #3947
2020-04-22 12:08:52 +05:30
Neel Patel
07f72252d7
Added job step and job schedule disable icons to identify it quickly within the browser tree. Fixes #4636
...
Add Reverse Engineered and Modified SQL tests for pgAgent jobs. Fixes #4623
Fixed modified SQL issue while adding an exception in pgAgent job schedule. Fixes #5356
2020-04-21 17:00:21 +05:30
Akshay Joshi
f289dfb762
Fixed following issues for packages:
...
1) Removing the package header removes the body as well.
2) Schema is not visible on the properties dialog.
3) Reverse engineering SQL and Create script not showing schema-qualified packages.
Fixes #5410
2020-04-21 16:49:23 +05:30
Nagesh Dhope
8d4f3c07c7
Fixed an issue where slider jumps up when new rows get loaded while scrolling down in the DataView panel in the query tool. Fixes #3269
2020-04-21 13:29:49 +05:30
Yogesh Jain
7e30a99937
Fixed the rightmost and bottom tooltip crop issues in the explain query plan. Fixes #5352
2020-04-21 13:14:26 +05:30
Pradip Parkale
3d516101a4
Fixed an issue wherein grant wizard the last object is not selectable. Fixes #4545
2020-04-21 13:09:15 +05:30
Aditya Toshniwal
05abb9e430
Ensure that the query tool context menu should work on the collection nodes. Fixes #5415
2020-04-20 18:50:20 +05:30
Aditya Toshniwal
dc4571a3c8
Fixed search object issue when the object name contains special characters. Fixes #5401
2020-04-20 18:40:40 +05:30
Aditya Toshniwal
7361470b64
Fixed an issue where the search object module unable to locate the object in the browser tree. Fixes #5396
2020-04-20 18:27:36 +05:30
Amol Vyavahare
f282b26883
Fixed an issue when the user creates a temporary table with 'on commit drop as' clause. Fixes #4946
2020-04-20 18:22:34 +05:30
Akshay Joshi
4692b21bcf
Fixed an issue where schema diff marks an identical table as different. Fixes #5350
...
Fixed an issue where schema diff showing changes in the identical domain constraints. Fixes #5315
Ignore the keys from the source and target list and also sort both the lists.
2020-04-20 18:04:16 +05:30
Libor M
36a3d4e53b
Some more gettext() usage fixes:
...
- fixed `%` vs. `.format()`
- unified texts and usage `%s` vs. `{}`/`{0}`
- improved text sentences for translate
- added gettext for next texts
2020-04-20 11:19:09 +05:30
Nagesh Dhope
8bdfa18efb
Ensure that if the delimiter is set other than comma then download the file as '.txt' file. Fixes #4573
2020-04-17 17:37:02 +05:30
Yogesh Jain
52d031f2d0
Fixed encoding issue while saving data in encoded charset other than 'utf-8'. Fixes #4684
2020-04-17 16:30:22 +05:30
Akshay Joshi
d8ad0b8faf
Fixed validation issue in Synonyms node. Fixes #5409
2020-04-17 14:50:38 +05:30
Akshay Joshi
c6deb9393c
Fixed an issue while removing the package body showing wrong modified SQL. Fixes #5410
2020-04-17 13:06:07 +05:30
Murtuza Zabuawala
d35433d0b8
Fixed an issue where the query tool unable to load the file which contains the BOM marker. Fixes #3495
2020-04-17 12:40:09 +05:30
Nagesh Dhope
0ce4f49e08
Fixed copy-paste row issues in View/Edit Data. Fixes #3947
...
1) Copy table rows across two or more active query tool sessions.
2) Copied rows can be pasted multiple times without selecting a row in the query tool grid.
3) Adds an empty row at the end in the query tool grid after pasting rows.
2020-04-16 15:25:39 +05:30
Aditya Toshniwal
dc1e32a632
Fixed internal server error when the database server is logged in with non-super user. Fixes #5400
2020-04-16 15:05:17 +05:30
navnath gadakh
c0a2f1f24d
Ensure that text larger than underlying field size should not be truncated automatically. Fixes #5210
2020-04-16 14:39:31 +05:30
Murtuza Zabuawala
eec2cfd5dd
Fixed an issue where the Mode cell of argument grid does not appear completely in the Functions dialog. Fixes #5375
2020-04-16 13:16:07 +05:30
Shubham Agarwal
d6cab7b421
Ensure the DROP statements in reverse engineered SQL are properly quoted for all objects. Fixes #4440
2020-04-16 13:06:50 +05:30
Libor M
8254e9f030
Some minor gettext and format fixes.
2020-04-16 12:55:19 +05:30
Ganesh Jaybhay
7493649893
Added schema-qualified dictionary names in FTS configuration to avoid confusion of duplicate names. Fixes #4709
2020-04-16 12:47:00 +05:30
Khushboo Vashi
738c421edf
Ensure that Constraint Trigger, Deferrable, Deferred option should be disabled when the user selects EDB-SPL function for the trigger. Fixes #4957
2020-04-16 12:38:20 +05:30
Murtuza Zabuawala
c41da41efe
Fixed python exception error when user tries to download the CSV and there is a connection issue. Fixes #4858
2020-04-15 16:46:03 +05:30
Khushboo Vashi
ed0a596286
Added alert message to Reset Layout if any of the panels from Query Tool failed to load. Fixes #5366
2020-04-15 16:23:54 +05:30
Aditya Toshniwal
31a929388b
Make changes to use gettext() function correctly.
2020-04-15 16:23:17 +05:30
Aditya Toshniwal
0424f7d962
Fixed following issues for Procedures:
...
1) Change comments on the procedure with arguments as a procedure can be overloaded.
Note that on EPAS servers, procedure overloading works only for v11+.
2) The save button of a procedure dialog is enabled without any change.
3) Fixed formatting of the reverse-engineered SQL.
4) On EPAS servers, the parameters set were not displayed in the SQL generated.
They are visible only if set to edbsql.
5) Changing the volatility option of any existing procedure was not working.
6) Changing the parallel option (EPAS v9.6+) was not working.
7) Added RE-SQL test cases for procedures.
Fixes #4620 , Fixes #4873
2020-04-15 13:54:17 +05:30
Shubham Agarwal
8654d6cf43
Fixed an issue where the mode is not shown in the properties dialog of functions/procedures if all the arguments are IN arguments. Fixes #5387
2020-04-15 12:33:54 +05:30
Dave Page
74b3495542
Warn the user if an unsupported, deprecated or unknown browser is detected. Fixes #5399
2020-04-14 21:15:02 +05:30
Ashesh Vashi
3a4641889c
Using 'is_valid_ipaddress' utility function everywhere
2020-04-14 18:51:48 +05:30
Ashesh Vashi
d9c84edf9a
A valid ip address can be IPv4/IPv6
2020-04-14 18:45:45 +05:30
Ashesh Vashi
a930c6617b
Merged adjustanct 'if' statements when allowed.
...
Also - removed the unused variables.
2020-04-14 18:43:04 +05:30
Ashesh Vashi
6c5883bce0
We don't need to pass gettext for inline CSS transforation
2020-04-14 18:43:04 +05:30
Ashesh Vashi
414e336852
[Authentication] Some of the base class functions are not static
...
function, but - methods. Hence - 'self' should be used, and not 'cls'.
Also - use a constant for duplicate string literal in LDAP
authentication implementation.
2020-04-14 18:43:04 +05:30
Ashesh Vashi
d226ffbd1f
[Foreign Key] Removed 1 unexpected arguments; 'get_node_list' expects
...
5 positional arguments.
Also,
- Using 'gettext' instead of '_'.
- Using constant string for 'foreign_key not found' error message.
2020-04-14 18:40:15 +05:30
Ganesh Jaybhay
12530cd973
Ensure index dropdown should have existing indexes while creating unique constraints. Fixes #5007
2020-04-14 14:02:33 +05:30
Khushboo Vashi
a0fcb38e68
Fixed syntax error while refreshing the existing synonyms. Fixes #5383
2020-04-14 13:43:56 +05:30
Pradip Parkale
a05acb4f99
Fixed tab key navigation for some dialogs. Fixes #5371
2020-04-14 13:32:03 +05:30
Neel Patel
21cb1a0166
Fix the typo in the test configuration json file.
2020-04-14 13:07:27 +05:30
Shubham Agarwal
41521a9b98
Ensure all object names in the title line of the reverse-engineered SQL are not quoted. Fixes #4445
2020-04-14 13:02:58 +05:30
Akshay Joshi
781b766ac4
Fixed an issue where difference SQL is not seen in the schema diff tool for Types. Fixes #5302
2020-04-13 20:24:12 +05:30
Akshay Joshi
df11f28593
Fixed an issue where the identical packages and sequences visible as different in the schema diff tool. Fixes #5362
2020-04-13 18:06:20 +05:30
Khushboo Vashi
030741bba5
Modified some logic for the EPAS server as the user can change the view definition without dropping it. Fixes #5053
2020-04-13 16:00:01 +05:30
Aditya Toshniwal
b427a87724
Fixed an issue where changing the values of columns with JSONB or JSON types to NULL. Fixes #4969
2020-04-13 12:34:32 +05:30
Aditya Toshniwal
077589e08b
Fixed an issue where right-clicking a browser object does not apply to the object on which right-click was fired. Fixes #3523
...
Fixes keyboard navigation on the context menu applied to browser tree.
2020-04-10 17:34:57 +05:30
Murtuza Zabuawala
4de6b93ba8
Ensure that the password prompt should not be visible if the database server is in trust authentication mode. Fixes #2813
2020-04-10 17:03:04 +05:30
Aditya Toshniwal
014ce31589
Fixed user management related issues:
...
1) Unable to add a user when there are many users. The dialog went blank. Fixed.
2) The error message did not have a close button. Fixed.
3) When clicked on the add button, then the cursor will focus on the email box of
the new row for convenience.
4) When the dialog opens, the cursor will focus on the search text box.
5) By default, the "User" role will be selected when adding a new user.
Also removed an empty option in the roles dropdown.
6) When the search filter is applied and we try to add an already existing user, the
validation is done only on the filtered data and not on all the users' data.
Fixes #5227
2020-04-10 16:49:33 +05:30
Nagesh Dhope
d9574f3caa
Fixes following OSX native keyboard shortcuts in Query Tool:
...
1) option+arrow (L/R) should skip by "word"
2) option+arrow (up/down) should go up/down one line
3) shift+option+arrow (L/R) should select/highlight by "word"
2020-04-10 15:21:56 +05:30
Libor M
6a9af07f7a
Fixed gettext usage:
...
- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in the dialog.
- improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js,
word 'cancel' needs to be translated in the Czech language as 'zrušit' but in another sentence as 'zrušení')
- added gettext for text translations.
2020-04-10 14:52:41 +05:30
Khushboo Vashi
e238ecf182
Ensure that OID should be shown in properties for Synonyms. Fixes #5270
2020-04-10 13:19:52 +05:30
Akshay Joshi
c8646f99c0
Fixed typo
2020-04-09 21:46:47 +05:30
Akshay Joshi
31f255b541
Added support of Foreign Tables to the Schema Diff. Fixes #5263
2020-04-09 21:03:28 +05:30
Akshay Joshi
fecf3915c5
Fixed API/RESQL test cases for View/MView failed due to #5053 commit.
2020-04-09 21:03:28 +05:30
Ashesh Vashi
8a550b569f
Fixed expected output status code, as 410 should be the status code
...
for the object (CAST) not exists in the database server.
2020-04-08 16:51:53 +05:30
Ashesh Vashi
1a34f61b24
Moved the ip-address check functionality to a separate file to improve
...
the maintainability of the code.
2020-04-08 16:50:14 +05:30
Ashesh Vashi
775e61c248
Fixed pep8 issue
2020-04-08 14:34:34 +05:30
Ashesh Vashi
aa7ced4ef1
Fixed a typo in previous commit
2020-04-08 14:30:29 +05:30
Ashesh Vashi
d9f6baac72
Various misc fixes:
...
- Using the 'gettext' as oppose to '_', which is not defined
- Define missing variables
- Fixed escape character in string with double quote
- Removed some dead code in a test case
- Removed unnecessary self assignment
Includes some fixes for Accessibility improvements
- Use semantic markup to mark emphasized or special text
- Added hidden legend in <fieldset> for better screen reader support
2020-04-08 14:14:25 +05:30
Ashesh Vashi
8fe687eb55
[Rules] Removing unnecessary 'if' condition
2020-04-08 13:14:14 +05:30
Ashesh Vashi
6c693d158e
[Exclusion Constraint] Fixed an typo - it should have been assignment
2020-04-08 13:05:28 +05:30
Ashesh Vashi
6b3e1f1e65
[TABLES] Do not assign the paramter values, use separate variable for new value
2020-04-08 13:04:24 +05:30
Ashesh Vashi
8fe344c268
[EDB Package Functions] [Functions] Fixed typos:
...
- 'gettext' should be used as '_' is not defined
- Identical expressions should not be used on both sides of a binary operator.
2020-04-08 13:02:37 +05:30
Ashesh Vashi
c7afa30d0c
[Packages] Fixed a typo
2020-04-08 13:00:49 +05:30
Ashesh Vashi
14f21921bb
[Functions] Fixed typos:
...
- 'gettext' should be used as '_' is not defined
- Identical expressions should not be used on both sides of a binary operator.
2020-04-08 13:00:01 +05:30
Ashesh Vashi
29ae6dfbf6
[FTS Configuration] Fixed an typo - it should have been assignment
2020-04-08 12:56:51 +05:30
Ashesh Vashi
a6c03a6b75
[Domain] Existing expression will expression will always result into false
2020-04-08 12:54:37 +05:30
Ashesh Vashi
068b812245
[COLLATIONS] Do not assign the paramter values, use separate variable for new value
2020-04-08 12:53:48 +05:30
Ashesh Vashi
a84a62def8
Using the 'gettext' as oppose to '_', which is not defined in these
...
files.
2020-04-08 12:34:57 +05:30
Ashesh Vashi
7f0847b95d
Using the 'gettext' as oppose to '_', which is not defined in the file
2020-04-08 12:29:11 +05:30
Ashesh Vashi
073e310a5a
[Accessibility] Use semantic markup to mark emphasized or special text.
...
Reference: https://www.w3.org/TR/WCAG20-TECHS/H49.html
2020-04-08 12:27:18 +05:30
Ashesh Vashi
d9e95d13e6
[LDAP Authentication] Use more secure protocol TSL v1.2 for security reason
2020-04-08 11:57:01 +05:30
Khushboo Vashi
f4607885e1
Fixed an issue where changing the columns in the existing view throws an error. Fixes #5053
...
PostgreSQL doesn't allow to change the view columns. So the view should be dropped first
and then recreate it and also the user will get a warning first.
2020-04-08 11:29:03 +05:30
Aditya Toshniwal
03f4109ac4
Fixes an issue where pgAdmin4 GUI does not display properly in IE 11. Fixes #5361
...
Use the ES5 dist of @simonwep/pickr to make it work on IE.
2020-04-08 11:29:03 +05:30
Dave Page
bd0aaf7665
Update yarn.lock
2020-04-07 09:43:54 +01:00
Aditya Toshniwal
134c1802e7
Enable the save button by default when a query tool is opened with CREATE or other scripts. Fixes #4856
2020-04-07 13:54:16 +05:30
Pradip Parkale
33deacacee
Ensure that the grant wizard should be closed on pressing the ESC key. Fixes #4206
2020-04-07 13:48:56 +05:30
Aditya Toshniwal
d6bc3ccc8b
Fixed cursor disappeared issue in the query editor for some of the characters when zoomed out. Fixes #3988
2020-04-07 11:51:19 +05:30
Aditya Toshniwal
e1f990190e
Added search object functionality. Fixes #2172
2020-04-06 17:33:07 +05:30
Khushboo Vashi
f77aa3284f
Added LDAP authentication support. Fixes #2186
2020-04-06 15:57:05 +05:30
Pradip Parkale
8ceeb39268
Fixed tab key navigation issue for parameters in table dialog. Fixes #5275
2020-04-06 13:13:21 +05:30
Aditya Toshniwal
4f71dae598
Fixed calendar opening issue on the exception tab inside the schedules tab of pgAgent. Fixes #4512
2020-04-06 12:59:22 +05:30
Akshay Joshi
99e4c3350f
Fixed RESQL test cases for Packages.
2020-04-03 19:15:40 +05:30
Vishal Sawale
99a72e529b
Fixed some accessibility issues:
...
1) Added missing search filter label in backgrid.
2) broken aria issue for objects menu.
2020-04-03 17:11:46 +05:30
Aditya Toshniwal
824e3866d8
Replace the existing color picker - spectrum-colorpicker with @simonwep/pickr.
...
spectrum-colorpicker has accessibility issues and is not maintained since long
Part of #5197
2020-04-03 17:06:47 +05:30
Akshay Joshi
ce89ae3c1d
Added support of Packages, Sequences and Synonyms to the Schema Diff. Fixes #5264
2020-04-03 16:52:45 +05:30
Vishal Sawale
4036f2a0f2
Fixed accessibility issue for the missing label from the table header.
2020-04-02 12:47:39 +05:30
Murtuza Zabuawala
37f55ccc25
Ensure that switch cell is in sync with switch control for accessibility. Fixes #5314
2020-04-02 12:25:55 +05:30
Aditya Toshniwal
358c5d0a0f
Added support for parameter toast_tuple_target and parallel_workers of the table. Fixes #5181
...
Fixed an issue where the autovacuum_enabled parameter is added automatically in the RE-SQL
when the table has been created using the WITH clause. Fixes #5180
2020-04-01 18:19:55 +05:30
Aditya Toshniwal
88a1e03314
Fixed generated SQL when any token in FTS Configuration or any option in FTS Dictionary is changed. Fixes #5268
2020-04-01 15:03:30 +05:30