7dd6372eeb
Extract the tests and refactor some of the methods.
...
Extract some of the ACI Tree functionalities, and decouple it from the
main source. Also - create some abstractions from the repeated code
around the enable/disable the schema children object create/edit/delete
functionalities, and also created the dialog wrappers for backup and
restore dialogs.
Reviewed by: Khushboo and Ashesh
Refactored by: Ashesh
2018-06-05 16:42:59 +05:30
38ee39ae7a
Add support for LISTEN/NOTIFY in the query tool. Fixes #3204
2018-05-30 21:58:28 -04:00
9f13865777
Update jQuery to 3.3.1. Fixes #3271
...
Patch by Aditya, with test enhancements from Anthony and Joao at Pivotal.
2018-05-25 16:26:37 +01:00
bc4d16eb83
Initial version of the new tree implementation.
...
This is the first version of our Tree implementation. At this point is a
very simple tree without no abstractions and with code that eventually
is not very performant, but this is only the first iteration and we are
trying to follow the 'Last Responsible Moment Principle' [1].
Implemention details:
- Creation of PGBrowser.treeMenu
- Initial version of the Tree Adaptor 'pgadmin/static/js/tree/tree.js'
- TreeFake test double that can replace the Tree for testing purposes
- Tests, As an interesting asside because Fake’s need to behave like
the real object you will noticed that there are tests for this type
of double and they the same as of the real object.
[1] https://medium.com/@aidanjcasey/guiding-principles-for-an-evolutionary-software-architecture-b6dc2cb24680
Patched by: Victoria && Joao
Reviewed by: Khushboo & Ashesh
2018-05-14 18:00:23 +05:30
8937375885
Standardise the error handling for parsing of JSON response messages from the server. Fixes #3238
2018-05-04 16:56:15 +01:00
b7fb01ab04
Add support for SSH tunneled connections. Fixes #1447
2018-05-04 11:27:27 +01:00
732d8d903d
F5 key should work to refresh Browser tree. Fixes #3284
...
Refactoring by: Joao Pedro De Almeida Pereira
2018-05-02 11:43:42 +05:30
c94439bf8e
Fixed the issues for all the javascript files reported by the liner.
2018-04-30 17:51:57 +05:30
f5e474e4ec
Ensure the query tool will open properly under MS Edge.
2018-04-10 11:09:59 +01:00
fa1854bd85
Allow sorting when viewing/editing data. Fixes #1894
2018-04-05 16:25:17 +01:00
a705fb46a8
Refactor and simplify query tool connection error handling code. Fixes #3235
2018-04-04 11:20:36 +01:00
7805170783
Add the ability to enable/disable UI animations. Fixes #1978
2018-04-03 14:52:13 +01:00
94e1e46201
Show more granular timing info in the query tool history panel. Fixes #3244
2018-04-03 14:11:11 +01:00
637f3b9d1a
Fix a number of broken connection detection scenarios.
2018-03-21 08:38:18 +00:00
34f1ebc88e
Ensure the host parameter is correctly pickup up from the service file. Fixes #3200
2018-03-19 12:38:44 +00:00
3c4359270e
Fix trim function which was causing some JS errors during Server Properties validation. Victoria & Joao
2018-03-14 17:58:01 -04:00
6b03cb78af
Refactor server dialogue validation for better unit testing.
...
Victoria & Joao @ Pivotal.
2018-03-13 14:47:32 -04:00
e7316e2181
Update Jasmine to v3. Fixes #3182
2018-03-07 16:01:04 +00:00
d1ab47c10c
Disable function statistics on Greenplum. Fixes #3176
2018-03-07 11:52:02 +00:00
427314cfdf
Support for external tables in GPDB. Fixes #3168
2018-03-02 16:49:25 +00:00
92a0bb605d
Ensure we can edit grid values in the debugger using keyboard shortcuts. Fixes #3153
2018-03-02 15:05:04 +00:00
a9de043fef
Add keyboard shortcuts for the Query Tool. Fixes #2900
2018-02-27 14:32:03 +00:00
aa1849c13a
Support tab navigation in dialogs. Fixes #2898
2018-02-27 11:18:36 +00:00
0677ad254a
Un-vendorise React, now that it contains bug fixes we need.
2018-02-19 10:53:54 +00:00
15862e903a
Fix creation of tables and columns in GPDB. Fixes #3099
2018-02-19 10:40:10 +00:00
942ac733a4
Configurable shortcuts in the Debugger. Fixes #2901
2018-02-09 12:43:27 +00:00
e16a952753
Support EXPLAIN on Greenplum. Fixes #3097
...
- Extract SQLEditor.execute and SQLEditor._poll into their own files and add test around them
- Extract SQLEditor backend functions that start executing query to their own files and add tests around it
- Move the Explain SQL from the front-end and now pass the Explain plan parameters as a JSON object in the start query call.
- Extract the compile_template_name into a function that can be used by the different places that try to select the version of the template and the server type
2018-02-09 11:54:42 +00:00
66341e6947
Add infrastructure for managing configurable keyboard shortcuts.
2018-01-25 12:49:06 +00:00
97760d65c2
Add keyboard navigation in Query tool module via Tab/Shift-Tab key. Fixes #2896
...
Note:
1) Once the keyboard shortcut infrastructure is ready we will add generic shortcut to focus out from CodeMirror editor and set foucs to next element, Right now there is no way of doing this, For testing purpose you can manually focus out from CodeMirror and click on data output panel to continue navigate using Tab key.
2) As of now inner panel's are not getting focused on Tab/Shift-Tab keys but once RM#2895 patch gets committed it will start working automatically as it's inherited code which will add tabindex tag automatically on each newly created wcDocker panel.
2018-01-25 12:27:13 +00:00
0e41b3364b
Support keyboard navigation in the debugger. Fixes #2897
...
In passing, fix injection of variable values. Fixes #2981
2018-01-23 11:58:10 +00:00
89821c0d19
Update copyright notices for 2018.
2018-01-05 10:42:50 +00:00
d54c35d74f
Fixing the lint error messages in javascript using 'eslint --fix'
...
command.
2017-11-30 13:01:41 +05:30
0c566f132e
Allow configuration of CSV and clipboard formatting of query results. Fixes #2781
2017-11-20 13:50:47 +00:00
2ddbddba33
Improve display of error messages in the query tool. Fixes #2700
2017-09-20 11:29:24 +01:00
cca7526b9b
Remove menu icon tests that are no longer required.
2017-09-11 10:13:54 +01:00
b585063a26
Refactor keyboard shortcut functions in the query tool. Fix some incorrect keycodes and update docs.
...
Initial work by Sarah & Violet @ Pivotal, with additional tweaks by Murtuza @ EDB.
2017-08-21 15:27:29 +01:00
d527769bf8
Extract the generate_url(..) function from node.js, and collection.js
2017-08-17 21:43:07 +05:30
5141debae7
UX improvements of the history in the query tool.
...
- Added copy button for query text.
- Historical queries are binned/grouped by day.
Patch By: Hao Wang, Sarah McAlear
2017-08-09 16:52:43 +05:30
e506fa1dbe
Improved alertify notification logic. Remove AlertifyWrapper class and extend notification methods in alertify itself.
2017-07-31 18:59:44 +05:30
af26d983e5
Fixup tests following label changes.
2017-07-26 13:45:44 +01:00
fe95b7670b
Ensure the appropriate entry is focussed when entering the history tab.
2017-07-24 11:46:06 +01:00
7182b59976
Ensure arrow keys work correctly when the pane is focused instead of the tab in the query tool history.
2017-07-21 13:33:59 +01:00
86dc1e81f1
Move Query Tool keyboard shortcut code into a new module and add tests.
2017-07-20 22:22:25 +01:00
e29cd8d83d
Improve the history UI.
2017-07-20 20:50:37 +01:00
21bfcd83f4
Allow navigation of query history using the arrow keys. Fixes #2590
2017-07-20 20:47:40 +01:00
4a91bcde30
Webpack all the things! Fixes #2135
...
This significantly speeds up loading of the application; in an average of 3 tests, v1.6
loaded in 11.5s in the runtime on a Mac, whilst the webpacked version of the code
loaded in 5.53s.
2017-07-18 15:13:17 +01:00
fc78202600
Fix clear history.
2017-07-07 15:51:06 +01:00
e2cbaaef71
UI tweaks for the query history.
2017-07-06 13:08:29 +01:00
ffb00b502a
Fix a couple of gripes from the JS linter on Windows.
2017-06-30 10:34:06 +01:00
f2d2075d81
Update alertify alerts to use the styling defined in the styleguide (missed some files in the original commit).
2017-06-30 10:23:12 +01:00
7f55412059
Overhaul the query history tab to allow browsing of the history and full query text. Fixes #2282
...
Patch by Joao and the team at Pivotal.
2017-06-27 10:55:57 -04:00
c65158312d
Use on-demand loading for results in the query tool. Fixes #2137
...
With a 27420 row query, pgAdmin III runs the query in 5.873s on my laptop. pgAdmin 4 now takes ~1s.
2017-06-27 09:03:04 -04:00
94aa5487fb
Update Slickgrid to 2.3.7. As this version includes all the features we need, it can be moved out of the vendor directory and we'll use yarn to pull it in.
2017-06-23 09:35:56 +01:00
5d45dee686
Fix Yarn tasks for Windows
2017-06-15 15:32:07 +01:00
2a87585665
Fix script options which were inadvertently broken in the query tool tab naming patch.
2017-06-15 12:19:47 +01:00
1208206bc0
Initial re-vamp of the History tab.
2017-06-13 09:50:41 +01:00
3f4f8b9e77
Add linting support, and, well, lint.
2017-06-12 16:55:14 +01:00
659eb1c1e8
Bring React into the tree, and add linting and bundling framework for the JS etc.
2017-06-12 16:51:54 +01:00
fd3ddbeafb
Implementation of the client side 'url_for(...)' function.
...
Created a url_for function module to be used by different javascript
modules to use the same functionality of flask at client side.
A python module can expose the list of endpoints, used by its
javascripts, by overriding the 'get_exposed_url_endpoints(self)'
function.
In this patch, we have modified all the browser modules to use this
function. It will allow us to move the majority of the javascript
modules of browser nodes from templates directory to the static
directory.
TODO::
- Move these javascripts modules to the static directory.
- Use this function in all the applicable javascript modules.
e.g. tools, miscellaneous modules
2017-06-12 12:01:25 +05:30
01bfa88309
Improvements to the Query Results grid:
...
- Improve the UI
- Allow copy/paste from sets of rows, columns or arbitrary blocks of cells
Patch by Matt, Shruti, Joao and Sarah @ Pivotal
Fixes #2476
2017-06-08 13:31:36 +01:00
2fddf750e6
Retain column sizing in the query tool results grid when the same query is re-run multiple times in a row. Fixes #1971
2017-06-08 12:41:56 +01:00
8d8e7dab3c
Extract row staging into it's own module with tests.
2017-06-07 14:17:10 +01:00
0d05385585
Update the styling to use the set of grays defined in the WIP style guide.
2017-06-07 13:57:49 +01:00
aea0d93390
Hide menu options for creating objects, if the object type is set to hidden. Includes Jasmine tests. Fixes #2225
2017-05-12 12:10:46 +01:00
94b7fc483a
Fix sorting of sizes on the statistics views by sorting raw values and prettifying on the client side. Includes Jasmine tests for the prettyfying function. Fixes #2315
2017-05-08 11:29:13 +01:00
d663d553c5
Allow column or row selection in the query tool. Fixes #2216
2017-04-18 13:28:45 +01:00
1d27341e21
Fix translation extraction for new client side translations, and update catalogs.
2017-03-28 15:21:49 -04:00
95f43d59b8
Revert "Ensure client-side translations are correctly extracted into the message templates."
...
This reverts commit 82bd97aed0
2017-03-27 13:53:40 -04:00
82bd97aed0
Ensure client-side translations are correctly extracted into the message templates.
2017-03-27 13:24:47 -04:00
4ff082ee74
Use correct file header for a JS file.
2017-03-20 19:32:52 +00:00
b2a74ad26d
Fix a bunch of file headers.
2017-03-16 14:27:55 +00:00
5593faf2a4
Move the karma config and node_modules into the web directory.
2017-03-15 17:13:55 +00:00
Joao De Almeida Pereira
Akshay Joshi
Aditya Toshniwal
Dave Page
Khushboo Vashi
Ashesh Vashi
Murtuza Zabuawala
Victoria Henry
Harshal Dhumal
Sarah McAlear
Violet Cheng
Hao Wang
Matthew Kleiman
Surinder Kumar
Shruti B Iyer
George Gelashvili
Atira Odhner