Nikhil Mohite
72f0e87367
Fixed cognitive complexity issues reported by SonarQube.
2020-09-09 11:20:17 +05:30
Cyril Jouve
5a253f9053
Change the following to replace Python 2 code with Python 3:
...
1) Replace the deprecated unit test method.
2) Wraps filter usage in a list call.
3) Converts the old metaclass syntax to new.
4) Use range instead of xrange method.
5) Change Unicode to str.
6) Several other transformations.
7) Fixed change password test cases.
8) Use simplejson instead of plain JSON.
2020-08-31 16:45:31 +05:30
Cyril Jouve
36574b25b6
The 'str' object never has attribute decode in Python3, so remove the dead code.
2020-08-12 18:55:35 +05:30
Yogesh Mahajan
1f70385a4e
Fixed an issue where conversion of bytea to the binary string results in an error. Fixes #5567
2020-08-11 15:31:14 +05:30
Aditya Toshniwal
536593bf8a
Fixed following SonarQube issues:
...
- Remove this assignment to the local variable, the value is never used.
- Rename local variables to match the regular expression
- Add logic to this except clause or eliminate it and rethrow the exception automatically.
- Rename fields to match the regular expression
- Extract this nested conditional expression into an independent statement.
- Change this default value to "None" and initialize this parameter inside the function/method.
- Update this function so that its implementation is not identical to __repr__
- Refactor this method to not always return the same value
- Reraise this exception to stop the application as the user expects
- Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
- Remove this redundant continue.
- Remove this unused function declaration
- Remove this identity check; it will always be False.
2020-08-03 12:59:51 +05:30
Cyril Jouve
f93cfe8c4c
Remove old Python 2 compatibility code. Fixes #5700
2020-07-27 11:03:13 +01:00
Ashesh Vashi
1889c256e1
Fixed a typo in the psycopg2 driver in fetching result with
...
'execute_scalar' while attempting to reconnect.
2020-07-13 22:45:01 +05:30
Aditya Toshniwal
357a9179b1
Fixed convention related issues reported by SonarQube.
2020-07-09 18:55:33 +05:30
Yogesh Mahajan
3c08e618bd
Fixed an issue where CSV download quotes numeric columns. Fixes #5463
2020-07-09 18:11:46 +05:30
Satish V
a1fd9ea3ce
Fixed issue related to extra semicolons and function naming convention reported by SonarQube.
2020-06-24 16:16:12 +05:30
Yogesh Mahajan
caebdcfa91
Ensure that the query tool should display the proper error message while terminating the active session. Fixes #3591
2020-06-22 17:09:10 +05:30
Aditya Toshniwal
641f7bbe9d
Some clumsy coding related fixes reported by SonarQube.
2020-06-15 16:50:07 +05:30
Yogesh Mahajan
92d9c41da7
Fixed connection and version number detection issue when the database server is upgraded. Fixes #5507
2020-06-04 18:18:11 +05:30
Khushboo Vashi
0f56c25893
Changed the user identity from email to username in the log file.
...
refs #5452
2020-05-18 11:01:20 +05:30
Akshay Joshi
c0451cd454
Added connected pgAdmin user and connection name in the log file. Fixes #5452
...
Patch By: Nico T
2020-05-13 17:43:21 +05:30
Ashesh Vashi
e73e2d2502
Fixed the errors, and warnings reported by pylama.
...
TODO::
- Don't use unicode in Python 3 for removing the support of Python 2 (
psycopg2 driver - __init__.py, server_manager.py).
- Merge the lastest pgcli (version: 3.0.0) for SQL autocompletion.
2020-05-08 14:13:38 +05:30
Akshay Joshi
ad80217593
Remove Python2 references from the source code.
...
refs #5443
Initial patch: Neel Patel
2020-04-30 17:22:48 +05:30
Libor M
6a9af07f7a
Fixed gettext usage:
...
- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in the dialog.
- improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js,
word 'cancel' needs to be translated in the Czech language as 'zrušit' but in another sentence as 'zrušení')
- added gettext for text translations.
2020-04-10 14:52:41 +05:30
Aditya Toshniwal
c9d04684ce
Ensure that all the transactions should be canceled before closing the connections when a server is disconnected using pgAdmin. Fixes #5142
2020-02-28 14:12:44 +05:30
Aditya Toshniwal
915b09255c
Added Python 3.8 support. Fixes #5179
...
1) Upgraded passlib==1.7.1 to passlib==1.7.2
2) Replace unmaintained Flask-Security with maintained Flask-Security-Too package, which is also compatible with python 3.8
3) Other compatibility code changes.
2020-02-18 12:10:38 +05:30
Dave Page
01c7636c75
Update copyright notices for 2020.
2020-01-02 14:43:50 +00:00
Akshay Joshi
f22134dabd
Ensure that the superuser should be able to create database and role, as the superuser
...
overrides all the access restrictions.
Fixes #4792 Fixes #4878
2019-11-14 18:14:53 +05:30
Yosry Muhammad
687204771c
Add support in query history to show internal queries generated by pgAdmin during save data operations. Fixes #4612
2019-08-16 17:17:12 +05:30
Aditya Toshniwal
dfa892d2a2
1. Added Master Password to increase the security of saved passwords. Fixes #4184
...
2. In server(web) mode, update all the saved server credentials when user password is changed. Fixes #3377
2019-05-28 12:00:18 +05:30
Aditya Toshniwal
7627e9c699
Display errors during CSV download from the Query Tool in the UI rather than putting them in the CSV file. Fixes #4085
...
Ensure the toolbar buttons are properly reset following a CSV download in the Query Tool. Fixes #4096
2019-03-29 14:31:33 +00:00
Khushboo Vashi
efeb9d6d20
Fix regression issue caused due to encoding fixes.
2019-03-04 16:11:20 +05:30
Khushboo Vashi
849e34c2f7
Add full support and testsfor all PG server side encodings. Fixes #3992 . Fixes #3982 . Fixes #3911
2019-03-01 13:51:50 +00:00
Khushboo Vashi
34045efb38
Modify the Download as CSV option to use the same connection as the Query Tool its running in so temporary tables etc. can be used. Fixes #3673
2019-02-20 11:49:45 +00:00
Ashesh Vashi
eb3d3980e0
Use 'set_config(...)' function to update the 'bytea_output' settings
...
instead of 'UPDATE' statement, which is not allowed in the the read-only
instances.
Reported by: Robert J. Rotter
Solution provided by: Tom Lane
Fixes #3973
2019-02-08 10:18:32 +05:30
Murtuza Zabuawala
d9fc9fdc4d
Ensure object names in external process dialogues are properly escaped. Fixes #3872
2019-01-24 16:34:18 +00:00
Diego Augusto Molina
d92368f8e5
Use 'UPDATE pg_settings' for setting bytea_output as a
...
convenience hack for those running on old, unsupported versions of
PostgreSQL 'cos we're nice like that.
2019-01-22 15:56:29 +00:00
Dave Page
14f462e9dc
Fix PEP-8 issues.
2019-01-11 22:13:17 +05:30
Aditya Toshniwal
d641b47adb
Make the browser more robust in the face of multibyte characters in SQL_ASCII databases. Fixes #3877
2019-01-11 21:55:49 +05:30
Murtuza Zabuawala
e23d307c56
Update copyright notices for 2019
2019-01-02 15:54:12 +05:30
Akshay Joshi
41c028f944
Ensure that null values handled properly in CSV download. Fixes #3780
2019-01-01 15:15:36 +05:30
Khushboo Vashi
e666b0fab0
Fix an issue that could cause the Query Tool to fail to render. Fixes #3433
2018-12-13 11:15:55 +00:00
Dave Page
980d1e0292
Fix PEP8 issue.
2018-12-04 17:07:41 +00:00
Khushboo Vashi
7e3bd8b88a
Fix an encoding issue in the query tool. Fixes #3711
2018-12-04 17:03:19 +00:00
Akshay Joshi
eae18f6f14
Ensure previous notices are not removed from the Messages tab in the Query Tool if an error occurs during query execution. Fixes #3016
2018-11-14 08:27:47 -05:00
Akshay Joshi
15fe26a710
Fix handling of backslashes in the edit grid. Fixes #3551
2018-09-25 10:34:33 -04:00
Akshay Joshi
52fc0846cd
pgAdmin4 should work with python 3.7, Fixes #3458
2018-08-06 15:35:03 +05:30
Akshay Joshi
213cb440d0
Add support for SCRAM password changes (requires psycopg2 >= 2.8). Fixes #2214
2018-07-23 15:03:44 +01:00
Akshay Joshi
ce768c7f8a
Support SSH tunneling with keys that don't have a passphrase. Fixes #3468
2018-07-18 14:15:05 +01:00
Dave Page
4ba0e1a6f3
Fix Python 2.6 support for SQL_ASCII data in the query tool.
2018-06-21 17:06:28 -04:00
Aditya Toshniwal
df85392bbf
Fix handling of SQL_ASCII data in the query tool. Fixes #3289 . Fixes #3250
2018-06-21 08:26:01 -04:00
Akshay Joshi
7a06acb678
Allow the connection timeout to be configured on a per-server basis. Fixes #3388
2018-06-19 19:58:46 -04:00
Akshay Joshi
38ee39ae7a
Add support for LISTEN/NOTIFY in the query tool. Fixes #3204
2018-05-30 21:58:28 -04:00
Akshay Joshi
b7fb01ab04
Add support for SSH tunneled connections. Fixes #1447
2018-05-04 11:27:27 +01:00
Murtuza Zabuawala
be055ce57d
Update Python and JS modules. Fixes #3154
2018-04-04 10:47:01 +01:00
Akshay Joshi
1baddd5e9a
Decode the severity field in database exception objects properly. Fixes #3090
2018-03-26 13:59:49 +01:00