Ashesh Vashi
845025db8f
Some cosmetic changes.
...
- Loading 'pgadmin' as 'sources/pgadmin', as found under the 'sources'
reference directory to be consistent with other files.
- Removed the 'pgadmin' reference from the base.html template.
- Renamed 'pgadmin.slickgrid.editors.js', and
'pgadmin.slickgrid.formatters.js' as 'editors.js', and 'formatters.js'
respectively, as they're already in the 'pgadmin/static/js/slickgrid'
directory.
- Removed the duplicate entry of 'translations' from the webpack.shim.js
2017-08-09 16:52:12 +05:30
Akshay Joshi
e418cb8387
Changed the mapping of cell from 'numeric' to 'integer' for integer control as numeric cell has been removed from the code. Fixes #2631
2017-08-07 14:02:59 +05:30
Akshay Joshi
e506fa1dbe
Improved alertify notification logic. Remove AlertifyWrapper class and extend notification methods in alertify itself.
2017-07-31 18:59:44 +05:30
Surinder Kumar
6d5417709c
Moved the javascripts of different modules from 'templates' to 'static' directory.
...
Moving the javascripts for the following modules:
- About
- Browser nodes
- Dashboard
- FileManager
- Vendor/snap.svg
- Preferences
- Settings
- Backup
- Datagrid
- Debugger
- Sqleditor
- Grant Wizard
- Import & Export
- Maintenance
- Restore and
- User Management
2017-07-27 17:25:08 +05:30
Khushboo Vashi
d1e7254fbd
Handle control visibility properly in javascript strict mode.
2017-07-26 12:55:46 +01:00
Murtuza Zabuawala
1fa9648a21
Update keyboard shortcuts per discussion. Also, make the labels platform sensitive.
2017-07-26 12:50:42 +01:00
Murtuza Zabuawala
617e9dbb3a
Allow queries to be cancelled from the dashboards. Fixes #1812
2017-07-24 12:13:24 +01:00
Atul Sharma
70418144cf
Add a field to the Server Dialogue allowing users to specify a subset of databases they'd like to see in the treeview. Fixes #1918
2017-07-21 12:44:57 +01:00
Sarah McAlear
86dc1e81f1
Move Query Tool keyboard shortcut code into a new module and add tests.
2017-07-20 22:22:25 +01:00
Harshal Dhumal
54882e061c
Don't attempt to render binary data in the query tool result grid. Fixes #2080 . Fixes #2074 .
2017-07-20 13:09:47 +01:00
Surinder Kumar
b90d368ee7
Resolve an issue where collection nodes sometimes wouldn't sort properly.
2017-07-18 16:31:05 +01:00
Surinder Kumar
4a91bcde30
Webpack all the things! Fixes #2135
...
This significantly speeds up loading of the application; in an average of 3 tests, v1.6
loaded in 11.5s in the runtime on a Mac, whilst the webpacked version of the code
loaded in 5.53s.
2017-07-18 15:13:17 +01:00
Harshal Dhumal
fc78202600
Fix clear history.
2017-07-07 15:51:06 +01:00
Murtuza Zabuawala
b211eb199c
Improve styling for alerts by highlighting the icon.
2017-07-04 12:03:32 +01:00
Harshal Dhumal
1977a5fcda
Fix clipboard handling with large datasets. Fixes #2489
2017-07-03 11:19:02 +01:00
Joao Pedro De Almeida Pereira
f2d2075d81
Update alertify alerts to use the styling defined in the styleguide (missed some files in the original commit).
2017-06-30 10:23:12 +01:00
Harshal Dhumal
2d65312910
Improve speed of Select All in the results grid. Fixes #2522
2017-06-30 09:54:31 +01:00
Akshay Joshi
c98b64fd82
1) Edit cellEditing function, in some cases grid object is undefined.
...
2) Modify SubNodeCollectionControl, so that user can pass custom backgrid row.
3) Handling of visible parameter in SubNodeCollectionControl.
4) Customise title and delete message for Delete Cell.
5) Added Backgrid.Extension.Select2DepCell and moved Backgrid.Extension.StringDepCell from user management to backgrid.pgadmin.js.
2017-06-29 19:01:29 +05:30
Joao Pedro De Almeida Pereira
7f55412059
Overhaul the query history tab to allow browsing of the history and full query text. Fixes #2282
...
Patch by Joao and the team at Pivotal.
2017-06-27 10:55:57 -04:00
Murtuza Zabuawala
1b49bb8b22
Add preferences to enable brace matching and brace closing in the SQL editors. Fixes #2513
2017-06-27 09:57:38 -04:00
Harshal Dhumal
c65158312d
Use on-demand loading for results in the query tool. Fixes #2137
...
With a 27420 row query, pgAdmin III runs the query in 5.873s on my laptop. pgAdmin 4 now takes ~1s.
2017-06-27 09:03:04 -04:00
Matthew Kleiman
9af29364c7
Fix cell selection window alignment for the updated SlickGrid.
2017-06-23 09:37:58 +01:00
Matthew Kleiman
94aa5487fb
Update Slickgrid to 2.3.7. As this version includes all the features we need, it can be moved out of the vendor directory and we'll use yarn to pull it in.
2017-06-23 09:35:56 +01:00
Khushboo Vashi
25282f3094
Additional preference fix.
2017-06-22 14:55:45 +01:00
Khushboo Vashi
67fd119de8
Maintain a client-side cache of preference values, populated using an async call. Fixes #2487
2017-06-21 17:09:59 +01:00
Surinder Kumar
2a87585665
Fix script options which were inadvertently broken in the query tool tab naming patch.
2017-06-15 12:19:47 +01:00
Surinder Kumar
fdc9eed514
Ensure text editors render in an appropriate place on the results grid. Fixes #2477
2017-06-14 12:18:27 +01:00
Shruti B Iyer
1208206bc0
Initial re-vamp of the History tab.
2017-06-13 09:50:41 +01:00
Shruti B Iyer
f1acad85db
Add a missing translation call.
2017-06-12 17:20:40 +01:00
Shruti B Iyer
3f4f8b9e77
Add linting support, and, well, lint.
2017-06-12 16:55:14 +01:00
Ashesh Vashi
fd3ddbeafb
Implementation of the client side 'url_for(...)' function.
...
Created a url_for function module to be used by different javascript
modules to use the same functionality of flask at client side.
A python module can expose the list of endpoints, used by its
javascripts, by overriding the 'get_exposed_url_endpoints(self)'
function.
In this patch, we have modified all the browser modules to use this
function. It will allow us to move the majority of the javascript
modules of browser nodes from templates directory to the static
directory.
TODO::
- Move these javascripts modules to the static directory.
- Use this function in all the applicable javascript modules.
e.g. tools, miscellaneous modules
2017-06-12 12:01:25 +05:30
Surinder Kumar
49976b1934
Fine tune result grid column sizing now we don't have checkboxes.
2017-06-09 09:24:20 +01:00
Harshal Dhumal
aa400cbc12
Fix integer/numeric validation on various dialogues. Fixes #2421
2017-06-08 14:59:26 +01:00
Sarah McAlear
01bfa88309
Improvements to the Query Results grid:
...
- Improve the UI
- Allow copy/paste from sets of rows, columns or arbitrary blocks of cells
Patch by Matt, Shruti, Joao and Sarah @ Pivotal
Fixes #2476
2017-06-08 13:31:36 +01:00
Surinder Kumar
2fddf750e6
Retain column sizing in the query tool results grid when the same query is re-run multiple times in a row. Fixes #1971
2017-06-08 12:41:56 +01:00
George Gelashvili
8d8e7dab3c
Extract row staging into it's own module with tests.
2017-06-07 14:17:10 +01:00
Ashesh Vashi
ae80976689
Using the client-side translation using the client-side 'gettext'
...
implementation.
This is the first step towards 'Avoid creating the javascript modules
using Jinja templates'.
2017-06-07 15:53:05 +05:30
Surinder Kumar
b82e001478
Ensure that boolean checkboxes cycle values in the correct order. Fixes #2448
2017-06-06 11:29:18 +01:00
Surinder Kumar
1f26953504
Cleanup handling of default/null values when data editting. FIxes #2400
2017-05-27 14:51:02 -04:00
Murtuza Zabuawala
aea0d93390
Hide menu options for creating objects, if the object type is set to hidden. Includes Jasmine tests. Fixes #2225
2017-05-12 12:10:46 +01:00
Surinder Kumar
4f9628ed43
Improve handling of nulls and default values in the data editor. Fixes #2257
2017-05-12 10:53:57 +01:00
Khushboo Vashi
94b7fc483a
Fix sorting of sizes on the statistics views by sorting raw values and prettifying on the client side. Includes Jasmine tests for the prettyfying function. Fixes #2315
2017-05-08 11:29:13 +01:00
Matthew Kleiman
d663d553c5
Allow column or row selection in the query tool. Fixes #2216
2017-04-18 13:28:45 +01:00
Murtuza Zabuawala
a2a2b8b888
Ensure the query tool displays but does not render HTML returned by the server in the results grid. Fixes #2330 .
2017-04-10 14:07:48 +01:00
Jonas Thelemann
65f21a8cd7
Replace all occurrences of "can not" with "cannot".
2017-04-05 13:38:14 +01:00
Sarah McAlear
1d27341e21
Fix translation extraction for new client side translations, and update catalogs.
2017-03-28 15:21:49 -04:00
Khushboo Vashi
8745417926
Fix ascending/descending sort order in backgrid while clicking on the headers. Fixes #2303
2017-03-28 09:19:24 -04:00
Dave Page
95f43d59b8
Revert "Ensure client-side translations are correctly extracted into the message templates."
...
This reverts commit 82bd97aed0
.
There are still issues extracting with these changes.
2017-03-27 13:53:40 -04:00
Sarah McAlear
82bd97aed0
Ensure client-side translations are correctly extracted into the message templates.
2017-03-27 13:24:47 -04:00
Harshal Dhumal
720aefbe6f
Select2Cell: Check if cell is in multiselect mode before setting default selection of multiple values. Fixes #2283
2017-03-23 10:45:42 +00:00
Atira Odhner
ae0d8e89eb
Fix the path to JS
2017-03-15 17:12:58 +00:00
Atira Odhner
172b41cba8
Refactor clipboard copying into a separate file for use outside the SQL Editor.
2017-03-15 17:11:11 +00:00
Atira Odhner
4445f9dd63
Add a mechanism for centralising JS translations, to avoid having to render many JS files with Jinja.
2017-03-15 17:10:22 +00:00
Harshal Dhumal
502c827697
Fix numeric control validation in nested schemas. Fixes #2241
2017-03-09 15:23:18 +00:00
Murtuza Zabuawala
af499c0c9a
Show the correct indeterminate state when editing new boolean values. Fixes #2218
2017-03-06 10:30:58 +00:00
Murtuza Zabuawala
480e00fddf
Query tool efficiency.Convert the data as a 2D array instead of dict. Fixes #2036
...
Incremental back off when polling. Fixes #2038
Initial Patch By: Dave Page
2017-03-01 16:58:51 +05:30
Dave Page
3638d63330
Move pgadmin plugins for codemirror back out of the vendor area.
2017-02-27 13:18:28 +00:00
Sarah McAlear
a0a31e55ae
Move 3rd party client code into vendor/ directories for ease of maintenance.
2017-02-24 17:01:21 +00:00
Surinder Kumar
40ff651ef3
Fix display of boolean nulls in the query tool. Fixes #2205
2017-02-24 13:47:37 +00:00
Surinder Kumar
88cae263b2
Fix display of long integers and decimals. Fixes #2039 . Fixes #2119 . Fixes #2154
2017-02-24 13:39:40 +00:00
Surinder Kumar
c0f2aab001
Ensure we never sort columns on the treeview. Fixes #2185
2017-02-24 13:02:13 +00:00
Surinder Kumar
4566877188
Handle NULL booleans in the data editor. Fixes #1790
2017-02-05 11:06:48 +01:00
Surinder Kumar
54ba1fbe59
Support setting text fields to empty strings or NULL in the data editor grid. Fixes #1790
2017-02-04 14:10:30 +01:00
Murtuza Zabuawala
687a793383
Fix display of zeros in read-only grid editors. Fixes #2138
2017-02-01 13:48:46 +00:00
Harshal Dhumal
415119d581
Properly remove any event listeners added by subnode control.
2017-01-20 13:24:37 +00:00
Murtuza Zabuawala
28621999f2
Improve display of columns of exclusion contraints and foreign keys in the properties lists. Fixes #2065
2017-01-17 10:25:26 +00:00
Surinder Kumar
86f6857cb7
Fix sorting of numerics in the statistics grids. Fixes #1938
2017-01-09 15:55:38 +05:30
Surinder Kumar
e400693126
Add BigNumberJS library for upcoming large number related fixes.
2017-01-09 09:07:21 +05:30
Murtuza Zabuawala
879a6bef53
Fix keyboard control of switches in the column grid. Fixes #1394
2017-01-08 15:27:58 +05:30
Dave Page
87d4937726
Minimise memory requirements for rendered cells and rows in SlickGrid. Fixes #2035
...
- The CSS class 'slick-row' has been renamed to 'sr'
- The CSS class 'slick-cell' has been renamed to 'sc'
- The SQL Editor included an unused 'normal_row' class on each row which has been removed as it was unreferenced in the code or CSS.
The intent of these changes is to minimise memory usage by the grid, by saving a few bytes per row/cell.
It's questionable how much difference this actually makes given that SlickGrid updates the document so it
only includes the visible rows on the fly, but every little helps.
2016-12-22 17:43:42 +00:00
Murtuza Zabuawala
6fc8f040ff
Allow users to enable wrapping of code in SQL boxes. Fixes#2025
2016-12-16 17:07:41 +00:00
Khushboo Vashi
53ea991907
Properly size the SQL Editor gutter as the width of the line numbers increases. Fixes #1780
2016-12-16 13:04:16 +00:00
Surinder Kumar
19bd021696
Ensure select2 instances have a destroy property before calling destroy.
2016-10-21 16:16:10 +01:00
Dave Page
62a35f24e7
Fix layout of DateTimePicker control help message. Fixes #1864
2016-10-18 12:43:58 +01:00
Surinder Kumar
7f507f294e
While clicking on Select2 control, it tries to destroy the control and thus it doesn't get this object sometimes and throws error.
...
It should attempt to destroy the select2 object only if this object is not undefined.
2016-10-14 12:20:29 -07:00
Surinder Kumar
e4d870cbe6
Ensure errorModel unset property properly in while adding a new server. Fixes #1786
2016-10-03 13:50:54 +01:00
Dave Page
6790f14c6c
Fix button label and colour
2016-09-26 16:10:00 +01:00
Ashesh Vashi
e591c6b5c0
pgAgent misc fixes:
...
1. When an existing schedule updated, or a new schedule is added from a pgAgent job dialog, it was not able to generate the proper update SQL Query.
2. The SubNodeCollectionControl was not removing the grid, when it is being getting removed.
2016-09-26 13:43:13 +01:00
Ashesh Vashi
b80cd43ae6
Misc changes
...
- Setting the CodeMirror height when panel is resized, which you had mentioned.
- Added a new CellEditor (DatetimePickerEditor) for datetime picker.
2016-09-26 10:04:49 +01:00
Ashesh Vashi
163ae4d53d
Misc fixes and additions for pgAgent support:
...
- Added DatetimepickerControl, MomentCell (using moment.js)
- Used the 'DatetimepickerControl' in Role (Also - resolved an issue, when unset the datetime for 'Valid Until'.)
- Added a 'Select All/Unselect All' adaptor for Select2 used by pgAgent nodes.
- Fixed an issue with SubNodeCollectionControl, which was not starting the modification session of the child model, when created default value for collection is not null/undefined. And, hence - validation on the child model was not working.
- Fixed a memory leak with SqlFieldControl, and SqlTabControl, which was not releasing the CodeMirror properly.
2016-09-22 15:27:59 +01:00
Dave Page
7a40171300
Handle nested JSON correctly in SlickGrid. Fixes #1713 . Fixes #1404
2016-09-21 13:43:27 +01:00
Dave Page
fcc81d32cc
Fix condition check for avoiding sorting of columns.
2016-09-14 12:33:54 +01:00
Murtuza Zabuawala
4ba8f4830b
Don't sort columns (tables, views, matviews, catalogs etc) on the treeview by name, but by ordinal. Fixes #1687
2016-09-14 11:13:50 +01:00
Murtuza Zabuawala
ffc58b74d2
Allow viewing of long data values in the grid. Fixes #1672
2016-09-12 12:39:40 +01:00
Murtuza Zabuawala
087332f32e
Fix the boolean editor, and warn the user if there are unsaved changed in the edit grid before refreshing.
2016-09-01 11:50:48 +01:00
Murtuza Zabuawala
c56e4667df
SlickGrid Integration in to query tool. Fixes #1618
2016-08-29 20:17:01 +05:30
Ashesh Vashi
b6f307256b
Sorting the data during tree data loading using the natural sort
...
algorithm.
This patch takes care of:
* Consistent behaviour during create, update operation on any node.
- It should return the node data during creating a new object, or
updating the existing one.
* Now that - we have consistent behaviour during these operations, we
can consistently move, update the tree item based the node data from
the server.
* Implemented the methods for each node to get the information about
that particular node only.
* Using the above changes to implement the 'refresh' operation on tree
node properly.
I must thank Surinder, and Harshal for helping me implement the 'node'
method, and also changed the behaviour of create & update methods to
return the node data for most of the nodes.
Fixes #1244
2016-08-29 20:06:58 +05:30
Surinder Kumar
2d75eac117
SqlFieldControl enhancements
2016-08-29 13:21:45 +05:30
Ashesh Vashi
f12d981a9d
Handling the bad/lost connection of a database server.
...
Made backend changes for:
* Taking care of the connection status in the psycopg2 driver. And, when
the connection is lost, it throws a exception with 503 http status
message, and connection lost information in it.
* Allowing the flask application to propagate the exceptions even in the
release mode.
* Utilising the existing password (while reconnection, if not
disconnected explicitly).
* Introduced a new ajax response message 'service_unavailable' (http
status code: 503), which suggests temporary service unavailable.
Client (front-end) changes:
* To handle the connection lost of a database server for different
operations by generating proper events, and handle them properly.
Removed the connection status check code from different nodes, so that
- it generates the proper exception, when accessing the non-alive
connection.
Fixes #1387
2016-08-29 12:01:35 +05:30
Surinder Kumar
4c2020cdc7
Allow the use of the tab key to select options in combo boxes. Fixes #1251
2016-08-22 12:18:38 +01:00
Surinder Kumar
761b54ce69
Allow the user to configure tabs in the SQL editor. Fixes #1406
2016-08-19 11:40:19 +01:00
Surinder Kumar
d5b0cd29d8
Display full text from backgrid cells that overflow in a tooltip. Fixes #1442
2016-08-19 10:54:13 +01:00
Surinder Kumar
1bcac0b67c
Fix more of the funky keyboard shortcuts.
2016-08-08 15:26:37 +01:00
Khushboo Vashi
8e099e29c3
Fix various escaping issues. Fixes #1527
2016-08-05 12:20:00 +01:00
Harshal Dhumal
ec3b9bb15b
Allow to create the foreign table with inherits options. Fixes #1260
2016-08-02 09:38:56 +05:30
Akshay Joshi
e1cc3dded2
Allow customisable delete confirmation messages in backgrid.
2016-08-01 15:18:57 +01:00
Dave Page
16304aafd2
s/buttton/button/g, per Anthony DeBarros. Fixes #1518
2016-08-01 15:16:14 +01:00
Akshay Joshi
e803464ee0
Replace 'Add' buttons with '+'
2016-07-26 12:54:59 +01:00
Harshal Dhumal
875360d1c8
When we use deps functionality, backform controls re-render then. But before we re-render them we must remove old grid (if any) otherwise is causes js error "Unable to call exitEditMode of undefined". Fixes #1497
2016-07-25 14:31:17 +01:00
Dave Page
f783aeac63
Change button label to initcap.
2016-07-21 17:18:15 +01:00