e793413d76
Fixed issue by adding extra check for 'relkind' column
2017-07-07 12:33:58 +05:30
c2fb0394bf
Added support of Declarative Partitioning (Range, List) for PostgreSQL 10.
...
This allows the user to create partitioned table and it's partitions.
- Edit partitions, Create/Listing of constraints, rules, triggers under partitions. (Implemented by Harshal)
- Updating browser tree node when create/attach/detach partitions from table dialog.(Implemented by Ashesh)
2017-07-07 11:55:55 +05:30
ca7fe9a520
Ensure the save password option is enabled when creating a server. Fixes #2540
2017-07-06 13:33:46 +01:00
e5bedf088e
In subnodes without dropdowns, the rows had smaller height, making them appear unintentionally different than those with dropdowns. Make them the same.
2017-07-06 13:11:40 +01:00
e2cbaaef71
UI tweaks for the query history.
2017-07-06 13:08:29 +01:00
1291841d98
Remove unused minimisation code
2017-07-06 13:04:13 +01:00
9de6c08d28
Allow use of Shift+Tab to un-indent selected text. Fixes #1988
2017-07-05 14:20:19 +01:00
2bb01e2d1a
Fix alert layout when more than one are shown at once.
2017-07-05 12:04:48 +01:00
76939e4f63
Prompt the user to save dirty queries rather than discard them for a more natural workflow. Fixes #1972
2017-07-04 23:39:10 +01:00
b211eb199c
Improve styling for alerts by highlighting the icon.
2017-07-04 12:03:32 +01:00
66b101fe4c
Resolve a number of issues with domains and domain constraints. Fixes #2529
2017-07-04 11:52:58 +01:00
0aa763b706
Remove unnecessary whitespace from stored procedure SQL. Fixes #2146
2017-07-03 16:32:19 +01:00
5c7dcaba81
Allow debugging of functions in packages. Fixes #1948
2017-07-03 16:30:12 +01:00
070a9c077e
Allow breakpoints to be set on triggers on views. Fixes #2528
2017-07-03 16:15:42 +01:00
f6b879233c
Fix deletion of table rows with the column definition having NOT NULL TRUE and HAS NO DEFAULT VALUE. Fixes #2527
2017-07-03 15:49:59 +01:00
2d5e55964a
Improve the debugger's default page layout, and prevent attempts to continue debugging after the user has stopped. Fixes #2512 , Fixes #2511
2017-07-03 15:14:45 +01:00
1977a5fcda
Fix clipboard handling with large datasets. Fixes #2489
2017-07-03 11:19:02 +01:00
4e21cdb64b
Fix a syntax error in the SQL Editor.
2017-07-03 11:02:20 +01:00
1e427890de
Fix an issue where duplicate entry is made of successful executed query, one with status message and one without status message.
2017-07-03 11:00:42 +01:00
7c09a8f827
Fix typo that caused a layout issue with the Edit Grid.
2017-06-30 12:58:47 +01:00
ffb00b502a
Fix a couple of gripes from the JS linter on Windows.
2017-06-30 10:34:06 +01:00
f2d2075d81
Update alertify alerts to use the styling defined in the styleguide (missed some files in the original commit).
2017-06-30 10:23:12 +01:00
2a30a86e7d
Update alertify alerts to use the styling defined in the styleguide.
2017-06-30 10:21:05 +01:00
ba3ab7b322
Add support for SCSS building in webpack.
2017-06-30 10:15:44 +01:00
501120701e
Allow the dashboard panel to be closed. Fixes #2506
2017-06-30 10:11:34 +01:00
2d65312910
Improve speed of Select All in the results grid. Fixes #2522
2017-06-30 09:54:31 +01:00
c98b64fd82
1) Edit cellEditing function, in some cases grid object is undefined.
...
2) Modify SubNodeCollectionControl, so that user can pass custom backgrid row.
3) Handling of visible parameter in SubNodeCollectionControl.
4) Customise title and delete message for Delete Cell.
5) Added Backgrid.Extension.Select2DepCell and moved Backgrid.Extension.StringDepCell from user management to backgrid.pgadmin.js.
2017-06-29 19:01:29 +05:30
7389744ecf
A number of minor cleanups to the recent changes to the query tool.
2017-06-28 09:49:39 -04:00
301798d87a
Fix encoding issue when saving servers. Fixes #2518
...
Patch by Khushboo, based on a suggested fix from Ladislav Jech
2017-06-28 09:44:32 -04:00
a9fa093d4b
Allow non-superusers to debug their own functions and prevent them from setting global breakpoints. Fixes #2162
...
Based on a patch from Kit Yam Tse
2017-06-27 16:58:07 -04:00
7f55412059
Overhaul the query history tab to allow browsing of the history and full query text. Fixes #2282
...
Patch by Joao and the team at Pivotal.
2017-06-27 10:55:57 -04:00
e413186d23
Add stylesheet to override brace matching styles, missed from the feature commit.
2017-06-27 10:41:26 -04:00
96412b3219
Revert "Allow the user to close the dashboard panel. Fixes #2506"
...
This reverts commit a87ee6d059
2017-06-27 10:35:43 -04:00
1b49bb8b22
Add preferences to enable brace matching and brace closing in the SQL editors. Fixes #2513
2017-06-27 09:57:38 -04:00
a87ee6d059
Allow the user to close the dashboard panel. Fixes #2506
2017-06-27 09:21:24 -04:00
c65158312d
Use on-demand loading for results in the query tool. Fixes #2137
...
With a 27420 row query, pgAdmin III runs the query in 5.873s on my laptop. pgAdmin 4 now takes ~1s.
2017-06-27 09:03:04 -04:00
15cb9fc35b
Add support for the hostaddr connection parameter. This helps us play nicely with Kerberos/SSPI and friends. Fixes #2191
2017-06-26 15:48:59 -04:00
3f4781cdcb
Un-break query tool feature tests.
2017-06-26 15:25:05 -04:00
27bc5c803f
Ensure saved passwords are effective immediately, not just following a restart when first saved. Fixes #1920
2017-06-26 07:55:34 -04:00
d4e77deda4
Ensure revoked public privileges are displayed in the RE-SQL for functions. Fixes #2507
2017-06-26 07:50:39 -04:00
cfb4b11573
Use client-side url_for in the sql editor and data grid modules.
2017-06-26 07:43:03 -04:00
6b6d3369b3
Wait for the Tools menu to be populated when running the feature tests, instead of failing.
...
Fix by Khushboo, based on Harshal's previous work.
2017-06-23 14:07:31 +01:00
92b1b1365e
Tidy up About box formatting, 'cos it's been annoying me for ages.
2017-06-23 10:21:40 +01:00
6fabf4764b
Add access keys for top level menus.
2017-06-23 09:58:46 +01:00
7a4945ff9e
Fix removal of sizes from column definitions. Fixes #2155
2017-06-23 09:42:46 +01:00
9af29364c7
Fix cell selection window alignment for the updated SlickGrid.
2017-06-23 09:37:58 +01:00
94aa5487fb
Update Slickgrid to 2.3.7. As this version includes all the features we need, it can be moved out of the vendor directory and we'll use yarn to pull it in.
2017-06-23 09:35:56 +01:00
25282f3094
Additional preference fix.
2017-06-22 14:55:45 +01:00
0ab637c7ab
Fix import/export to work as expected with TSV data. Fixes #1934
2017-06-22 13:57:32 +01:00
33e75d24f8
Fix preferences handling for utilities.
2017-06-22 12:18:56 +01:00
137bae1b04
Ensure default values are honoured when adding/editing columns. Fixes #1860
2017-06-22 12:11:02 +01:00
d26337a1ba
Moved the javascripts of the following browser node modules to the
...
'static' directory from 'templates' in the respective module directory:
- Server Group
- Server
- Database
- Schema
- Cast
- Event trigger
- Extension
- Foreign data wrapper
- Language
- Catalog Object
- Collation
- Domain Constraint
- Domain
- Foreign server
- FTS Configuration
- FTS Dictionary
- FTS Parser
- FTS Template
- Function
- Procedure
- Trigger Function
- Package
- Sequence
- Catalog
- Schema
- Synonym
- Table
- Type
- Materialized View
- View
- pgAgent Modules
+ Job (pga_job)
+ Schedule (pga_schedule)
+ Steps (pga_jobstep)
Added new dynanic modules for listing the supported server types, and
current user information.
NOTE: We've not yet moved the javascripts for the children of the table
module.
2017-06-22 15:58:32 +05:30
67fd119de8
Maintain a client-side cache of preference values, populated using an async call. Fixes #2487
2017-06-21 17:09:59 +01:00
b9f6fb9545
Update MatView and pgAgent modules to work with recent integer/numeric changes. Fixes #2504
2017-06-21 17:03:43 +01:00
b9736cbd74
Handle missing/dropped synonyms gracefully. Fixes #2503
2017-06-21 16:59:43 +01:00
5cfa22cf23
Fix React to work with QtWebKit
...
We learned that the underlying issue was related to react-dom's SyntheticEvent.augmentClass function being undefined.
This seems to be caused by attempted property assignment after the SyntheticEvent had been replaced by a Proxy of itself. This works fine in Chromium et al, but QtWebKit doesn't deal with Proxy Event objects well.
Moving the augmentClass definition and assignment up above the Proxy stuff resolves the issue in a PR to React: https://github.com/facebook/react/pull/10011
2017-06-21 11:25:22 +01:00
a45b87d9b7
Vendorize React. This is required at this time because we need to modify it to work with QtWebKit.
...
The patch to do that has been submitted upstream; if accepted, we can un-vendorize again.
2017-06-21 11:20:02 +01:00
281b67952a
Consolidate selection colors in the drop down menu and browser tree to match the light blue agreed upon in the styleguide.
2017-06-21 11:11:49 +01:00
f0202228d0
Increase the default size of the Grant Wizard to enable it to properly display privileges at the default size on smaller displays. Fixes #2013
2017-06-21 11:08:23 +01:00
9829d74a04
Correct the v10 template path.
2017-06-20 12:04:13 +01:00
34518d328e
No need for the menu icon to link to the homepage, as pgAdmin is a SPA. Fixes #2479
2017-06-20 10:28:35 +01:00
d2ba57c1ab
Properly handle bytea[], and 'infinity'::real/real[]. Fixes #2498 . Fixes #2502 .
2017-06-20 10:19:11 +01:00
1ee555e468
Ensure the feature tests use the correct test settings database. Fixes #2486
2017-06-16 10:17:38 +01:00
900ccebb50
Using client-side implementation of 'url_for' in the settings module.
2017-06-16 08:57:23 +05:30
5c140b3f58
Using client-side 'url_for' implementation in the user management
...
module.
2017-06-16 00:16:30 +05:30
e65b605912
Using client-side 'url_for' implementation in the import/export module.
2017-06-16 00:00:17 +05:30
07580b8444
Using client-side 'url_for' implementation in the maintenance module.
2017-06-15 23:50:53 +05:30
5d45dee686
Fix Yarn tasks for Windows
2017-06-15 15:32:07 +01:00
827aa72e99
Fix a typo in the config file
2017-06-15 15:18:59 +01:00
2a87585665
Fix script options which were inadvertently broken in the query tool tab naming patch.
2017-06-15 12:19:47 +01:00
d70c3003d3
Add double precision[] tests to the query tool.
2017-06-15 11:54:17 +01:00
8376d33d77
Fix canceling of Grant Wizard on Windows. Fixes #2142
2017-06-15 11:42:13 +01:00
fdc9eed514
Ensure text editors render in an appropriate place on the results grid. Fixes #2477
2017-06-14 12:18:27 +01:00
2b4a8ed89c
Un-break the feature tests. Fixes from Surinder and myself.
2017-06-14 09:59:11 +01:00
4b846ae4e0
Fix the JS Bundler test to work when there are multiple servers defined in a test run.
2017-06-14 09:37:20 +01:00
cb97722fc3
Temporarily disable the Javascript bundler test until it handle more than one run.
2017-06-13 14:21:41 +01:00
57d866f7b7
Use a more sensible name for Query Tool tabs. Fixes #2482
2017-06-13 11:34:24 +01:00
467825c2d1
Package 'mock' is required for testing, and for Python < 3.3 only.
2017-06-13 15:57:56 +05:30
794b70daea
Fixed issue of opening file manager dialog from Query Tool.
2017-06-13 15:48:12 +05:30
903389d7b7
Required mock package for python < 3.3.
...
It was required for the commit:
1208206bc0
2017-06-13 15:43:31 +05:30
a9ce9c9717
Skip a test that uses the COLLATE option on PG versions below 9.1 (e.g. Greenplum).
2017-06-13 10:27:09 +01:00
1208206bc0
Initial re-vamp of the History tab.
2017-06-13 09:50:41 +01:00
16a15bf934
Fix the fix for RM2324.
2017-06-13 09:18:44 +01:00
0243d886c3
Using client-side 'url_for' implementation in the Grant-Wizard module.
2017-06-13 11:47:55 +05:30
f9a3878220
Using client-side 'url_for' implementation in the restore module.
2017-06-13 11:00:17 +05:30
4a46f7b1eb
Using client-side 'url_for' implementation in the backup module.
2017-06-13 10:59:11 +05:30
1a7c9d5ca1
Using client-side 'url_for' implementation in the module - bgprocess
...
(background-processes).
2017-06-13 09:18:48 +05:30
f1acad85db
Add a missing translation call.
2017-06-12 17:20:40 +01:00
3f4f8b9e77
Add linting support, and, well, lint.
2017-06-12 16:55:14 +01:00
659eb1c1e8
Bring React into the tree, and add linting and bundling framework for the JS etc.
2017-06-12 16:51:54 +01:00
af43ccfc07
Teach dialogues about Escape to cancel, Enter to Save/OK, and F1 for help. Fixes #1535
2017-06-12 16:43:29 +01:00
ec5bc23dfd
Allow editing of the WITH ADMIN option of role membership. Fixes #2086
2017-06-12 13:58:51 +01:00
3743c6e86e
Refresh the SQL editor view on resize to ensure the contents are re-rendered for the new viewport. Fixes #2078
2017-06-12 13:25:52 +01:00
c435d48885
Properly handle trigger functions with parameters. Fixes #2043
2017-06-12 13:19:49 +01:00
49cd578816
Fix error on the stats tab with PG10. Also, rename the 10.0_plus template directory to 10_plus to match the new versioning. Fixes #2450
2017-06-12 12:53:09 +01:00
8bd8ae001b
Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for Table, Column, Foreign Table and Type node. Fixes #2324
...
Note that this doesn't add full support for PostGIS types to the table/column dialogues, which still can't handle the typmod usage. It does bring support to parity with pgAdmin 3 though.
2017-06-12 12:49:17 +01:00
59da69087c
Stop ignoring yarn.lock, per discussion with Pivotal team.
2017-06-12 09:16:32 +01:00
fd3ddbeafb
Implementation of the client side 'url_for(...)' function.
...
Created a url_for function module to be used by different javascript
modules to use the same functionality of flask at client side.
A python module can expose the list of endpoints, used by its
javascripts, by overriding the 'get_exposed_url_endpoints(self)'
function.
In this patch, we have modified all the browser modules to use this
function. It will allow us to move the majority of the javascript
modules of browser nodes from templates directory to the static
directory.
TODO::
- Move these javascripts modules to the static directory.
- Use this function in all the applicable javascript modules.
e.g. tools, miscellaneous modules
2017-06-12 12:01:25 +05:30
f0d287588a
Couple of minor performance tweaks. Tests on my Windows VM show a consistent 30% startup time reduction.
2017-06-11 13:56:49 +01:00
49976b1934
Fine tune result grid column sizing now we don't have checkboxes.
2017-06-09 09:24:20 +01:00
ee4a847784
Use the correct font for the treeview.
2017-06-09 09:09:39 +01:00
73c6f1ca3b
A little leanup of the styling of the edit grid
2017-06-08 17:06:34 +01:00
aa400cbc12
Fix integer/numeric validation on various dialogues. Fixes #2421
2017-06-08 14:59:26 +01:00
3bcbc50525
Fix the handling of double precision[] type. Fixes #1928
2017-06-08 14:50:51 +01:00
c9b717ed68
Set focus on the first enabled field when a dialogue is opened. Fixes #1533
2017-06-08 14:37:31 +01:00
01bfa88309
Improvements to the Query Results grid:
...
- Improve the UI
- Allow copy/paste from sets of rows, columns or arbitrary blocks of cells
Patch by Matt, Shruti, Joao and Sarah @ Pivotal
Fixes #2476
2017-06-08 13:31:36 +01:00
2fddf750e6
Retain column sizing in the query tool results grid when the same query is re-run multiple times in a row. Fixes #1971
2017-06-08 12:41:56 +01:00
678b891ff7
Fix an intermittent error seen during result polling. Fixes #2470
2017-06-08 12:34:14 +01:00
b149fe371e
Fix various issues with pgAgent job steps and schedules:
...
1) Error on clicking SQL panel when Schedule OR Step node is selected in browser. Fixes #1888
2) Error while dropping Schedule OR Step node. Fixes #1889
3) Newly created Schedule/Step node was not displaying in browser. Fixes #1890
2017-06-08 12:30:00 +01:00
88737248ab
Fix a couple of missing greys.
2017-06-07 16:31:47 +01:00
63c093248d
Allow users to remove default values from columns properly. Fixes #2461
2017-06-07 14:33:28 +01:00
f89aec867a
Resolve the PG datatype feature test flakiness and make for a nice buttery crust.
2017-06-07 14:26:42 +01:00
8d8e7dab3c
Extract row staging into it's own module with tests.
2017-06-07 14:17:10 +01:00
0d05385585
Update the styling to use the set of grays defined in the WIP style guide.
2017-06-07 13:57:49 +01:00
495a3cedb0
List packages in PPAS 9.2-9.4 when creating synonyms. Fixes #1813
2017-06-07 13:44:36 +01:00
b134ae2cb4
Fix the RE-SQL for for views to properly qualify trigger function names. Fixes #2381
2017-06-07 13:40:11 +01:00
ae80976689
Using the client-side translation using the client-side 'gettext'
...
implementation.
This is the first step towards 'Avoid creating the javascript modules
using Jinja templates'.
2017-06-07 15:53:05 +05:30
7e9f82bc17
Prevent attempts to debug procedures with variadic arguments. Fixes #1466
2017-06-06 12:58:52 +01:00
beda7ebbf2
Add feature tests for the View Data tool.
2017-06-06 12:54:20 +01:00
9803468a77
Properly display security labels on EPAS 9.2+. Fixes #1575
2017-06-06 11:46:49 +01:00
cd3484d936
Make $ quoting consistent. Fixes #1525
2017-06-06 11:40:25 +01:00
b82e001478
Ensure that boolean checkboxes cycle values in the correct order. Fixes #2448
2017-06-06 11:29:18 +01:00
bf06d82870
Fix validation for external and range types. Fixes #1795
2017-06-06 11:24:10 +01:00
e6aa3e1494
Fix default values and SQL formatting for event triggers. Fixes #1229
2017-06-06 11:19:40 +01:00
4c2004d479
Correct the validation logic when modifying indexes/exclusion constraints. Fixes #2113
2017-06-06 11:15:51 +01:00
d21cbb8b1f
Handle composite primary keys correctly when deleting rows in the Edit Grid. Fixes #2425
2017-06-06 09:58:47 +01:00
4b74a5ff35
Enable dialogue help buttons on Language and Foreign Table dialogues. Fixes #2116
2017-06-06 09:52:44 +01:00
0bc9997a95
Properly refresh the parent node when renaming children. Fixes #2355
2017-06-06 09:50:05 +01:00
9e98ded06c
Display and allow toggling of trigger enable/disable status from the trigger dialogue. Fixes #2386
2017-06-05 17:11:21 +01:00
3f150f3f4e
Handle procedure flags (IMMUTABLE STRICT SECURITY DEFINER PARALLEL RESTRICTED) properly in RE-SQL on EPAS. Fixes #2280
2017-06-05 17:04:55 +01:00
a4d86d24e6
Cache statistics more reliably. Fixes #2357
2017-06-05 17:01:03 +01:00
456096092d
Avoid re-rendering the edit grid for every row that is pasted.
2017-05-30 16:22:11 +01:00
1f26953504
Cleanup handling of default/null values when data editting. FIxes #2400
2017-05-27 14:51:02 -04:00
10caae4dc6
Increase feature test timeouts.
2017-05-27 14:17:06 -04:00
8aabee352c
Import the ordereddict module for Python 2.6
2017-05-26 12:34:05 -04:00
2c9af4784e
Allow creation of ENUM types with no members. Fixes #2426
2017-05-26 12:21:23 -04:00
dba64e77f1
Order columns in multi-column pkeys correctly. Fixes #2417
2017-05-26 11:04:32 -04:00
45d423c0ce
Ensure the last placeholder is included when generating UPDATE scripts for tables. Fixes #2436
2017-05-26 10:59:09 -04:00
a45bb905f5
Pass the database ID to the query tool when using the Script options. Fixes #2435
2017-05-26 10:57:31 -04:00
3216eca4a8
Add feature tests to ensure that data types are properly rendered in the query tool.
2017-05-26 10:46:58 -04:00
2f097cd016
Fix typo in freshly added check.
2017-05-25 17:10:41 -04:00
e9da157cc7
Add numerous missing checks to ensure objects really exist when we think they do. Fixes #2427
2017-05-25 16:28:04 -04:00
04ce72a6ae
Fix RE-SQL for rules which got the table name wrong in the header and DROP statement. Fixes #2422
2017-05-19 12:21:29 +01:00
eb18320950
Improve error handling in cases where the user tries to rename or create a server group that would duplicate an existing group. Fixes #2414
2017-05-17 15:57:38 +01:00
17de7db70b
Fix server stats display for EPAS 9.2, where inet needs casting to text for concatenation. Fixes #1831
2017-05-17 15:53:13 +01:00
a3226b1eb5
Reverse engineer SQL for table-returning functions correctly. Fixes #1851
2017-05-17 15:49:56 +01:00
655d5888a6
Various FTS dictionary cleanups. Fixes #1126
2017-05-17 14:13:05 +01:00
1db81da020
Fix JS error when selecting a single grid cell.
2017-05-16 08:44:29 +01:00
be42b67f79
Ensure all required directories are created before we start logging.
2017-05-15 15:59:47 +01:00
d7d4bf475b
Various improvements to the NULL/DEFAULT handling in the data editor. Fixes #2399
2017-05-15 15:04:16 +01:00
Akshay Joshi
Murtuza Zabuawala
George Gelashvili
Matthew Kleiman
Dave Page
Harshal Dhumal
Khushboo Vashi
Joao Pedro De Almeida Pereira
Atul Sharma
Surinder Kumar
Ashesh Vashi
Shruti B Iyer
Johan Van de Wauw
Sarah McAlear