Commit Graph

182 Commits (47b2bc8a837f6f2ecdec10bcbbeebde7da46947f)

Author SHA1 Message Date
Khushboo Vashi 9ff015e73c
Added support of AWS provider for BigAnimal cloud deployment. #5569 2023-01-09 12:32:26 +05:30
Akshay Joshi 98184e5835 Update copyright notices for 2023 2023-01-02 11:53:55 +05:30
Aditya Toshniwal 5c34c10d4e
- Move pgadmin4-treeview to pgAdmin main repo.
- Use react based context menu for browser tree. #5615.
- Fix feature tests failure.
2023-01-02 10:51:13 +05:30
Aditya Toshniwal ff9daec5ec
Rewrite pgAdmin main menu bar to use React. #5615 2022-12-22 14:25:18 +05:30
Pravesh Sharma a954f22fe8
Fixed an issue where the CSV file would not download if the CSV quote character length exceeded 1. #5505 2022-11-28 13:49:22 +05:30
Akshay Joshi 398675597a Fixed an issue where AutoComplete was not working correctly due to incorrect regex. #5473 2022-11-07 13:59:18 +05:30
Aditya Toshniwal dd25bb0fff
Reposition the select dropdown when the browser is resized. #5206 2022-10-20 16:21:59 +05:30
Aditya Toshniwal 794cbed57c
Added support to specify the background fill color to the table nodes in the ERD tool. #4392 2022-10-12 10:07:30 +05:30
Nikhil Mohite 9acc59d099
Fixed an issue where pgAdmin is crashing if the user find/replace in the query tool multiple time. #5249 2022-09-30 10:42:00 +05:30
Pravesh Sharma 9817a9b20f
Fixed an issue where user was unable to select privileges in Safari #5327 2022-09-29 16:41:11 +05:30
Nikhil Mohite 0203bbc7ef Added the ability to display the selected text from the query tool in the find/replace box. #5249 2022-09-22 14:59:42 +05:30
Aditya Toshniwal a2a18d4b4a Fixed an error while saving changes to the ERD table. Fixes #5342 2022-09-19 16:20:07 +05:30
Nikhil Mohite ab5d53f3b1 Fixed following issues for Schema Diff:
1) When some option from filter is selected, that particular type should be completely removed from top level result instead of showing identical:0
 2) Copy button is missing for Difference SQL
 3) Throw error when source & target server versions selected are different
 4) In High contrast - Font color for identical turns same as background.
 5) In High contrast - Checkbox box column turns same color of row resulting unable to distingiush about selection of item.

refs #6133
2022-09-13 16:49:44 +05:30
Aditya Toshniwal b128ba2f57 Fixed a couple of SonarQube issues. 2022-09-10 14:04:28 +05:30
Pravesh Sharma 43022b7aa2 Fixed 'ternary operators should not be nested' code smell. 2022-09-10 14:00:22 +05:30
Yogesh Mahajan cbf5886430 Fixed the following code smells:
1. Use concise character class syntax
2. Add a "break" statement or remove this "else" clause.
3. Replace this generic exception class with a more specific one.
4. Use a regular expression literal instead of the 'RegExp' constructor.
5. Use the opposite operator ("not in") instead.
2022-09-10 13:48:14 +05:30
Akshay Joshi b8f63adf41 Fixes following code smell reported by SonarQube:
1) Replace this if-then-else flow by a single return statement
 2) Remove the unnecessary boolean literals.
2022-09-08 19:56:02 +05:30
Yogesh Mahajan 603ce21d24 Fixed an issue where textarea of the JSON Editor does not resize with dialog. Fixes #7656 2022-09-08 15:31:36 +05:30
Nikhil Mohite 0c9c57e608 1. Resolved resize window issue for DDL result panel.
2. Updated the Screenshots.
3. Updated server group title to bold.

refs #6133
2022-09-08 15:24:43 +05:30
Akshay Joshi 18b77f15dd Remove Alertify from pgAdmin completely. Fixes #7619 2022-09-08 15:16:48 +05:30
Nikhil Mohite e1942d8c9e 1) Port schema diff to React. Fixes #6133
2) Remove SlickGrid.
2022-09-07 19:20:03 +05:30
Aditya Toshniwal 0f46f070ed Port the remaining components of the ERD Tool to React. Fixes #7343
1. Make use of MUI styles and remove SCSS.
2. Use the new common components for buttons and tooltips, so that they are consistent.
3. UI design should be aligned with the query tool.
4. Remove tippyjs and Alertify dependencies.
2022-09-06 18:09:13 +05:30
Akshay Joshi e58b9c767b Port search object dialog to React. Fixes #7622 2022-08-30 17:08:12 +05:30
Yogesh Mahajan 41a3345101 Fixed an issue where the cursor was not visible in the code tab of the trigger dialog. 2022-08-23 18:45:43 +05:30
Aditya Toshniwal 09e2c0eac0 1. Explain plan crashes query tool after SonarQube fixes.
2. Fix XSS issue in query tool.
3. Process details for cloud process not showing complete command.
4. Confirm dialog before removing processes.
2022-08-18 18:42:03 +05:30
Aditya Toshniwal 306b184e11 1. Fixed an issue where Alt-Shift-Q didn't work after creating a new query. Fixes #7575
2. Fixed an issue where the Query Editor loses focus when saving a query (Alt+s). Fixes #7521
3. Ensure that an error is thrown if clipboard access is not provided and change the copy rows shortcut. Fixes #7452
2022-08-17 17:23:44 +05:30
Aditya Toshniwal c2b23465cc 1) Added support to show all background processes in separate panel. Fixes #3709
2) Port process watcher to React. Fixes #7404
2022-08-11 10:49:45 +05:30
Akshay Joshi d1c94ac73d Fixed SonarQube issues. 2022-08-05 18:58:03 +05:30
Akshay Joshi 95312f2d14 1) Ensure that autocomplete does not appear when navigating code using arrow keys. Fixes #7573
2) Fixed an issue where autocomplete is not working after clearing the query editor. Fixes #7563
2022-08-01 14:38:32 +05:30
Akshay Joshi 81f52a82c8 Port About dialog to React. Fixes #7567 2022-07-28 10:11:40 +05:30
Aditya Toshniwal 4808df5e95 1) Port the file/storage manager to React. Fixes #7313
2) Allow users to delete files/folders from the storage manager. Fixes #4607
3) Allow users to search within the file/storage manager. Fixes #7389
4) Fixed an issue where new folders cannot be created in the save dialog. Fixes #7524
2022-07-19 15:27:47 +05:30
Akshay Joshi 4585597388 Added option to trigger autocomplete on key press in the query tool. Fixes #4488 2022-07-19 11:55:37 +05:30
Yogesh Mahajan 59f5c0d955 Added support for Azure PostgreSQL deployment in server mode. Fixes #7522 2022-07-06 11:43:49 +05:30
Nikhil Mohite d90b2621da Fixed an issue where passwords entered in the 'Connect To Server' dialog were truncated. Fixes #7440 2022-06-22 17:35:22 +05:30
Akshay Joshi 93bc1f3c57 Added support for visualise the graph using a Line chart in the query tool. Fixes #7485 2022-06-22 17:18:51 +05:30
Nikhil Mohite 2adca6bbc4 1) Added mouse over indication for breakpoint area in the Debugger. Fixes #2647
2) Added search text option to the Debugger panel. Fixes #2648
3) Port Debugger to React. Fixes #6132
2022-06-15 11:37:54 +05:30
Yogesh Mahajan 7e1e068370 Added capability to deploy PostgreSQL servers on Microsoft Azure. Fixes #7178 2022-06-15 11:22:42 +05:30
Aditya Toshniwal ea3203f466 Fixed and issue where 'Use spaces' not working in the query tool. Fixes #7443 2022-06-13 11:46:09 +05:30
Pradip Parkale a5ad956088 Ensure that when Authentication buttons are disabled their text is visible in the Dark and High contrast theme. Fixes #7347 2022-05-24 17:12:37 +05:30
Khushboo Vashi 345cfd7c60 Ensure that unwanted APIs should not be getting called for BigAnimal. Fixes #7368
Updated the BigAnimal icon.
2022-05-24 11:34:23 +05:30
Akshay Joshi 4f7bcc2919 Added the ability to detect and warn users about bidirectional Unicode characters. Fixes #7002 2022-05-23 16:04:21 +05:30
Pradip Parkale 11cfea3860 Added the ability to resize columns on dashboard tables. Fixes #7364 2022-05-18 17:49:54 +05:30
Aditya Toshniwal ca8e14455f Fixed the following issues:
1. Feature test cases for the new query tool.
 2. Query tool panel rename is not persisting.
2022-05-12 18:29:09 +05:30
Pradip Parkale a0c85431dc Ensure that the Dashboard column sort order should be remembered when the refresh button is clicked. Fixes #7339 2022-04-29 10:26:24 +05:30
Aditya Toshniwal bd799ea51a Autofocus CodeMirror SQL input to the first element of a form. 2022-04-28 14:09:27 +05:30
Pradip Parkale 7c61017f57 Fixed an issue where the Dashboard Server Activity was showing old queries as active. Fixes #7305 2022-04-28 12:10:42 +05:30
Khushboo Vashi 5677b1e5f8 Added capability to deploy PostgreSQL servers on EDB BigAnimal. Fixes #7179 2022-04-26 16:41:10 +05:30
Aditya Toshniwal 0795b22ae6 Fixed the following issues for the new query tool:
1) In Dark mode > Replace/Find dialogue forward & reverse buttons are stuck to each other.
 2) In Dark/High contrast mode > Checkbox is not visible for false value.
 3) Wrap toolbar when size goes very small.
 4) Replace functionality does not work when tried in sequence 2 times. Codemirror search is not cyclic. So, changes are made to always search from the start.
 5) Replace all does not work when tried in sequence 2 times. Same reason as above.
 6) Fix broken macros $SELECTION$ feature.
 7) Make query history SQL readonly.
 8) The Filter dialog save button should be disabled when opened.
2022-04-26 16:27:53 +05:30
Aditya Toshniwal e5ef6a7b21 Fixed following issues for Query Tool (after React Porting):
1) Find/Replace both opens the same dialogue box.(by clicking menu option)
2) Add New Server Connection > Server options keep loading(For multiple Server groups & should have some server)
3) Fixed CSS issues of slickgrid at various places.
4) C should be captial in ’<New connection…>'
5) In pop title for New Connection, all words should be capital.(Add new connection)
6) Explain > Analaysis tab > Column heading missing ROWS PLAN with cost & In explain only.
7) Explain > Analaysis tab > with cost enabled > Upward arrow size does not match with font of number. Arrow is little bigger than number.
8) Boolean default is not considered while ading new row.(try table from feature test defaults)
9) In query history , when not query history present, warning icon size big. Match it to warning message - No history found
10) Select table/db object > Open query tool from Tools menu > NOT FOUND error is shown. Existing issue, fixed.
11) Any cell just open by clicking it > Do NOT change any thing > Click Ok > Cell is shown as edited.

refs #6131
2022-04-20 19:02:16 +05:30
Aditya Toshniwal 9c30d983bd Fixed following issues for query tool after react porting:
1) Add New Server Connection > Server options keep loading(For empty Server group).
 2) After clicking indent/Unindent(for all operations) for large query option left as it is till operation completes
 3) Check sign beside options in Execute Option/Copy Header is little bit big
 4) In explain > Analysis tab does not show ROWS column
 5) In explain > Explain > analysis previous explain output is NOT cleared. New rows are appended. Same applies to the statistics tab.
 6) Update new query tool connection tool tip. Fixes #7289
 7) Explain-Analyze > Loops column is empty.
 8) Explain-Analyze with Verbose & Costs > in ROW X columns upward arrows are missing.
 9) Explain-Analyze with all option checked > background colors are missing for timing.
 10) Explain-Analyze > Additional bullet is added before Hash Cond.
 11) Browser Tree > Filtered rows icon is not working.
 12) Create table with timestamp and default value as function now() > Add new row > Enter mandatory columns except column where default value is function(now()) > Click Save > New row added but column with default value has value [default]. not updated to actual value. / Default values are not considered for any column while adding a new entry.
 13) Disable execute options in View/Edit data.
 14) The Boolean column always shows null.
 15) In Query history Remove & Remove all buttons are stuck to each other.
 16) On Remove all, the right panel is empty.
 17) Create a column with boolean[]/ text[], Try to add a new entry from data grid, enter “” quotes > Click Ok > Now try edit cell > You can not change value.
 18) In query history - Select queries are suffixed by ’Save Data’ icon
 19) Edit any table with PK > Try to insert duplicate PK > Error thrown > Correct pK value > Still old error shown > Not able to add new entry (This works when focus is moved from edited cell)
 20) Clicking arrows after opening dropdown options, does not collapse dropdown.

refs #6131
2022-04-18 12:50:51 +05:30
Pradip Parkale 131ff4de48 Ensure that sorting should be preserved on refresh for Server Activity. Fixes #7308 2022-04-14 11:11:45 +05:30
Pradip Parkale c2f1a7bdc5 Ensure the database and schema restriction controls are not shown as a drop-down. Fixes #7255 2022-04-09 12:09:35 +05:30
Aditya Toshniwal b5b9ee46a1 1) Port query tool to React. Fixes #6131
2) Added status bar to the Query Tool. Fixes #3253
3) Ensure that row numbers should be visible in view when scrolling horizontally. Fixes #3989
4) Allow removing a single query history. Refs #4113
5) Partially fixed Macros usability issues. Ref #6969
6) Fixed an issue where the Query tool opens on minimum size if the user opens multiple query tool Window quickly. Fixes #6725
7) Relocate GIS Viewer Button to the Left Side of the Results Table. Fixes #6830
8) Fixed an issue where the connection bar is not visible. Fixes #7188
9) Fixed an issue where an Empty message popup after running a query. Fixes #7260
10) Ensure that Autocomplete should work after changing the connection. Fixes #7262
11) Fixed an issue where the copy and paste row does not work if the first column contains no data. Fixes #7294
2022-04-07 17:36:56 +05:30
Pradip Parkale 8f8adcf71b 1 Fixed the issue where db connection was getting disconnected for dashboard, if network is slow.
2 Fixed publication collection node properties issue which was missed during react node porting.
3 Removed unwanted variable from theme style sheet.
2022-04-05 13:40:22 +05:30
Aditya Toshniwal 953a9d7fd1 Fixes some issues and improves the PgTable component. 2022-04-05 12:10:51 +05:30
Nikhil Mohite 56a4263a5c Fixed an issue in loading user details on the properties panel. Fixes #7287 2022-04-05 11:19:24 +05:30
Aditya Toshniwal 4fff26c571 Makes some improvements/restructurings to the PgTable component. 2022-04-04 19:06:43 +05:30
Pradip Parkale b397ba7787 Fixed issues related to porting of properties collection and dashboard.
refs #7132
2022-04-04 17:42:42 +05:30
Nikhil Mohite 07527ba69b Fixed maximize button issue on the preferences dialog.
refs #7149
2022-04-03 12:27:47 +05:30
Pradip Parkale cb052f1988 1) Port Properties panel for collection node, Dashboard, and SQL panel in React. Fixes #7132
2) Added transaction start time to Server activity sessions view. Fixes #7215
2022-03-30 12:06:59 +05:30
Nikhil Mohite 931a399890 Fixed issues in the Preferences:
1) Show a single note in the binary path.
  2) Resolved issue in the keyboard shortcut.

refs #7149
2022-03-29 16:27:33 +05:30
Nikhil Mohite 0b4a874f30 Fixed an issue where unexpected error messages are displayed when users change the language via preferences. Fixes #7267 2022-03-24 16:08:13 +05:30
Aditya Toshniwal 7f2e87b27d Fixed Jasmine test cases. 2022-03-24 12:05:59 +05:30
Nikhil Mohite 2f37f0ca51 Fixes for the preferences dialog
1) Add server mode validation in the binary path.
  2) Updated preferences tree rendering to avoid using the ReactDOM render.
  3) Updated CSS for keyboard shortcuts checkbox border makes it consistent with input box border.
  4) Fixed jasmine test case and improved code coverage.
  5) Fixed SonarQube issues.
  6) Added validation to disable "Maximum column with" option if "Column sized by" option is set to "Column name" in Query Tool -> Result grid.
  7) Updated documentation with the latest screenshots.
  8) Correct typo in the documentation. Fixes #7261

refs #7149
2022-03-23 13:28:35 +05:30
Nikhil Mohite 74e794b416 Port preferences dialog to React. Fixes #7149 2022-03-21 13:29:26 +05:30
Khushboo Vashi 69069e9af3 The following issues related to cloud deployment have been resolved:
- Masking the credentials input fields
- The loading symbol doesn't work while reloading the options in the select control
- Reduce the wizard opening timeout
- urllib library upgrade impacts host IP fetch

refs #7177
2022-03-02 19:04:15 +05:30
Aditya Toshniwal bc4e8a3c82 Implemented utilities in React to make porting easier for pgAdmin tools. 2022-02-11 10:36:24 +05:30
Pradip Parkale 7a2716bf77 Fixed issues related to porting of dependent, dependencies, and statistics panel.
refs #7016
2022-02-03 11:13:39 +05:30
Nikhil Mohite 64c419e6f8 Fixed Jasmine test cases.
refs #7110
2022-02-02 17:55:14 +05:30
Nikhil Mohite b4b658c59d Ensure that cursor should be focused on the first options of the Utility dialogs. Fixes #7110 2022-02-02 14:48:35 +05:30
Aditya Toshniwal bc0b25d995 1) Fixed an issue where a warning message was shown after database creation/modification. Fixes #7142.
2) Added error boundary to schema view which will improve the exception stack trace details.
3) Fixed Jasmine test cases.
2022-01-31 13:41:22 +05:30
Pradip Parkale 094129e2be Port Dependent, dependencies, statistics panel to React. Fixes #7016 2022-01-24 14:13:02 +05:30
Akshay Joshi 343c3ee49c Fixed following code smells reported by SonarQube:
1) Remove this redundant jump.
 2) Remove this commented out code.
 3) Variables should not be shadowed.
2022-01-21 18:54:23 +05:30
Aditya Toshniwal fbc3b1a318 Added support for grouping in input select boxes and allow setting default selected options. 2022-01-18 18:44:55 +05:30
Akshay Joshi 9f836f5433 Fixed following code smells reported by SonarQube:
1) Immediately return this expression instead of assigning it to the temporary variable.
 2) Extract this nested ternary operation into an independent statement.
 3) Expected a `for-of` loop instead of a `for` loop with this simple iteration.
2022-01-18 14:49:54 +05:30
Akshay Joshi c98fb887cc Fixed code smell 'Unexpected empty arrow function' reported by SonarQube. 2022-01-12 17:32:20 +05:30
Akshay Joshi 2786f7ac5a Update copyright notices for 2022 2022-01-04 13:54:25 +05:30
Akshay Joshi 9dd957a2aa Added support to import/export server groups and servers from GUI. Fixes #4803 2022-01-04 12:27:17 +05:30
Nikhil Mohite e18ce2c9e3 Updates CSS and structure in Wizard, also fixed css issues in GrantWizard. 2021-12-31 14:16:50 +05:30
Nikhil Mohite 45179ccb8c Change logic for grant wizard, wizard component, and updated CSS. 2021-12-22 18:26:21 +05:30
Akshay Joshi 02b83146be 1) Added spacing for message and loading spinner.
2) Rename the GrantWizard Dialog.
3) Return the activeStep from disableNextStep function.
2021-12-21 18:00:07 +05:30
Akshay Joshi 92a997b16a Rearrange tools menu on the basis of usability and form groups of similar sub-menus. 2021-12-16 18:29:44 +05:30
Aditya Toshniwal dfdaf7f6d1 Implemented React based modal provider to create models on the fly.
Also, use this to replace Alertify alert and confirm dialog.
2021-12-03 12:50:24 +05:30
Akshay Joshi c6424e3897 Replaced alertifyjs notifiers with React-based notistack. Fixes #7004 2021-12-02 16:05:52 +05:30
Aditya Toshniwal 1ed4d0f95e Fixed an issue where textarea should be allowed to resize and have more than 255 chars. Fixes #6976 2021-11-07 10:51:54 +05:30
Akshay Joshi 39992a817d Added support of Aggregate and Operator node in view-only mode. Fixes #3834 2021-10-29 16:14:33 +05:30
Aditya Toshniwal 038fd6ce21 Fixed Dark theme UI related issues. Fixes #6846 2021-10-04 12:41:48 +05:30
Nikhil Mohite 1a25fdffbb Ensure that the 'When' field should be read-only in the properties panel. Fixes #6836 2021-09-30 16:25:27 +05:30
Aditya Toshniwal 381f5edbd5 Few more stability improvements to date time picker.
refs #6816
2021-09-30 15:00:32 +05:30
Nikhil Mohite 3da85f415d Fixed an issue while saving grant wizard data with user-defined functions. Fixes #6826 2021-09-30 10:56:51 +05:30
Akshay Joshi 1b6ab6b3bb 1) Fixed pgAgent related issues. Fixes #6827
2) Added helpMessageMode parameter to hide help messages from properties panel.
2021-09-29 19:48:43 +05:30
Aditya Toshniwal 332351efaf 1. Date time control not working on firefox.
2. Replace moment with date-fns in date time control as date-fns is more maintained.

Fixes #6816
2021-09-29 13:43:05 +05:30
Aditya Toshniwal be69470d55 Server and Database node fixes:
1. Unable to change shared server switch.
2. DB restriction and schema restriction have an empty option.
3. File select input control does not allow manual text input.
4. In the Parameters tab if the value is a switch control, then an empty value error should not come.
5. Values for parameters should be reset on changing parameters.
6. Added a new key - helpMessageMode which can have a value similar to mode. It will show the help message if the mode is supported.

Fixes #6814
2021-09-28 15:05:32 +05:30
Aditya Toshniwal dc8ab7cd2a 1. Switch control and CodeMirror control UI improvements for read-only and disabled states.
2. If a form input value changes to null, pass it as an empty string in URL params.
3. Use server_type instead of type from the server info.
2021-09-28 10:24:25 +05:30
Akshay Joshi 8125320093 Fixed linter error. 2021-09-23 17:12:34 +05:30
Akshay Joshi ecaaa8a1b5 Fixed scrollbar issue and used flex layout in grant wizard. 2021-09-23 16:59:59 +05:30
Akshay Joshi b9bc628189 1. Placeholder should be inside the controlProps. Change the placeholder from 'Select...' to 'Select an item...'
2. Updated grant wizard screenshot and documentation.
3. Remove '(Beta)' from ERD Tool and PSQL Tool.
2021-09-23 16:17:39 +05:30
Aditya Toshniwal 9179b7464b Fixed following issues after React Porting:
1. Unique constraint should not allow changing values for deferrable, deferred, included columns.
2. Primary keys should not allow changing values for deferrable, deferred, included columns.
3. Foreign keys should not allow changing match type. The referenced table name is empty.
4. Exclude - Column/Expression has incorrect values.
5. Save should not be enabled when Custom auto-vacuum is enabled but none of the parameters are edited.

Fixes #6777
2021-09-23 14:46:10 +05:30
Nikhil Mohite 15a494c189 Fixed review comments for Grant Wizard.
refs #6687
2021-09-23 14:40:38 +05:30
Aditya Toshniwal a1aa080956 Fixed an issue where unable to change the column properties from edit dialog. Fixes #6766 2021-09-22 18:23:40 +05:30