Commit Graph

145 Commits (47b2bc8a837f6f2ecdec10bcbbeebde7da46947f)

Author SHA1 Message Date
Khushboo Vashi e1c5a06bf0 Fixed some cloud deployment issues:
- Added High Availability option
 - Server group renamed to pgAdmin server group
 - Removed the Private option from Networking otherwise, it would not be possible to connect the server from pgAdmin.
2022-06-09 14:07:05 +05:30
Aditya Toshniwal 1135821870 Fix Query tool issues:
1. Warning/Confirm dialogs should be inside the query tool.
2. The Help button in View/Edit data should open the corresponding help page.
3. Disable execute options when query tool in transaction.
4. Grid not loading more than 10000 rows. react-data-grid issue, PR sent. Use a fork till then.
5. NOTICE messages should not be part of Notifier success popups.

Fixes #7350
2022-05-09 12:39:29 +05:30
Aditya Toshniwal bd799ea51a Autofocus CodeMirror SQL input to the first element of a form. 2022-04-28 14:09:27 +05:30
Aditya Toshniwal 25b89f7624 Fixed the following issues for the new query tool:
1) Failed to fetch query history error sometimes.
 2) In copy paste row, if a copied row has [null], then those are pasted as an empty string.
 3) When Data output is empty, show an empty grid.
 4) Schema diff generates a script button resulting in an empty window. Fixes #7306.
 5) Detach the DataOutput panel > Try editing text cell > Text editor is hidden behind the data output panel

refs #6131
2022-04-25 18:11:39 +05:30
Aditya Toshniwal a91762fb30 Ensure that Columns should always be visible in the import/export dialog. Fixes #7252 2022-04-11 17:25:19 +05:30
Aditya Toshniwal b5b9ee46a1 1) Port query tool to React. Fixes #6131
2) Added status bar to the Query Tool. Fixes #3253
3) Ensure that row numbers should be visible in view when scrolling horizontally. Fixes #3989
4) Allow removing a single query history. Refs #4113
5) Partially fixed Macros usability issues. Ref #6969
6) Fixed an issue where the Query tool opens on minimum size if the user opens multiple query tool Window quickly. Fixes #6725
7) Relocate GIS Viewer Button to the Left Side of the Results Table. Fixes #6830
8) Fixed an issue where the connection bar is not visible. Fixes #7188
9) Fixed an issue where an Empty message popup after running a query. Fixes #7260
10) Ensure that Autocomplete should work after changing the connection. Fixes #7262
11) Fixed an issue where the copy and paste row does not work if the first column contains no data. Fixes #7294
2022-04-07 17:36:56 +05:30
Akshay Joshi 38278c179e Ensure that the master password dialog is popped up if the crypt key is missing. Fixes #6960 2022-04-04 17:00:18 +05:30
Aditya Toshniwal 7f2e87b27d Fixed Jasmine test cases. 2022-03-24 12:05:59 +05:30
Nikhil Mohite 2f37f0ca51 Fixes for the preferences dialog
1) Add server mode validation in the binary path.
  2) Updated preferences tree rendering to avoid using the ReactDOM render.
  3) Updated CSS for keyboard shortcuts checkbox border makes it consistent with input box border.
  4) Fixed jasmine test case and improved code coverage.
  5) Fixed SonarQube issues.
  6) Added validation to disable "Maximum column with" option if "Column sized by" option is set to "Column name" in Query Tool -> Result grid.
  7) Updated documentation with the latest screenshots.
  8) Correct typo in the documentation. Fixes #7261

refs #7149
2022-03-23 13:28:35 +05:30
Nikhil Mohite 74e794b416 Port preferences dialog to React. Fixes #7149 2022-03-21 13:29:26 +05:30
Aditya Toshniwal f9707a8bf5 Allow users to scroll and enter input when there is a validation error. Fixes #7172 2022-03-04 17:25:36 +05:30
Khushboo Vashi e61a1045f5 Added capability to deploy PostgreSQL servers on Amazon RDS. Fixes #7177 2022-02-14 12:13:48 +05:30
Aditya Toshniwal bc4e8a3c82 Implemented utilities in React to make porting easier for pgAdmin tools. 2022-02-11 10:36:24 +05:30
Nikhil Mohite 64c419e6f8 Fixed Jasmine test cases.
refs #7110
2022-02-02 17:55:14 +05:30
Nikhil Mohite b4b658c59d Ensure that cursor should be focused on the first options of the Utility dialogs. Fixes #7110 2022-02-02 14:48:35 +05:30
Aditya Toshniwal bc0b25d995 1) Fixed an issue where a warning message was shown after database creation/modification. Fixes #7142.
2) Added error boundary to schema view which will improve the exception stack trace details.
3) Fixed Jasmine test cases.
2022-01-31 13:41:22 +05:30
Akshay Joshi 0ce3434631 Fixed code smell 'Update this function so that its implementation is not identical' reported by SonarQube. 2022-01-25 20:10:31 +05:30
Akshay Joshi 343c3ee49c Fixed following code smells reported by SonarQube:
1) Remove this redundant jump.
 2) Remove this commented out code.
 3) Variables should not be shadowed.
2022-01-21 18:54:23 +05:30
Akshay Joshi 1013d7ccdd Fixed code smell reported by SonarQube. 2022-01-20 16:58:21 +05:30
Akshay Joshi 9f836f5433 Fixed following code smells reported by SonarQube:
1) Immediately return this expression instead of assigning it to the temporary variable.
 2) Extract this nested ternary operation into an independent statement.
 3) Expected a `for-of` loop instead of a `for` loop with this simple iteration.
2022-01-18 14:49:54 +05:30
Akshay Joshi c98fb887cc Fixed code smell 'Unexpected empty arrow function' reported by SonarQube. 2022-01-12 17:32:20 +05:30
Akshay Joshi e38c38cd58 Fixed following SonarQube code smells:
1) Remove this useless assignment to a variable.
2) Remove the unused local variable.
2022-01-12 14:53:19 +05:30
Nikhil Mohite af6ff20020 Fixed SonarQube issues. 2022-01-07 19:58:19 +05:30
Nikhil Mohite ad862f4084 Port Maintenance dialog to React. Fixes #7019 2022-01-07 12:07:49 +05:30
Rahul Shirsat 6528d086ba Fixed review comments:
1. Split the restore options/backup options into 2 tabs
2. Restore icon changes
3. feature tests issues
4. restore help link broken
5. Comment section not visible

refs #7018
2022-01-06 16:46:44 +05:30
Akshay Joshi 2786f7ac5a Update copyright notices for 2022 2022-01-04 13:54:25 +05:30
Akshay Joshi fd53e4f5f9 Replace Alertify alert and confirm with React-based model dialog. Fixes #7053 2021-12-07 18:52:40 +05:30
Akshay Joshi c6424e3897 Replaced alertifyjs notifiers with React-based notistack. Fixes #7004 2021-12-02 16:05:52 +05:30
Nikhil Mohite 3afeb8ca46 Port Backup Global, Backup Server, and Backup object dialog in React. Fixes #6984 2021-11-22 11:20:44 +05:30
Akshay Joshi 39992a817d Added support of Aggregate and Operator node in view-only mode. Fixes #3834 2021-10-29 16:14:33 +05:30
Aditya Toshniwal a2f5e6ad8f Fixed an issue where the wrong SQL is generated when deleting and renaming table columns together. Fixes #6935 2021-10-19 17:13:12 +05:30
Aditya Toshniwal 9ace229152 Fixed an issue where exclusion constraint cannot be created from table dialog
if the access method name is changed once. Fixes #6900
2021-10-13 11:35:19 +05:30
Nikhil Mohite 5b9383c880 Fixed an issue where the user is unable to create an index with concurrently keyword. Fixes #6790 2021-10-12 18:19:40 +05:30
Aditya Toshniwal a92c1b43a2 1) Added support for advanced table fields like the foreign key, primary key in the ERD tool. Fixes #6081
2) Added index creation when generating SQL in the ERD tool. Fixes #6529
2021-10-11 17:42:14 +05:30
Aditya Toshniwal 400896c563 1. Operators dropdown disabled. Fixes #6771.
2. Vacuum options value is not considered for M-SQL when creating. Fixes #6781.
2021-10-05 14:13:15 +05:30
Aditya Toshniwal 357a020828 Table node related fixes:
1. File select control sets the value for all other to last selected file. Fixes #6814
2. Vacuum parameters-related issues. Fixes #6777
3. Exclusion removes all columns if one row is removed. Fixes #6771
2021-10-01 12:57:04 +05:30
Aditya Toshniwal 08706ba6b2 1. Make Unlogged switch in table as read only.
2. Fix a console warning when saving node data.

Fixes #6778
2021-09-28 17:48:09 +05:30
Aditya Toshniwal be69470d55 Server and Database node fixes:
1. Unable to change shared server switch.
2. DB restriction and schema restriction have an empty option.
3. File select input control does not allow manual text input.
4. In the Parameters tab if the value is a switch control, then an empty value error should not come.
5. Values for parameters should be reset on changing parameters.
6. Added a new key - helpMessageMode which can have a value similar to mode. It will show the help message if the mode is supported.

Fixes #6814
2021-09-28 15:05:32 +05:30
Aditya Toshniwal dc8ab7cd2a 1. Switch control and CodeMirror control UI improvements for read-only and disabled states.
2. If a form input value changes to null, pass it as an empty string in URL params.
3. Use server_type instead of type from the server info.
2021-09-28 10:24:25 +05:30
Aditya Toshniwal 0228d16990 Partition related fixes:
1. When attaching a partition, tables were not loading in the dropdown.
2. When adding a sub partition in a partition, collations were not loading in dropdown.
3. Fix some grid column widths in table node.

Fixes #6783
2021-09-24 16:28:55 +05:30
Aditya Toshniwal d28f8bc7ee Fixed exclusion constraint issues:
1. Incorrect error message.
2. Properties panel Column Section data missing
3. Operator class value is missing

Fixes #6771
2021-09-23 19:28:35 +05:30
Aditya Toshniwal 9179b7464b Fixed following issues after React Porting:
1. Unique constraint should not allow changing values for deferrable, deferred, included columns.
2. Primary keys should not allow changing values for deferrable, deferred, included columns.
3. Foreign keys should not allow changing match type. The referenced table name is empty.
4. Exclude - Column/Expression has incorrect values.
5. Save should not be enabled when Custom auto-vacuum is enabled but none of the parameters are edited.

Fixes #6777
2021-09-23 14:46:10 +05:30
Aditya Toshniwal 78c8fbbe00 Fixed an issue where the Properties panel was not loaded for catalog tables. Fixes #6778 2021-09-23 10:42:50 +05:30
Aditya Toshniwal a8c8ea69e3 Foreign Key fixes:
1. Auto FK related fixes.
2. Properties tab not showing columns.
3. Toggle button is editable even if set to read-only.
4. Dropdown placeholder should be blank for read-only/disabled.
5. Input control help text color on a dark theme.

Fixes #6770
2021-09-22 18:18:09 +05:30
Aditya Toshniwal fc86faf51e Changed the layout for tables from block layout to flex layout to fix the width of the columns as per the dialog size. 2021-09-22 18:11:50 +05:30
Aditya Toshniwal 08009f8edc 1) Make default values column read-only for inherited columns when creating table.
2) Default values not populated for inherited columns. The existing issue, API changed.
3) Options are not populated for Name in Column > Variable tab.
4) The empty check error message is changed from Label cannot be empty to Label in Collection cannot be empty for collections.

Fixes #6763
2021-09-21 16:56:29 +05:30
Aditya Toshniwal f874276d0f Added some missing propTypes. 2021-09-09 15:57:17 +05:30
Aditya Toshniwal f7b8969c72 Stability and bug fixes for the react schema view framework. 2021-09-09 13:09:53 +05:30
Aditya Toshniwal af27af8d42 Integer and Numeric inputs fixes. 2021-09-09 13:09:44 +05:30
Aditya Toshniwal 73e1cbc0b9 Change the parse changes logic to get changes at any level of depth. 2021-09-09 13:09:42 +05:30
Aditya Toshniwal d62fba024b - Focus on first tab and first element on reset. - Move formErr to state context. 2021-09-09 13:09:42 +05:30
Aditya Toshniwal ae49b556ce - Properties tab should refresh if node is updated. - Error should be hierarchical and not just id based. 2021-09-09 13:09:41 +05:30
Aditya Toshniwal c02705c53c - Fix all the jasmine test case failures. - Show default value column in Table->Columns grid. Fixes #4353. 2021-09-09 13:06:24 +05:30
Aditya Toshniwal 27e446a0b0 Fixed following: - Dropdown selected menu color - CodeMirror render on properties tab - Placeholders on select control - Codemirror borders 2021-09-09 13:06:24 +05:30
Akshay Joshi 4bfffa3806 Port FTS Configurations node to react. Fixes #6638 2021-09-09 13:06:24 +05:30
Aditya Toshniwal 261cec1d20 Port Table, Column, Primary key, Foreign key, Check constraint, Unique constraint, Exclusion constraint. 2021-09-09 13:05:57 +05:30
Rahul Shirsat 725d9b4bbf Port package and it’s child node to React. Fixes #6675 2021-09-09 13:04:42 +05:30
Akshay Joshi b7105093e2 1) Port Compound Trigger node to react. Fixes #6674 2) Remove 'inSchema' method and create a generic method 'inCatalog'. 2021-09-09 13:03:54 +05:30
Aditya Toshniwal 9274df0f11 - Fix Jasmine test cases failing in framework. - More stability fixes and enhancements. 2021-09-09 13:03:54 +05:30
Nikhil Mohite 351cb3e6ca Port Triggers node to react. Fixes #6672 2021-09-09 13:03:54 +05:30
Aditya Toshniwal bb5e2b98e9 Stability and bug fixes in schemaview react framework. 2021-09-09 13:03:54 +05:30
Akshay Joshi 1b7a77f5cb Port pgAgent and it's child nodes to react. Fixes #6645 2021-09-09 13:03:54 +05:30
Aditya Toshniwal 314fcabbeb Add plain string control with formatter. 2021-09-09 13:03:54 +05:30
Aditya Toshniwal 0ddd053e88 Framework stability fixes. 2021-09-09 13:03:54 +05:30
Aditya Toshniwal 9bfef1f6e5 - Add feature to allow collection header form using CustomControl. - Framework stability and bug fixes. 2021-09-09 13:03:38 +05:30
Rahul Shirsat 08f2121544 Port Schema & Catalog node to react. Fixes #6655 2021-09-09 13:01:53 +05:30
Pradip Parkale 1f430227aa Port Subscriptions node to react. Fixes #6634 2021-09-09 13:01:52 +05:30
Rahul Shirsat 1e07ef13cf Port Types node to react. Fixes #6602 2021-09-09 13:01:18 +05:30
Akshay Joshi 56ef085412 Added DateTimePicker control in React. 2021-09-09 13:00:36 +05:30
Aditya Toshniwal bcab0e3754 - Fix jasmine test cases. - Unregister listener when row removed in DataGrid. 2021-09-09 13:00:36 +05:30
Aditya Toshniwal 1810d810d8 Few more UI changes for Note. 2021-09-09 13:00:33 +05:30
Aditya Toshniwal 82ca5145c2 Add the note control. 2021-09-09 13:00:33 +05:30
Aditya Toshniwal 377fe80046 - Add VaccumSettings schema. - Allow collection to have fixed rows. - Changes in data change comparison and add state utils context. - Fixed jasmine test cases. 2021-09-09 13:00:33 +05:30
Aditya Toshniwal 09db3ddd5c Use isFullTab instead of noLabel for full space code field spec. 2021-09-09 13:00:03 +05:30
Nikhil Mohite d9cfbf592e Port View node to react. Fixes #6637 2021-09-09 12:59:26 +05:30
Akshay Joshi 6d18842dd3 Port Domain and Domain Constraints node to react. Fixes #6330 2021-09-09 12:59:26 +05:30
Pradip Parkale c474ca2c5f Port Publications node to react. Fixes #6610 2021-09-09 12:55:56 +05:30
Akshay Joshi be04bea2b6 Port Resource Group node to react. Fixes #6629 2021-09-09 12:55:56 +05:30
Aditya Toshniwal 5db72a6916 - Some UI changes based on review comments. - Fix the numeric type. 2021-09-09 12:55:56 +05:30
Aditya Toshniwal 453f26817a Check if type is string for nested type changes parsing. 2021-09-09 12:55:55 +05:30
Aditya Toshniwal 51c11a21fa Fieldset changes should be included. Fix linter errors. 2021-09-09 12:54:25 +05:30
Aditya Toshniwal cd9e37bac5 Fix typo in fieldsetview also. 2021-09-09 12:54:25 +05:30
Aditya Toshniwal 3d7450b308 - Fix typo modeSupported. - Add support for collection conditional visibility. 2021-09-09 12:54:25 +05:30
Aditya Toshniwal 48176ea986 Add support for nested-fieldset control. 2021-09-09 12:54:25 +05:30
Aditya Toshniwal 5d8eeba0dd Fix linter issues in previous commit. 2021-09-09 12:50:32 +05:30
Aditya Toshniwal a06f78b2d5 - Introduce deps listener context and move the old code. - Add support for deffered deps change - deferredDepChange. - Changes for canEditRow and canDeleteRow. - Select the tab again on visible if it is rendered when hidden. - It is helpful to show the error footer in SQL tab also. - Fix isEmptyString. 2021-09-09 12:50:32 +05:30
Akshay Joshi 5c1ce23780 Port Synonyms node to react. Fixes #6599 2021-09-09 12:50:32 +05:30
Aditya Toshniwal 79e1b0c5d8 Added field key - optionsReloadBasis to allow options to be re-loaded. Add formatters to select and input control. 2021-09-09 12:44:37 +05:30
Aditya Toshniwal de3f3e6e61 Fix jasmine test case failures in SchemaView. 2021-09-09 12:44:37 +05:30
Nikhil Mohite 793dbc6e7f Port Event Triggers node to react. Fixes #6578 2021-09-09 12:44:37 +05:30
Aditya Toshniwal bd5536dbf9 Fix linter errors in previous commit. 2021-09-09 12:27:42 +05:30
Aditya Toshniwal 6b9e8c3039 Fixes for expanded table row form control. 2021-09-09 12:27:42 +05:30
Aditya Toshniwal 9d33b03be9 Few more changes to core schema framework required by other nodes. 2021-09-09 12:22:05 +05:30
Aditya Toshniwal b20558cb99 Some changes to the core code that will be helpful for other nodes. 2021-09-09 12:20:59 +05:30
Aditya Toshniwal 764677431f Added React framework for the properties dialog and port Server Group, Server, and Database dialogs.
Following changes done for the framework:
 - Framework for creating React based dynamic form view out of a pre-defined UI schema. Previously, it was based on Backform/Backbone.
 - The new framework and components will use MaterialUI as the base. Previously, Bootstrap/Backform/jQuery components were used.
 - The new code uses JSS instead of CSS since material UI and most modern React libraries also use JSS. In the future, this will allow us to change the theme in real-time without refresh.
 - 90% code covered by 80-85 new jasmine test cases.
 - Server group node UI Schema migration to new, with schema test cases.
 - Server node UI Schema migration to new, with schema test cases.
 - Database node UI Schema migration to new, with schema test cases.
 - Few other UI changes.

Fixes #6130
2021-09-09 12:20:59 +05:30