1. Delete unreachable code or refactor the code to make it reachable.
2. Unexpected var, use let or const instead.
3. Remove useless assignment to variable.
4. Define a constant instead of duplicating the literal
5. Remove commented out code
1) From PG 15 onward, the datlastsysoid has been removed from the table pg_database.
We have added the constant _DATABASE_LAST_SYSTEM_OID = 16383, all the objects below
this value are considered to be system objects. Modified the pgAdmin logic accordingly.
2) Concatenation operator '||' needs a specific typecast to be applied to query variables. Modified SQL's accordingly.
Fixes#7283
1) Boolean checks should not be inverted.
2) Review this redundant assignment.
3) Extract this nested ternary operation into an independent statement.
4) Unexpected empty function.
5) Immediately return this expression instead of assigning it to the temporary variable.
1) Replace the deprecated unit test method.
2) Wraps filter usage in a list call.
3) Converts the old metaclass syntax to new.
4) Use range instead of xrange method.
5) Change Unicode to str.
6) Several other transformations.
7) Fixed change password test cases.
8) Use simplejson instead of plain JSON.
1) Rename field "node_type" to prevent any misunderstanding/clash with field "NODE_TYPE" defined.
2) Define a constant instead of duplicating this literal.
Solution:
1) Rename the field "NODE_TYPE" and "COLLECTION_LABEL" to "_NODE_TYPE" and "_COLLECTION_LABEL"
2) Declare the constant in PGChildNodeView for SQL files.
- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in the dialog.
- improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js,
word 'cancel' needs to be translated in the Czech language as 'zrušit' but in another sentence as 'zrušení')
- added gettext for text translations.
1) Fixed usage gettext('') instead of _('') in javascript files.
2) Fixed usage gettext('') instead of `${gettext('')}` in javascript files,
because "pybabel extract" not support extracting from this syntax.
Akshay Joshi
Pravesh Sharma
Aditya Toshniwal
Khushboo Vashi
Matěj Cepl
Nikhil Mohite
Mark Mayo
Pradip Parkale
huangj.fnst@fujitsu.com
Rahul Shirsat
Cyril Jouve
Dave Page
Libor M
Ashesh Vashi
Yogesh Mahajan