Aditya Toshniwal
2185ea302d
Omit the geometry viewer in the Query Tool from layout saving. Fixes #4169
2019-05-30 15:15:37 -04:00
Murtuza Zabuawala
32defc91cc
Improve the performance of explain plan by embedding the images only when downloading it. Fixes #4307
2019-05-30 17:49:43 +05:30
Dave Page
37bde4aaf4
Credit reporter who provided test script.
2019-05-29 16:34:04 -04:00
Dave Page
1f76d207f2
Minor phrasing fix.
2019-05-29 16:32:35 -04:00
Dave Page
8eab534c95
Fix typo
2019-05-29 16:27:56 -04:00
Dave Page
0eb3008426
Tidy up keyboard shortcut docs.
2019-05-29 16:24:29 -04:00
Aditya Toshniwal
15252b0a26
Added Help button on all master password dialogs.
2019-05-29 13:07:50 +05:30
Aditya Toshniwal
dfa892d2a2
1. Added Master Password to increase the security of saved passwords. Fixes #4184
...
2. In server(web) mode, update all the saved server credentials when user password is changed. Fixes #3377
2019-05-28 12:00:18 +05:30
Khushboo Vashi
6f0eafb223
Fixed CSRF security vulnerability issue. per Alvin Lindstam. Fixes #4217
...
Initial patch by: Khushboo Vashi
Modified by: Ashesh Vashi and Murtuza Zabuawala
2019-05-28 10:59:51 +05:30
Akshay Joshi
90a45557b9
1. Fix syntax error when adding more than one column to the existing table. Fixes #4162
...
2. Fix syntax error when creating a table with a serial column. Fixes #4284
2019-05-27 13:09:11 +05:30
Dave Page
4d23bb24a5
Add a missing fix.
2019-05-24 09:36:33 +01:00
Aditya Toshniwal
361f7077fd
Update the UI logo. Artwork by Chethana Kumar. Fixes #4208
2019-05-23 16:39:10 +01:00
Aditya Toshniwal
ee37be56f9
Fix handling of JSON in the Query Tool with NULL elements. Fixes #4263
2019-05-23 08:53:29 +01:00
Dave Page
0ee50ac248
Clarify wording for the NO INHERIT option on constraints, per Michel Feinstein. Fixes #4275
2019-05-21 11:51:19 +01:00
Murtuza Zabuawala
155768a2d7
Prevent Backgrid Password cells from losing focus if the browser opens an autocomplete list. Fixes #4278
2019-05-20 13:34:47 +01:00
Dave Page
da8da7bb49
Relax the permission check on the directory containing the config database, as it may fail in some environments such as OpenShift. Fixes #4276
2019-05-20 09:46:02 +01:00
Murtuza Zabuawala
5786c17569
Fix navigation of switch cells in grids. Fixes #4269
2019-05-17 16:27:14 +01:00
Dave Page
941dea99f5
Fix typo.
2019-05-17 09:04:04 +01:00
Sander Eikelenboom
ab5f35da8d
Fixed error on displaying table properties of a table partitioned by list having a default partition. Fixes #4262
2019-05-15 18:36:16 +05:30
Aditya Toshniwal
db4bb22cc6
Ensure that element should get highlighted when they get focus on using Tab key. Fixes #4245
2019-05-15 17:42:07 +05:30
Aditya Toshniwal
2cd58efcdd
1) Fixed Tab key navigation for Maintenance dialog. Fixes #4227
...
2) Fix Tab key issue for Toggle switch controls and button on the dialog footer in Safari browser. Fixes #4244
2019-05-15 16:37:06 +05:30
Aditya Toshniwal
ed8d1cde00
Fix accessibility issue for menu navigation. Fixes #4194
2019-05-15 15:38:33 +05:30
Dave Page
4b421550d3
Stop using application/x-javascript as a mime type and use the RFC-compliant application/javascript instead. Fixes #4261
2019-05-15 09:44:57 +01:00
Dave Page
020d9bb018
Clarify when the container will load server definitions.
2019-05-14 09:27:47 +01:00
Murtuza Zabuawala
eb189844e7
Fixed console error when subnode control is used in panels. Fixes #4246
2019-05-10 11:24:15 +05:30
Aditya Toshniwal
036bd66638
Fix file browser path issue which occurs when client is on Windows and server is on Mac/Linux. Fixes #4164
2019-05-03 11:58:06 +05:30
Dave Page
f02f91cbf1
Ensure popper.js is installed when needed. Fixes #4219
2019-04-30 13:57:10 +01:00
Neel Patel
34b59da526
Properly assign dropdownParent in Select2 controls. Fixes #4218
2019-04-30 12:57:17 +01:00
Dave Page
e53c2b1a5d
Ensure the treeview shows all sequences except those used to implement IDENTITY columns (which can be edited as part of the column). Show all if Show System Objects is enabled. Fixes #4154
2019-04-26 12:36:56 +01:00
Akshay Joshi
9b5a6e2bb7
Prevent duplicate columns being included in reverse engineered SQL for tables. Fixes #4163
2019-04-24 11:35:20 +01:00
Khushboo Vashi
74af8976c9
Ensure that newly added row in backgrid should be visible.
2019-04-23 17:32:00 +05:30
Khushboo Vashi
ecded18333
Fix an issue where 'GRANT UPDATE' sql should be displayed for default sequence privileges. Fixes #4087
2019-04-22 12:24:47 +05:30
Khushboo Vashi
5452bff49e
Fixed 'Increment value cannot be empty' error for existing tables. Fixes #4160
2019-04-22 12:04:49 +05:30
Aditya Toshniwal
49b318c39e
Ensure that confirmation dialog should be popped up before reload of query tool or debugger
...
if it is opened in a new browser tab. Fixes #4101
2019-04-18 15:39:36 +05:30
Aditya Toshniwal
d96f453e7f
Fixed 'Location cannot be empty' error when open Tablespace properties. Fixes #4134
2019-04-18 12:31:35 +05:30
Khushboo Vashi
0b47d1dbf6
1) Fix an issue where Deleting N number of rows makes first N number of rows disable. Fixes #3605
...
2) Ensure that on clicking Delete button should not delete rows immediately from the database server,
it should be deleted when Save button will be clicked. Fixes #2392
2019-04-18 12:09:35 +05:30
Dave Page
d728ee7436
Ensure sanity of the permissions on the storage and session directories and the config database. Fixes #4182
2019-04-17 16:57:34 +01:00
Aditya Toshniwal
024cfd2fab
1) Ensure that JSON strings as comments should be added properly for all the objects. Fixes #3582
...
2) Fixed alignment issue of columns in definition section of Index node. Fixes #4121
2019-04-12 15:07:07 +05:30
Dave Page
ded446fe8a
Depend on psycopg2-binary in the Python wheel, rather than psycopg2. Fixes #4165
2019-04-11 10:08:44 +01:00
Khushboo Vashi
a9d964b5ca
1) Added support for Default Partition. Fixes #3938
...
2) Ensure that record should be add/edited for root partition table with primary keys. Fixes #4104
2019-04-11 13:25:24 +05:30
Akshay Joshi
9c3925e448
Ensure that parameters of procedures for EPAS server 10 and below should be set/reset properly. Fixes #4161
2019-04-10 13:22:52 +05:30
Murtuza Zabuawala
6016a5ee98
Fix an issue where the dropdown becomes misaligned/displaced. Fixes #4138
2019-04-09 12:09:25 +05:30
Akshay Joshi
490999f528
Updated release notes
2019-04-08 18:33:20 +05:30
Khushboo Vashi
c21ea3c342
Ensure that pgAdmin4 should work properly with psycopg2 v2.8. Fixes #4143
2019-04-08 17:49:50 +05:30
Murtuza Zabuawala
84ecffa4d9
Added recommended ESLinter checks. Fixes #4142
2019-04-05 13:07:43 +05:30
Dave Page
f706f7ed0c
Relabel the Save button on the datagrid text editor to avoid confusion with the actual Save button that updates the database. Fixes #4131
2019-04-02 17:20:43 +01:00
Akshay Joshi
d286bada5c
Fix custom autovacuum configuration for Materialized Views. Fixes #4110
2019-04-01 09:47:17 +01:00
Akshay Joshi
fe6e5e3c45
Correct the feature number in the release note.
2019-04-01 12:18:45 +05:30
Dave Page
be313bb17b
Missed a bug :-(
2019-03-29 14:35:43 +00:00
Aditya Toshniwal
7627e9c699
Display errors during CSV download from the Query Tool in the UI rather than putting them in the CSV file. Fixes #4085
...
Ensure the toolbar buttons are properly reset following a CSV download in the Query Tool. Fixes #4096
2019-03-29 14:31:33 +00:00
Khushboo Vashi
97919d091a
Add support for IDENTITY columns. Fixes #4030
2019-03-28 13:13:43 -04:00
Aditya Toshniwal
8aaacdf96e
Include inherited column comments and defaults in reverse engineered table SQL. Fixes #2627
...
Include comment SQL for inherited columns in reverse engineered table SQL. Fixes #4037
Include inherited columns in SELECT scripts. Fixes #4058
2019-03-28 08:36:41 -04:00
Aditya Toshniwal
fbc6aea497
Fix an issue where JSON data would not be rendered in the Query Tool. Fixes #4105
2019-03-28 08:12:09 -04:00
Aditya Toshniwal
6fb35f2649
Overhaul the layout saving code so it includes the Query Tool and Debugger, and stores the layout when change events are detected rather than (unreliably) on exit. Fixes #4084
2019-03-26 11:08:45 -04:00
Akshay Joshi
9c2ea3ca11
1) Ensure View/Materialized View node should be visible after updating any property. Fixes #4109
...
2) Updated the icon for Materialized View.
2019-03-26 14:12:47 +05:30
Dave Page
a5ebdafb82
Enlarge the grab handles for resizing dialogs etc. Fixes #4063
2019-03-25 07:50:55 -04:00
Akshay Joshi
212ca01506
Ensure sequences can be created with increment, start, minimum and maximum options set. Fixes #4100
2019-03-22 15:54:34 +00:00
Dave Page
ce073a2856
Fix SQL help for EPAS 10+, and refactor the URL generation code into a testable function. Fixes #4099
2019-03-22 14:09:24 +00:00
Dave Page
ae23f146d1
Use the user's full email address (not just the username part) as the basis for the storage directory name.. Fixes #3887
2019-03-22 09:36:13 +00:00
Dave Page
83bb07e01d
Improve the German translation for Backup Server, per H Re. Fixes #4090
2019-03-21 16:18:09 +00:00
Dave Page
89784413dd
Fix indent.
2019-03-21 14:05:40 +00:00
Dave Page
3f22503ad2
Tidy up table formatting in the docs. Thanks to Susan Douglas for the tips!
2019-03-21 11:38:34 +00:00
Aditya Toshniwal
61f11aa4fc
Update wcDocker to fix the issue where the Scratch Pad grows in size if the results panel is resized. Fixes #3968
2019-03-21 09:15:28 +00:00
Dave Page
bb1e908b54
Apply codestyle checks to all Python code.
2019-03-20 11:17:51 +00:00
Aditya Toshniwal
3db3740cf2
Fix handling of numeric arrays in View/Edit Data. Fixes #4062
2019-03-19 16:29:05 +00:00
Dave Page
7a271a34c6
Make the WHEN field a CodeMirror control on the Event Trigger dialogue. Fixes #4050
2019-03-15 10:35:47 +00:00
Dave Page
2e3475e06a
Fix the RE-SQL syntax for roles with a VALID UNTIL clause. Fixes #4081
2019-03-15 10:03:11 +00:00
Dave Page
69ec460b60
Fix naming inconsistency for the column and FTS parser modules. Fixes #1269
2019-03-14 16:52:42 +00:00
Dave Page
395d3cb545
Improve a couple of German translations. Fixes #3104
2019-03-14 16:36:02 +00:00
Dave Page
c548eac5ef
Append the file suffix to filenames when needed in the File Create dialogue. Fixes #4069
2019-03-14 15:48:21 +00:00
Khushboo Vashi
e4417229aa
Update all Python and JS dependencies. Fixes #4019
2019-03-14 15:11:16 +00:00
Dave Page
c7b29d35ae
Add an ePub doc build target (update to release notes). Fixes #4075
2019-03-13 16:23:27 +00:00
Dave Page
a9dad423f6
Fix the online help button on the resource group dialogue. Fixes #4052
2019-03-13 16:21:10 +00:00
Dave Page
cdc9ed678f
Enable the online help button on the index dialogue. Fixes #4053
2019-03-13 16:18:51 +00:00
Dave Page
870d373ced
Change the CodeMirror active line background colour to $color-danger-lighter so it doesn't conflict with the selection colour. Fixes #4073
2019-03-13 16:04:26 +00:00
Dave Page
ab9a3a57ad
Make the Query Tool history persistent across sessions. Fixes #4017
2019-03-13 13:37:34 +00:00
Dave Page
25b8a909b1
Update links in docs to https where possible, and fix a couple of broken/out of date ones.
2019-03-12 14:24:46 +00:00
Dave Page
2356988bdf
Ensure that Firefox prompts for a filename/location when downloading query results as a CSV file. Fixes #4071
2019-03-12 12:45:25 +00:00
Khushboo Vashi
eb1db50f85
Avoid 'bogus varno' message from Postgres when viewing the SQL for a table with triggers. Fixes #3995
2019-03-12 10:13:31 +00:00
Dave Page
8f1f04e5f3
Major doc cleanup:
...
- Reformat source so it's wrapped.
- Standardise markup.
- Center images.
- Restructure in various places to improve the indexing.
- Remove duplicated Query Tool toolbar descriptions.
- Ensure the structure works in both HTML and LaTeX.
2019-03-08 15:29:05 +00:00
Dave Page
f4ca208474
Fix the latexpdf doc build. Fixes #4060
...
Thanks to Jean-François for the assist:
https://groups.google.com/forum/#!topic/sphinx-users/ZlQ95_QikXo
2019-03-08 09:45:04 +00:00
Aditya Toshniwal
6aae9d6e20
Handle resultsets with zero columns correctly in the Query Tool. Fixes #4054
2019-03-07 15:22:45 +00:00
Dave Page
f8b9a86e95
Include the license in the docs, and ensure it gets updated each year.
2019-03-07 15:12:12 +00:00
Dave Page
47bce4eb23
Some more doc restructuring and cleanup.
2019-03-07 14:29:51 +00:00
Dave Page
64ee23a088
Some doc restructuring and cleanup.
2019-03-07 14:26:56 +00:00
Aditya Toshniwal
4b895941b3
Remove the large and unnecessary dependency on React and 87 other related libraries. Fixes #4018
2019-03-07 10:51:59 +00:00
Dave Page
f401def044
Add support for reverse proxied setups with Gunicorn, and document Gunicorn, uWSGI & NGINX configurations. Fixes #2001
2019-03-04 16:29:41 +00:00
Abhilasha Narendra
9d96d6123e
Update documentation screenshots as per new design. Fixes #3890
2019-03-04 13:06:04 +05:30
Murtuza Zabuawala
36ffdb93e8
Custom-encode forward slashes in URL parameters as Apache HTTPD doesn't allow them in some cases. Fixes #3998
2019-03-01 14:55:25 +00:00
Dave Page
13f52ad9ac
Update release notes.
2019-03-01 13:54:11 +00:00
Akshay Joshi
bbeb395beb
Ignore exceptions in the logger. Fixes #3933
2019-02-28 13:22:12 +00:00
Aditya Toshniwal
e6e7cf0f69
Fix support for bigint's in JSONB data. Fixes #3587
2019-02-27 13:39:47 +00:00
Aditya Toshniwal
9c5b9364b6
Support double-click on Query Tool result grid column resize handles to auto-size to the content. Fixes #4034
2019-02-26 13:44:16 +00:00
Dave Page
0694f59e70
Fix formatting
2019-02-25 12:51:50 +00:00
Dave Page
42aa4dcd22
Clarify pgAgent installation options.
2019-02-25 12:10:53 +00:00
Aditya Toshniwal
59446bb4b5
Ensure JSON data isn't modified in-flight by psycopg2 when using View/Edit data. Fixes #3600
2019-02-25 10:34:36 +00:00
Akshay Joshi
a5d39003b6
Handle display of roles with expiration set to infinity correctly. Fixes #3352
2019-02-25 10:24:11 +00:00
Dave Page
c45675e019
Ensure long queries don't cause errors when downloading CSV in the Query Tool. Fixes #4013
...
This was actually fixed by #3673 it would appear.
2019-02-22 16:29:45 +00:00
Dave Page
27d3990ba2
Allow editing of values in columns with the oid datatype which are not an actual row OID. Fixes #3418
2019-02-22 16:18:39 +00:00
Dave Page
d326ddd21a
Update release notes as the fix for #3583 appears to have resolved other issues. Fixes #4000
2019-02-22 15:44:14 +00:00
Dave Page
3ad606733a
Update doc colours to more closely match the new UI.
2019-02-22 15:22:50 +00:00
Akshay Joshi
38b034ec3c
Add Commit and Rollback buttons to the Query Tool. Fixes #2418
2019-02-22 14:28:05 +00:00
Dave Page
73b144c45c
Fix an issue where importing servers fails if a group already exists for a different user. Fixes #4022
2019-02-21 15:40:37 +00:00
Khushboo Vashi
98283c1213
Disable the editor and execute functions whilst queries are executing. Fixes #4021
2019-02-21 14:19:25 +00:00
Akshay Joshi
5be0d17df5
Don't exclude SELECT statements from transaction management in the Query Tool in case they call data-modifying functions. Fixes #3958
2019-02-21 14:05:10 +00:00
Dave Page
bacb57086c
Update CodeMirror to 5.43.0 to resolve issues with auto-indent. Fixes #3583
2019-02-21 10:57:44 +00:00
Dave Page
e5598038fa
Ensure size stats are prettified on the statistics tab when the UI language != English. Fixes #3096
2019-02-20 16:39:38 +00:00
Dave Page
a39f43788b
Include multiple versions of the PG utilties in containers. Fixes #3886
2019-02-20 15:17:16 +00:00
Khushboo Vashi
34045efb38
Modify the Download as CSV option to use the same connection as the Query Tool its running in so temporary tables etc. can be used. Fixes #3673
2019-02-20 11:49:45 +00:00
Aditya Toshniwal
292ac32db5
Fix editing of table data with a JSON primary key. Fixes #3912
2019-02-20 11:15:39 +00:00
Dave Page
255afe673a
Add a "scratch pad" to the Query Tool to hold text snippets whilst editing. Fixes #2233
2019-02-15 15:44:49 +00:00
Dave Page
c64373435b
Make the Query Tool tab titles more concise and useful. Fixes #3544
2019-02-15 15:09:49 +00:00
Khushboo Vashi
622b67684d
Optimise display of Dependencies and Dependents, and use on-demand loading of rows in batches of 100. Fixes #3959
2019-02-14 11:15:01 +00:00
Dave Page
122336eb63
Update release notes.
2019-02-14 09:19:36 +00:00
Khushboo Vashi
17694ab467
Automatically expand child nodes as well as the selected node on the treeview if there is only one. Fixes #3559
...
This also ensure the browser state is cleared if the save interval is set to -1.
2019-02-14 09:18:08 +00:00
Dave Page
438116c574
Update Alpine Linux version in the docker container. This also updates the PG utilities to v11. Fixes #3991
2019-02-13 17:18:14 +00:00
Akshay Joshi
944cc55df7
Prevent an error when closing the Sort/Filter dialogue with an empty filter string. Fixes #3970
2019-02-13 16:44:57 +00:00
Dave Page
6af8efb5b1
You can't change colours in Preferences. Fixes #2990
2019-02-13 11:07:47 +00:00
Akshay Joshi
1f43b05c2a
Fix alignment of checkbox to drop multiple schedules of pgAgent job. Fixes #3946
2019-02-13 14:55:52 +05:30
Akshay Joshi
10ee75bb1f
Fix alignment of Close and Maximize button of Grant Wizard. Fixes #3906
2019-02-13 13:13:07 +05:30
Akshay Joshi
0aa93ac3ba
Fix alignment of Connection type toggle switch of pgagent. Fixes #3974
2019-02-13 13:03:44 +05:30
Dave Page
f72dcc23ea
Allow X-FRAME-OPTIONS to be set in config.py. Default to SAMEORIGIN. Fixes #3439
...
DENY cannot be supported without breaking the debugger and query tool.
2019-02-12 16:17:14 +00:00
Dave Page
1fc66406f5
Don't embed docs and external sites in iframes, to allow the external sites to set X-FRAME-OPTIONS = DENY for security. Fxies #3985
2019-02-12 16:07:38 +00:00
Dave Page
e0e7d6f1f6
Install a script to start pgAdmin (pgadmin4) from the command line when installed from the Python wheel. Fixes #1825
2019-02-12 14:04:45 +00:00
Dave Page
7f3e5c95c6
Add a missing bug fix.
2019-02-11 15:45:13 +00:00
Akshay Joshi
399d490342
Fix context sub-menu alignment on Safari. Fixes #3873
2019-02-11 13:38:11 +00:00
Akshay Joshi
22d458b01e
Close connections gracefully when the user logs out of pgAdmin. Fixes #3942
2019-02-06 13:17:52 +00:00
Akshay Joshi
0cc37de404
Added release_notes_4_3 to the toctree for the documentation.
2019-02-06 17:03:56 +05:30
Akshay Joshi
8f4d1f14f2
1) Fix alignment of import/export toggle switch. Fixes #3963
...
2) Remove unnecessary options for toggle switch which are already the default options.
2019-02-06 16:49:36 +05:30
Navnath Gadakh
5fdc1ffb38
Exclude HTTPExceptions from the all_exception_handler as they should be returned as-is. Fixes #3961
2019-02-04 10:31:47 +00:00
Dave Page
9df89f9bd5
There are no new features in 4.1 or 4.2, just fixes and optimisations.
2019-02-04 10:10:53 +00:00
Aditya Toshniwal
aad7830d37
Dashboard graph optimization. Fixes #3941
2019-02-04 15:39:47 +05:30
Khushboo Vashi
dae8186c2a
Replace Bootstrap switch with Bootstrap4 toggle to improve the performance. Fixes #3051
2019-02-04 11:31:48 +05:30
Akshay Joshi
93234c86b7
Fix alignment of submenu for Internet Explorer. Fixes #3932
2019-02-01 17:55:38 +05:30
Cyril Jouve
b786c4c140
Replace the PyCrypto module with the cryptography module. Fixes #3272
2019-01-31 15:57:27 +01:00
Diego Augusto Molina
da3b3de397
Expose the bind address in the Docker container via PGADMIN_BIND_ADDRESS. Fixes #3955
2019-01-31 14:26:35 +01:00
Cyril Jouve
cbd8f8236a
Remove Python 2.6 code that's now obsolete. Fixes #3935
2019-01-31 13:47:56 +01:00
Khushboo Vashi
6244463ac1
Fixed Statistics panel hang issue for 1000+ tables. Fixes #3664
2019-01-31 14:47:29 +05:30
Khushboo Vashi
3b35aaa1d7
Fixed unable to drop multiple Rules and Foreign Tables from properties tab. Fixes #3899
2019-01-31 13:03:37 +05:30
Akshay Joshi
0bb4f005e5
Correct schema should be displayed in Materialized View dialog. Fixes #3916
2019-01-31 11:29:18 +05:30
Akshay Joshi
0e489df7b0
Fixed debugger issue for procedure inside package for EPAS servers. Fixes #3927
2019-01-30 14:48:58 +05:30
Aditya Toshniwal
ab094e8f16
Increase frames splitter mouse hover area to make it easier to resize. Fixes #3865
2019-01-30 14:26:36 +05:30
Akshay Joshi
fedbcd4045
Ensure that output of the query should be displayed even if Data Output window is detached from the Query Tool. Fixes #3697
2019-01-29 18:48:21 +05:30
Aditya Toshniwal
821496dc84
Fixed Query Tool Initialization Error. Fixes #3903
2019-01-29 11:45:31 +05:30
Murtuza Zabuawala
07f16f40cd
Ensure that grant wizard should list down functions for EPAS server running with no-redwood-compat mode. Fixes #3935
2019-01-28 12:47:27 +05:30
Murtuza Zabuawala
2d7eaa63c4
Fix alignment of help messages in properties panels. Fixes #3929
2019-01-24 16:39:55 +00:00
Murtuza Zabuawala
d9fc9fdc4d
Ensure object names in external process dialogues are properly escaped. Fixes #3872
2019-01-24 16:34:18 +00:00
Akshay Joshi
f316e0533e
1) Messages tab of query tool should be clear on subsequent execution of table/view using View/Edit Data. Fixes #3608
...
2) Clear drop-down menu should be disabled for View/Edit Data. Fixes #3609
2019-01-23 18:25:33 +05:30
Khushboo Vashi
406ada10f5
Fixed EXEC script for procedures. Fixes #3850
2019-01-23 14:44:24 +05:30
Aditya Toshniwal
fcfe0929d3
Ensure that browser should warn before close or refresh. Fixes #3849
2019-01-23 11:57:36 +05:30