Major refactoring of the runtime code, Specifically:
- Move the bulk of the core code from main() into a new Runtime class.
- Break up the mass of code that was main() into a number of relatively simple functions.
- Make the Configuration dialog synchronous so the Log dialog can be properly viewed.
- Enable/disable menu options at the right time.
- Remove support for Qt < 5.0.
- Remove the application name constant and hardcode the name to simplify the code.
- Improve log messages.
- Replace the sdbm hashing with Qt's MD5 hashing.
1) Shutdown the python server properly.
2) Disabled "Shutdown server" menu till server is not successfully started.
Initial patch sent by Maxim, modified by Akshay Joshi.
Ship the web code using server mode with appropriate paths by default and enable the runtime to override the mode, and force into desktop changing the appropriate paths to user-specific ones.
Note that this change will likely cause more advanced users to have to tweak configs.
RPMs will also need changes to create /var/lib/pgadmin and /var/log/pgadmin, owned by the webserver account.
Desktop runtime has a couple bugs using already freed memory supplied to embedded python leading to occasional crashes and failures to start maintenance processes (VACUUM, ANALYZE, REINDEX, CLUSTER).
This is caused by incorrect usage of QString::toUtf8() which returns newly created QByteArray which is automatically destroyed once closing context; e.g.
Py_SetPythonHome(pythonHome.toUtf8().data());
Windows 2008 R2 (32 bit), while running the pgAdmin 4 as runtime for
the PostgreSQL one click installers.
- Found a typo in runtime code, we were appending the path using ';' on
*nix systems too. We should have used ':', and that did not allow the
os.environ['PATH'] to identify the correct path of the python
interpreter under the 'venv' directory.
- On Windows 2008, it was not honouring the environment variables, set
under the Qt application (e.g. pgAdmin4.exe runtime), in the python
application. (e.g. pgAdmin4.py). We will need to assume that - the
python interpreter resides under the 'venv' directory outside the
'bin' directory.
- Also, on windows 2008, it was setting PYTHONHOME environment variable
to the full path of the pgAdmin4.exe, we need to reset it to 'venv'
directory, if we find the python interpreter under it.
Thanks Murtuza Zabuawala for tips, and help.
PYTHONPATH) to run the runtime with the virtual environment properly.
And, also allow to use the python interpreter to be used with the
background process modules.
- Add binary directory of the virtual environment to PATH environment
variable.
- Add lib, dynamic libraries (python specific), and site-package
directories of the virtual environment in the PYTHONPATH environment
variable.
Akshay Joshi
Dave Page
Murtuza Zabuawala
Anthony DeBarros
Maxim Zakharov
Ashesh Vashi
Neel Patel
Asser Schrøder Femø
Sandeep Thakkar