1a6fe946ce
Open query tool and debugger windows in new tabs by default.
2017-07-07 16:53:45 +01:00
08e874a026
Fix alert animation on IE11
2017-07-07 16:50:47 +01:00
d151bdb4cd
Fix handling of CREATE TABLE OF <type>. Fixes #2534
2017-07-07 16:34:33 +01:00
815c4b4c45
Improve spacing around delete icons in backform tables.
2017-07-07 16:06:51 +01:00
acd3568f06
Fix the formatting of the ROWS option for functions etc. Fixes #2537
2017-07-07 15:57:43 +01:00
fc78202600
Fix clear history.
2017-07-07 15:51:06 +01:00
fae185ff66
Partitioned table does not present in grant wizard. Fixes #2543
2017-07-07 15:15:15 +05:30
e793413d76
Fixed issue by adding extra check for 'relkind' column
2017-07-07 12:33:58 +05:30
c2fb0394bf
Added support of Declarative Partitioning (Range, List) for PostgreSQL 10.
...
This allows the user to create partitioned table and it's partitions.
- Edit partitions, Create/Listing of constraints, rules, triggers under partitions. (Implemented by Harshal)
- Updating browser tree node when create/attach/detach partitions from table dialog.(Implemented by Ashesh)
2017-07-07 11:55:55 +05:30
ca7fe9a520
Ensure the save password option is enabled when creating a server. Fixes #2540
2017-07-06 13:33:46 +01:00
e5bedf088e
In subnodes without dropdowns, the rows had smaller height, making them appear unintentionally different than those with dropdowns. Make them the same.
2017-07-06 13:11:40 +01:00
e2cbaaef71
UI tweaks for the query history.
2017-07-06 13:08:29 +01:00
9de6c08d28
Allow use of Shift+Tab to un-indent selected text. Fixes #1988
2017-07-05 14:20:19 +01:00
2bb01e2d1a
Fix alert layout when more than one are shown at once.
2017-07-05 12:04:48 +01:00
76939e4f63
Prompt the user to save dirty queries rather than discard them for a more natural workflow. Fixes #1972
2017-07-04 23:39:10 +01:00
b211eb199c
Improve styling for alerts by highlighting the icon.
2017-07-04 12:03:32 +01:00
66b101fe4c
Resolve a number of issues with domains and domain constraints. Fixes #2529
2017-07-04 11:52:58 +01:00
0aa763b706
Remove unnecessary whitespace from stored procedure SQL. Fixes #2146
2017-07-03 16:32:19 +01:00
5c7dcaba81
Allow debugging of functions in packages. Fixes #1948
2017-07-03 16:30:12 +01:00
070a9c077e
Allow breakpoints to be set on triggers on views. Fixes #2528
2017-07-03 16:15:42 +01:00
f6b879233c
Fix deletion of table rows with the column definition having NOT NULL TRUE and HAS NO DEFAULT VALUE. Fixes #2527
2017-07-03 15:49:59 +01:00
2d5e55964a
Improve the debugger's default page layout, and prevent attempts to continue debugging after the user has stopped. Fixes #2512 , Fixes #2511
2017-07-03 15:14:45 +01:00
1977a5fcda
Fix clipboard handling with large datasets. Fixes #2489
2017-07-03 11:19:02 +01:00
4e21cdb64b
Fix a syntax error in the SQL Editor.
2017-07-03 11:02:20 +01:00
1e427890de
Fix an issue where duplicate entry is made of successful executed query, one with status message and one without status message.
2017-07-03 11:00:42 +01:00
7c09a8f827
Fix typo that caused a layout issue with the Edit Grid.
2017-06-30 12:58:47 +01:00
f2d2075d81
Update alertify alerts to use the styling defined in the styleguide (missed some files in the original commit).
2017-06-30 10:23:12 +01:00
2a30a86e7d
Update alertify alerts to use the styling defined in the styleguide.
2017-06-30 10:21:05 +01:00
ba3ab7b322
Add support for SCSS building in webpack.
2017-06-30 10:15:44 +01:00
501120701e
Allow the dashboard panel to be closed. Fixes #2506
2017-06-30 10:11:34 +01:00
2d65312910
Improve speed of Select All in the results grid. Fixes #2522
2017-06-30 09:54:31 +01:00
c98b64fd82
1) Edit cellEditing function, in some cases grid object is undefined.
...
2) Modify SubNodeCollectionControl, so that user can pass custom backgrid row.
3) Handling of visible parameter in SubNodeCollectionControl.
4) Customise title and delete message for Delete Cell.
5) Added Backgrid.Extension.Select2DepCell and moved Backgrid.Extension.StringDepCell from user management to backgrid.pgadmin.js.
2017-06-29 19:01:29 +05:30
7389744ecf
A number of minor cleanups to the recent changes to the query tool.
2017-06-28 09:49:39 -04:00
301798d87a
Fix encoding issue when saving servers. Fixes #2518
...
Patch by Khushboo, based on a suggested fix from Ladislav Jech
2017-06-28 09:44:32 -04:00
a9fa093d4b
Allow non-superusers to debug their own functions and prevent them from setting global breakpoints. Fixes #2162
...
Based on a patch from Kit Yam Tse
2017-06-27 16:58:07 -04:00
7f55412059
Overhaul the query history tab to allow browsing of the history and full query text. Fixes #2282
...
Patch by Joao and the team at Pivotal.
2017-06-27 10:55:57 -04:00
e413186d23
Add stylesheet to override brace matching styles, missed from the feature commit.
2017-06-27 10:41:26 -04:00
96412b3219
Revert "Allow the user to close the dashboard panel. Fixes #2506"
...
This reverts commit a87ee6d059
2017-06-27 10:35:43 -04:00
1b49bb8b22
Add preferences to enable brace matching and brace closing in the SQL editors. Fixes #2513
2017-06-27 09:57:38 -04:00
a87ee6d059
Allow the user to close the dashboard panel. Fixes #2506
2017-06-27 09:21:24 -04:00
c65158312d
Use on-demand loading for results in the query tool. Fixes #2137
...
With a 27420 row query, pgAdmin III runs the query in 5.873s on my laptop. pgAdmin 4 now takes ~1s.
2017-06-27 09:03:04 -04:00
15cb9fc35b
Add support for the hostaddr connection parameter. This helps us play nicely with Kerberos/SSPI and friends. Fixes #2191
2017-06-26 15:48:59 -04:00
3f4781cdcb
Un-break query tool feature tests.
2017-06-26 15:25:05 -04:00
27bc5c803f
Ensure saved passwords are effective immediately, not just following a restart when first saved. Fixes #1920
2017-06-26 07:55:34 -04:00
d4e77deda4
Ensure revoked public privileges are displayed in the RE-SQL for functions. Fixes #2507
2017-06-26 07:50:39 -04:00
cfb4b11573
Use client-side url_for in the sql editor and data grid modules.
2017-06-26 07:43:03 -04:00
6b6d3369b3
Wait for the Tools menu to be populated when running the feature tests, instead of failing.
...
Fix by Khushboo, based on Harshal's previous work.
2017-06-23 14:07:31 +01:00
92b1b1365e
Tidy up About box formatting, 'cos it's been annoying me for ages.
2017-06-23 10:21:40 +01:00
6fabf4764b
Add access keys for top level menus.
2017-06-23 09:58:46 +01:00
7a4945ff9e
Fix removal of sizes from column definitions. Fixes #2155
2017-06-23 09:42:46 +01:00
9af29364c7
Fix cell selection window alignment for the updated SlickGrid.
2017-06-23 09:37:58 +01:00
94aa5487fb
Update Slickgrid to 2.3.7. As this version includes all the features we need, it can be moved out of the vendor directory and we'll use yarn to pull it in.
2017-06-23 09:35:56 +01:00
25282f3094
Additional preference fix.
2017-06-22 14:55:45 +01:00
0ab637c7ab
Fix import/export to work as expected with TSV data. Fixes #1934
2017-06-22 13:57:32 +01:00
33e75d24f8
Fix preferences handling for utilities.
2017-06-22 12:18:56 +01:00
137bae1b04
Ensure default values are honoured when adding/editing columns. Fixes #1860
2017-06-22 12:11:02 +01:00
d26337a1ba
Moved the javascripts of the following browser node modules to the
...
'static' directory from 'templates' in the respective module directory:
- Server Group
- Server
- Database
- Schema
- Cast
- Event trigger
- Extension
- Foreign data wrapper
- Language
- Catalog Object
- Collation
- Domain Constraint
- Domain
- Foreign server
- FTS Configuration
- FTS Dictionary
- FTS Parser
- FTS Template
- Function
- Procedure
- Trigger Function
- Package
- Sequence
- Catalog
- Schema
- Synonym
- Table
- Type
- Materialized View
- View
- pgAgent Modules
+ Job (pga_job)
+ Schedule (pga_schedule)
+ Steps (pga_jobstep)
Added new dynanic modules for listing the supported server types, and
current user information.
NOTE: We've not yet moved the javascripts for the children of the table
module.
2017-06-22 15:58:32 +05:30
67fd119de8
Maintain a client-side cache of preference values, populated using an async call. Fixes #2487
2017-06-21 17:09:59 +01:00
b9f6fb9545
Update MatView and pgAgent modules to work with recent integer/numeric changes. Fixes #2504
2017-06-21 17:03:43 +01:00
b9736cbd74
Handle missing/dropped synonyms gracefully. Fixes #2503
2017-06-21 16:59:43 +01:00
5cfa22cf23
Fix React to work with QtWebKit
...
We learned that the underlying issue was related to react-dom's SyntheticEvent.augmentClass function being undefined.
This seems to be caused by attempted property assignment after the SyntheticEvent had been replaced by a Proxy of itself. This works fine in Chromium et al, but QtWebKit doesn't deal with Proxy Event objects well.
Moving the augmentClass definition and assignment up above the Proxy stuff resolves the issue in a PR to React: https://github.com/facebook/react/pull/10011
2017-06-21 11:25:22 +01:00
a45b87d9b7
Vendorize React. This is required at this time because we need to modify it to work with QtWebKit.
...
The patch to do that has been submitted upstream; if accepted, we can un-vendorize again.
2017-06-21 11:20:02 +01:00
281b67952a
Consolidate selection colors in the drop down menu and browser tree to match the light blue agreed upon in the styleguide.
2017-06-21 11:11:49 +01:00
f0202228d0
Increase the default size of the Grant Wizard to enable it to properly display privileges at the default size on smaller displays. Fixes #2013
2017-06-21 11:08:23 +01:00
9829d74a04
Correct the v10 template path.
2017-06-20 12:04:13 +01:00
34518d328e
No need for the menu icon to link to the homepage, as pgAdmin is a SPA. Fixes #2479
2017-06-20 10:28:35 +01:00
d2ba57c1ab
Properly handle bytea[], and 'infinity'::real/real[]. Fixes #2498 . Fixes #2502 .
2017-06-20 10:19:11 +01:00
1ee555e468
Ensure the feature tests use the correct test settings database. Fixes #2486
2017-06-16 10:17:38 +01:00
900ccebb50
Using client-side implementation of 'url_for' in the settings module.
2017-06-16 08:57:23 +05:30
5c140b3f58
Using client-side 'url_for' implementation in the user management
...
module.
2017-06-16 00:16:30 +05:30
e65b605912
Using client-side 'url_for' implementation in the import/export module.
2017-06-16 00:00:17 +05:30
07580b8444
Using client-side 'url_for' implementation in the maintenance module.
2017-06-15 23:50:53 +05:30
2a87585665
Fix script options which were inadvertently broken in the query tool tab naming patch.
2017-06-15 12:19:47 +01:00
d70c3003d3
Add double precision[] tests to the query tool.
2017-06-15 11:54:17 +01:00
8376d33d77
Fix canceling of Grant Wizard on Windows. Fixes #2142
2017-06-15 11:42:13 +01:00
fdc9eed514
Ensure text editors render in an appropriate place on the results grid. Fixes #2477
2017-06-14 12:18:27 +01:00
2b4a8ed89c
Un-break the feature tests. Fixes from Surinder and myself.
2017-06-14 09:59:11 +01:00
4b846ae4e0
Fix the JS Bundler test to work when there are multiple servers defined in a test run.
2017-06-14 09:37:20 +01:00
cb97722fc3
Temporarily disable the Javascript bundler test until it handle more than one run.
2017-06-13 14:21:41 +01:00
57d866f7b7
Use a more sensible name for Query Tool tabs. Fixes #2482
2017-06-13 11:34:24 +01:00
794b70daea
Fixed issue of opening file manager dialog from Query Tool.
2017-06-13 15:48:12 +05:30
a9ce9c9717
Skip a test that uses the COLLATE option on PG versions below 9.1 (e.g. Greenplum).
2017-06-13 10:27:09 +01:00
1208206bc0
Initial re-vamp of the History tab.
2017-06-13 09:50:41 +01:00
16a15bf934
Fix the fix for RM2324.
2017-06-13 09:18:44 +01:00
0243d886c3
Using client-side 'url_for' implementation in the Grant-Wizard module.
2017-06-13 11:47:55 +05:30
f9a3878220
Using client-side 'url_for' implementation in the restore module.
2017-06-13 11:00:17 +05:30
4a46f7b1eb
Using client-side 'url_for' implementation in the backup module.
2017-06-13 10:59:11 +05:30
1a7c9d5ca1
Using client-side 'url_for' implementation in the module - bgprocess
...
(background-processes).
2017-06-13 09:18:48 +05:30
f1acad85db
Add a missing translation call.
2017-06-12 17:20:40 +01:00
3f4f8b9e77
Add linting support, and, well, lint.
2017-06-12 16:55:14 +01:00
659eb1c1e8
Bring React into the tree, and add linting and bundling framework for the JS etc.
2017-06-12 16:51:54 +01:00
af43ccfc07
Teach dialogues about Escape to cancel, Enter to Save/OK, and F1 for help. Fixes #1535
2017-06-12 16:43:29 +01:00
ec5bc23dfd
Allow editing of the WITH ADMIN option of role membership. Fixes #2086
2017-06-12 13:58:51 +01:00
3743c6e86e
Refresh the SQL editor view on resize to ensure the contents are re-rendered for the new viewport. Fixes #2078
2017-06-12 13:25:52 +01:00
c435d48885
Properly handle trigger functions with parameters. Fixes #2043
2017-06-12 13:19:49 +01:00
49cd578816
Fix error on the stats tab with PG10. Also, rename the 10.0_plus template directory to 10_plus to match the new versioning. Fixes #2450
2017-06-12 12:53:09 +01:00
8bd8ae001b
Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for Table, Column, Foreign Table and Type node. Fixes #2324
...
Note that this doesn't add full support for PostGIS types to the table/column dialogues, which still can't handle the typmod usage. It does bring support to parity with pgAdmin 3 though.
2017-06-12 12:49:17 +01:00
fd3ddbeafb
Implementation of the client side 'url_for(...)' function.
...
Created a url_for function module to be used by different javascript
modules to use the same functionality of flask at client side.
A python module can expose the list of endpoints, used by its
javascripts, by overriding the 'get_exposed_url_endpoints(self)'
function.
In this patch, we have modified all the browser modules to use this
function. It will allow us to move the majority of the javascript
modules of browser nodes from templates directory to the static
directory.
TODO::
- Move these javascripts modules to the static directory.
- Use this function in all the applicable javascript modules.
e.g. tools, miscellaneous modules
2017-06-12 12:01:25 +05:30
49976b1934
Fine tune result grid column sizing now we don't have checkboxes.
2017-06-09 09:24:20 +01:00
ee4a847784
Use the correct font for the treeview.
2017-06-09 09:09:39 +01:00
73c6f1ca3b
A little leanup of the styling of the edit grid
2017-06-08 17:06:34 +01:00
aa400cbc12
Fix integer/numeric validation on various dialogues. Fixes #2421
2017-06-08 14:59:26 +01:00
3bcbc50525
Fix the handling of double precision[] type. Fixes #1928
2017-06-08 14:50:51 +01:00
c9b717ed68
Set focus on the first enabled field when a dialogue is opened. Fixes #1533
2017-06-08 14:37:31 +01:00
01bfa88309
Improvements to the Query Results grid:
...
- Improve the UI
- Allow copy/paste from sets of rows, columns or arbitrary blocks of cells
Patch by Matt, Shruti, Joao and Sarah @ Pivotal
Fixes #2476
2017-06-08 13:31:36 +01:00
2fddf750e6
Retain column sizing in the query tool results grid when the same query is re-run multiple times in a row. Fixes #1971
2017-06-08 12:41:56 +01:00
678b891ff7
Fix an intermittent error seen during result polling. Fixes #2470
2017-06-08 12:34:14 +01:00
b149fe371e
Fix various issues with pgAgent job steps and schedules:
...
1) Error on clicking SQL panel when Schedule OR Step node is selected in browser. Fixes #1888
2) Error while dropping Schedule OR Step node. Fixes #1889
3) Newly created Schedule/Step node was not displaying in browser. Fixes #1890
2017-06-08 12:30:00 +01:00
88737248ab
Fix a couple of missing greys.
2017-06-07 16:31:47 +01:00
63c093248d
Allow users to remove default values from columns properly. Fixes #2461
2017-06-07 14:33:28 +01:00
f89aec867a
Resolve the PG datatype feature test flakiness and make for a nice buttery crust.
2017-06-07 14:26:42 +01:00
8d8e7dab3c
Extract row staging into it's own module with tests.
2017-06-07 14:17:10 +01:00
0d05385585
Update the styling to use the set of grays defined in the WIP style guide.
2017-06-07 13:57:49 +01:00
495a3cedb0
List packages in PPAS 9.2-9.4 when creating synonyms. Fixes #1813
2017-06-07 13:44:36 +01:00
b134ae2cb4
Fix the RE-SQL for for views to properly qualify trigger function names. Fixes #2381
2017-06-07 13:40:11 +01:00
ae80976689
Using the client-side translation using the client-side 'gettext'
...
implementation.
This is the first step towards 'Avoid creating the javascript modules
using Jinja templates'.
2017-06-07 15:53:05 +05:30
7e9f82bc17
Prevent attempts to debug procedures with variadic arguments. Fixes #1466
2017-06-06 12:58:52 +01:00
beda7ebbf2
Add feature tests for the View Data tool.
2017-06-06 12:54:20 +01:00
9803468a77
Properly display security labels on EPAS 9.2+. Fixes #1575
2017-06-06 11:46:49 +01:00
cd3484d936
Make $ quoting consistent. Fixes #1525
2017-06-06 11:40:25 +01:00
b82e001478
Ensure that boolean checkboxes cycle values in the correct order. Fixes #2448
2017-06-06 11:29:18 +01:00
bf06d82870
Fix validation for external and range types. Fixes #1795
2017-06-06 11:24:10 +01:00
e6aa3e1494
Fix default values and SQL formatting for event triggers. Fixes #1229
2017-06-06 11:19:40 +01:00
4c2004d479
Correct the validation logic when modifying indexes/exclusion constraints. Fixes #2113
2017-06-06 11:15:51 +01:00
d21cbb8b1f
Handle composite primary keys correctly when deleting rows in the Edit Grid. Fixes #2425
2017-06-06 09:58:47 +01:00
4b74a5ff35
Enable dialogue help buttons on Language and Foreign Table dialogues. Fixes #2116
2017-06-06 09:52:44 +01:00
0bc9997a95
Properly refresh the parent node when renaming children. Fixes #2355
2017-06-06 09:50:05 +01:00
9e98ded06c
Display and allow toggling of trigger enable/disable status from the trigger dialogue. Fixes #2386
2017-06-05 17:11:21 +01:00
3f150f3f4e
Handle procedure flags (IMMUTABLE STRICT SECURITY DEFINER PARALLEL RESTRICTED) properly in RE-SQL on EPAS. Fixes #2280
2017-06-05 17:04:55 +01:00
a4d86d24e6
Cache statistics more reliably. Fixes #2357
2017-06-05 17:01:03 +01:00
456096092d
Avoid re-rendering the edit grid for every row that is pasted.
2017-05-30 16:22:11 +01:00
1f26953504
Cleanup handling of default/null values when data editting. FIxes #2400
2017-05-27 14:51:02 -04:00
8aabee352c
Import the ordereddict module for Python 2.6
2017-05-26 12:34:05 -04:00
2c9af4784e
Allow creation of ENUM types with no members. Fixes #2426
2017-05-26 12:21:23 -04:00
dba64e77f1
Order columns in multi-column pkeys correctly. Fixes #2417
2017-05-26 11:04:32 -04:00
45d423c0ce
Ensure the last placeholder is included when generating UPDATE scripts for tables. Fixes #2436
2017-05-26 10:59:09 -04:00
a45bb905f5
Pass the database ID to the query tool when using the Script options. Fixes #2435
2017-05-26 10:57:31 -04:00
3216eca4a8
Add feature tests to ensure that data types are properly rendered in the query tool.
2017-05-26 10:46:58 -04:00
2f097cd016
Fix typo in freshly added check.
2017-05-25 17:10:41 -04:00
e9da157cc7
Add numerous missing checks to ensure objects really exist when we think they do. Fixes #2427
2017-05-25 16:28:04 -04:00
04ce72a6ae
Fix RE-SQL for rules which got the table name wrong in the header and DROP statement. Fixes #2422
2017-05-19 12:21:29 +01:00
eb18320950
Improve error handling in cases where the user tries to rename or create a server group that would duplicate an existing group. Fixes #2414
2017-05-17 15:57:38 +01:00
17de7db70b
Fix server stats display for EPAS 9.2, where inet needs casting to text for concatenation. Fixes #1831
2017-05-17 15:53:13 +01:00
a3226b1eb5
Reverse engineer SQL for table-returning functions correctly. Fixes #1851
2017-05-17 15:49:56 +01:00
655d5888a6
Various FTS dictionary cleanups. Fixes #1126
2017-05-17 14:13:05 +01:00
1db81da020
Fix JS error when selecting a single grid cell.
2017-05-16 08:44:29 +01:00
be42b67f79
Ensure all required directories are created before we start logging.
2017-05-15 15:59:47 +01:00
d7d4bf475b
Various improvements to the NULL/DEFAULT handling in the data editor. Fixes #2399
2017-05-15 15:04:16 +01:00
1cb2a62fa8
Ensure object names are properly escaped for external process management. Fixes #2405
2017-05-15 13:01:12 +01:00
2ad14b379e
Validate table presence in SQL and Properties route handles. Fixes #2395
2017-05-15 10:15:09 +01:00
3bf17d9df4
1) Splits the SQL query used to retrieve the Dependents, Dependencies, and Roles SQL file into multiple versioned files.
...
2) Add Unit Tests for each file.
3) Add ORDER BY into Copy Selection Feature test to ensure the results are retrieved always in the same order
4) Renamed the Scenario of the xss_checks_pgadmin_debugger_test and skip it for versions less than 9.1
5) Deleted unused __init__.py files.
2017-05-15 10:40:46 +05:30
0e7efc0cf8
Track disabled rows properly in the edit grid.
2017-05-12 16:42:06 +01:00
aea0d93390
Hide menu options for creating objects, if the object type is set to hidden. Includes Jasmine tests. Fixes #2225
2017-05-12 12:10:46 +01:00
dd318e679d
Minor colour tweaks for highlighted rows in the data editor. These are likely to be changed again when we overhaul and standardise the colouring, but at least now they're using colours from the style guide.
2017-05-12 11:29:46 +01:00
4f9628ed43
Improve handling of nulls and default values in the data editor. Fixes #2257
2017-05-12 10:53:57 +01:00
05787fdba9
Properly handle non-ASCII column names in CSV. Fixes #2314
2017-05-12 10:38:23 +01:00
94cbd70370
Don't change the trigger icon back to "enabled" when the trigger is updated when it's disabled. Fixes #2271
2017-05-10 09:48:21 +01:00
9452e0699e
Allow creation of tables with pure numeric names. Fixes #2284
2017-05-10 09:40:32 +01:00
cbf2de6c27
HTML escape the label, when setting the collection node count along
...
with the label of the tree-nodes.
2017-05-10 13:26:18 +05:30
13f4432bbd
Support loading files with Unicode BOMs. Fixes #2369
2017-05-09 12:06:49 +01:00
d0e9c82fea
Fixes #2328
...
1) Fixed issue of opening Query Tool and Debugger in new Tab with QT 5.8 and annulen webkit
2) Moved unload event of window from javascript files to html.
3) Change alertify messages for debugger.
4) Closed all connections created by debugger. Previously only one connection has been closed.
2017-05-09 13:03:44 +05:30
63d42745ef
Fix various issues in CSV file download feature:
...
1) To handle non-ascii filenames which we set from table name. Fixes #2314
2) To handle non-ascii query data. Fixes #2253
3) To dump JSON type columns properly in csv. Fixes #2360
2017-05-08 13:36:11 +01:00
a80f760933
Only reconnect to databases that were previously connected. Fixes #2292
2017-05-08 12:36:51 +01:00
94b7fc483a
Fix sorting of sizes on the statistics views by sorting raw values and prettifying on the client side. Includes Jasmine tests for the prettyfying function. Fixes #2315
2017-05-08 11:29:13 +01:00
c32bf7780e
Windows compatibility fixes for the test suite.
2017-05-08 09:25:05 +01:00
155348d712
Fix the Backup module where it was not working if user changes its preference language other than english. Fixes #2354
2017-05-04 16:06:10 +01:00
95f763463f
Fix an issue in NodeAjaxControl caching with cache-node field and add cache-node field in Trigger & Event trigger node so that whenever the user creates new Trigger Function we get new data from server in NodeAjaxControl. . Fixes #2242
2017-05-04 16:02:28 +01:00
93df5e3e54
Ensure errors thrown when deleting rows in the query tool in edit mode are shown properly. Fixes #2356
2017-05-02 12:20:30 +01:00
6790bfd0c0
Fixed handling of default parameters ordering in functions. Fixes #2350
2017-04-25 18:40:44 +05:30
1ce1f216ca
Fixed handling of nested privileges. Fixes #2335
2017-04-25 12:39:46 +05:30
38c8a4fb60
Fix handling of bigint[] type. Fixes #2272
2017-04-25 12:24:02 +05:30
928c0d3de8
startsWith() function of java script is not supported in IE, instead use startsWith() function of underscore string. Fixes #2347
2017-04-25 12:00:15 +05:30
f718e1f49c
Only display the header row in SlickGrid where columns actually exist.
2017-04-24 20:26:59 +01:00
a449be784e
Initial support for PG 10.0, per #2214 (missed some files)
2017-04-24 13:56:01 +01:00
59834fba31
Initial support for PG 10.0, per #2214
2017-04-24 13:55:29 +01:00
6283ef7f5e
[Configuration][Migration] Use 'alembic' for migration of the SQLite
...
based configuration file from one version to another, and also allows us
to have a single path of creating the table instead of creating tables
using SQLAlchemy or hand rolled SQL
This allows us to run the migrations directly in the code, and it will
avoid the error prone version numbering.
Patched by: Sarah McAlear
Revisions: Joao Pedro De Almeida Pereira, George Gelashvili.
Reviewed by: Ashesh Vashi, Murtuza Zabuawala
2017-04-24 08:37:27 +05:30
618d9bc7a9
Enable horizontal scrolling in the treeview. Fixes #2339
2017-04-21 10:00:22 +01:00
929a43c9fa
Prevent the top-left logo from changing colour when clicked.
2017-04-18 15:09:09 +01:00
8e127cf4fa
German translation update.
2017-04-18 15:03:36 +01:00
9f6041b2a7
Revert "Ensure the treeview can be scrolled horizontally. Fixes #2339"
...
This reverts commit 78c25cef21
2017-04-18 14:51:26 +01:00
8d6add13c0
Order foreign table columns correctly. Fixes #2318
2017-04-18 14:37:30 +01:00
78c25cef21
Ensure the treeview can be scrolled horizontally. Fixes #2339
2017-04-18 14:01:13 +01:00
a3007b7335
Ensure database driver names and description strings can be translated. Fixes #2190
2017-04-18 13:33:27 +01:00
d663d553c5
Allow column or row selection in the query tool. Fixes #2216
2017-04-18 13:28:45 +01:00
c35dbc7211
Proper alignment of dropdown menu labels
2017-04-14 15:53:25 +05:30
0d566a6f3a
Changed switch label from True/False to Show/Hide for 'Package Functions' and 'Package Procedures' node in Preferences dialog.
2017-04-14 14:57:38 +05:30
9bbc05051c
Remove some unused events.
2017-04-12 15:46:31 +01:00
019c1302cb
Update inode info when refreshing treeview nodes. Fixes #2336
2017-04-12 13:29:56 +01:00
cbee76eac8
Align labels with switches properly.
2017-04-12 13:28:07 +01:00
62716c4193
Include passed test results in the JSON output from the regression tests.
2017-04-12 13:11:53 +01:00
7dd9efd811
Fix binary search algorithm so new treeview nodes are added in the correct position. Fixes #2331
2017-04-12 13:01:24 +01:00
a2a2b8b888
Ensure the query tool displays but does not render HTML returned by the server in the results grid. Fixes #2330 .
2017-04-10 14:07:48 +01:00
024b97479d
Recover properly if a database is renamed externally. Fixes #2077
2017-04-10 11:09:01 +01:00
14f3a57d82
Ensure menus are updated after disconnecting a server. Fixes #2281
2017-04-10 09:35:21 +01:00
3dba7d8303
Fixes #2321 - [Browser Tree] Shows only the newly created node (not, all
...
other child node) of a parent node, when it has not been already loaded.
In order to resolve the issue - we will open the parent, and select the
created node, instead of adding it to parent node.
2017-04-07 08:58:43 +05:30
3880bc7eb8
Fix validation on the table dialogue so the Save button isn't enabled if the name is removed and autovac custom settings are enabled. Fixes #2105
2017-04-06 09:56:52 +01:00
c758920890
Properly handle EXPLAIN queries entered directly by the user in the query tool. Fixes #2287
2017-04-06 09:46:42 +01:00
9ac5bf4f12
Update the Polish translation
2017-04-06 09:36:10 +01:00
dd23f71478
Write a JSON file when regression tests run, listing results.
2017-04-06 09:33:29 +01:00
b8566a0127
Un-split some strings for translateability. And so begins the battle between gettext and pep8...
2017-04-05 15:05:11 +01:00
6d9cfa6679
Update translations
2017-04-05 14:03:17 +01:00
e66616b1d8
Add German translation Fixes #2323
2017-04-05 14:02:46 +01:00
ea2b3f43bd
Remove unnecessary quotes.
2017-04-05 13:58:47 +01:00
ddfa934357
Unified usage of "definition incomplete".
2017-04-05 13:55:00 +01:00
37120bf199
(De)Capitalized strings to fit the common/usual format, corrected spelling, removed unnecessary characters.
2017-04-05 13:50:49 +01:00
65f21a8cd7
Replace all occurrences of "can not" with "cannot".
2017-04-05 13:38:14 +01:00
85db82c7f4
Avoid an unauthorised error if clicking on the logo in desktop mode.
2017-04-05 13:33:12 +01:00
4d55e8abe8
Resolved a typo in the previous commit.
2017-04-03 19:00:06 +05:30
02a3919b06
As per Murtuza, we will have the '__module__', when running as a WSGI
...
application, but - it will not have the '__file__' attribute.
2017-04-03 18:55:24 +05:30
b756407c3c
When running pgAdmin as a WSGI application, we will not be able to find
...
the '__main__' module under 'sys.modules'.
2017-04-03 18:44:53 +05:30
74655e60a0
Replace the '$DIR' only when found in the binary directory string.
2017-04-03 18:32:50 +05:30
bb0bd8acc5
Properly handle truncated table names (> NAMEDATALEN). Fixes #2277
2017-04-01 02:57:48 -04:00
9acf340400
Generic function qtLiteral was not adapting values properly when they contain non ascii characters. Fixes #2305
2017-03-31 21:11:25 -04:00
4ba9269a88
Remove debug code.
2017-03-31 20:27:41 -04:00
6a861f7a91
Add the config option ALLOW_SAVE_PASSWORD to allow admins to disable saving of passwords. Fixes #2232
2017-03-31 20:14:37 -04:00
efb077b7f7
Fix error highlighting in the query tool. Fixes #2291
2017-03-31 20:06:55 -04:00
08ff9d7422
Dialog Help was broken in case where query tool/Debugger opens in new browser tab. Fixes #2310
2017-03-31 16:08:05 +05:30
8005b05292
Fixes #2304 , #2145 - Resolve the issue for restoring the table from the backup.
...
Earlier - implementation was generating the backup code like as below:
XXX/pg_restore.exe --host "x.x.x.x" --port "xxxx" --username "osboxes" --no-password --dbname "test" --data-only --verbose --table "tt.test2" "XXX-FILE.bak"
It should have been:
XXX/pg_restore.exe --host "x.x.x.x" --port "xxxx" --username "osboxes" --no-password --dbname "test" --data-only --verbose --schema "tt" --table "test2" "XXX-FILE.bak"
2017-03-31 13:16:17 +05:30
eb89998dc0
From a visual standpoint, grey highlight makes selection look deselected rather than selected. A brighter color would quickly provide visual feedback on an action.
...
With this patch the color of selected rows look more highlighted.
2017-03-30 22:56:13 -04:00
1d27341e21
Fix translation extraction for new client side translations, and update catalogs.
2017-03-28 15:21:49 -04:00
8745417926
Fix ascending/descending sort order in backgrid while clicking on the headers. Fixes #2303
2017-03-28 09:19:24 -04:00
7450c2df0d
Revert code cleanup that wasn't 2.6 compatible.
2017-03-27 21:27:17 -04:00
95f43d59b8
Revert "Ensure client-side translations are correctly extracted into the message templates."
...
This reverts commit 82bd97aed0
2017-03-27 13:53:40 -04:00
82bd97aed0
Ensure client-side translations are correctly extracted into the message templates.
2017-03-27 13:24:47 -04:00
633d2ad28c
Fix the bin path preferences.
2017-03-27 12:25:59 -04:00
757500c478
Ensure preferences are properly saved the first time they're set.
2017-03-27 12:19:28 -04:00
b2ab35e990
Don't require an auth key for the static help files. It doesn't play nicely with webkit.
2017-03-26 21:52:31 -04:00
c391696054
Remove some unnecessary line breaks causing problems with translations.
2017-03-26 20:26:58 -04:00
6152d73f13
Fix some code inspection complaints
2017-03-25 22:04:52 -04:00
a6fa35789c
Fix broken markup
2017-03-25 22:04:52 -04:00
4f27afc99b
Ensure the spinner doesn't obscure the version
2017-03-25 22:04:52 -04:00
569ceb3906
Modify the web code to allow the Query Tool and Debugger to be opened in new tabs, per settings in Preferences. Fixes #1344
...
Note that this does *not* enable the runtime to use multiple windows at this stage. It's really only useful in Server mode.
2017-03-24 14:43:56 +00:00
0eda6033df
Allow users to select UI language at login or from Preferences rather than unpredictable behaviour from browsers. Fixes #2190
2017-03-24 14:20:10 +00:00
6cb9ece6fd
Decode error messages before trying to use them.
2017-03-24 14:11:31 +00:00
5f2a15dd6d
Fix deletion of rows where the primary key isn't at ordinal zero. Fixes #2274
2017-03-24 13:32:56 +00:00
d4e88217eb
Added timeout in _wait_timeout function in our psycopg2 module.
...
Fixes debugger module, Added common function to covert 2d array data to dict for BackGrid.
2017-03-24 14:01:59 +05:30
d205550b53
Fix Python 3 compatibility.
2017-03-23 13:43:24 +00:00
8748ee20cb
Client side translation.
2017-03-23 12:35:28 +00:00
10920404e1
Re-organised the regression directory now we have multiple test suites: move test_utils.py into python_test_utils/
2017-03-23 11:59:31 +00:00
fe9bc379c7
Replace the template selection feature test with one that tests table DDL generation (which also covers template selection).
2017-03-23 11:47:21 +00:00
77007996ed
Support generation of DDL for tables in Greenplum DB. Fixes #2261
2017-03-23 11:40:06 +00:00
0ba0b25290
Move foreign key templates into a default directory.
2017-03-23 11:13:06 +00:00
720aefbe6f
Select2Cell: Check if cell is in multiselect mode before setting default selection of multiple values. Fixes #2283
2017-03-23 10:45:42 +00:00
5b12fd6d5f
Client-side translation for the About and Dashboard modules.
2017-03-22 12:57:59 +00:00
90a369b7de
[Extendible][Dashboard] Allow to create a server clicking the
...
'Add New Server' button on the dashboard, even when the first node is
of not type of 'server-group' in the browser tree.
2017-03-21 22:58:07 +05:30
2142824448
PRevent an error being displayed if the user views data on a table with no columns. Fixes #2244
2017-03-21 16:40:21 +00:00
aee1492d0d
Correct some EDB Postgres Advanced Server branding.
2017-03-21 10:12:26 +00:00
4eafdbeff6
Resolved a typo - show a '?' after the 'Show timing' preference.
2017-03-21 11:17:35 +05:30
72128df75c
[Extendible][Dashboard] Allow to show the dashboard of their choice for
...
the selected node in the browser tree.
2017-03-20 19:17:47 +05:30
c9e04fec8d
Show tooltips for disabled buttons to help user learning. Fixes #2226
2017-03-20 10:33:35 +00:00
145983d544
Add miissing braces to reverse engineered SQL header block for Functions. Fixes #2246
2017-03-17 12:48:58 +00:00
461086c17d
Fix View Data filter options. Fixes #2265
2017-03-17 12:45:59 +00:00
e9702752d9
Fix hadling of DATERANGE[] type. Fixes #2258
2017-03-17 12:40:08 +00:00
e4134695e5
Fix dropping of databases with Unicode names. Fixes #2243
...
1. Pickup correct encoding in qtLiteral to decode.
2. While releasing database connection only decode database name if it's not unicode.
2017-03-17 10:33:03 +00:00
648c332488
Import from flask_babel instead of the deprecated flask.ext.babel. Fixes #2264
2017-03-17 10:22:41 +00:00
4464be6f43
Fix a typo and remove an unnecessary copy of the column properties template.
2017-03-17 10:02:52 +00:00
b2a74ad26d
Fix a bunch of file headers.
2017-03-16 14:27:55 +00:00
ae0d8e89eb
Fix the path to JS
2017-03-15 17:12:58 +00:00
889050b71d
Fix quotes to ensure we have valid JS.
2017-03-15 17:11:53 +00:00
172b41cba8
Refactor clipboard copying into a separate file for use outside the SQL Editor.
2017-03-15 17:11:11 +00:00
4445f9dd63
Add a mechanism for centralising JS translations, to avoid having to render many JS files with Jinja.
2017-03-15 17:10:22 +00:00
ff9d6cd3d5
Fix previous partial commit
2017-03-14 09:34:12 +00:00
cc4c557122
Move Bootstrap files into the distribution format.
2017-03-14 09:23:30 +00:00
1c6f30a0ed
Remove \n in translation that was causing a syntax error.
2017-03-13 10:39:36 +00:00
7767c085c3
Resolved an issue finding the python interpreter on *nix systems, and
...
Windows 2008 R2 (32 bit), while running the pgAdmin 4 as runtime for
the PostgreSQL one click installers.
- Found a typo in runtime code, we were appending the path using ';' on
*nix systems too. We should have used ':', and that did not allow the
os.environ['PATH'] to identify the correct path of the python
interpreter under the 'venv' directory.
- On Windows 2008, it was not honouring the environment variables, set
under the Qt application (e.g. pgAdmin4.exe runtime), in the python
application. (e.g. pgAdmin4.py). We will need to assume that - the
python interpreter resides under the 'venv' directory outside the
'bin' directory.
- Also, on windows 2008, it was setting PYTHONHOME environment variable
to the full path of the pgAdmin4.exe, we need to reset it to 'venv'
directory, if we find the python interpreter under it.
Thanks Murtuza Zabuawala for tips, and help.
2017-03-10 21:19:06 +05:30
28deb34283
Remove some dead code.
2017-03-10 10:27:17 +00:00
5e6c29d5db
Update Polish translation
2017-03-10 09:03:18 +00:00
d756f2f6c6
Create screenshots when feature tests fail.
2017-03-09 15:34:51 +00:00
502c827697
Fix numeric control validation in nested schemas. Fixes #2241
2017-03-09 15:23:18 +00:00
670c8a2cc1
Disable HTMLMIN with Python 2.6 as it doesn't work on that older version.
2017-03-09 15:21:52 +00:00
bc63652811
Fix the issue where Import/Export was failing in linux runtime. Fixes #2166
...
Issue:
Changes done by Ashesh in pgAdmin4.py file for setting up PYTHONHOME variable to sys.prefix was applicable only for windows only.
Additionally I have also added exception handling for file provided by user for Backup/Restore/Import/Export.
2017-03-09 09:54:55 +00:00
533833cb02
Cleanup some ugly code formatting.
2017-03-09 09:27:41 +00:00
18d465e7bc
Fix some messages and update the Polish translation from Begina Felicysym
2017-03-09 09:23:19 +00:00
b6fefd89b6
Add a Polish translation
2017-03-08 10:14:18 +00:00
fb44ffffa0
Fix a couple of translation issues, and remove the test French translation files.
2017-03-08 10:13:15 +00:00
1f9fd507b0
Translation updates.
2017-03-07 11:20:20 +00:00
6cc1fbe739
Import config only when needed, it was causing cyclic dependency when
...
running the regression suite.
2017-03-07 16:07:10 +05:30
e3e951e86d
Prevent the Slonik logo obscuring the login dialogue on small displays in server mode. Fixes #2230
2017-03-07 10:33:38 +00:00
c34f5fd2d4
Use "could not" consistently, instead of "couldn't" which was used in some places.
2017-03-07 10:29:54 +00:00
f2fc1ceba8
Resolved quite a few file-system encoding/decoding related cases.
...
In order to resolve the non-ascii characters in path (in user directory,
storage path, etc) on windows, we have converted the path into the
short-path, so that - we don't need to deal with the encoding issues
(specially with Python 2).
We've resolved majority of the issues with this patch.
We still need couple issues to resolve after this in the same area.
TODO
* Add better support for non-ascii characters in the database name on
windows with Python 3
* Improve the messages created after the background processes by
different modules (such as Backup, Restore, Import/Export, etc.),
which does not show short-paths, and xml representable characters for
non-ascii characters, when found in the database objects, and the file
PATH.
Fixes #2174 , #1797 , #2166 , #1940
Initial patch by: Surinder Kumar
Reviewed by: Murtuza Zabuawala
2017-03-07 15:31:03 +05:30
3317a02120
Fix regression tests with runtime auth. Fixes #2228
2017-03-06 15:24:52 +00:00
6696b3c316
Authenticate the runtime to the server. Fixes #2228
2017-03-06 14:53:49 +00:00
6d6a3753ee
Fix the path to the busy indicator for the treeview which changed when the aciTree module was moved.
2017-03-06 10:36:07 +00:00
da186ea77b
Ensure servers are deleted when their parent group is deleted. Fixes #2212
2017-03-06 10:35:27 +00:00
af499c0c9a
Show the correct indeterminate state when editing new boolean values. Fixes #2218
2017-03-06 10:30:58 +00:00
278c64c361
Add missing "Run Now" option for pgAdmin jobs. Fixes #1796
2017-03-06 10:24:43 +00:00
d1b95aeb33
Revert "Rename the top level feature tests directory for consistency with other test directories"
...
The exclude command line option relies on the directory name. This needs fixing...
This reverts commit 9288d69b62
2017-03-02 11:23:05 +00:00
9288d69b62
Rename the top level feature tests directory for consistency with other test directories
2017-03-02 11:09:08 +00:00
ffa8d94e76
Better handling the non-ascii characters for different database objects.
...
Using 'psycopg2.extensions.UNICODE' (for Python < 3) in the psycopg2
driver for proper conversation of unicode characters. Also - adjusted
the string typecaster to take care of different character types (char,
character, text, name, character varying, and their array types).
Reviewed by: Dave Page, Murtuza Zabuawala & Akshay Joshi
2017-03-02 15:09:28 +05:30
e89c54c15d
Make feature test app teardown more reliable, and tests faster
...
- don't spin up app and chromedriver between each test
- catching signals also tears down the app
- do layout reset between tests, but assume that tests will not leave a modal opened.
Use selenium built-in waiting function and fix flakiness around clicking the alertify OK button
- we think the OK button does not have its event bound when it is created.
If you see more flakiness around clicking the alertify OK button, let us know. The element is clickable but we have to arbitrarily wait for the event to be bound and that timing may vary system to system.
The feature tests are about 7 seconds faster now.
Tira & Joao
2017-03-01 13:20:06 +00:00
59c6be534d
Typo fixes.
2017-03-01 12:49:15 +00:00
ddb8bad201
Fix Sequence ACL SQL for PG 9.3/9.2.
2017-03-01 12:46:58 +00:00
480e00fddf
Query tool efficiency.Convert the data as a 2D array instead of dict. Fixes #2036
...
Incremental back off when polling. Fixes #2038
Initial Patch By: Dave Page
2017-03-01 16:58:51 +05:30
0cd914f3f9
Improve visibility of syntax highlighting colours. Fixes #2215
2017-02-28 15:08:36 +00:00
e2e000a371
Remove a debug message.
2017-02-28 14:44:58 +00:00
1f935d699e
Testsuite fixes for 9.3 and 9.2 support.
2017-02-28 14:22:10 +00:00
5dc2326e9d
Consistent dialogue configuration
2017-02-27 14:58:22 +00:00
3638d63330
Move pgadmin plugins for codemirror back out of the vendor area.
2017-02-27 13:18:28 +00:00
206b9255c5
Fix CSS path. Fixes #2213
2017-02-27 12:39:13 +00:00
a0a31e55ae
Move 3rd party client code into vendor/ directories for ease of maintenance.
2017-02-24 17:01:21 +00:00
Dave Page
Murtuza Zabuawala
Harshal Dhumal
Joao Pedro De Almeida Pereira
Akshay Joshi
George Gelashvili
Matthew Kleiman
Khushboo Vashi
Atul Sharma
Surinder Kumar
Ashesh Vashi
Shruti B Iyer
Sarah McAlear
Andrei Antonov
Neel Patel
Navnath Gadakh
Jonas Thelemann
RAJASEKAR G
Begina Felicysym
Maxim Zakharov
Aravindraja Thinakaran
Wayne Winch Jr
Atira Odhner
Joao Pedro De Almeida Pereira