Nikhil Mohite
37d82d457c
Fixed an issue where the F2 Function key removes browser panel contents. Fixes #7126
2022-01-28 10:55:23 +05:30
Akshay Joshi
0ce3434631
Fixed code smell 'Update this function so that its implementation is not identical' reported by SonarQube.
2022-01-25 20:10:31 +05:30
Pradip Parkale
094129e2be
Port Dependent, dependencies, statistics panel to React. Fixes #7016
2022-01-24 14:13:02 +05:30
Akshay Joshi
343c3ee49c
Fixed following code smells reported by SonarQube:
...
1) Remove this redundant jump.
2) Remove this commented out code.
3) Variables should not be shadowed.
2022-01-21 18:54:23 +05:30
Akshay Joshi
1013d7ccdd
Fixed code smell reported by SonarQube.
2022-01-20 16:58:21 +05:30
Akshay Joshi
dabe64a8df
Fixed enable/disable menu issue introduced by SonarQube fix.
2022-01-19 12:16:57 +05:30
Akshay Joshi
6adc1bfd42
Fixed context menu issue.
2022-01-18 18:43:34 +05:30
Akshay Joshi
9f836f5433
Fixed following code smells reported by SonarQube:
...
1) Immediately return this expression instead of assigning it to the temporary variable.
2) Extract this nested ternary operation into an independent statement.
3) Expected a `for-of` loop instead of a `for` loop with this simple iteration.
2022-01-18 14:49:54 +05:30
Akshay Joshi
e3807ec3d6
Fixed following code smells reported by SonarQube:
...
1) Boolean checks should not be inverted.
2) Review this redundant assignment.
3) Extract this nested ternary operation into an independent statement.
4) Unexpected empty function.
5) Immediately return this expression instead of assigning it to the temporary variable.
2022-01-17 13:56:01 +05:30
Akshay Joshi
3f7e921cce
Fixed code smell 'Unexpected empty arrow function' reported by SonarQube.
2022-01-12 18:59:21 +05:30
Akshay Joshi
c98fb887cc
Fixed code smell 'Unexpected empty arrow function' reported by SonarQube.
2022-01-12 17:32:20 +05:30
Nikhil Mohite
af6ff20020
Fixed SonarQube issues.
2022-01-07 19:58:19 +05:30
Rahul Shirsat
6528d086ba
Fixed review comments:
...
1. Split the restore options/backup options into 2 tabs
2. Restore icon changes
3. feature tests issues
4. restore help link broken
5. Comment section not visible
refs #7018
2022-01-06 16:46:44 +05:30
Akshay Joshi
2786f7ac5a
Update copyright notices for 2022
2022-01-04 13:54:25 +05:30
Nikhil Mohite
191e2b6242
Fixed an issue where an operation error message pop up showing the database object's name incorrectly. Fixes #7078
2021-12-28 13:49:04 +05:30
Rahul Shirsat
603d91be0e
Port Restore dialog to React. Fixes #7018
2021-12-28 13:45:59 +05:30
Nikhil Mohite
461c0abce1
Fixed an issue where Tablespace is created though an error is shown on the dialog. Fixes #6745
2021-12-21 18:07:17 +05:30
Akshay Joshi
92a997b16a
Rearrange tools menu on the basis of usability and form groups of similar sub-menus.
2021-12-16 18:29:44 +05:30
Akshay Joshi
f24348b2b0
Fixed an issue where notifier not working when opening query tool in a new
...
window and then open it in the new tab.
2021-12-08 18:15:13 +05:30
Akshay Joshi
fd53e4f5f9
Replace Alertify alert and confirm with React-based model dialog. Fixes #7053
2021-12-07 18:52:40 +05:30
Ashesh Vashi
36c9eb3dfd
Added support for Two-factor authentication for improving security. Fixes #6543
2021-12-02 16:47:18 +05:30
Akshay Joshi
c6424e3897
Replaced alertifyjs notifiers with React-based notistack. Fixes #7004
2021-12-02 16:05:52 +05:30
Nikhil Mohite
61b440261f
Ensure that sort order should be maintained when renaming a server group. Fixes #6955
2021-11-29 12:04:04 +05:30
Nikhil Mohite
3a30f27153
1. Updated notification message for the reset layout.
...
2. Added notification type in alertify which was missing.
refs #6988
2021-11-24 10:58:15 +05:30
Nikhil Mohite
3afeb8ca46
Port Backup Global, Backup Server, and Backup object dialog in React. Fixes #6984
2021-11-22 11:20:44 +05:30
Nikhil Mohite
cc91e5da94
Fixed an issue where properties of the database should not be visible after removing the database.
...
Fixes #6964
2021-11-18 12:36:39 +05:30
Nikhil Mohite
1408bad8ba
Fixed an issue where reset layout message showing when the user opens the query tool.
...
refs #6988
2021-11-15 16:34:25 +05:30
Nikhil Mohite
8bf178b0a3
Reset the layout if pgAdmin4 detects the layout is in an inconsistent state. Fixes #6988
2021-11-12 11:50:37 +05:30
Pradip Parkale
a61a9e5b8f
Fixed an issue where older server group name displayed in the confirmation
...
pop-up when the user removes server group. Fixes #6939
2021-11-10 11:17:51 +05:30
Nikhil Mohite
f71e2e8040
Fixed an issue where pgAdmin is not opening properly. Fixes #6809
2021-10-29 16:17:36 +05:30
Akshay Joshi
7b85253465
Corrected some menu lables.
2021-10-27 11:05:23 +05:30
Pradip Parkale
35b1e1d0d2
Fixed pgAdmin freezing issue by providing the error message for the operation
...
that can't perform due to lock on the particular table. Fixes #5427
2021-10-27 10:51:52 +05:30
Rahul Shirsat
711ea3bfa1
Fixed an issue where properties panel is not updated when any object is added from the browser tree. Fixes #6859
2021-10-27 10:31:49 +05:30
Aditya Toshniwal
9de1489322
Ensure that only the table node should be allowed to drop on the ERD tool. Fixes #6929
2021-10-19 12:01:43 +05:30
Khushboo Vashi
9e3165c0ff
1) Ensure that the master password should be prompt when MASTER_PASSWORD_REQUIRED
...
is set to True and AUTHENTICATION_SOURCES is the webserver. Fixes #6928
2) Fixed an issue where the existing server group is disappeared on rename it. Fixes #6930
2021-10-19 11:56:44 +05:30
Aditya Toshniwal
7f3c3fa6f9
Added support to allow tables to be dragged to ERD Tool. Fixes #6241
2021-10-16 12:43:39 +05:30
Nikhil Mohite
476d7c5fc9
Fixed background colour issue in the browser tree. Fixes #6890
2021-10-16 12:40:57 +05:30
Aditya Toshniwal
7787def660
The nodes index, RLS policy, rules, triggers are failing to save for partitions.
...
refs #6868
2021-10-06 16:51:46 +05:30
Aditya Toshniwal
dce5038ffd
1. Unable to create trigger for partition table. Fixes #6867 .
...
2. Unable to create index, RLS policy, rules, triggers for partition. Fixes #6868 .
2021-10-06 14:54:01 +05:30
Akshay Joshi
1ed6272e7b
Ensure that SQL help should work for EPAS servers. Fixes #6834
2021-10-06 14:54:01 +05:30
Khushboo Vashi
a693014371
1) Table Dialogue does not close on addition/deletion of partition. Fixes #6863
...
2) Nodes are loaded multiple times in server mode on 'Reset Layout'. Fixes #6861
2021-10-05 17:33:50 +05:30
Khushboo Vashi
44e1a405f0
1) Newly added server/server group is not visible in the tree unless pgAdmin is refreshed. Fixes #6839
...
2) Internal server error displayed if disconnect the server. Fixes #6852
2021-10-03 12:12:02 +05:30
Khushboo Vashi
5e0c113c7b
Properties panel is not updated when any object is added/deleted from the browser tree. Fixes #6833
2021-09-30 18:21:43 +05:30
Khushboo Vashi
aa8854db53
1) Browser panel turns blank on connecting disconnected database & server has multiple databases. Fixes #6817
...
2) The object is not selected/properties panel is not updated when the user moves to object with arrow keys. Fixes #6821
3) Object gets deselected after editing. Fixes #6824
2021-09-29 17:18:55 +05:30
Akshay Joshi
7d07770244
Reverting 'Two-factor authentication' support as it cause OSX and docker build failures.
...
This reverts commit 787a441343
.
2021-09-29 13:24:18 +05:30
Ashesh Vashi
787a441343
Added support for Two-factor authentication for improving security. Fixes #6543
2021-09-28 17:47:00 +05:30
Aditya Toshniwal
dc8ab7cd2a
1. Switch control and CodeMirror control UI improvements for read-only and disabled states.
...
2. If a form input value changes to null, pass it as an empty string in URL params.
3. Use server_type instead of type from the server info.
2021-09-28 10:24:25 +05:30
Khushboo Vashi
483e2ca8d0
Port browser tree to React. Fixes #6129
2021-09-27 16:44:26 +05:30
Aditya Toshniwal
0228d16990
Partition related fixes:
...
1. When attaching a partition, tables were not loading in the dropdown.
2. When adding a sub partition in a partition, collations were not loading in dropdown.
3. Fix some grid column widths in table node.
Fixes #6783
2021-09-24 16:28:55 +05:30
Akshay Joshi
ecaaa8a1b5
Fixed scrollbar issue and used flex layout in grant wizard.
2021-09-23 16:59:59 +05:30
Akshay Joshi
b9bc628189
1. Placeholder should be inside the controlProps. Change the placeholder from 'Select...' to 'Select an item...'
...
2. Updated grant wizard screenshot and documentation.
3. Remove '(Beta)' from ERD Tool and PSQL Tool.
2021-09-23 16:17:39 +05:30
Nikhil Mohite
15a494c189
Fixed review comments for Grant Wizard.
...
refs #6687
2021-09-23 14:40:38 +05:30
Aditya Toshniwal
08009f8edc
1) Make default values column read-only for inherited columns when creating table.
...
2) Default values not populated for inherited columns. The existing issue, API changed.
3) Options are not populated for Name in Column > Variable tab.
4) The empty check error message is changed from Label cannot be empty to Label in Collection cannot be empty for collections.
Fixes #6763
2021-09-21 16:56:29 +05:30
Nikhil Mohite
7aa213a5ce
1) Port Grant Wizard to react. Fixes #6687
...
2) Fixed an issue where grant wizard is unresponsive if the database size is huge. Fixes #2097
2021-09-20 13:02:41 +05:30
Rahul Shirsat
346ee6ba5f
Fixed an issue where privileges not shown in catalog nodes for Properties tab. Fixes #6743
2021-09-17 20:50:29 +05:30
Aditya Toshniwal
32e97b6422
Fixed the CSS issue causing extra space at the bottom of maintenance backup dialog.
2021-09-17 20:47:03 +05:30
Aditya Toshniwal
ae49b556ce
- Properties tab should refresh if node is updated. - Error should be hierarchical and not just id based.
2021-09-09 13:09:41 +05:30
Aditya Toshniwal
261cec1d20
Port Table, Column, Primary key, Foreign key, Check constraint, Unique constraint, Exclusion constraint.
2021-09-09 13:05:57 +05:30
Aditya Toshniwal
9274df0f11
- Fix Jasmine test cases failing in framework. - More stability fixes and enhancements.
2021-09-09 13:03:54 +05:30
Rahul Shirsat
08f2121544
Port Schema & Catalog node to react. Fixes #6655
2021-09-09 13:01:53 +05:30
Aditya Toshniwal
377fe80046
- Add VaccumSettings schema. - Allow collection to have fixed rows. - Changes in data change comparison and add state utils context. - Fixed jasmine test cases.
2021-09-09 13:00:33 +05:30
Akshay Joshi
5c1ce23780
Port Synonyms node to react. Fixes #6599
2021-09-09 12:50:32 +05:30
Aditya Toshniwal
47855eae0b
Allow node ajax functions to send URL params.
2021-09-09 12:50:32 +05:30
Aditya Toshniwal
9d33b03be9
Few more changes to core schema framework required by other nodes.
2021-09-09 12:22:05 +05:30
Aditya Toshniwal
b20558cb99
Some changes to the core code that will be helpful for other nodes.
2021-09-09 12:20:59 +05:30
Aditya Toshniwal
764677431f
Added React framework for the properties dialog and port Server Group, Server, and Database dialogs.
...
Following changes done for the framework:
- Framework for creating React based dynamic form view out of a pre-defined UI schema. Previously, it was based on Backform/Backbone.
- The new framework and components will use MaterialUI as the base. Previously, Bootstrap/Backform/jQuery components were used.
- The new code uses JSS instead of CSS since material UI and most modern React libraries also use JSS. In the future, this will allow us to change the theme in real-time without refresh.
- 90% code covered by 80-85 new jasmine test cases.
- Server group node UI Schema migration to new, with schema test cases.
- Server node UI Schema migration to new, with schema test cases.
- Database node UI Schema migration to new, with schema test cases.
- Few other UI changes.
Fixes #6130
2021-09-09 12:20:59 +05:30
Aditya Toshniwal
173517985e
Avoid a potential conflict with jquery.drag and use addEventListener to bind events.
2021-09-01 15:02:20 +05:30
Nikhil Mohite
b30a42ab9e
Ensure that deleting a database should not automatically connect to the next database. Fixes #6685
2021-08-25 17:01:48 +05:30
Pradip Parkale
7483ddf2b2
Added support to copy SQL from main window to query tool. Fixes #4904
2021-08-09 14:29:31 +05:30
Pradip Parkale
5581f0909a
Fixed an issue where Debugger and ERD tool panel give a blank white panel, missing from the last patch.
...
refs #6398
2021-06-25 11:38:02 +05:30
Libor M
cc989c5c08
Added missing gettexts and text space improvements.
2021-06-24 11:15:50 +05:30
Nikhil Mohite
7c88ee7cff
Added a mechanism to detect a corrupt/broken config database file. Fixes #6460
2021-06-08 19:41:47 +05:30
Nikhil Mohite
9f12747d9b
Added PSQL tool support for the Windows platform.
...
Fixed following issues:
1. If the database name contains escape characters then PSQL unable to connect.
2. If the user terminates the connection by typing the 'exit' command, PSQL
will show the connection termination msg.
Fixes #2341
2021-06-08 14:58:43 +05:30
Nikhil Mohite
5b12483416
Fixed an issue where the Foreground Color property of server dialog does not work. Fixes #6482
2021-06-07 21:09:04 +05:30
Nikhil Mohite
e0eac875b6
Disable the PSQL tool for Windows, the 'fcntl' module is not working on Windows.
2021-06-01 20:04:43 +05:30
Rahul Shirsat
658a2de619
Fixed the issue of renaming the database by another user. Fixes #4203
2021-05-31 12:41:09 +05:30
Ashesh Vashi
a487a51135
Fixes SonarQube issues.
2021-05-29 12:55:59 +05:30
Nikhil Mohite
3ddf941cd7
Added support to launch PSQL for the connected database server. Fixes #2341
2021-05-25 20:12:57 +05:30
Rahul Shirsat
37dece2cd8
Added window maximize/restore functionality for properties dialog. Fixes #4064
2021-05-24 22:08:23 +05:30
Pradip Parkale
0bb40de1c4
Ensure that the user should not be able to add duplicate panels. Fixes #6399
2021-05-12 15:19:41 +05:30
Murtuza Zabuawala
4c55044440
Remove duplicate code and avoid DOM search operation.
...
refs #6355
2021-05-06 10:53:32 +05:30
Khushboo Vashi
72f3730c34
Added support to connect PostgreSQL servers via Kerberos authentication. Fixes #6158
2021-05-03 16:10:45 +05:30
Pradip Parkale
9dd1bae3c7
Ensure that pgAdmin should not allow opening external files that are dragged into it. Fixes #6355
2021-04-28 11:59:45 +05:30
Pradip Parkale
abdd3190fe
Fixed some SonarQube issues.
2021-04-22 17:40:41 +05:30
Aditya Toshniwal
2b1910c1c1
Better fix for the black screen issues, reverted the old fix.
...
refs #6334
2021-04-16 18:23:29 +05:30
Akshay Joshi
b4d44541bb
Fixed SQL panel black screen issue when detaching it in runtime. Fixes #6334
2021-04-15 16:40:35 +05:30
Rahul Shirsat
585ba81492
Fixed sizing issue of help dialog for Query Tool and ERD Tool when open in the new browser tab. Fixes #6333
2021-04-06 15:26:25 +05:30
Akshay Joshi
4bb71c56ad
Fixed an issue where the top menu disappears when entering into the full screen for minimum screen resolution. Fixes #6322
2021-03-17 18:47:25 +05:30
Akshay Joshi
49a59f8929
Added zoom scaling options with keyboard shortcuts in runtime. Fixes #6271
2021-03-15 14:26:11 +05:30
Akshay Joshi
008bc6da28
Fixed some SonarQube issues.
2021-03-02 14:53:05 +05:30
Pradip Parkale
4267207c7f
1) Fixed an issue where the user is unable to create a subscription if the host/IP address for connection is 127.0.0.1. Fixes #6253
...
2) Ensure that proper error message should be shown on the properties and statistics tab in case of insufficient privileges for a subscription. Fixes #6259
3) Fixed an issue where the 'Create Slot' option is disabled in case of the same IP/host provided but the port is different. Fixes #6260
2021-03-01 12:08:33 +05:30
Nikhil Mohite
4fc36a9053
Fixed an issue where the properties tab for collection nodes is unresponsive after switching the tabs. Fixes #4959
2021-02-26 12:50:30 +05:30
Akshay Joshi
3fc0cc3e92
Fixed SonarQube issues
2021-02-15 17:31:20 +05:30
Aditya Toshniwal
1317e4254b
Updated the JS dependencies to the latest
...
1) Migrate from webpack 4 to webpack 5. This had a lot of breaking changes,
so updated multiple webpack plugins and changed the config accordingly.
2) Replaced iconfont-webpack-plugin with a more maintained webfonts-loader.
3) Replaced deprecated babel-eslint with @babel/eslint-parser.
4) Replaced optimize-css-assets-webpack-plugin with a more maintained css-minimizer-webpack-plugin.
5) Updated all other JS packages and made the required code changes.
Fixes #6207
2021-02-10 12:47:52 +05:30
Aditya Toshniwal
617440e1db
Ensure that ajax request for Dashboard, Statistics, Dependencies, and Dependents
...
should not be raised until the panel will be in focus.
refs #5091
2021-02-09 15:31:26 +05:30
Aditya Toshniwal
73b6b95fbc
Make Statistics, Dependencies, Dependants tabs closable and the user can add them back using the 'Add panel' option. Fixes #5091
2021-02-03 12:46:32 +05:30
Pramod Ahire
9e90350e44
Fixed jasmine test cases and added some missing messages for disabled menus.
2021-02-03 12:15:37 +05:30
Pramod Ahire
b948f43dda
Added Quick Search functionality for menu items and help articles. Fixes #6148
2021-02-02 14:47:58 +05:30
Pradip Parkale
bf56a6723b
Added support for Logical Replication. Fixes #5912
2021-02-01 15:12:43 +05:30
Akshay Joshi
102ffd141c
Implemented runtime using NWjs to open pgAdmin4 in a standalone window
...
instead of the system tray and web browser. Used NWjs to get rid of QT
and C++. Fixes #5967
Use cheroot as the default production server for pgAdmin4. Fixes #5017
2021-01-29 13:38:27 +05:30