b91f6f0f5c
Fixed an issue where the semicolon is misplaced in RLS Policy SQL.
...
Fixed one regression issue introduced by renaming the method 'gc' to 'gc_timeout'.
2020-06-26 19:24:54 +05:30
830ac1cc91
Fixed following SonarQube issues:
...
1. Method/Field names should comply with a naming convention.
2. Conditionals should start on new lines
2020-06-26 13:32:45 +05:30
5206dafb35
Fixed code smells having rule 'Rename class name to match the regular expression'.
2020-06-26 13:23:23 +05:30
c7a16a4bd5
Fixed code smells having rule 'Nested blocks of code should not be left empty'.
2020-06-26 13:18:27 +05:30
d3b3d07f2e
Fixed SonarQube issues with the tag unused. All the unused variables, assignments, code comments are fixed.
2020-06-25 11:09:43 +05:30
a1fd9ea3ce
Fixed issue related to extra semicolons and function naming convention reported by SonarQube.
2020-06-24 16:16:12 +05:30
caebdcfa91
Ensure that the query tool should display the proper error message while terminating the active session. Fixes #3591
2020-06-22 17:09:10 +05:30
df05efd7d9
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation.
2020-06-17 17:15:09 +05:30
641f7bbe9d
Some clumsy coding related fixes reported by SonarQube.
2020-06-15 16:50:07 +05:30
92d9c41da7
Fixed connection and version number detection issue when the database server is upgraded. Fixes #5507
2020-06-04 18:18:11 +05:30
d22e276586
Ensure that proper error should be displayed for the deleted node. Fixes #3669
2020-06-03 11:26:26 +05:30
09b76b306c
Fixed typo in exception keyword. Fixes #5539
2020-05-28 18:11:41 +05:30
0f56c25893
Changed the user identity from email to username in the log file.
...
refs #5452
2020-05-18 11:01:20 +05:30
c0451cd454
Added connected pgAdmin user and connection name in the log file. Fixes #5452
...
Patch By: Nico T
2020-05-13 17:43:21 +05:30
0620fafb6c
Fixed PEP8 issues discovered after pycodestyle gets upgraded.
2020-05-13 17:14:32 +05:30
46e9924ebb
Fixed Unicode decode error 'utf-8' codec can't decode byte. Fixes #5510
...
It's a regression of commit id: 04d6d4e2ccc129baa698471ce0680ccabe2282be
2020-05-12 17:22:22 +05:30
1294c089a8
Implement Selenium Grid to run multiple tests across different browsers, operating systems, and machines in parallel. Fixes #5255
2020-05-11 12:11:31 +05:30
e73e2d2502
Fixed the errors, and warnings reported by pylama.
...
TODO::
- Don't use unicode in Python 3 for removing the support of Python 2 (
psycopg2 driver - __init__.py, server_manager.py).
- Merge the lastest pgcli (version: 3.0.0) for SQL autocompletion.
2020-05-08 14:13:38 +05:30
d68e6bd892
Remove Python2 modules.
...
refs #5443
2020-05-08 12:28:21 +05:30
04d6d4e2cc
Remove support for Python 2. Fixes #5443
2020-05-04 14:58:49 +01:00
ad80217593
Remove Python2 references from the source code.
...
refs #5443
Initial patch: Neel Patel
2020-04-30 17:22:48 +05:30
86afec860f
Remove Python 2 support from the Python tests.
...
refs #5443
2020-04-30 12:56:45 +05:30
0f6abcc7fa
Fixed an issue where the user is not able to create a server if login with an LDAP account. Fixes #5439
...
Improved LDAP error messages.
2020-04-27 15:33:19 +05:30
4c616f32eb
1) Fixed feature test and API test cases.
...
2) Added logic to exclude RESQL test cases.
2020-04-22 13:57:32 +05:30
d9c84edf9a
A valid ip address can be IPv4/IPv6
2020-04-14 18:45:45 +05:30
6a9af07f7a
Fixed gettext usage:
...
- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in the dialog.
- improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js,
word 'cancel' needs to be translated in the Czech language as 'zrušit' but in another sentence as 'zrušení')
- added gettext for text translations.
2020-04-10 14:52:41 +05:30
1a34f61b24
Moved the ip-address check functionality to a separate file to improve
...
the maintainability of the code.
2020-04-08 16:50:14 +05:30
c9d04684ce
Ensure that all the transactions should be canceled before closing the connections when a server is disconnected using pgAdmin. Fixes #5142
2020-02-28 14:12:44 +05:30
915b09255c
Added Python 3.8 support. Fixes #5179
...
1) Upgraded passlib==1.7.1 to passlib==1.7.2
2) Replace unmaintained Flask-Security with maintained Flask-Security-Too package, which is also compatible with python 3.8
3) Other compatibility code changes.
2020-02-18 12:10:38 +05:30
2ae279a382
Remove the deprecated 'is_xhr' parameter of flask.request object.
2020-02-10 12:31:52 +05:30
45f2e35a99
Added Schema Diff tool to compare two schemas and generate the difference script.
...
Currently supported objects are Table, View, Materialized View, Function and Procedure.
Backend comparison of two schemas implemented by: Akshay Joshi
Fixes #3452 .
2020-01-10 15:42:09 +05:30
ed279cac31
Improve the test framework to run for multiple classes defined in a single file. Fixes #5071 .
2020-01-10 11:48:36 +05:30
01c7636c75
Update copyright notices for 2020.
2020-01-02 14:43:50 +00:00
4ed2d74d9c
1) Fix network disconnect issue while establishing the connection via SSH Tunnel and it impossible to expand the Servers node. Fixes #4724 .
...
2) Fix server connection drops out issue in query tool. Fixes #4818
3) Fix VPN network disconnect issue where pgAdmin4 hangs on expanding the Servers node. Fixes #4926 .
4) Ensure that the Servers collection node should expand independently of server connections. Fixes #4933 .
Set the default connection timeout to 10 seconds instead of 0.
2019-11-26 09:04:41 +05:30
de878b3198
Refactored code of table and it's child nodes.
...
1) Remove duplicate logic.
2) Child node specific logic should be inside the child node and table node gets the required information from the respective child node.
Note:- Refactoring of columns node still in progress.
Fixes #4807
2019-11-15 14:45:55 +05:30
f22134dabd
Ensure that the superuser should be able to create database and role, as the superuser
...
overrides all the access restrictions.
Fixes #4792 Fixes #4878
2019-11-14 18:14:53 +05:30
687204771c
Add support in query history to show internal queries generated by pgAdmin during save data operations. Fixes #4612
2019-08-16 17:17:12 +05:30
db7a2e3023
Add a --modules option to the RE-SQL test suite to allow testing of specific object types. Fixes #4560
2019-08-06 13:43:49 +01:00
3f4d5a687b
Rename horribly named function.
2019-07-12 13:00:23 +01:00
776884860e
Ensure parameter values are quoted when needed when editing roles. Fixes #4393
2019-07-04 15:00:29 +01:00
0d42f8026c
Fix SSH tunnel password decryption. Fixes #4320
2019-06-25 07:06:04 -04:00
6e8ebbd375
Allow editing of data where a primary key column includes a % sign in the value. Fixes #4036
...
Fix an XSS issue seen in View/Edit data mode if a column name includes HTML. Fixes #4367
2019-06-20 12:21:37 +01:00
9e65c971a3
Add a framework for testing reversed engineered SQL and CRUD API endpoints. Fixes #4202
2019-06-18 14:28:25 +01:00
71919a4ce9
Prevent the "Please login to access this page" message displaying multiple times. Fixes #4306
2019-06-17 14:12:36 +01:00
82bd94e696
Fix connection restoration issue when pgAdmin server is restarted and the page is refreshed. Fixes #4357
2019-06-14 11:50:01 +05:30
6d52f2b911
Initial support for PostgreSQL 12. Fixes #4283 . Fixes #4288 . Fixes #4290 .
2019-06-10 14:24:45 +01:00
f561c0cee6
Fix keyboard navigation in "inner" tabsets such as the Query Tool and Debugger. Fixes #4195
2019-06-10 11:10:49 +01:00
a588c2994d
1) Fix issue where SSH tunnel connection using password is failing, it's regression of Master Password. Fixes #4320
...
2) Fix some more issues related to SSH Tunnel(By: Akshay Joshi)
2019-06-05 12:07:24 +05:30
2dd075161d
Allow the UI layout to be fully locked or to prevent docking changes. Fixes #2653
2019-05-31 11:51:30 -04:00
aa95ff9f57
Fix encoding issue for background process, it is regression of Master Password. Fixes #4303
2019-05-29 12:50:48 +05:30
dfa892d2a2
1. Added Master Password to increase the security of saved passwords. Fixes #4184
...
2. In server(web) mode, update all the saved server credentials when user password is changed. Fixes #3377
2019-05-28 12:00:18 +05:30
6f0eafb223
Fixed CSRF security vulnerability issue. per Alvin Lindstam. Fixes #4217
...
Initial patch by: Khushboo Vashi
Modified by: Ashesh Vashi and Murtuza Zabuawala
2019-05-28 10:59:51 +05:30
c21ea3c342
Ensure that pgAdmin4 should work properly with psycopg2 v2.8. Fixes #4143
2019-04-08 17:49:50 +05:30
7627e9c699
Display errors during CSV download from the Query Tool in the UI rather than putting them in the CSV file. Fixes #4085
...
Ensure the toolbar buttons are properly reset following a CSV download in the Query Tool. Fixes #4096
2019-03-29 14:31:33 +00:00
ae23f146d1
Use the user's full email address (not just the username part) as the basis for the storage directory name.. Fixes #3887
2019-03-22 09:36:13 +00:00
be26fc540c
Many fixes to the stability of the feature tests, including:
...
tree toggle issue
Query tool inteliSence issue eg. when there is only one option and drop down is not shown
Backup and restore windows locator changes
Fixes required due to resolving rm # 4041
Dependent tab not showing data sometime, so refreshed the page and handled it
Due to change of logic for auto commit, did the required changes
Due to fix of RM 4062, did the required workaround which broke the test case.
2019-03-21 12:04:37 +00:00
e4417229aa
Update all Python and JS dependencies. Fixes #4019
2019-03-14 15:11:16 +00:00
efeb9d6d20
Fix regression issue caused due to encoding fixes.
2019-03-04 16:11:20 +05:30
ecbba79c2a
Fix PEP-8 issue.
2019-03-01 14:19:08 +00:00
849e34c2f7
Add full support and testsfor all PG server side encodings. Fixes #3992 . Fixes #3982 . Fixes #3911
2019-03-01 13:51:50 +00:00
e6e7cf0f69
Fix support for bigint's in JSONB data. Fixes #3587
2019-02-27 13:39:47 +00:00
59446bb4b5
Ensure JSON data isn't modified in-flight by psycopg2 when using View/Edit data. Fixes #3600
2019-02-25 10:34:36 +00:00
34045efb38
Modify the Download as CSV option to use the same connection as the Query Tool its running in so temporary tables etc. can be used. Fixes #3673
2019-02-20 11:49:45 +00:00
292ac32db5
Fix editing of table data with a JSON primary key. Fixes #3912
2019-02-20 11:15:39 +00:00
eb3d3980e0
Use 'set_config(...)' function to update the 'bytea_output' settings
...
instead of 'UPDATE' statement, which is not allowed in the the read-only
instances.
Reported by: Robert J. Rotter
Solution provided by: Tom Lane
Fixes #3973
2019-02-08 10:18:32 +05:30
22d458b01e
Close connections gracefully when the user logs out of pgAdmin. Fixes #3942
2019-02-06 13:17:52 +00:00
b786c4c140
Replace the PyCrypto module with the cryptography module. Fixes #3272
2019-01-31 15:57:27 +01:00
cbd8f8236a
Remove Python 2.6 code that's now obsolete. Fixes #3935
2019-01-31 13:47:56 +01:00
d9fc9fdc4d
Ensure object names in external process dialogues are properly escaped. Fixes #3872
2019-01-24 16:34:18 +00:00
d92368f8e5
Use 'UPDATE pg_settings' for setting bytea_output as a
...
convenience hack for those running on old, unsupported versions of
PostgreSQL 'cos we're nice like that.
2019-01-22 15:56:29 +00:00
14f462e9dc
Fix PEP-8 issues.
2019-01-11 22:13:17 +05:30
d641b47adb
Make the browser more robust in the face of multibyte characters in SQL_ASCII databases. Fixes #3877
2019-01-11 21:55:49 +05:30
c455dda3ce
Ensure auto complete should works for columns from a schema-qualified table. Fixes #3810
2019-01-03 18:59:57 +05:30
3a130d68c5
Ensure auto complete should works when first identifier in the FROM clause needs quoting. Fixes #3809
2019-01-03 17:22:42 +05:30
e23d307c56
Update copyright notices for 2019
2019-01-02 15:54:12 +05:30
41c028f944
Ensure that null values handled properly in CSV download. Fixes #3780
2019-01-01 15:15:36 +05:30
e666b0fab0
Fix an issue that could cause the Query Tool to fail to render. Fixes #3433
2018-12-13 11:15:55 +00:00
980d1e0292
Fix PEP8 issue.
2018-12-04 17:07:41 +00:00
7e3bd8b88a
Fix an encoding issue in the query tool. Fixes #3711
2018-12-04 17:03:19 +00:00
eae18f6f14
Ensure previous notices are not removed from the Messages tab in the Query Tool if an error occurs during query execution. Fixes #3016
2018-11-14 08:27:47 -05:00
6bc6bc7f60
Ensure that Utilities(Backup/Restore/Maintenence/Import-Export) should not be started
...
if binary path is wrong and also added 'Stop Process' button to cancel the process.
2018-10-22 12:35:53 +05:30
370df47042
Fixed issue where session files are not deleted first time when pgAdmin4 server started,
...
it always wait for CHECK_SESSION_FILES_INTERVAL which is 24 hours by default.
2018-10-18 18:02:45 +05:30
822d384746
Purge connections from the cache on logout. Fixes #3703
2018-10-17 12:42:41 +01:00
ce31726af5
Fix connection garbage collector. Fixes #3700
2018-10-17 12:35:45 +01:00
ef0e53e8fc
Fixed pep8 issue
2018-10-15 17:41:21 +05:30
fd2c2c4ff7
Fixed minor issue in SQL autocomplete.
2018-10-15 17:36:11 +05:30
7144db7f5a
Cleanup session files periodically. Fixes #3674
2018-10-09 11:34:13 +01:00
15fe26a710
Fix handling of backslashes in the edit grid. Fixes #3551
2018-09-25 10:34:33 -04:00
38ddea038a
Fix support for the CLOB datatype in EPAS. Fixes #3596
2018-09-13 13:45:06 +01:00
4010dc80a9
Ensure auto-complete works for objects in schemas other than public and pg_catalog. Fixes #3630
2018-09-11 12:56:14 +01:00
b665f8fac8
Fixed auto complete issue for EPAS database server.
2018-08-30 12:30:00 +05:30
ea787b30eb
Fixed auto complete issues for Python 2.6
2018-08-27 16:37:00 +05:30
7a3f3046df
Merge pgcli code with version 1.10.3, which is used for auto complete feature.
2018-08-27 15:00:56 +05:30
013ad7446f
Make the session thread safe.
...
As sessions in pgAdmin4 are filesystem based session, they need locking
for avoiding the access from multiple threads, specially running as an
WSGI application.
Fixes #3547
2018-08-22 11:58:27 +05:30
70c95fcdd5
Stabilise feature tests for continuous running on CI systems. Fixes #3136 .
2018-08-21 17:39:36 +05:30
c8c5f83dfe
Add support to save and clear SSH Tunnel password. Fixes #3511
2018-08-06 15:56:46 +05:30
52fc0846cd
pgAdmin4 should work with python 3.7, Fixes #3458
2018-08-06 15:35:03 +05:30
213cb440d0
Add support for SCRAM password changes (requires psycopg2 >= 2.8). Fixes #2214
2018-07-23 15:03:44 +01:00
051ce6afeb
Ensure the SSH tunnel port number is honoured. Fixes #3471
2018-07-19 10:52:16 +01:00
ce768c7f8a
Support SSH tunneling with keys that don't have a passphrase. Fixes #3468
2018-07-18 14:15:05 +01:00
1fc82d328c
Fix backup in directory format on Windows.
2018-07-17 13:04:28 +01:00
d1784137a5
Ensure text is visible in the SQL Filter dialogue. Fixes #3478
2018-07-09 14:08:41 +01:00
82d77c4608
Don't create a session when the /misc/ping test endpoint is called. Fixes #3371
2018-07-05 11:12:03 +01:00
4ba0e1a6f3
Fix Python 2.6 support for SQL_ASCII data in the query tool.
2018-06-21 17:06:28 -04:00
df85392bbf
Fix handling of SQL_ASCII data in the query tool. Fixes #3289 . Fixes #3250
2018-06-21 08:26:01 -04:00
7a06acb678
Allow the connection timeout to be configured on a per-server basis. Fixes #3388
2018-06-19 19:58:46 -04:00
b48145f01f
Add an option to auto-complete keywords in upper case. Fixes #2686
2018-06-15 10:18:56 +01:00
88a2309a26
Fix auto-complete. Fixes #3374
2018-06-13 15:53:21 +01:00
d1ecba56b8
Function and procedure support for PG11. Fixes #3362
2018-06-13 15:03:17 +01:00
38ee39ae7a
Add support for LISTEN/NOTIFY in the query tool. Fixes #3204
2018-05-30 21:58:28 -04:00
17977d5d0e
Fix dropping of databases over SSH tunneled connections. Fixes #3357
2018-05-28 17:37:24 -04:00
b7fb01ab04
Add support for SSH tunneled connections. Fixes #1447
2018-05-04 11:27:27 +01:00
56658a9f8e
Fix the template loader to work reliably under Windows (fixing external tables under Greenplum). Fixes #3324
2018-05-03 15:54:15 +01:00
201f6d359f
Cleanup some old code that was failing CI.
2018-04-26 16:21:46 +01:00
2ace6a60f3
Fixed display SQL of table with index for GreenPlum database. Fixes #3306
2018-04-25 12:36:41 +05:30
79edf40141
Fix password encryption/decryption on Python 3.
2018-04-11 13:45:59 +01:00
163cadc279
Revert "Fix non-ASCII password decryption/encryption under Python 3"
...
This reverts commit d0a640442c
2018-04-10 17:12:14 +01:00
d0a640442c
Fix non-ASCII password decryption/encryption under Python 3
2018-04-10 16:50:43 +01:00
be055ce57d
Update Python and JS modules. Fixes #3154
2018-04-04 10:47:01 +01:00
1baddd5e9a
Decode the severity field in database exception objects properly. Fixes #3090
2018-03-26 13:59:49 +01:00
637f3b9d1a
Fix a number of broken connection detection scenarios.
2018-03-21 08:38:18 +00:00
534f1f35fe
Appropriately set the cookie path. Fixes #3197
2018-03-19 17:09:19 +00:00
93d44d5643
Revert "Ensure the cookie domain and path are properly set. Fixes #3197"
...
This reverts commit 9c4edb4a28
2018-03-15 14:54:14 -04:00
9c4edb4a28
Ensure the cookie domain and path are properly set. Fixes #3197
2018-03-15 13:59:29 -04:00
876ce1799a
Skip tests where appropriate on GPDB. Fixes #3190
...
Victoria & Joao @ Pivotal.
2018-03-13 15:32:35 -04:00
156b308fd3
Fix template paths for Windows. Fixes #3139
...
Joint work from Joao and Murtuza.
2018-03-13 12:45:14 -04:00
9365ab62fe
Revert "Fix template path generation for Windows. Fixes #3139"
...
This reverts commit 695d4e648c
2018-03-13 08:49:34 -04:00
695d4e648c
Fix template path generation for Windows. Fixes #3139
2018-03-13 07:55:37 -04:00
03b772bf64
Add support for connecting using pg_service.conf files. Fixes #3140
2018-03-12 16:45:56 -04:00
d3c303e455
Ensure all messages are retrieved from the server in the Query Tool. Fixes #3094
2018-03-07 13:38:27 +00:00
a4124c2496
PEP8 fixes.
2018-03-02 09:37:11 +00:00
a9de043fef
Add keyboard shortcuts for the Query Tool. Fixes #2900
2018-02-27 14:32:03 +00:00
bcdb8eb275
Revert "Ensure we pick up the messages from the current query and not a previous one. Fixes #3094"
...
This reverts commit 08b3ccc01a#1523
2018-02-26 16:32:53 +00:00
08b3ccc01a
Ensure we pick up the messages from the current query and not a previous one. Fixes #3094
2018-02-26 14:19:43 +00:00
fa9aebadbd
PEP8 fixes.
2018-02-26 13:54:58 +00:00
05e91044c7
Fix intermittent specified_version_number ValueError issue on restart. Fixes #2983
...
Now we try to restore server details like server version number at restart so template paths can be resolved.
2018-02-20 17:31:13 +00:00
15862e903a
Fix creation of tables and columns in GPDB. Fixes #3099
2018-02-19 10:40:10 +00:00
e16a952753
Support EXPLAIN on Greenplum. Fixes #3097
...
- Extract SQLEditor.execute and SQLEditor._poll into their own files and add test around them
- Extract SQLEditor backend functions that start executing query to their own files and add tests around it
- Move the Explain SQL from the front-end and now pass the Explain plan parameters as a JSON object in the start query call.
- Extract the compile_template_name into a function that can be used by the different places that try to select the version of the template and the server type
2018-02-09 11:54:42 +00:00
25647c16ba
Ensure we capture notices raised by queries. Fixes #3027
2018-02-02 15:23:33 +01:00
2042f89ce0
Don't include sizes on primitive datatypes that shouldn't have them when modifying columns. Fixes #3052
2018-02-01 16:27:36 +01:00
e0da9c5a0c
Significantly improve connection loss detection and handling in the query tool. Fixes #2815
2018-02-01 14:29:18 +01:00
c3ddb7df38
PEP8 fixes for the utils module. Fixes #3076
2018-01-31 13:58:55 +00:00
66341e6947
Add infrastructure for managing configurable keyboard shortcuts.
2018-01-25 12:49:06 +00:00
678699c408
Display partitions in Greenplum. Fixes #3036
2018-01-23 10:41:36 +00:00
89821c0d19
Update copyright notices for 2018.
2018-01-05 10:42:50 +00:00
1dd1c10255
Do not decrypt the password when the password is 'None'. Fixes #2765
...
This should avoid the common but harmless exception "ValueError: IV must be 16 bytes long while decrypting the password."
2018-01-03 13:19:58 +00:00
4246a3b22f
Ensure password changes are successful if authenticating using a pgpass file. Fixes #2720
2017-12-13 13:28:07 +00:00
55254a649f
Re-hash the way that we handle rendering of special types such as arrays. Fixes #2782 . Fixes #2822 .
2017-12-13 11:53:27 +00:00
fe7cfa35df
Attempt to decode database errors based on lc_messages. Fixes #2806 . Fixes #2821
2017-11-27 11:53:25 +00:00
4568fe22f7
Decode the field separator and quote char if needed.
2017-11-20 16:28:13 +00:00
Akshay Joshi
Satish V
Pradip Parkale
Khushboo Vashi
Aditya Toshniwal
Yogesh Mahajan
Ashesh Vashi
Dave Page
Libor M
Yosry Muhammad
Usman Muzaffar
Cyril Jouve
Murtuza Zabuawala
Diego Augusto Molina
Harshal Dhumal
Anthony Emengo
Joao Pedro De Almeida Pereira
Murtuza Zabuawala