Commit Graph

2081 Commits (0fa4609220bec097619455945f1cb15ab28b69a4)

Author SHA1 Message Date
Akshay Joshi 2c02e6fc23 Ensure that the user should be allowed to set the schema of an extension while creating it. Fixes #6963 2021-11-29 15:27:44 +05:30
Nikhil Mohite 61b440261f Ensure that sort order should be maintained when renaming a server group. Fixes #6955 2021-11-29 12:04:04 +05:30
Akshay Joshi fbd10ef4b6 Fixed an issue where reverse engineering SQL is wrong for Aggregate. Fixes #7024 2021-11-29 12:00:38 +05:30
Akshay Joshi d644b4f94e 1) Replace Flask-BabelEx with Flask-Babel. Fixes #6088
2) Upgrade Flask to version 2. Fixes #7010
2021-11-24 17:22:57 +05:30
Nikhil Mohite 3a30f27153 1. Updated notification message for the reset layout.
2. Added notification type in alertify which was missing.

refs #6988
2021-11-24 10:58:15 +05:30
Nikhil Mohite 3afeb8ca46 Port Backup Global, Backup Server, and Backup object dialog in React. Fixes #6984 2021-11-22 11:20:44 +05:30
Akshay Joshi a701e8c766 Fixed an issue where the Change Password menu option is missing for internal
authentication source when more than one authentication source is defined.

Fixes #6989
2021-11-22 11:02:26 +05:30
Nikhil Mohite cc91e5da94 Fixed an issue where properties of the database should not be visible after removing the database.
Fixes #6964
2021-11-18 12:36:39 +05:30
Nikhil Mohite 3d5d507f4b Fixed an issue where referenced table drop-down should be disabled in
foreign key -> columns after one row is added.

Fixes #6906
2021-11-18 12:22:14 +05:30
Nikhil Mohite 1408bad8ba Fixed an issue where reset layout message showing when the user opens the query tool.
refs #6988
2021-11-15 16:34:25 +05:30
Pradip Parkale 33cc2a7514 Fixed an issue where SQL for index shows the same column multiple times. Fixes #6981 2021-11-15 16:31:40 +05:30
Akshay Joshi 0ca7dbccf6 Ensure that the Binary path for PG14 should be visible in the preferences. Fixes #6972 2021-11-15 12:44:33 +05:30
Nikhil Mohite 8bf178b0a3 Reset the layout if pgAdmin4 detects the layout is in an inconsistent state. Fixes #6988 2021-11-12 11:50:37 +05:30
Pradip Parkale d4bf7164f9 Ensure that inherit table icon should be visible properly in the tree view. Fixes #6845 2021-11-11 12:55:38 +05:30
Nikhil Mohite 7468ca36ae Fixed SQL syntax error if select "Custom auto-vacuum" option and not set Autovacuum option to Yes or No. Fixes #6925 2021-11-11 12:36:19 +05:30
Pradip Parkale a61a9e5b8f Fixed an issue where older server group name displayed in the confirmation
pop-up when the user removes server group. Fixes #6939
2021-11-10 11:17:51 +05:30
Pradip Parkale eb8168285e Cover more scenarios for the pgAdmin freezing issue. Fixes #5427 2021-11-10 11:11:24 +05:30
Akshay Joshi 719f8c8fd2 Fixed API test case for DataTypeReader 2021-10-29 17:37:02 +05:30
Pradip Parkale fa8b3edda5 Fixed an issue where user details are not shown when the non-admin user tries
to connect to the shared server. Fixes #6940
2021-10-29 16:26:11 +05:30
Nikhil Mohite f71e2e8040 Fixed an issue where pgAdmin is not opening properly. Fixes #6809 2021-10-29 16:17:36 +05:30
Akshay Joshi 39992a817d Added support of Aggregate and Operator node in view-only mode. Fixes #3834 2021-10-29 16:14:33 +05:30
Akshay Joshi 7b85253465 Corrected some menu lables. 2021-10-27 11:05:23 +05:30
Pradip Parkale 35b1e1d0d2 Fixed pgAdmin freezing issue by providing the error message for the operation
that can't perform due to lock on the particular table. Fixes #5427
2021-10-27 10:51:52 +05:30
Rahul Shirsat 711ea3bfa1 Fixed an issue where properties panel is not updated when any object is added from the browser tree. Fixes #6859 2021-10-27 10:31:49 +05:30
Rahul Shirsat 8eb6f8061d Ensure that dialog should be opened when clicking on Reassign/Drop owned menu. Fixes #6949 2021-10-25 11:47:28 +05:30
Pradip Parkale c7cd57db91 Ensure that columns should be merged if the newly added column is present in the parent table. Fixes #6780 2021-10-21 10:59:52 +05:30
Akshay Joshi d2a7f7fffe Fixed API test cases for PG 14 2021-10-20 18:39:42 +05:30
Rahul Shirsat 27b6e07e21 Fixed object delete issue from the properties tab for the collection nodes. Fixes #6858 2021-10-19 17:21:46 +05:30
Akshay Joshi ea0d3eb812 Fixed an issue where a blank string is stored instead of NULL in create mode in server dialog. Fixes #6915 2021-10-19 17:01:50 +05:30
Aditya Toshniwal 9de1489322 Ensure that only the table node should be allowed to drop on the ERD tool. Fixes #6929 2021-10-19 12:01:43 +05:30
Khushboo Vashi 9e3165c0ff 1) Ensure that the master password should be prompt when MASTER_PASSWORD_REQUIRED
is set to True and AUTHENTICATION_SOURCES is the webserver. Fixes #6928
2) Fixed an issue where the existing server group is disappeared on rename it. Fixes #6930
2021-10-19 11:56:44 +05:30
Akshay Joshi b8072bd630 Fixed an issue where the blank string is stored instead of NULL in the server table of SQLite database. Fixes #6915 2021-10-18 15:50:42 +05:30
Aditya Toshniwal 7f3c3fa6f9 Added support to allow tables to be dragged to ERD Tool. Fixes #6241 2021-10-16 12:43:39 +05:30
Nikhil Mohite 476d7c5fc9 Fixed background colour issue in the browser tree. Fixes #6890 2021-10-16 12:40:57 +05:30
Rahul Shirsat 1377244e52 Fixed the issue of editing triggers for advanced servers. Fixes #6802 2021-10-16 12:36:25 +05:30
Pradip Parkale 173cb60691 Added support to enable/disable rules. Fixes #6794 2021-10-14 11:44:03 +05:30
Nikhil Mohite fa21e25cb2 Ensure that the Dashboard should get updated after connecting to the server. Fixes #6876 2021-10-14 11:24:43 +05:30
huangj.fnst@fujitsu.com 8a21d9b500 Fixed some typos in the documentation and comments. 2021-10-14 11:13:16 +05:30
Aditya Toshniwal 8b7b63868f Added support for composite foreign keys in the ERD tool. Fixes #6891 2021-10-13 14:28:55 +05:30
Nikhil Mohite 96ce298789 Port columns node under the Catalog Objects in React. 2021-10-13 12:59:08 +05:30
Yogesh Mahajan 6c692df118 Changed the label 'Inherits Tables?' to 'Is inherited?' as it misleading in the properties panel. Fixes #6776 2021-10-13 11:41:21 +05:30
Nikhil Mohite 5b9383c880 Fixed an issue where the user is unable to create an index with concurrently keyword. Fixes #6790 2021-10-12 18:19:40 +05:30
Khushboo Vashi a726635290 1) Added support for authentication via the web server (REMOTE_USER). Fixes #6657
2) Fixed OAuth2 integration redirect issue. Fixes #6719

Initial patch for 6657 sent by: Tom Schreiber
2021-10-12 14:52:30 +05:30
Aditya Toshniwal a92c1b43a2 1) Added support for advanced table fields like the foreign key, primary key in the ERD tool. Fixes #6081
2) Added index creation when generating SQL in the ERD tool. Fixes #6529
2021-10-11 17:42:14 +05:30
Nikhil Mohite d65930a8a6 Remove an extra blank line at the start of the SQL for function, procedure, and trigger function. Fixes #6797 2021-10-07 17:11:48 +05:30
Aditya Toshniwal a92bad7909 Fixed indexes not loading in Primary constraint and Unique constraint dialog for partition.
refs #6868
2021-10-06 17:49:50 +05:30
Aditya Toshniwal 7787def660 The nodes index, RLS policy, rules, triggers are failing to save for partitions.
refs #6868
2021-10-06 16:51:46 +05:30
Aditya Toshniwal dce5038ffd 1. Unable to create trigger for partition table. Fixes #6867.
2. Unable to create index, RLS policy, rules, triggers for partition. Fixes #6868.
2021-10-06 14:54:01 +05:30
Akshay Joshi 1ed6272e7b Ensure that SQL help should work for EPAS servers. Fixes #6834 2021-10-06 14:54:01 +05:30
Khushboo Vashi a693014371 1) Table Dialogue does not close on addition/deletion of partition. Fixes #6863
2) Nodes are loaded multiple times in server mode on 'Reset Layout'. Fixes #6861
2021-10-05 17:33:50 +05:30
Rahul Shirsat bfb65e82aa Fixed dialog crash issue when added security label and changing the type to shell. Fixes #6744 2021-10-05 17:24:16 +05:30
Pradip Parkale 4bbc811aed 1) 'Only Table' should be disabled unless the table value is changed. Fixes #6862.
2) 'ALTER' statement should not be generated every time a user updates the password in edit mode. Fixes #6835
3) Connection timeout and sslmode value is getting updated after subscription update. Fixes #6835.
2021-10-05 17:19:22 +05:30
Aditya Toshniwal 400896c563 1. Operators dropdown disabled. Fixes #6771.
2. Vacuum options value is not considered for M-SQL when creating. Fixes #6781.
2021-10-05 14:13:15 +05:30
Rahul Shirsat 2932ef770d Fixed an issue where adding security privileges and change type to shell crash the dialog. Fixes #6744 2021-10-04 19:34:41 +05:30
Aditya Toshniwal 7eaa3179ad Fixed an issue where the index is not loaded in the Unique Constraint dialog. Fixes #6857 2021-10-04 19:28:27 +05:30
Aditya Toshniwal e77f933fe7 Foreign key issues in edit mode:
1. Couple of foreign key issues in edit mode. Fixes #6837
2. Table "Of type" related issues. Fixes #6825
2021-10-04 14:14:27 +05:30
Pradip Parkale 69109a19db Ensure that the user should be able to edit the publication in the subscription dialog. Fixes #6835 2021-10-04 14:11:57 +05:30
Aditya Toshniwal 038fd6ce21 Fixed Dark theme UI related issues. Fixes #6846 2021-10-04 12:41:48 +05:30
Khushboo Vashi 44e1a405f0 1) Newly added server/server group is not visible in the tree unless pgAdmin is refreshed. Fixes #6839
2) Internal server error displayed if disconnect the server. Fixes #6852
2021-10-03 12:12:02 +05:30
Aditya Toshniwal 357a020828 Table node related fixes:
1. File select control sets the value for all other to last selected file. Fixes #6814
2. Vacuum parameters-related issues. Fixes #6777
3. Exclusion removes all columns if one row is removed. Fixes #6771
2021-10-01 12:57:04 +05:30
Khushboo Vashi 5e0c113c7b Properties panel is not updated when any object is added/deleted from the browser tree. Fixes #6833 2021-09-30 18:21:43 +05:30
Pradip Parkale 8056e7e3e3 1) System procedure should not be visible in the properties tab for function.
2) The estimated cost option should be editable in edit mode for Procedure.
3) Should give an error when language is not specified.

Fixes #6838 #6841
2021-09-30 16:27:02 +05:30
Rahul Shirsat 1632e5287a Fixed some additional issues for the Type node.
refs #6744
2021-09-30 15:16:21 +05:30
Akshay Joshi 031167fbea Use the correct way to update the state variable using depChange method. 2021-09-30 10:57:39 +05:30
Akshay Joshi 8ac38a076b Fixed linter error. 2021-09-29 20:17:54 +05:30
Nikhil Mohite c80ea7ae89 1) Fixed accessibility issues for Trigger functions. Fixes #6803
2) Fixed incorrect privileges value in Materialize View. Fixes #6781
2021-09-29 19:56:30 +05:30
Akshay Joshi 1b6ab6b3bb 1) Fixed pgAgent related issues. Fixes #6827
2) Added helpMessageMode parameter to hide help messages from properties panel.
2021-09-29 19:48:43 +05:30
Khushboo Vashi aa8854db53 1) Browser panel turns blank on connecting disconnected database & server has multiple databases. Fixes #6817
2) The object is not selected/properties panel is not updated when the user moves to object with arrow keys. Fixes #6821
3) Object gets deselected after editing. Fixes #6824
2021-09-29 17:18:55 +05:30
Aditya Toshniwal c57fc74e18 Fixed Jasmine test cases. 2021-09-29 16:36:49 +05:30
Aditya Toshniwal 28892bb07f Remove redundant empty option for Exclusion constraint access method name, Of type, and Like relations. Fixes #6825 2021-09-29 15:23:48 +05:30
Akshay Joshi 82935ad3be Fixed API test caes for Domain node. 2021-09-29 15:20:50 +05:30
Aditya Toshniwal 332351efaf 1. Date time control not working on firefox.
2. Replace moment with date-fns in date time control as date-fns is more maintained.

Fixes #6816
2021-09-29 13:43:05 +05:30
Pradip Parkale d753719891 1) Ensure the edit dialog should not allow clearing owner in the Language node. Fixes #6815
2) Fixed an issue where the Language node is disabled for the functions for
   EPAS/PG 9.6 and 10. Fixes #6823
2021-09-29 13:40:10 +05:30
Akshay Joshi 7d07770244 Reverting 'Two-factor authentication' support as it cause OSX and docker build failures.
This reverts commit 787a441343.
2021-09-29 13:24:18 +05:30
Aditya Toshniwal 08706ba6b2 1. Make Unlogged switch in table as read only.
2. Fix a console warning when saving node data.

Fixes #6778
2021-09-28 17:48:09 +05:30
Ashesh Vashi 787a441343 Added support for Two-factor authentication for improving security. Fixes #6543 2021-09-28 17:47:00 +05:30
Nikhil Mohite c4db223a64 Added appropriate 'IF EXISTS', 'CASCADE', 'IF NOT EXISTS' clause for the remaining nodes.
refs #5741
2021-09-28 16:05:46 +05:30
Aditya Toshniwal be69470d55 Server and Database node fixes:
1. Unable to change shared server switch.
2. DB restriction and schema restriction have an empty option.
3. File select input control does not allow manual text input.
4. In the Parameters tab if the value is a switch control, then an empty value error should not come.
5. Values for parameters should be reset on changing parameters.
6. Added a new key - helpMessageMode which can have a value similar to mode. It will show the help message if the mode is supported.

Fixes #6814
2021-09-28 15:05:32 +05:30
Akshay Joshi 1569be7866 Fixed keyerror issue in schema diff for 'attnum' and 'edit_types' parameter. Fixes #6755 2021-09-28 15:03:28 +05:30
Akshay Joshi 2265ffc0a7 Handler and Validator should not allow selecting the empty options. Fixes #6810 2021-09-28 11:34:45 +05:30
Pradip Parkale d616cb88aa 1. Syntax error displayed If the table is not available and the user tries to use the blank option. Fixes #6793
2. Not able to add Parameters for Functions and Procedures.
3. For the procedure, the Volatility option should be disabled in some cases. Fixes #6799
2021-09-28 10:37:47 +05:30
Rahul Shirsat 15ecf5d821 Fixed an issue for sort and null controls for the Index node. Fixes #6791 2021-09-28 10:32:00 +05:30
Aditya Toshniwal dc8ab7cd2a 1. Switch control and CodeMirror control UI improvements for read-only and disabled states.
2. If a form input value changes to null, pass it as an empty string in URL params.
3. Use server_type instead of type from the server info.
2021-09-28 10:24:25 +05:30
Nikhil Mohite 48a5143485 Fixed an issue where SQL is not getting generated for Foreign table options. Fixes #6813 2021-09-28 10:21:25 +05:30
Khushboo Vashi 483e2ca8d0 Port browser tree to React. Fixes #6129 2021-09-27 16:44:26 +05:30
zhangjie2@fujitsu.com d983225683 Correct the variable names in the error messages for the Domain node. 2021-09-27 15:09:17 +05:30
Rahul Shirsat d8d88b948a Fixed an issue where Schema icon is not visible in the drop-down of General tab. Fixes #6806 2021-09-27 13:36:13 +05:30
Nikhil Mohite 2320370fd2 1) Fixed an issue where for constraint trigger only After event should be displayed,
also fixed the Incorrect values for Constraint trigger, Deferrable, Deferred. Fixes #6803
2) Fixed an issue where the user was unable to create the trigger for views. Fixes #6804
2021-09-27 11:31:52 +05:30
Nikhil Mohite 9d2f3b5ee9 Ensure that RLS names should not be editable in the collection node of properties tab. Fixes #6759 2021-09-27 10:57:08 +05:30
Aditya Toshniwal 0228d16990 Partition related fixes:
1. When attaching a partition, tables were not loading in the dropdown.
2. When adding a sub partition in a partition, collations were not loading in dropdown.
3. Fix some grid column widths in table node.

Fixes #6783
2021-09-24 16:28:55 +05:30
Akshay Joshi c32a325c11 Fixed html help for foreign server dialog. 2021-09-24 13:32:13 +05:30
Aditya Toshniwal d28f8bc7ee Fixed exclusion constraint issues:
1. Incorrect error message.
2. Properties panel Column Section data missing
3. Operator class value is missing

Fixes #6771
2021-09-23 19:28:35 +05:30
Nikhil Mohite a6dce27ffa Fixed an issue where options are missing in the trigger function's Security tab. Fixes #6792 2021-09-23 19:23:08 +05:30
Pradip Parkale 6d08d9aa9f Fixed Cast node related issues. Fixes #6741 2021-09-23 19:19:34 +05:30
Akshay Joshi ecaaa8a1b5 Fixed scrollbar issue and used flex layout in grant wizard. 2021-09-23 16:59:59 +05:30
Akshay Joshi b9bc628189 1. Placeholder should be inside the controlProps. Change the placeholder from 'Select...' to 'Select an item...'
2. Updated grant wizard screenshot and documentation.
3. Remove '(Beta)' from ERD Tool and PSQL Tool.
2021-09-23 16:17:39 +05:30
Aditya Toshniwal 0e6794f2f5 Fixed issue where modified SQL not loading Unique Constraint dialog. Fixes #6772 2021-09-23 14:47:31 +05:30
Aditya Toshniwal 9179b7464b Fixed following issues after React Porting:
1. Unique constraint should not allow changing values for deferrable, deferred, included columns.
2. Primary keys should not allow changing values for deferrable, deferred, included columns.
3. Foreign keys should not allow changing match type. The referenced table name is empty.
4. Exclude - Column/Expression has incorrect values.
5. Save should not be enabled when Custom auto-vacuum is enabled but none of the parameters are edited.

Fixes #6777
2021-09-23 14:46:10 +05:30
Nikhil Mohite 15a494c189 Fixed review comments for Grant Wizard.
refs #6687
2021-09-23 14:40:38 +05:30
Akshay Joshi 25c98f8054 Fixed API test case. 2021-09-23 12:09:24 +05:30