3e09f1bf40
Ensure that the current value of the sequence should be ignored while comparing using schema diff. Fixes #6144
2021-01-21 14:18:06 +05:30
a2f626046a
Fix labels.
2021-01-20 15:47:41 +00:00
da9f9017a9
Fixed cognitive complexity reported by SonarQube.
2021-01-19 13:34:14 +05:30
c0ef0a893d
1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457
...
2) Fixed incorrect log information for AUTHENTICATION_SOURCES. Fixes #5829
2021-01-18 16:32:10 +05:30
0c8226ff39
Added ERD Diagram support with basic table fields, primary key, foreign key, and DDL SQL generation. Fixes #1802
2021-01-16 17:06:50 +05:30
a2edf317a9
Ensure that the user should be able to specify an older date for the account expiration of the role/user. Fixes #6120
2021-01-15 11:38:08 +05:30
f86f58dc56
Revert "Ensure that the account expiration date for role/user can’t be older than the current date. Fixes #6120"
...
This reverts commit 9a47e574e3
2021-01-14 14:47:52 +05:30
f0debdd513
Revert "1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457"
...
This reverts commit 6ead597b43
2021-01-14 14:46:59 +05:30
6ead597b43
1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457
...
2) Fixed incorrect log information for AUTHENTICATION_SOURCES. Fixes #5829
2021-01-14 13:46:48 +05:30
9a47e574e3
Ensure that the account expiration date for role/user can’t be older than the current date. Fixes #6120
2021-01-14 12:09:03 +05:30
d55555c544
Fixed an issue where sequences are not created. Fixes #6128
...
refs #6084
2021-01-11 17:29:08 +05:30
f8497d4e7a
Fixed an issue where the database list in the new connection window is not visible. Fixes #6121
2021-01-11 13:03:15 +05:30
b372f08a59
Update copyright notices for 2021
2021-01-04 15:34:45 +05:30
5198a881b7
Added 'Count Rows' option to the partition sub tables. Fixes #5282
2021-01-04 15:25:05 +05:30
233736897d
Added 'CREATE TABLE' SQL missed in the last patch for #5571
...
refs #5571
2021-01-04 15:06:28 +05:30
cd5243ac6d
Fixed RESQL test cases for schema
2020-12-31 13:54:19 +05:30
d1f5511566
Improve code coverage and API test cases for pgAgent. Fixes #5338
2020-12-31 13:52:14 +05:30
26bbc0e877
Fixed RESQL test cases for Column.
2020-12-30 12:25:07 +05:30
f9087475d4
Fixed RESQL test cases for exclusion constraints.
...
refs #5571
2020-12-24 14:03:07 +05:30
4c9853f10d
Fixed an issue where pressing the back button will show another instance of the main page inside of the Query Tool tab. Fixes #4892
2020-12-24 13:13:57 +05:30
5448de2d3f
Added support for expression in exclusion constraints. Fixes #5571
2020-12-24 12:50:57 +05:30
a92595012f
Fixed extra parentheses issue around joins for Views. Fixes #6061
2020-12-23 13:02:16 +05:30
3def9792be
Added appropriate help message and a placeholder for letting users know about the account password expiry for Login/Group Role. Fixes #5973
2020-12-17 12:02:32 +05:30
cb0a914099
Ensure that the 'template1' database should not be visible after pg_upgrade. Fixes #5875
2020-12-16 11:37:19 +05:30
21333490ef
1. Added check to skip debugger test case if the plugin is not installed.
...
2. Added code to delete the existing "pldbgapi" extension and create a new extension.
3. Updated a few test cases that are falling on specific servers.
4. Fixed test cases for pgAgent.
Fixed by: Nikhil & Yogesh
2020-12-16 11:25:16 +05:30
794bd50ed1
Improve code coverage and API test cases for Debugger. Fixes #5343
2020-12-03 10:31:24 +05:30
26b3bc3f74
Fixed an issue where an illegal argument is showing for trigger SQL when a trigger is created for View. Fixes #6003
2020-12-02 10:55:23 +05:30
64e6570f00
Fixed an issue where schema diff doesn't show the result of compare if source schema has tables with RLS. Fixes #5998
2020-12-01 13:46:19 +05:30
783b7516a7
Fixed false error is shown while adding a new foreign key from the table dialog when a foreign key already exists with Auto FK Index set to true. Fixes #5886
2020-12-01 11:35:01 +05:30
b54cf2edca
Improve code coverage and API test cases for Foreign Tables. Fixes #5328
2020-11-26 11:52:06 +05:30
ce14696165
Improve code coverage and API test cases for Views and Materialized Views. Fixes #5337
2020-11-20 10:04:30 +05:30
be386e77f2
1) Fixed an issue where the process watcher dialog throws an error for
...
the database server which is already removed. Fixes #5985
2) Fixed cognitive complexity reported by SonarQube.
2020-11-12 17:47:21 +05:30
a026f339c3
Fixed cognitive complexity reported by SonarQube.
2020-11-12 17:20:58 +05:30
25fcdab9db
Fixed an issue where a mismatch in the value of 'Estimated row' for functions. Fixes #5914
2020-10-30 15:09:40 +05:30
b76bb58378
Added support to compare schemas and databases in schema diff. Fixes #5891
2020-10-27 16:36:10 +05:30
7648bd9646
Added missing gettext.
2020-10-27 10:51:35 +05:30
275d13d40f
Following issues have been resolved for the new connection feature:
...
1. Show servers with server groups in the dropdown.
2. Highlighted current selected connection in the new connection dropdown.
3. Notify the user before changing the connection.
refs #3794
2020-10-21 17:14:59 +05:30
3413a42af4
Ensure that some fields should be disabled for the trigger in edit mode. Fixes #4639
...
Fixed illegal argument issue in the trigger for EPAS servers. Fixes #5799
2020-10-20 16:18:34 +05:30
7b9504bdfb
Fixed an issue where the suffix for Toast table size is not visible in the Statistics tab. Fixes #5895
2020-10-20 15:57:32 +05:30
1bb510cdd4
Fixed following issues in the function module:
...
1) The volatility option is not reflecting. It stays volatile always when creating the function.
2) Set "Returns as set" to true and enter estimated rows like 12. Now set returns as set to false and save.
It gives ERROR: ROWS is not applicable when the function does not return a set.
Need to clear estimated rows when returns as set is false.
3) If estimated rows are added and support function is selected then SQL looks ugly.
Fixes #5843
2020-10-12 14:01:04 +05:30
556278dbc5
Added support to view trigger function under the respective trigger node. Fixes #2519
2020-10-12 13:49:54 +05:30
f27527a614
Fixed API test cases failed for PG 9.5 due to change in the order of ACL.
2020-10-07 08:41:21 +05:30
82e912ffad
Fixed 'can't execute an empty query' message if the user change the option of Auto FK Index. Fixes #5835
2020-10-06 17:20:43 +05:30
6c4049f29a
Added RESQL/MSQL test cases for Functions. Fixes #5395
...
Initial patch sent by Nikhil Mohite.
2020-10-06 17:13:41 +05:30
e4029cca04
Ensure that the user should be able to change the start value of the existing sequence. Fixes #5855
2020-10-05 16:38:16 +05:30
542be2b2d4
Fixed issues where the 'pg_pltemplate' system catalog is removed from PG 13 and it gives error while creating the language.
2020-10-05 14:35:48 +05:30
9a77d4dc1a
Allow users to modify the option settings of the procedure.
...
refs #5843
2020-10-05 09:02:27 +05:30
be7bb81a19
Allow user to change the database connection from an open query tool tab. Fixes #3794
2020-10-01 13:29:46 +05:30
656e239e55
Fixed API test cases introduce in the commit for #5867 .
...
refs #5867
2020-10-01 13:29:46 +05:30
b097cec45e
Fixed an issue where some properties are not being updated correctly for the shared server. Fixes #5867
2020-09-30 12:29:59 +05:30
1c70a43b91
Fixed code smells 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-09-29 15:08:14 +05:30
952197f130
Added support to ignore the owner while comparing objects in the Schema Diff tool. Fixes #5200 .
2020-09-28 15:22:46 +05:30
68588fbb44
Fixed an issue where schema diff is showing identical table as different due to default vacuum settings. Fixes #5826
2020-09-24 13:24:25 +05:30
c1d04747a1
Ensure that the 'Remove Server' option should be visible in the context menu. Fixes #5861
2020-09-24 10:58:30 +05:30
f8611416ec
Added the 'PARALLEL UNSAFE' option to the missing SQL files.
...
refs #5843
2020-09-24 10:47:42 +05:30
2e55b1f660
Fixed an issue where the 'PARALLEL UNSAFE' option is missing from reverse engineering SQL of function/procedure node. Fixes #5843 .
2020-09-23 13:21:50 +05:30
43d97b0e6f
Improve code coverage and API test cases for Functions. Fixes #5330
2020-09-22 14:43:46 +05:30
458036ad6b
Fixed an issue where the server is not able to connect using the service. Fixes #5841
2020-09-22 13:14:40 +05:30
b0475566ca
Fixed reverse engineering SQL where parenthesis is not properly arranged for View/MView definition. Fixes #5830
2020-09-21 11:05:56 +05:30
3489f94ca7
Ensure that multiple extensions can be dropped from the properties tab. Fixes #5839 .
2020-09-21 10:09:41 +05:30
a25e808e06
Remove maximum length on the password field in the server dialog. Fixes #5802
2020-09-17 20:21:00 +05:30
95a5b1e459
Some more accessibility fixes.
...
refs #5732
2020-09-17 20:16:38 +05:30
55b5080c77
Fixed and improve API test cases for the schema diff tool. Fixes #5417
2020-09-17 20:10:01 +05:30
324e3e74be
Fixed an issue where custom sequences are not visible when show system objects are set to false. Fixes #5833
2020-09-15 12:58:43 +05:30
5eb1c57320
1) Correct the reverse engineering SQL of the collation node for database server version < 10.
...
2) Added 'rngcollation' and 'attnum' in the ignore list of Types node and fixed an issue occurs due to SonarQube fix.
2020-09-14 16:12:20 +05:30
a7d40e238e
Ensure that the 'CREATE SCHEMA' statement should be present in the generated script if the schema is not present in the target database. Fixes #5816
2020-09-11 19:06:56 +05:30
1bd0a0edf5
Remove illegal argument from trigger function in trigger DDL statement. Fixes #5779
2020-09-10 17:27:01 +05:30
1bc1ef7f17
Fixed an issue where vacuum options not consider in Schema Diff. It's a regression.
2020-09-09 15:34:50 +05:30
ffb829e80c
Fixed an issue while refreshing Resource Group. Fixes #5820
2020-09-09 14:34:14 +05:30
98e86a8160
Fixed an issue where the server icon getting change to the shared server icon in desktop mode.
...
refs #4979
2020-09-08 10:09:16 +05:30
9e5487d5ad
Fixed SQL for Row Level Security which is incorrectly generated. Fixes #5764
2020-09-07 18:40:49 +05:30
4da4a05611
Fixed code smell 'Remove duplicates string literals'.
2020-09-07 17:56:02 +05:30
eaa90ee8eb
Fixed primary key/unique constraint icon issue.
2020-09-03 18:53:40 +05:30
31bbdd6a12
Fixed code smell 'String literals should not be duplicated'.
2020-09-03 18:35:58 +05:30
a67f6e4f9c
Fixed API test cases failed due to commit for #4979 .
2020-09-03 14:20:45 +05:30
b562ab7681
Added shared server support for admin users. Fixes #4979
2020-09-03 12:59:28 +05:30
3e35dc95e5
Improve code coverage and API test cases for Tables. Fixes #5774 .
2020-09-03 12:35:56 +05:30
8f3bdf1cf3
Fixed cognitive complexity issues reported by SonarQube.
2020-09-02 14:39:54 +05:30
5a253f9053
Change the following to replace Python 2 code with Python 3:
...
1) Replace the deprecated unit test method.
2) Wraps filter usage in a list call.
3) Converts the old metaclass syntax to new.
4) Use range instead of xrange method.
5) Change Unicode to str.
6) Several other transformations.
7) Fixed change password test cases.
8) Use simplejson instead of plain JSON.
2020-08-31 16:45:31 +05:30
11d5613866
Fixed RESQL test cases for Roles module.
2020-08-28 18:22:25 +05:30
3984544bdb
Fixed code smell 'String literals should not be duplicated'.
2020-08-28 18:17:27 +05:30
e226b2fa75
Adjusted the height of jobstep code block to use maximum space. Fixes #5426 .
2020-08-28 14:00:49 +05:30
28b637c99c
Fixed RE-SQL test cases failed due to the previous commit.
...
Introduces a new key - replace_regex_pattern to synchronize the
expected SQL with the backend SQL based on the regex string
2020-08-27 19:08:00 +05:30
53a5410337
Fixed cognitive complexity issues and added some more RESQL test cases for roles module.
2020-08-27 13:09:22 +05:30
f3bde7b5f1
Ensure that schema names starting with 'pg' should be visible in browser tree when standard_conforming_strings is set to off. Fixes #4216
2020-08-26 18:16:16 +05:30
8fcf527632
Improve code coverage and API test cases for Columns and Constraints (Index, Foreign Key, Check, Exclusion). Fixes #5332
2020-08-26 12:35:22 +05:30
4eb17afe4e
Warn the user when connecting to a server that is older than pgAdmin supports. Fixes #5772
2020-08-25 17:18:43 +01:00
d2577e32e6
Fixed cognitive complexity issues reported by SonarQube.
2020-08-25 18:13:01 +05:30
e2ac6187dc
Fixed Jenkins build failure due to API test case failed.
2020-08-25 14:14:48 +05:30
df9aaf19c2
Fixed string indices must be integers issue for PostgreSQL < 9.3. Fixes #5766
2020-08-25 13:38:24 +05:30
275c671576
Fixed cognitive complexity issues reported by SonarQube.
2020-08-25 12:39:14 +05:30
86bbc3a9e8
Ensure that the user should be able to drop the database even if it is connected. Fixes #5722
2020-08-25 12:37:50 +05:30
b3d49c61a5
Fixed incorrect reverse engineering SQL for Foreign key when creating a table. Fixes #5748
2020-08-25 12:31:58 +05:30
7f947f146c
Fixed cognitive complexity issues reported by SonarQube.
2020-08-25 12:28:55 +05:30
52d0241a17
Fixed an issue where schema diff is not working when providing the options to Foreign Data Wrapper, Foreign Server, and User Mapping. Fixes #5754
2020-08-24 12:11:09 +05:30
b53de0c31d
Updated some more font awesome icons for v5
2020-08-21 14:15:18 +05:30
19491d79a5
Fixed cognitive complexity issues reported by SonarQube.
2020-08-21 13:52:05 +05:30
fbbbc36221
Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-08-20 20:26:51 +05:30
7f3e8596e3
Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-08-20 18:34:49 +05:30
103b08c9c5
Define constants for preferences label to fix SonarQube issues.
2020-08-20 17:58:37 +05:30
cc5a7ea334
Fixed code smell 'String literals should not be duplicated'.
...
Create a constant.py file which contains the common Constants.
2020-08-19 14:16:02 +05:30
4b56962c1b
Fixed cognitive complexity issues reported by SonarQube.
2020-08-19 13:41:53 +05:30
63df19ee1c
Fixed following schema diff issues:
...
1) Avoid template databases from the Database drop-down list.
2) Exclude system schemas while comparing two databases.
3) Escape group name for XSS.
2020-08-13 14:12:37 +05:30
93adf6884f
Upgrade font awesome from v4 to v5. Fixes #5731
2020-08-13 12:04:00 +05:30
36574b25b6
The 'str' object never has attribute decode in Python3, so remove the dead code.
2020-08-12 18:55:35 +05:30
7dd313f5fc
Fixed an issue where debugger doesn't work if the search path is set other than 'public'. Fixes #4123
2020-08-12 14:24:40 +05:30
8129df42da
Fixed cognitive complexity issues reported by SonarQube.
2020-08-11 15:13:35 +05:30
082b968bbc
Fixed following schema diff issues:
...
1) Wrong SQL generated for the columns having different data type.
2) Added 'castfunc' in the ignore list.
2020-08-11 14:42:32 +05:30
2907a79dd7
Added missing comments in reverse engineering SQL for each column of a View. Fixes #3791
2020-08-11 11:30:47 +05:30
46af290b85
Fixed API test cases for packages.
2020-08-10 18:13:00 +05:30
9d006d0ec5
Fixed cognitive complexity issues reported by SonarQube.
2020-08-10 16:30:07 +05:30
7a0bfecfc5
Use Python3 'ipaddress' module to validate the IPv4 and IPv6 addresses.
2020-08-10 15:57:25 +05:30
604937cf66
Fixed an issue where 'ALTER VIEW' statement is missing when the user sets the default value of a column for View. Fixes #5664
2020-08-10 15:27:57 +05:30
4f74609ecf
Modified schema diff tool to compare two databases instead of two schemas. Fixes #5126
2020-08-10 15:13:34 +05:30
9ad7476a34
Corrected DROP SQL syntax for catalog. Fixes #5713
2020-08-07 16:58:38 +05:30
518b13c779
Added the 'ORDER BY' clause for the privileges type to fix schema diff issue. Fixes #5689
2020-08-07 16:30:03 +05:30
d6400bbcae
Replace the generic exception class with a more specific one.
2020-08-07 12:37:00 +05:30
1122e06f48
Fixed cognitive complexity issues reported by SonarQube.
2020-08-06 12:38:35 +05:30
6a406f466d
Fixed cognitive complexity issues reported by SonarQube.
2020-08-05 13:00:44 +05:30
aa679e06b2
Replace the generic exception class with a more specific one to fix SonarQube issues.
2020-08-05 12:41:28 +05:30
5ce2773658
Ensure that the Dictionaries drop-down shows all the dictionaries in the FTS configuration dialog. Fixes #5429
2020-08-04 15:48:20 +05:30
87d08de3a0
Corrected the syntax as per jinja standards. refs #5632
2020-08-03 13:08:29 +05:30
536593bf8a
Fixed following SonarQube issues:
...
- Remove this assignment to the local variable, the value is never used.
- Rename local variables to match the regular expression
- Add logic to this except clause or eliminate it and rethrow the exception automatically.
- Rename fields to match the regular expression
- Extract this nested conditional expression into an independent statement.
- Change this default value to "None" and initialize this parameter inside the function/method.
- Update this function so that its implementation is not identical to __repr__
- Refactor this method to not always return the same value
- Reraise this exception to stop the application as the user expects
- Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
- Remove this redundant continue.
- Remove this unused function declaration
- Remove this identity check; it will always be False.
2020-08-03 12:59:51 +05:30
318d712c4f
Improve code coverage and API test cases for Schemas. Fixes #5327
2020-08-03 12:38:38 +05:30
56cf64ad22
Fixed following SonarQube issues:
...
- Refactor functions to not always return the same value.
- Rename "cls" to "self" or add the missing "self" parameter.
- Remove useless assignment to variables.
2020-07-30 14:04:22 +05:30
dd7eb54e90
Fixed an issue when comparing the table with a trigger throwing error in schema diff. Fixes #5710
2020-07-30 13:57:00 +05:30
89fa85d650
Fixed cognitive complexity issues reported by SonarQube.
2020-07-29 18:29:04 +05:30
74fd5dfe96
Ensure that the user will be able to modify the start value of the Identity column. Fixes #5632
2020-07-29 16:22:11 +05:30
287a6628ed
Improve code coverage and API test cases for Types. Fixes #5336
2020-07-29 15:41:04 +05:30
a0893fe43b
Fixed code smell 'variable shadows a builtin' reported by SonarQube.
2020-07-28 16:20:26 +05:30
fb0bc65ced
Fixed following SonarQube issues:
...
1) Define a constant instead of duplicating this literal.
2) Reduce cognitive complexity (Patch by Aditya)
2020-07-27 16:31:03 +05:30
f93cfe8c4c
Remove old Python 2 compatibility code. Fixes #5700
2020-07-27 11:03:13 +01:00
7a22cff28c
Fixed 'cannot unpack non-iterable Response object' issue.
2020-07-24 14:59:50 +05:30
4cf8c2f300
Improve code coverage and API test cases for Foreign Servers and User Mappings. Fixes #5324
2020-07-24 14:14:13 +05:30
937877e841
Ensure that RLS Policy node should be searchable using search object. Fixes #5646
2020-07-24 13:47:39 +05:30
dd27e08a98
Fixed code smell 'Unused local variables should be removed'.
2020-07-24 12:15:29 +05:30
1fbf298d30
Fixed cognitive complexity issues reported by SonarQube.
2020-07-24 12:03:05 +05:30
505a3ac960
1) Fixed cognitive complexity issues reported by SonarQube.
...
2) Fixed code smell 'Add a nested comment explaining why this method is
empty, or complete the implementation'.
2020-07-24 11:46:30 +05:30
28a4359020
Fixed issue where the user was not able to update policy if the policy is created with space. Fixes #5686
2020-07-21 18:14:49 +05:30
7edcca9b07
Added High Contrast theme support. Fixes #5653
...
Fixed text color issue in explain analyze for the Dark theme. Fixes #5677
2020-07-20 11:51:21 +05:30
4e2c4b0498
Fixed cognitive complexity issues reported by SonarQube.
2020-07-17 15:31:04 +05:30
703faf3b15
Fixed following SoanrQube issues
...
1) Rename field "node_type" to prevent any misunderstanding/clash with field "NODE_TYPE" defined.
2) Define a constant instead of duplicating this literal.
Solution:
1) Rename the field "NODE_TYPE" and "COLLECTION_LABEL" to "_NODE_TYPE" and "_COLLECTION_LABEL"
2) Declare the constant in PGChildNodeView for SQL files.
2020-07-16 19:39:55 +05:30
5d8c79da38
Added docstrings for some newly created functions.
2020-07-15 18:07:54 +05:30
11c4877859
Fixed an issue where difference DDL is showing the wrong SQL when changing the policy owner. Fixes #5647
2020-07-15 14:52:14 +05:30
d6893f9d8a
Fixed reverse engineered SQL for partitions when storage parameters are specified. Fixes #5569 .
2020-07-14 19:16:33 +05:30
4f34bc0f0e
Added missing dependencies/dependent and corrected some wrongly identified. Fixes #5666
2020-07-14 18:34:50 +05:30
a91e4d8a7f
Improve code coverage and API test cases for Foreign Data Wrapper. Fixes #5323 .
2020-07-14 15:58:22 +05:30
0013a3b047
Fixed cognitive complexity issues reported by SonarQube.
2020-07-14 15:33:54 +05:30
d3eaac8609
Reverted fix for #5569 due to a couple of issues.
2020-07-11 20:32:57 +05:30
29175d7ec4
Fixed reverse engineered SQL for partitions when storage parameters are specified. Fixes #5569
2020-07-11 16:23:31 +05:30
e8b81db977
Fixed cognitive complexity issues reported by SonarQube.
2020-07-10 11:44:33 +05:30
7420673a0f
Improve code coverage and API test cases for FTS Configuration, FTS Parser, FTS Dictionaries, and FTS Template. Fixes #5329 .
2020-07-10 11:40:08 +05:30
e1168f8de0
Fixed code smell to reduce cognitive complexity.
2020-07-09 18:41:13 +05:30
916182f80f
Fixed code smell for variable naming convention.
2020-07-09 18:28:08 +05:30
c58fda0a70
Ensure that create RLS Policy menu should not be visible for catalog objects. Fixes #5633
2020-07-09 18:04:32 +05:30
b4c25bdc0a
Fixed code smell 'Functions, methods, and lambdas should not have too many parameters' reported by SonarQube.
2020-07-07 19:39:06 +05:30
36a2c073bd
Added support for permissive/restricted policy type while creating RLS Policy. Fixes #5622
2020-07-07 17:55:05 +05:30
aee6bac5ef
Fixed cognitive complexity code smell reported by SonarQube.
2020-07-07 15:19:47 +05:30
45a03dd663
Fixed 'convention' related code smell reported by SonarQube.
2020-07-06 11:48:23 +05:30
cb1cdd1b23
Modified EPAS templates to support schema restriction.
2020-07-03 18:42:17 +05:30
0d92059155
Fixed code smells having rule 'Functions, methods and lambdas should not have too many parameters'.
2020-07-03 18:37:37 +05:30
80ab596992
Fixed the SoanrQube code smell 'Variables should not be shadowed'.
2020-07-03 14:33:30 +05:30
b5f0190799
Fixed the SonarQube Code smells having Rule 'Functions, methods and lambdas should not have too many parameters'.
2020-07-03 14:24:54 +05:30
341c3aded6
Fixed dark theme-related CSS and modify the color codes. Fixes #5287
...
Fixed backgrid row hover issue where on hover background color is set for edit and delete cell only. Fixes #5470
2020-07-03 11:47:40 +05:30
1ab257d512
Fixed Cognitive Complexity code smell reproted by SonarQube.
2020-07-03 11:15:41 +05:30
1802f8a3f8
Ensure that the referenced table should be displayed on foreign key constraints. Fixes #5530
2020-07-02 16:21:56 +05:30
8b10315e2a
Added hints for 'Using' and 'With check' options of RLS Policy node.
2020-07-02 16:21:56 +05:30
0850db2a9b
Fixed database connection issue, regression of SonarQube fixes.
2020-07-01 17:32:22 +05:30
a881e4e3f8
Fix PEP8
2020-07-01 15:33:51 +05:30
192a446131
Fixed API test cases failing due to updating the server manager instance.
2020-07-01 15:29:59 +05:30
b30c590866
Fixed SonarQube code smell 'Rename function and variable name to match the regular expression'.
2020-07-01 13:50:51 +05:30
6dd3ca31be
Fixed SonarQube code smell 'Variables should not be shadowed'.
2020-07-01 13:43:00 +05:30
979f806161
1) Added RLS Policy support in Schema Diff. Fixes #5601
...
2) Fixed 'cant execute empty query' issue when remove the value of
'USING' or 'WITH CHECK' option of RLS Policy. Fixes #5631
2020-07-01 12:44:28 +05:30
21d57b1f10
Do not let browser autocomplete the password field while connecting a
...
database server.
Set the autocomplete attribute of the password field to 'new-password'
to let browser know, we require a new password for the password, and do
not autocomplete it.
2020-07-01 11:26:52 +05:30
c873218c32
Added support for schema level restriction. Fixes #5583
...
Allow user to edit the connection properties when the database server
is already connected.
2020-06-30 19:15:23 +05:30
6713bc068b
Fixed SonarQube code smells 'Refactor this function to reduce its Cognitive Complexity'.
2020-06-30 17:06:55 +05:30
46d26cd029
Remove extra brackets from reverse engineering SQL of RLS Policy. Fixes #5621
2020-06-30 16:11:02 +05:30
88db5ec4d5
Remove extra brackets from reverse engineering SQL of trigger.
2020-06-30 16:07:55 +05:30
7add777b21
Add proper indentation to the code while generating functions, procedures, and trigger functions. Fixes #3851
2020-06-29 12:36:28 +05:30
b91f6f0f5c
Fixed an issue where the semicolon is misplaced in RLS Policy SQL.
...
Fixed one regression issue introduced by renaming the method 'gc' to 'gc_timeout'.
2020-06-26 19:24:54 +05:30
115657a465
Fixed following SonarQube issues:
...
1) Refactor function to reduce its Cognitive Complexity.
2) Rename variable to match the regular expression ^[_a-z][a-z0-9_]*$.
2020-06-26 15:03:50 +05:30
8e28e0a32b
Improve code coverage and API test cases for Domain and Domain Constraints. Fixes #5326
2020-06-26 14:15:09 +05:30
c7a16a4bd5
Fixed code smells having rule 'Nested blocks of code should not be left empty'.
2020-06-26 13:18:27 +05:30
707ff450b5
Fixed following SonarQube issues:
...
1. Boolean checks should not be inverted.
2. The comma operator should not be used.
3. Arguments to built-in functions should match documented types.
4. Redundant pairs of parentheses should be removed.
5. A conditionally executed single line should be denoted by indentation,
6. A while loop should be used instead of a 'for' loop.
2020-06-26 13:12:07 +05:30
6a63279396
Ensure that the OWNER should be quoted for foreign tables, procedures, and trigger functions.
2020-06-26 12:28:36 +05:30
d3b3d07f2e
Fixed SonarQube issues with the tag unused. All the unused variables, assignments, code comments are fixed.
2020-06-25 11:09:43 +05:30
a1fd9ea3ce
Fixed issue related to extra semicolons and function naming convention reported by SonarQube.
2020-06-24 16:16:12 +05:30
db9d684524
Fixed 'Rename local variable to match the regular expression' issue reported by SonarQube.
2020-06-24 16:08:14 +05:30
d265ed9729
Fixed an issue while creating RLS Policy with the name having space. Fixes #5620
2020-06-23 14:28:21 +05:30
c064eb0795
Fix an issue where RLS Policy dialog help is not working.
2020-06-23 14:13:08 +05:30
6012f49919
Added policy event 'ALL' in events drop-down list.
2020-06-22 17:09:10 +05:30
daad16ea93
Fixed issue related to reducing the if-else statement to single return expression. Reported by SonarQube.
2020-06-22 12:58:48 +05:30
6620f9263d
Fixed issues reported by SonarQube with tag 'bad-practice'.
2020-06-22 12:18:59 +05:30
6d3f13076f
Fixed 'Comma operator should not be used' issue reported by SonarQube.
2020-06-18 16:17:55 +05:30
905be1d894
Replace if-then-else statement by a single return statement, issue reported by SonarQube.
2020-06-18 15:51:01 +05:30
f0490a54b7
Fixed redundant tagged issue reported by SonarQube.
2020-06-18 11:14:56 +05:30
5ed1e1e5b6
Fixed some sonarqube issues.
2020-06-17 19:30:56 +05:30
df05efd7d9
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation.
2020-06-17 17:15:09 +05:30
7c12ade161
Fixed issue related to shadowing variables reported by SonarQube.
2020-06-17 17:08:23 +05:30
cb268075c2
1) Added option to ignore the whitespaces while comparing objects in schema diff. Fixes #5468
...
2) Added server group name while selecting servers in schema diff. Fixes #5500
3) Fixed an issue where two identical tables showing different by schema diff tool. Fixes #5584
2020-06-17 16:27:51 +05:30
d43518cb3c
Fixed following issues reported by SonarQube:
...
1) Replace this if-then-else statement by a single return statement. (clumsy)
2) 'switch' statements should have at least 3 'case' clauses. (bad practice)
2020-06-16 15:00:51 +05:30
3e00fe2b0f
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation. Reported by SonarQube
2020-06-16 11:14:57 +05:30
697f4aec95
Fixed issue related to shadowing variables reported by SonarQube.
2020-06-16 10:47:40 +05:30
a21e6448ce
Fixed RESQL test cases, regression of RLS policy.
2020-06-15 17:10:25 +05:30
eb1b17b636
Fix 'expressions evaluated to true/false always' issue reported by SonarQube.
2020-06-15 16:50:07 +05:30
38cd3327f3
Ensure that pgadmin should be able to connect to the server which has password more than 1000 characters. Fixes #5592
2020-06-15 16:50:07 +05:30
8ab358ccec
Fix following issues reported by SonarQube:
...
1) Properties of variables with "null" or "undefined" values should not be accessed
2) Variables should not be self-assigned
3) "in" should not be used with primitive types
2020-06-15 16:50:07 +05:30
641f7bbe9d
Some clumsy coding related fixes reported by SonarQube.
2020-06-15 16:50:07 +05:30
18277543b6
Added support of Row Security Policies. Fixes #5516
2020-06-15 15:44:59 +05:30
8c20f0c0d2
Some clumsy coding related fixes reported by SonarQube.
2020-06-12 15:24:17 +05:30
ee1ea47e88
Fixed issue 'expects 4 arguments, but 5 were provided' reported by SonarQube.
2020-06-12 15:15:07 +05:30
82c4a4a03e
Improve code coverage and API test cases for Collations. Fixes #5325
2020-06-11 11:12:41 +05:30
5c60dcd501
Remove blank line at EOF.
2020-06-10 17:02:39 +01:00
85e89c869a
Cleanup some code smells identified by SonarQube.
2020-06-10 16:42:59 +01:00
726ecd79e6
Fixed import statements.
...
refs #3669
2020-06-03 12:49:05 +05:30
d22e276586
Ensure that proper error should be displayed for the deleted node. Fixes #3669
2020-06-03 11:26:26 +05:30
9b8902dfb8
Fixed the SQL help issue for EDB Postgres Advanced Server. Fixes #4099
2020-05-22 14:11:58 +05:30
7b1cac6914
Fixed an issue where clicking on Select All button, not selecting all the options in pgAgent job scheduler. Fixes #5496
2020-05-19 13:54:21 +05:30
9f445dc052
Improve code coverage and API test cases for Indexes. Fixes #5333
2020-05-18 12:29:33 +05:30
6d6cd19b37
Improve code coverage and API test cases for Triggers and Compound Triggers. Fixes #5335
2020-05-15 12:50:50 +05:30
073d90c4a6
Fixed internal server error when clicking on Triggers -> 'Enable All' for partitions. Fixes #5052
2020-05-11 15:18:39 +05:30
1294c089a8
Implement Selenium Grid to run multiple tests across different browsers, operating systems, and machines in parallel. Fixes #5255
2020-05-11 12:11:31 +05:30
b64896f558
Fixed generated SQL issue for auto vacuum options. Fixes #5398
...
Fixed some more issues:
1) pgAdmin allows only true or false values for autovacuum_enabled,
and there is no way to reset it individually without disabling a custom auto vacuum.
To fix this, the control is changed from the switch to three state buttons.
2) Setting any vacuum options to zero made the option disappear from the SQL.
3) Right-click on a table with vacuum options set and create a new table.
4) The parameters tab will have the options prefilled.
5) Changed the UI a bit to remove unnecessary space around. Added "Autovacuum" before enabled.
The SQL generated was appending a ".0" to decimal vacuum options. Changed to remove the leading ".0".
2020-05-08 14:30:30 +05:30
e73e2d2502
Fixed the errors, and warnings reported by pylama.
...
TODO::
- Don't use unicode in Python 3 for removing the support of Python 2 (
psycopg2 driver - __init__.py, server_manager.py).
- Merge the lastest pgcli (version: 3.0.0) for SQL autocompletion.
2020-05-08 14:13:38 +05:30
057a2b2312
Improve code coverage and API test cases for the Rules module. Fixes #5334
2020-05-07 16:27:58 +05:30
6ad46e1860
Fixed invalid literal issue when removing the connection limit for the existing role. Fixes #5001
2020-05-07 13:14:45 +05:30
a0940fd145
Typecast the object to 'text' before using it in length() function, so that correct length function gets called.
2020-05-06 17:34:18 +05:30
5fe7813f9f
Fixed an issue where select2 hover is inconsistent for the SSL field in create server dialog. Fixes #5469
2020-05-04 13:19:13 +05:30
d61b8eb1b3
Gracefully informed the user that the database is already connected when they click on 'Connect Database...'. Fixes #3694
2020-05-04 13:08:56 +05:30
0fc2afb829
Add Reverse Engineered and Modified SQL tests for Column and Type.
2020-05-04 12:48:24 +05:30
5656f756e6
Ensure that the dependencies tab shows correct information for Synonyms. Fixes #5422
2020-05-04 12:23:18 +05:30
ad80217593
Remove Python2 references from the source code.
...
refs #5443
Initial patch: Neel Patel
2020-04-30 17:22:48 +05:30
86afec860f
Remove Python 2 support from the Python tests.
...
refs #5443
2020-04-30 12:56:45 +05:30
88aebb64f9
Fixed failed to fetch utility error when click on refresh(any option) materialized view. Fixes #5447
...
It's a regression of #5213
2020-04-28 11:00:23 +05:30
18748846ef
Fixed the regression where initial changes make the Save button enabled when the table dialog is opened. Fixes #4504
2020-04-27 18:48:44 +05:30
76eb3e9b67
Fixed an issue when the user performs refresh on a large size materialized view. Fixes #5213
2020-04-27 17:30:23 +05:30
ef58d277ca
Fixed an issue where like options should be disabled if the relation is not selected while creating a table. Fixes #4504
2020-04-24 18:22:11 +05:30
aec64aa582
Fixed following issues for 1257:
...
1. For synonyms, the property is shown as "Public Synonym".
2. For system procedure, the flag should be True but it is displaying as False.
3. For both views and materialized views, the property is "System View".
4. For FTS templates, the property is showing as "System FTS Parser".
Fixes #1257
2020-04-24 16:35:59 +05:30
dfb74904ed
Ensure all object types have a System XXX? property. Fixes #1257
2020-04-23 17:31:40 +05:30
2b5c90e379
A warning message will be displayed only when the package header is changed for EPAS packages. Fixes #5410
2020-04-23 17:14:01 +05:30
6e5dbf7beb
Added multiple drop/delete functionality for the table constraints. Fixes #3900
2020-04-22 18:47:13 +05:30
858294f36e
Fixed validation errors in view/materialized view javascript to
...
determine the number columns chagned. It was trying to execute
'replace' and 'includes' function on undefined values instead of
string value.
Also - changed the warning message, and separated the 'Do you want to
continue?' syntax in separate line for better user experience.
Fixes #5053
2020-04-22 17:19:18 +05:30
4c616f32eb
1) Fixed feature test and API test cases.
...
2) Added logic to exclude RESQL test cases.
2020-04-22 13:57:32 +05:30
07f72252d7
Added job step and job schedule disable icons to identify it quickly within the browser tree. Fixes #4636
...
Add Reverse Engineered and Modified SQL tests for pgAgent jobs. Fixes #4623
Fixed modified SQL issue while adding an exception in pgAgent job schedule. Fixes #5356
2020-04-21 17:00:21 +05:30
f289dfb762
Fixed following issues for packages:
...
1) Removing the package header removes the body as well.
2) Schema is not visible on the properties dialog.
3) Reverse engineering SQL and Create script not showing schema-qualified packages.
Fixes #5410
2020-04-21 16:49:23 +05:30
4692b21bcf
Fixed an issue where schema diff marks an identical table as different. Fixes #5350
...
Fixed an issue where schema diff showing changes in the identical domain constraints. Fixes #5315
Ignore the keys from the source and target list and also sort both the lists.
2020-04-20 18:04:16 +05:30
36a3d4e53b
Some more gettext() usage fixes:
...
- fixed `%` vs. `.format()`
- unified texts and usage `%s` vs. `{}`/`{0}`
- improved text sentences for translate
- added gettext for next texts
2020-04-20 11:19:09 +05:30
d8ad0b8faf
Fixed validation issue in Synonyms node. Fixes #5409
2020-04-17 14:50:38 +05:30
c6deb9393c
Fixed an issue while removing the package body showing wrong modified SQL. Fixes #5410
2020-04-17 13:06:07 +05:30
dc1e32a632
Fixed internal server error when the database server is logged in with non-super user. Fixes #5400
2020-04-16 15:05:17 +05:30
Akshay Joshi
Dave Page
Nikhil Mohite
Khushboo Vashi
Aditya Toshniwal
Rahul Shirsat
Yogesh Mahajan
Pradip Parkale
Libor M
Ganesh Jaybhay
Cyril Jouve
Neel Patel
Satish V
Murtuza Zabuawala
Ashesh Vashi
Zhang Jie
Diego Augusto Molina
Mishika Singh
Yogesh Jain