Commit Graph

891 Commits (master)

Author SHA1 Message Date
Akshay Joshi edec9adbfb
Fixed SonarQube code smell 'Unnecessary use of boolean literals in conditional expression'. 2024-04-08 17:19:51 +05:30
JyotiEdb 5931162556
Fixed an issue where maximize icon is missing from query tool panel. #7218 2024-03-28 11:53:56 +05:30
Pravesh Sharma 082fb165d3 Implemented shortcut mapping for the edit menu in the query tool. 2024-03-27 16:41:08 +05:30
Anil Sahoo a02ebe192b
Fixed rollback and commit button activation on execute button click. #7248 2024-03-27 16:38:42 +05:30
Aditya Toshniwal c0a1429664 Fix failing feature tests 2024-03-26 11:20:04 +05:30
Aditya Toshniwal cc1ce09b73 More CodeMirror fixes. #7268
Fix query tool autocomplete results when cursor is in between the SQL query. #7299
Fix an issue in query tool where custom keyboard shortcuts are not working for some. #7305
2024-03-23 18:22:06 +05:30
Aditya Toshniwal f351b10ed0 Fix an issue in query tool where toggle case of selected text loses selection. #7277
Also make changes to give pgAdmin shortcuts higher priority over CodeMirror default shortcuts.
2024-03-14 18:18:53 +05:30
Aditya Toshniwal 794c7cb335 Fixed multiple editor related issues:
1. Replace option in query tool edit menu is not working on non-Mac OS. #7262
2. Format SQL shortcut and multiline selection are not working. #7268
3. "Use Spaces?" Preference of Editor is not working. #7269
2024-03-11 16:52:56 +05:30
Aditya Toshniwal a5530f59f7 Fix sonarqube issues for the rule - 'If' statement should not be the only statement in 'else' block 2024-02-26 11:55:36 +05:30
Aditya Toshniwal 29e85a6b06 Fix SonarQube issues 2024-02-22 16:54:20 +05:30
Aditya Toshniwal b5bd236387 Fix edit menu related issues of query tool codemirror 2024-02-21 15:54:57 +05:30
Aditya Toshniwal d3ede3151a
Upgrade CodeMirror from version 5 to 6. #7097 2024-02-21 11:15:25 +05:30
Anil Sahoo 47b2bc8a83
1) Fix the tabbed panel backward/forward shortcut for tabs. #6808
2) Remove shortcuts for the dialog tab backward/forward.
3) Used hotkeys.js in place of mousetrap for listening to keyboard shortcuts.
2024-02-09 16:33:30 +05:30
Pravesh Sharma f7045b58d4
Fixed an issue where format sql was messing up operator. #5083
- The formatting is done on client side now using sql-formattor JS lib. Backend API based formatting is removed.
- Added new options data type case, expression width, function case, lines between queries, logical operator new line and new line before semicolon available in the new lib.
- Removed old options comma-first notations, re-indent aligned, re-indent, strip comments and wrap after N characters as not available in the new library.
- Capitalise casing is replaced with Preserve casing as it is not supported by the new library.
- Also fixes #6785, #6990, #7115.
2024-02-02 12:28:25 +05:30
Anil Sahoo 8145e042a6
Fix a backend server error when creating a named restore point. #7166 2024-02-01 14:20:22 +05:30
Aditya Toshniwal cdf49d6300 Fix failing feature tests 2024-01-30 13:01:57 +05:30
Aditya Toshniwal 028b70203c Fix SonarQube bugs 2024-01-29 18:39:30 +05:30
Akshay Joshi 639a28fbfc Fixed code smell 'Prefer using an optional chain expression instead, as it's more concise and easier to read'. 2024-01-25 16:51:40 +05:30
Akshay Joshi 0e0cbc40b8 Fixed SonarQube code smell Replace the unused local variable with '_'. 2024-01-24 18:33:43 +05:30
Aditya Toshniwal 5248055a01 Fixed an issue where auto commit/rollback setting not persisting across query tool connection change. #7091 2024-01-01 15:34:40 +05:30
Akshay Joshi 740ce15bd7 Update copyright notices for 2024 2024-01-01 14:13:48 +05:30
Nikhil Mohite ec12dc5288
Fixed the following issues found in testing #5908:
1. Filter buttons remain highlighted after promotion but the button is disabled.
2. Data changes are getting committed even when Auto commit is turned off on the promoted query tool window.
2023-12-27 13:36:20 +05:30
Aditya Toshniwal c8d6ff8a6d Fixed an issue where query tool title did not change after 'Save As' until any new change is made. #6193 2023-12-21 17:41:27 +05:30
Nikhil Mohite 04580652ab
Allow users to convert View/Edit table into a Query tool to enable editing the SQL generated. #5908 2023-12-19 15:52:57 +05:30
Pravesh Sharma a01b0973fc
Fixed an issue where syntax error was not highlighting for explain query. #6887 2023-12-11 10:57:17 +05:30
Aditya Toshniwal 51b02ae6d4
Fix few accessibility related issues. #6991 2023-12-06 11:18:23 +05:30
Anil Sahoo 4b71519b80
Rename all references of 'Execute query' to 'Execute script' to be more relevant. #6842 2023-12-04 12:28:53 +05:30
Anil Sahoo f2876cabe8
1. Fixed an issue where database name was missing in an error message if name contains any special characters. #6488
2. Add a confirmation dialog before closing a query tool when a query is already running.
2023-11-30 18:23:52 +05:30
Pravesh Sharma b51df0e5fd
Fixed an issue where syntax error was not highlighting in query tool. #6887 2023-11-23 15:55:23 +05:30
Aditya Toshniwal 0bc044fa67 Fixed an issue where Geometry Viewer renders geometry incorrectly after trying to view 3D or non-4326 SRID geometry. #6017 2023-11-17 16:29:01 +05:30
Aditya Toshniwal 85dd1e92ad Fix issues found when testing Flask upgrade and wcDocker changes. #6479 2023-11-08 18:07:32 +05:30
Aditya Toshniwal ef0b30b1ca Continue fixing multiple UI issues found when testing wcDocker changes. #6479 2023-11-06 18:08:16 +05:30
Akshay Joshi 9eb7c1cbea 1) Ensure that eventlet's subprocess is used for Python versions up to 3.11 and await the issue resolution for Python versions 3.12.
2) Fixed unescape sequence for Python 3.12
2023-11-02 16:03:50 +05:30
Aditya Toshniwal 17acce3e7b Continue fixing multiple UI issues found when testing wcDocker changes. #6479 2023-11-01 20:52:38 +05:30
Anil Sahoo 0b707be615
Fixed restoration of query tool database connection after dropping and re-creating the database with the same name. #6487 2023-11-01 15:27:18 +05:30
Aditya Toshniwal e30d2eca90 Continue fixing multiple UI and SonarQube issues found when testing wcDocker changes. #6479 2023-10-30 16:57:01 +05:30
Aditya Toshniwal b11b2a2f50 Continue fixing multiple UI and SonarQube issues found when testing wcDocker changes. #6479 2023-10-27 15:51:45 +05:30
Aditya Toshniwal 3bcac26ff9 Fix multiple UI and SonarQube issues found when testing wcDocker changes. #6479 2023-10-26 12:06:28 +05:30
Aditya Toshniwal 862f101772
Significant changes to use ReactJS extensively.
1. Replace the current layout library wcDocker with ReactJS based rc-dock. #6479
2. Have close buttons on individual panel tabs instead of common. #2821
3. Changes in the context menu on panel tabs - Add close, close all and close others menu items. #5394
4. Allow closing all the tabs, including SQL and Properties. #4733
5. Changes in docking behaviour of different tabs based on user requests and remove lock layout menu.
6. Fix an issue where the scroll position of panels was not remembered on Firefox. #2986
7. Reset layout now will not require page refresh and is done spontaneously.
8. Use the zustand store for storing preferences instead of plain JS objects. This will help reflecting preferences immediately.
9. The above fix incorrect format (no indent) of SQL stored functions/procedures. #6720
10. New version check is moved to an async request now instead of app start to improve startup performance.
11. Remove jQuery and Bootstrap completely.
12. Replace jasmine and karma test runner with jest. Migrate all the JS test cases to jest. This will save time in writing and debugging JS tests.
13. Other important code improvements and cleanup.
2023-10-23 17:43:17 +05:30
Aditya Toshniwal 6e3ee1c607 Fix an issue where servers are not listed in add new connection dialog. 2023-10-18 11:43:42 +05:30
Pravesh Sharma 5bb6e9133f
Fixed query history slowness issue by storing query only for those having certain threshold max length. #6666 2023-10-17 15:17:53 +05:30
Anil Sahoo 5113fda7a6
Fix an issue where global/native keyboard shortcuts are not working when any cell of data output grid has focus. #6579 (#6834) 2023-10-06 13:28:16 +05:30
Nikhil Mohite aa973fc8ae
Added support to select/deselect objects in the Backup dialog. #642 2023-09-13 11:07:28 +05:30
Yogesh Mahajan 0b24a8f39a
Ensure keyboard shortcut for query execution is disabled when query execution is in progress. #6664 2023-08-09 10:49:45 +05:30
Khushboo Vashi c72e2f159d
Fix the query tool issue 'pgAdminThread' object has no attribute 'native_id'. #6660 2023-08-08 11:00:52 +05:30
Khushboo Vashi b55164c454
Fix the query tool issue where raise Notice from func/proc or code blocks are no longer displayed live. #6420 2023-08-07 17:19:08 +05:30
Akshay Joshi 1a7a23de3f Added WAL option to EXPLAIN ANALYZE command. #6382 2023-08-03 15:57:12 +05:30
Khushboo Vashi a7f06eea0b Fix an issue where inserting more than 10 rows does not work correctly in View Data; only parts end up in the table. #6582 2023-07-24 12:49:42 +05:30
Aditya Toshniwal 4676961fc4 Fix multiple Query Tool, ERD title related issues. 2023-07-13 20:06:24 +05:30
Akshay Joshi 75d14565e4 Fixed escape/unescape issues in Query Tool and PSQL. 2023-07-13 17:02:51 +05:30
Akshay Joshi bd4e14da89 Added new/missing parameters to pg_restore. #6562 2023-07-13 13:01:48 +05:30
San Lin Naing 8dd8d1d03a
Fixed an issue where ERD Tool can't load the saved pgerd file from Shared Storage. #6558 2023-07-13 11:06:46 +05:30
Akshay Joshi 9aa116bf3f
1) Added new/missing parameters to pg_dumpall (Backup Server). #6416
2) Added new/missing parameters to pg_dump (Backup Objects). #6417
2023-07-10 10:34:30 +05:30
Khushboo Vashi 326dc2bbcc
Fix an issue where queries longer than 1 minute get stuck - Container 7.1. #6317 (#6491)
Fix an issue where queries longer than 1 minute get stuck - Container 7.1. #6317
Fix an issue where queries get stuck with auto-completion enabled. #6356
Fix an issue where queries can't complete execution. #6163
2023-07-04 10:44:46 +05:30
Aditya Toshniwal d6cddd8c29
Remove Bootstrap and jQuery from authentication pages and rewrite them in ReactJS. #6295 2023-06-30 16:08:33 +05:30
Nikhil Mohite 732bcc2b4d
Fixed an issue where the query tool is unable to execute a query on Postgres 10 and below versions. #6515 2023-06-30 12:40:48 +05:30
Aditya Toshniwal 8dc79e73bd Fix an XSS issue in PSQL tool title 2023-06-26 13:36:25 +05:30
Nikhil Mohite 4746fbd346
Fixed an issue where View/Edit data is throwing an error if the user deleted and re-create the same table for which View/Edit data was opened. #6431 2023-06-19 19:37:10 +05:30
Khushboo Vashi c5cbb33a06
Fix raise notice from func/proc or code blocks are no longer displayed live. #6420 2023-06-19 17:04:22 +05:30
Aditya Toshniwal a9ae7ca099 Ensure that query tool status poller is paused if the query tool is not visible/active 2023-06-19 16:28:48 +05:30
Pravesh Sharma 64446790d2
Add a precautionary fix to handle connection timeout issue when fetching more rows in query tool grid. #6291 2023-06-14 16:53:47 +05:30
Akshay Joshi 251bf05692 Fixed the following SonarQube code smells:
1) Do not use Array index in keys.
2) Unnecessary escape character.
3) Rename this local variable to match the regular expression ^[_a-z][a-z0-9_]*$
4) Remove the unused local variable.
2023-06-12 18:44:31 +05:30
Pravesh Sharma f4ea95da12
Fixed few query tool query tool shortcuts. #6065 2023-06-09 18:20:43 +05:30
Khushboo Vashi c0c9034326
Fix an issue where varchar column sizes are not visible in query tool data grid. #6281 2023-05-17 12:10:43 +05:30
Akshay Joshi cba42ef277 Allow user to set the minimum value to 1 from preferences for ON_DEMAND_ROW_COUNT 2023-05-03 12:37:37 +05:30
Aditya Toshniwal a73f58160f Fix an issue where running any query in query tool gives 'list index out of range' error. #5922 2023-05-03 11:05:00 +05:30
Aditya Toshniwal 46a9d4a69d
Fix an issue where query tool hangs for some time when multiple columns are selected to open geometry viewer. #5044 2023-04-27 11:58:50 +05:30
Pravesh Sharma 861c66d180
Ensure that when pasting a row in query tool grid, default value is used for autogenerated/serial columns. #5922 2023-04-26 15:41:10 +05:30
Nikhil Mohite a6faa77e5b
Throw an appropriate error when a table for which View/Edit data is open is deleted and query is executed. #6138 2023-04-18 15:26:40 +05:30
Khushboo Vashi 47a0009d32 Ensure to quote the primary key value if needed while deleting rows from the table. #6130 2023-04-17 12:38:16 +05:30
Yogesh Mahajan 64d5457e2b
Try to fix feature test failures happening due to error occurring while deleting test databases.
* Try to fix feature test failures happening due to error occurring while deleting test databases.

* Updated ON_DEMAND_ROW_COUNT to ON_DEMAND_RECORD_COUNT missed in #3275.
2023-04-13 17:25:12 +05:30
Yogesh Mahajan 993e1eb1b6
Allow on demand record count setting to be changed per user using preferences. #3275 2023-04-13 16:43:11 +05:30
Pravesh Sharma 6c7116a20c
Fix an issue where insert was failing when copy pasting a row and saving in result grid. #5934 2023-04-03 10:57:45 +05:30
Nikhil Mohite 50391ae3fd
Fixed an issue loading file fails in Desktop mode 2023-03-31 10:47:48 +05:30
Akshay Joshi 140494454a Fixed linter errors after eslint upgrade. 2023-03-29 17:22:50 +05:30
Aditya Toshniwal 9924fae378
Nomenclature changes:
1. Rename "Properties..." context menu option of object to "Edit Object...".
2. Rename "Browser" tree to "Object Explorer". #4734
2023-03-28 22:20:14 +05:30
Pravesh Sharma eef7461ae6
Ensure that default values are set only for insert statement if user does not provide any values, in case of updating existing values to blank it should be set to null. #5934
Incorporated review comments
2023-03-27 10:22:28 +05:30
Nikhil Mohite e4eeba2aa7
Fixed the UI related issues reported during testing for Shared Storage in Server Mode. #5014 2023-03-24 11:08:27 +05:30
Aditya Toshniwal 319701dbbd
Ensure that when pasting rows the rows are added right below the selected rows for copying. #5921 2023-03-23 18:49:15 +05:30
Aditya Toshniwal b923f5fcfa
Use fetch instead of axios to close connections in SQLEditor, ERD, Schema Diff and Debugger to ensure it completes. When closing a browser tab, axios does not guarantee AJAX request completion. #5894 2023-03-20 18:20:48 +05:30
Khushboo Vashi 64aa739224
Fix SQLEditor Notifier and InetLoader issue. 2023-03-20 18:20:25 +05:30
Khushboo Vashi 366dd3a973
Remove psycopg2 completely. 2023-03-20 16:57:30 +05:30
Aditya Toshniwal 3ce1589681
Fix an issue where query tool is stuck when running query after discarding changed data. #5955 2023-03-16 17:23:57 +05:30
Aditya Toshniwal 292d76b39e
Update SQLAlchemy, Flask, Flask-SQLAlchemy, and other packages to current versions. #5901
- Update Flask, Flask-SQLAlchemy, Flask-Babel, Flask-Security-Too, Flask-SocketIO, pytz, psutil, SQLAlchemy, bcrypt, cryptography, eventlet, Authlib, requests python packages
- Remove pinned dnspython, Werkzeug packages from requirements.txt
2023-03-15 11:57:16 +05:30
Akshay Joshi 3c56c0e4b7 Revert "Update SQLAlchemy, Flask, Flask-SQLAlchemy, and other packages to current versions. #5901"
This reverts commit 31818bb67a.
2023-03-09 16:53:43 +05:30
Aditya Toshniwal 31818bb67a
Update SQLAlchemy, Flask, Flask-SQLAlchemy, and other packages to current versions. #5901
Remove the python version check from the requirements.txt.
2023-03-08 18:26:51 +05:30
Akshay Joshi 6bd0ea7a02 Fixed an issue where the file name in the query tool tab was not changing if another file is opened. #5909 2023-03-08 17:37:45 +05:30
Nikhil Mohite 9da8a188fa
Added support for mounting shared storage in server mode. #5014 2023-03-06 17:03:47 +05:30
Khushboo Vashi b640df5bdd
Fix Query Tool error messages for psycopg3 driver. 2023-02-22 14:07:05 +05:30
Aditya Toshniwal 08062e67ca
Do not allow to save invalid JSON in query tool JSON editor. #5822 2023-02-20 15:37:59 +05:30
Khushboo Vashi 5e0daccf76 Added support for psycopg3 along with psycopg2. #5011 2023-02-15 11:31:29 +05:30
Matěj Cepl 7a4951f211
Remove dependency on simplejson package. 2023-02-15 11:10:12 +05:30
Pravesh Sharma 8388f1e7ba
Fix for query tool prompting for unsaved changes even if no changes have been made. #5756 2023-02-14 11:04:30 +05:30
Aditya Toshniwal 713ddb5f62
Remove usage of jQuery in pgAdmin.
Remove usage of Bootstrap in React components. #5701
2023-02-10 10:28:39 +05:30
Aditya Toshniwal 932dcd9666
Fix an issue where role is used as username for newly added servers when opening query tool. #5702 2023-02-01 13:11:00 +05:30
Aditya Toshniwal 706019d639
Fixed an issue where Geometry viewer does not show popup when columns are less than 3. #5641 2023-01-03 10:28:03 +05:30
Akshay Joshi 98184e5835 Update copyright notices for 2023 2023-01-02 11:53:55 +05:30
Akshay Joshi 953fb31e14 Fixed an issue with auto-complete not working as expected with double quotes. #5551 2022-12-09 14:13:40 +05:30
Nikhil Mohite cc0d467927
Fixed blank screen issue while opening query tools in new tab from native menu. #5503 2022-12-08 19:17:12 +05:30
Nikhil Mohite 2480d08e0f
Added native menu support in desktop mode. #5503 2022-12-06 18:16:36 +05:30
Aditya Toshniwal be011a4f3d
Fixed an issue where Transaction IDs were not found in session in the Query Tool. #5453 2022-12-05 10:48:42 +05:30
Yogesh Mahajan 9e078c0fa8
Fixed issue of opening query tool from new query tool icon beside connection status. #5575 2022-11-30 13:59:45 +05:30
Yogesh Mahajan 7710d5e21c
Ensure the query tool is launched successfully for the servers registered with the PostgreSQL service. #5575 2022-11-28 17:23:43 +05:30
Pravesh Sharma a954f22fe8
Fixed an issue where the CSV file would not download if the CSV quote character length exceeded 1. #5505 2022-11-28 13:49:22 +05:30
Pravesh Sharma a305c03238
Fixed an issue where editor position was wrong when editing data from result grid. #5548 2022-11-25 11:43:56 +05:30
Akshay Joshi 9d3654bd69
Ensure that the query history date format in Desktop mode matches the format of the locale of the pgadmin server. #5495
Format the time based on pgadmin servers locale.
2022-11-24 10:48:05 +05:30
Mark Mayo 41508f7f67
python 3 updates
- Fix super() calls for python 3
- No need to inherit objects.
- No need for u at the start of strings
- Tidied up some brackets and f-strings too
2022-11-19 10:13:41 +05:30
Aditya Toshniwal 6d881fa34e
Use the shared server username when opening query tool. #5533 2022-11-16 13:40:38 +05:30
Akshay Joshi 2a7b5a572f Fixed linter error. 2022-11-15 14:13:05 +05:30
Akshay Joshi aa4f992e30 Ensure that autocomplete works properly with objects starting with double quotes. #5281 2022-11-15 13:59:12 +05:30
Akshay Joshi c5e9aa6357 Ensure that the load file paths are children of the storage directory. #5522 2022-11-14 19:28:48 +05:30
Pravesh Sharma e701da7390
Fixed an issue where the editor was not visible in the result grid when editing a cell with a large string. #5463 2022-11-14 18:51:22 +05:30
Pravesh Sharma c8666f0029
Fixed an issue where the result grid was not working properly while trying to edit data by hitting Enter key. #5463 2022-11-10 16:49:41 +05:30
Nikhil Mohite 1979ea53c7
Fixed an issue where the 'Confirm on close or refresh' setting was ignored when closing the query/ERD tool opened in the new tab. #5475 2022-11-02 14:03:52 +05:30
Nikhil Mohite abfc30db8b
Ensure that users can use custom characters as CSV field separators/CSV quotes when downloading query results. #5066 2022-10-20 16:28:42 +05:30
Nikhil Mohite b4fcb61d64
Ensure that the save button should be disabled by default on the Sort/Filter dialog in the query tool. #5058 2022-10-20 16:22:40 +05:30
Nikhil Mohite 1904a64e42
Fixed XSS vulnerability issues. #5277 2022-10-13 10:59:05 +05:30
Pravesh Sharma 8a76122949
Fixed an issue where filtered rows was not working. #5427 2022-10-13 10:25:27 +05:30
Nikhil Mohite 19f96799df
Ensure that the scroll position should be preserved for the result set in the query tool on tab change. #5296 2022-10-11 10:53:46 +05:30
Nikhil Mohite 7e51a2f517
Ensure that the result grid column should take width as pre preferences setting on first execution. #5132 2022-10-06 15:59:27 +05:30
Akshay Joshi d13ee8db29 1) Remove folders that are no longer used for older database versions.
2) Fixed RESQL tests for View/MView.
2022-09-29 16:45:51 +05:30
Pravesh Sharma add5404f5e
Fixed an issue where the prompt is not visible when clicking on the 'save results to file' button on the large data. #5338
corrected issue id

corrected order of release notes
2022-09-27 14:27:22 +05:30
Akshay Joshi 0b6b2e733a 1) Remove Python's 'Six' package completely. #5357
2) Replace deprecated @abstractproperty with @property, @abstractmethod.
2022-09-26 12:47:31 +05:30
Aditya Toshniwal f64b572150
Fix failing API test cases. #5210 2022-09-23 16:22:16 +05:30
Aditya Toshniwal 9a6516a8b3
Ensure that the query tool creates a new tab with the appropriate user when pressing Alt+Shift+Q. #5210 (#5350) 2022-09-23 11:19:48 +05:30
Nikhil Mohite 3765131d21 Ensure that the default value for a column should be used if it is made empty. #5308 2022-09-22 14:59:42 +05:30
Aditya Toshniwal 2de965d710 1. Use EDB's repo for react-data-grid instead of the personal repo.
2. Improved searching in the Search Objects.
3. Fixed react warnings in the query tool.
4. Fixed some SonarQube issues.
2022-09-13 19:13:33 +05:30
Akshay Joshi 1bff94d0ea 1) Ensure that properties should be displayed after the SonarQube fixes. (Patch by: Aditya)
2) Fixed Tablespace wrong path issue. (Patch by: Nikhil)
3) Align the label and drop-down on Graph Visualizer.
2022-09-12 14:05:21 +05:30
Aditya Toshniwal b128ba2f57 Fixed a couple of SonarQube issues. 2022-09-10 14:04:28 +05:30
Nikhil Mohite d967d5046d Fixed 'Remove the unused function parameter' code smell. 2022-09-09 18:36:51 +05:30
Akshay Joshi 3b95a416ca Fixed 'Remove the unnecessary boolean literals' code smell. 2022-09-09 15:23:18 +05:30
Akshay Joshi 7086719640 Fixed SonarQube issues. 2022-09-08 18:08:58 +05:30
Akshay Joshi 18b77f15dd Remove Alertify from pgAdmin completely. Fixes #7619 2022-09-08 15:16:48 +05:30
Nikhil Mohite e1942d8c9e 1) Port schema diff to React. Fixes #6133
2) Remove SlickGrid.
2022-09-07 19:20:03 +05:30
Aditya Toshniwal 0f46f070ed Port the remaining components of the ERD Tool to React. Fixes #7343
1. Make use of MUI styles and remove SCSS.
2. Use the new common components for buttons and tooltips, so that they are consistent.
3. UI design should be aligned with the query tool.
4. Remove tippyjs and Alertify dependencies.
2022-09-06 18:09:13 +05:30
Yogesh Mahajan 71a4b20d90 Fixed some SonarQube issues. 2022-08-30 14:21:33 +05:30
Dave Page a84118823e Title case tab label 2022-08-25 13:47:59 +01:00
Aditya Toshniwal f2cc897f2f 1. Fixed an issue where copy and pasting a row in the results grid doesn't set the default for boolean. Fixes #7579
2. Fixed an issue where the History tab is getting blank and showing an error after some queries are executed. Fixes #7468
3. Fixed query tool view data crash.
2022-08-22 14:33:38 +05:30
Aditya Toshniwal 09e2c0eac0 1. Explain plan crashes query tool after SonarQube fixes.
2. Fix XSS issue in query tool.
3. Process details for cloud process not showing complete command.
4. Confirm dialog before removing processes.
2022-08-18 18:42:03 +05:30
Aditya Toshniwal 306b184e11 1. Fixed an issue where Alt-Shift-Q didn't work after creating a new query. Fixes #7575
2. Fixed an issue where the Query Editor loses focus when saving a query (Alt+s). Fixes #7521
3. Ensure that an error is thrown if clipboard access is not provided and change the copy rows shortcut. Fixes #7452
2022-08-17 17:23:44 +05:30
Akshay Joshi da927f4897 1) Autocomplete on keypress should be set to False by default.
2) Update the documentation for the locked option in user management.
2022-08-17 14:38:37 +05:30
Akshay Joshi f771d3a4bb Conditionally pin Flask version based on Python version. 2022-08-17 12:21:05 +05:30
Akshay Joshi d4fdd4601e 1) Pin Flask version 2.1.*
2) Fixed API test cases that failed due to a change in the Werkzeug version.
3) Change password issue is fixed.
2022-08-17 11:54:16 +05:30
Khushboo Vashi d45072fae5 Ensure that rename panel should work on view/edit panels. Fixes #7540 2022-08-16 15:31:55 +05:30
Akshay Joshi 084203debc Fixed Securtiy Hotspot reported by SonarQube. 2022-08-12 17:10:26 +05:30
Yogesh Mahajan f96653e9af Fixed an issue with rendering geometry when selecting a complete column. Fixes #7586 2022-08-09 13:28:09 +05:30
Akshay Joshi d1c94ac73d Fixed SonarQube issues. 2022-08-05 18:58:03 +05:30
Akshay Joshi 53887c32bf Port change ownership dialog to React. Fixes #7590 2022-08-05 14:11:17 +05:30
Akshay Joshi 95312f2d14 1) Ensure that autocomplete does not appear when navigating code using arrow keys. Fixes #7573
2) Fixed an issue where autocomplete is not working after clearing the query editor. Fixes #7563
2022-08-01 14:38:32 +05:30
Aditya Toshniwal a7fd7d67b3 1. Intermittently failing test cases.
2. Dialog vertical position should be more on the upper side.
3. File not supported error is not showing.

refs #7313
2022-07-25 11:48:27 +05:30
Akshay Joshi 3e3f06c55d Fixed an issue where Autocomplete did not work after pressing CTRL/CMD + Space
for the second time and autocomplete on keypress is off. Fixes #7563
2022-07-22 18:49:46 +05:30
Akshay Joshi 631a08189a 1) Improved autocomplete loading indicator.
2) Avoid too many ajax requests per key press.

refs #4488
2022-07-20 18:02:45 +05:30
Aditya Toshniwal 4808df5e95 1) Port the file/storage manager to React. Fixes #7313
2) Allow users to delete files/folders from the storage manager. Fixes #4607
3) Allow users to search within the file/storage manager. Fixes #7389
4) Fixed an issue where new folders cannot be created in the save dialog. Fixes #7524
2022-07-19 15:27:47 +05:30
Akshay Joshi 4585597388 Added option to trigger autocomplete on key press in the query tool. Fixes #4488 2022-07-19 11:55:37 +05:30
Yogesh Mahajan 8f2bda2309 1) Preserve the settings set by the user in the import/export data dialog. Fixes #7428
2) Fixed the JSON editor issue of hiding the first record. Fixes #7520
2022-07-18 10:54:03 +05:30
Aditya Toshniwal 9dde195af4 Ensure that notices should not disappear from the messages tab. Fixes #7512 2022-07-14 18:05:36 +05:30
Aditya Toshniwal 1fecf70123 Ensure that geometry should be shown for all the selected cells. Fixes #7519 2022-07-14 17:38:42 +05:30
Akshay Joshi 50c930f5fa Make the controls on the Graph Visualiser collapsible and reorganize the controls. 2022-07-07 14:10:10 +05:30
Akshay Joshi 9cdcad7a88 1) Keep the selected columns for the X and Y-axis.
2) Lighten the color of the stacked line chart.
2022-07-06 18:58:15 +05:30
Akshay Joshi 7414394ceb Fixed the following issues in the Graph Visualiser:
1) Change all theme's color codes.
 2) Bar graph for the first and last labels on the X-axis does not display all the bars.
 3) Make the graphs always start from zero on the Y-axis.
2022-07-05 18:44:20 +05:30
Akshay Joshi 8b62cd1f04 Added support for visualise the graph using a Pie chart in the query tool. Fixes #7487 2022-07-05 10:47:17 +05:30
Aditya Toshniwal 239e3bb6f1 Some more theme related fixes. 2022-07-04 14:26:33 +05:30
Aditya Toshniwal 86b30b3c83 Theme component usage has been fixed, a component should never be wrapped in multiple Theme components. 2022-06-30 15:18:20 +05:30
Akshay Joshi b92e2fcfc9 Added support for visualizing the graphs using Stacked Line, Bar, and Stacked Bar charts in the query tool. Fixes #7486 2022-06-30 12:38:48 +05:30
Aditya Toshniwal 524626b895 Ensure that the file name should be reflected on the query tool for the new tab title. 2022-06-28 18:21:08 +05:30
Yogesh Mahajan d4657dcd32 Fixed module import issue.
refs #7506
2022-06-28 11:28:55 +05:30
Akshay Joshi f905dc07cf Reset the zoom to original when chart object is created. Fixed an error on Windows. 2022-06-28 10:25:38 +05:30
Pradip Parkale e95eb14651 Fixed an issue where the connection wasn't being closed when the user switched
to a new connection and closed the query tool. Fixes #7461

Fixed the 'Show activity?' issue which was missed during Dashboard porting.
2022-06-23 18:15:16 +05:30
Akshay Joshi 2556771c32 The following issues were fixed in Graph Visualiser:
1) Allow the user to set the row limit and chart line width.
2) Zoom should only be applied to X-axis, not both.
3) On clicking the 'Generate' button, the chart should return to its original zoom level.
4) Negative values are not displayed.

refs #7485
2022-06-23 14:52:11 +05:30
Akshay Joshi 93bc1f3c57 Added support for visualise the graph using a Line chart in the query tool. Fixes #7485 2022-06-22 17:18:51 +05:30
Aditya Toshniwal 5c1493bd7e Fixed an issue where there is no setting to turn off notifications in the Query Tool. Fixes #7423 2022-06-13 14:32:07 +05:30
Aditya Toshniwal 725726f083 Ensure that the Query Editor should be focused when switching between query tool tabs. Fixes #7441 2022-06-13 14:26:01 +05:30
Aditya Toshniwal f615ef30f9 Skip the history records if the JSON info can't be parsed instead of showing 'No history'. Fixes #7468 2022-06-13 11:43:26 +05:30
Aditya Toshniwal 4c50940634 Fixed some issues related to the dropdown background color. Fixes #7374 2022-05-30 17:05:48 +05:30
Aditya Toshniwal b507eb8857 Fixed an issue when switching between connections in the Query Tool dropdown,
the background and foreground colors should be changed. Fixes #7374
2022-05-26 15:31:18 +05:30
Aditya Toshniwal aaab5c51a7 Fixed an issue where the data grid scroll is not reset when a query is executed. 2022-05-25 17:53:52 +05:30
Aditya Toshniwal 1e1e1f027a Fixed an issue where geometry is not visible when a single cell is selected. Fixes #7394 2022-05-24 17:08:02 +05:30
Aditya Toshniwal c5ca45c461 Ensure that null values are accepted for the numeric columns in react-data-grid. Fixes #7405 2022-05-24 15:02:06 +05:30
Aditya Toshniwal 04fa7dee68 Added missing toggle case keyboard shortcuts to the query tool. Fixes #7399 2022-05-24 14:54:43 +05:30
Aditya Toshniwal 6d26d5833f Added support for multi-cell selection in the query tool grid. Fixes #7380 2022-05-24 11:39:34 +05:30
Akshay Joshi 4f7bcc2919 Added the ability to detect and warn users about bidirectional Unicode characters. Fixes #7002 2022-05-23 16:04:21 +05:30
Aditya Toshniwal 5e0dfff42a Ensure that the editor position should not get changed once it is opened. Fixes #7393 2022-05-18 13:52:09 +05:30
Aditya Toshniwal 2d8aff6ca0 Fixed an issue with geometry window zoom mouse scroll not working. Fixes #7373 2022-05-17 18:58:49 +05:30
Aditya Toshniwal fbe7b56054 Fixed an issue where a popup for unsaved changes appears when clicking on the
open file button for a blank query editor. Fixes #7376
2022-05-17 18:56:15 +05:30
Aditya Toshniwal cb05d2924f Fixed an issue where an error message fills the entire window if the query is long. Fixes #7388 2022-05-17 18:52:19 +05:30
Akshay Joshi 44f9ba4a57 Port connect server password dialog to React. Fixes #7337 2022-05-16 16:21:14 +05:30
Aditya Toshniwal ca8e14455f Fixed the following issues:
1. Feature test cases for the new query tool.
 2. Query tool panel rename is not persisting.
2022-05-12 18:29:09 +05:30
Aditya Toshniwal 1135821870 Fix Query tool issues:
1. Warning/Confirm dialogs should be inside the query tool.
2. The Help button in View/Edit data should open the corresponding help page.
3. Disable execute options when query tool in transaction.
4. Grid not loading more than 10000 rows. react-data-grid issue, PR sent. Use a fork till then.
5. NOTICE messages should not be part of Notifier success popups.

Fixes #7350
2022-05-09 12:39:29 +05:30
Nikhil Mohite 5ebc9d7d2e Ensure the Copy button is enabled when columns or rows are selected in the query tool results. 2022-05-05 09:52:14 +01:00
Aditya Toshniwal 64ffed0ddb 1. Filter dialog doesn't work in edit mode (getting back end errors), reverting it back to create mode of SchemaView.
2. Enable the copy button when a cell is selected.
3. Exclude, Include related fixes.
2022-04-29 16:29:46 +05:30
Akshay Joshi c56fe813a5 Use gettext to wrap some strings. 2022-04-29 16:18:28 +05:30
Aditya Toshniwal 38f642d361 Ensure that the "Save results" button should be disabled when there are no rows.
refs #6131
2022-04-28 18:01:54 +05:30
Akshay Joshi 6e2ee9a21f Port data filter dialog to React. Fixes #7340 2022-04-28 12:04:56 +05:30
Aditya Toshniwal 0795b22ae6 Fixed the following issues for the new query tool:
1) In Dark mode > Replace/Find dialogue forward & reverse buttons are stuck to each other.
 2) In Dark/High contrast mode > Checkbox is not visible for false value.
 3) Wrap toolbar when size goes very small.
 4) Replace functionality does not work when tried in sequence 2 times. Codemirror search is not cyclic. So, changes are made to always search from the start.
 5) Replace all does not work when tried in sequence 2 times. Same reason as above.
 6) Fix broken macros $SELECTION$ feature.
 7) Make query history SQL readonly.
 8) The Filter dialog save button should be disabled when opened.
2022-04-26 16:27:53 +05:30
Akshay Joshi 4f9eaf850d Updated documentation for the new query tool.
refs #6131
2022-04-26 16:18:28 +05:30
Aditya Toshniwal 25b89f7624 Fixed the following issues for the new query tool:
1) Failed to fetch query history error sometimes.
 2) In copy paste row, if a copied row has [null], then those are pasted as an empty string.
 3) When Data output is empty, show an empty grid.
 4) Schema diff generates a script button resulting in an empty window. Fixes #7306.
 5) Detach the DataOutput panel > Try editing text cell > Text editor is hidden behind the data output panel

refs #6131
2022-04-25 18:11:39 +05:30
Aditya Toshniwal c5ca394cec 1. Add min width to panels.
2. Fix issues related to New connection in query tool. Also fixed some existing bugs related to this.

refs #6131
2022-04-22 18:17:01 +05:30
Aditya Toshniwal e5ef6a7b21 Fixed following issues for Query Tool (after React Porting):
1) Find/Replace both opens the same dialogue box.(by clicking menu option)
2) Add New Server Connection > Server options keep loading(For multiple Server groups & should have some server)
3) Fixed CSS issues of slickgrid at various places.
4) C should be captial in ’<New connection…>'
5) In pop title for New Connection, all words should be capital.(Add new connection)
6) Explain > Analaysis tab > Column heading missing ROWS PLAN with cost & In explain only.
7) Explain > Analaysis tab > with cost enabled > Upward arrow size does not match with font of number. Arrow is little bigger than number.
8) Boolean default is not considered while ading new row.(try table from feature test defaults)
9) In query history , when not query history present, warning icon size big. Match it to warning message - No history found
10) Select table/db object > Open query tool from Tools menu > NOT FOUND error is shown. Existing issue, fixed.
11) Any cell just open by clicking it > Do NOT change any thing > Click Ok > Cell is shown as edited.

refs #6131
2022-04-20 19:02:16 +05:30
Aditya Toshniwal 9c30d983bd Fixed following issues for query tool after react porting:
1) Add New Server Connection > Server options keep loading(For empty Server group).
 2) After clicking indent/Unindent(for all operations) for large query option left as it is till operation completes
 3) Check sign beside options in Execute Option/Copy Header is little bit big
 4) In explain > Analysis tab does not show ROWS column
 5) In explain > Explain > analysis previous explain output is NOT cleared. New rows are appended. Same applies to the statistics tab.
 6) Update new query tool connection tool tip. Fixes #7289
 7) Explain-Analyze > Loops column is empty.
 8) Explain-Analyze with Verbose & Costs > in ROW X columns upward arrows are missing.
 9) Explain-Analyze with all option checked > background colors are missing for timing.
 10) Explain-Analyze > Additional bullet is added before Hash Cond.
 11) Browser Tree > Filtered rows icon is not working.
 12) Create table with timestamp and default value as function now() > Add new row > Enter mandatory columns except column where default value is function(now()) > Click Save > New row added but column with default value has value [default]. not updated to actual value. / Default values are not considered for any column while adding a new entry.
 13) Disable execute options in View/Edit data.
 14) The Boolean column always shows null.
 15) In Query history Remove & Remove all buttons are stuck to each other.
 16) On Remove all, the right panel is empty.
 17) Create a column with boolean[]/ text[], Try to add a new entry from data grid, enter “” quotes > Click Ok > Now try edit cell > You can not change value.
 18) In query history - Select queries are suffixed by ’Save Data’ icon
 19) Edit any table with PK > Try to insert duplicate PK > Error thrown > Correct pK value > Still old error shown > Not able to add new entry (This works when focus is moved from edited cell)
 20) Clicking arrows after opening dropdown options, does not collapse dropdown.

refs #6131
2022-04-18 12:50:51 +05:30
Akshay Joshi 86a3696ab4 Remove aciTree and its references. 2022-04-13 17:35:01 +05:30