Pravesh Sharma
861c66d180
Ensure that when pasting a row in query tool grid, default value is used for autogenerated/serial columns. #5922
2023-04-26 15:41:10 +05:30
Nikhil Mohite
a6faa77e5b
Throw an appropriate error when a table for which View/Edit data is open is deleted and query is executed. #6138
2023-04-18 15:26:40 +05:30
Khushboo Vashi
47a0009d32
Ensure to quote the primary key value if needed while deleting rows from the table. #6130
2023-04-17 12:38:16 +05:30
Yogesh Mahajan
64d5457e2b
Try to fix feature test failures happening due to error occurring while deleting test databases.
...
* Try to fix feature test failures happening due to error occurring while deleting test databases.
* Updated ON_DEMAND_ROW_COUNT to ON_DEMAND_RECORD_COUNT missed in #3275 .
2023-04-13 17:25:12 +05:30
Yogesh Mahajan
993e1eb1b6
Allow on demand record count setting to be changed per user using preferences. #3275
2023-04-13 16:43:11 +05:30
Pravesh Sharma
eef7461ae6
Ensure that default values are set only for insert statement if user does not provide any values, in case of updating existing values to blank it should be set to null. #5934
...
Incorporated review comments
2023-03-27 10:22:28 +05:30
Khushboo Vashi
5e0daccf76
Added support for psycopg3 along with psycopg2. #5011
2023-02-15 11:31:29 +05:30
Matěj Cepl
7a4951f211
Remove dependency on simplejson package.
2023-02-15 11:10:12 +05:30
Akshay Joshi
98184e5835
Update copyright notices for 2023
2023-01-02 11:53:55 +05:30
Pravesh Sharma
a954f22fe8
Fixed an issue where the CSV file would not download if the CSV quote character length exceeded 1. #5505
2022-11-28 13:49:22 +05:30
Mark Mayo
41508f7f67
python 3 updates
...
- Fix super() calls for python 3
- No need to inherit objects.
- No need for u at the start of strings
- Tidied up some brackets and f-strings too
2022-11-19 10:13:41 +05:30
Nikhil Mohite
abfc30db8b
Ensure that users can use custom characters as CSV field separators/CSV quotes when downloading query results. #5066
2022-10-20 16:28:42 +05:30
Nikhil Mohite
d967d5046d
Fixed 'Remove the unused function parameter' code smell.
2022-09-09 18:36:51 +05:30
Aditya Toshniwal
306b184e11
1. Fixed an issue where Alt-Shift-Q didn't work after creating a new query. Fixes #7575
...
2. Fixed an issue where the Query Editor loses focus when saving a query (Alt+s). Fixes #7521
3. Ensure that an error is thrown if clipboard access is not provided and change the copy rows shortcut. Fixes #7452
2022-08-17 17:23:44 +05:30
Akshay Joshi
da927f4897
1) Autocomplete on keypress should be set to False by default.
...
2) Update the documentation for the locked option in user management.
2022-08-17 14:38:37 +05:30
Akshay Joshi
084203debc
Fixed Securtiy Hotspot reported by SonarQube.
2022-08-12 17:10:26 +05:30
Akshay Joshi
4585597388
Added option to trigger autocomplete on key press in the query tool. Fixes #4488
2022-07-19 11:55:37 +05:30
Akshay Joshi
2556771c32
The following issues were fixed in Graph Visualiser:
...
1) Allow the user to set the row limit and chart line width.
2) Zoom should only be applied to X-axis, not both.
3) On clicking the 'Generate' button, the chart should return to its original zoom level.
4) Negative values are not displayed.
refs #7485
2022-06-23 14:52:11 +05:30
Aditya Toshniwal
5c1493bd7e
Fixed an issue where there is no setting to turn off notifications in the Query Tool. Fixes #7423
2022-06-13 14:32:07 +05:30
Aditya Toshniwal
b5b9ee46a1
1) Port query tool to React. Fixes #6131
...
2) Added status bar to the Query Tool. Fixes #3253
3) Ensure that row numbers should be visible in view when scrolling horizontally. Fixes #3989
4) Allow removing a single query history. Refs #4113
5) Partially fixed Macros usability issues. Ref #6969
6) Fixed an issue where the Query tool opens on minimum size if the user opens multiple query tool Window quickly. Fixes #6725
7) Relocate GIS Viewer Button to the Left Side of the Results Table. Fixes #6830
8) Fixed an issue where the connection bar is not visible. Fixes #7188
9) Fixed an issue where an Empty message popup after running a query. Fixes #7260
10) Ensure that Autocomplete should work after changing the connection. Fixes #7262
11) Fixed an issue where the copy and paste row does not work if the first column contains no data. Fixes #7294
2022-04-07 17:36:56 +05:30
Nikhil Mohite
74e794b416
Port preferences dialog to React. Fixes #7149
2022-03-21 13:29:26 +05:30
Akshay Joshi
e38c38cd58
Fixed following SonarQube code smells:
...
1) Remove this useless assignment to a variable.
2) Remove the unused local variable.
2022-01-12 14:53:19 +05:30
Akshay Joshi
2786f7ac5a
Update copyright notices for 2022
2022-01-04 13:54:25 +05:30
Nikhil Mohite
e5e9981836
Fixed an issue where Columns with default value not showing when adding a new row. Fixes #7034
2021-12-21 18:09:20 +05:30
Pradip Parkale
9754b0fe14
Fixed an issue where Columns with default value not showing when adding a new row. Fixes #7034
2021-12-17 10:48:24 +05:30
Akshay Joshi
f8cb62180e
Fixed API test cases for StartRunningQueryTest.
2021-12-03 13:19:31 +05:30
Akshay Joshi
c6424e3897
Replaced alertifyjs notifiers with React-based notistack. Fixes #7004
2021-12-02 16:05:52 +05:30
Akshay Joshi
d644b4f94e
1) Replace Flask-BabelEx with Flask-Babel. Fixes #6088
...
2) Upgrade Flask to version 2. Fixes #7010
2021-11-24 17:22:57 +05:30
Akshay Joshi
eeff75ba20
Remove GPDB support completely. Fixes #6692
2021-09-09 13:09:53 +05:30
Akshay Joshi
3e4b5fd0d7
Renamed 'Auto rollback?' to 'Auto rollback on error?'. Fixes #6682
2021-08-19 15:30:58 +05:30
Pradip Parkale
7483ddf2b2
Added support to copy SQL from main window to query tool. Fixes #4904
2021-08-09 14:29:31 +05:30
Akshay Joshi
025c98ced8
1) Flash warning message of N no of attempts left for the unsuccessful login attempt.
...
2) Updated some strings in the Preferences for the "Maximum column width" option.
2021-08-03 17:06:06 +05:30
Akshay Joshi
508f97b08e
Rename the "Resize by data?" to "Columns sized by" and disabled the 'Maximum column width'
...
button if 'Columns sized by' is set to 'Column data'. Fixes #6622
2021-07-27 15:17:06 +05:30
Akshay Joshi
e68c8305a2
Added option to provide maximum width of the column when 'Resize by data?’ option in the preferences is set to True. Fixes #6559
2021-06-28 11:51:21 +05:30
Dave Page
2b7f8d8298
Improve some strings.
2021-05-11 11:31:14 +01:00
Akshay Joshi
d80087f6d5
Added support to set auto width of columns by content size in the data output window. Fixes #5954
2021-05-07 17:18:50 +05:30
Akshay Joshi
1f4affcb1e
Fixed an issue where a connection warning should be displayed when the user
...
clicks on explain or explain analyze and the database server is disconnected
from the browser tree. Fixes #6376
2021-04-08 18:49:31 +05:30
Nikhil Mohite
68132e2a8f
Fixed an issue where adding/updating records fails if the table name contains percent sign.
...
refs #4438
2021-03-12 11:59:45 +05:30
Nikhil Mohite
8cf7c41ad9
Fixed an issue where adding/updating records fails if the table name contains percent sign. Fixes #4438 .
2021-03-09 12:40:59 +05:30
Akshay Joshi
b372f08a59
Update copyright notices for 2021
2021-01-04 15:34:45 +05:30
Akshay Joshi
98b7603ebd
Close query tool connection for API test cases.
2020-12-25 18:32:01 +05:30
Rahul Shirsat
6475a70514
Ensure that the macro query result should be download properly. Fixes #5965
2020-12-14 11:58:53 +05:30
Nikhil Mohite
2793747d3c
1) Added support for dynamic tab size. Fixes #4231
...
2) Fixed an issue where a long file name is not visible on the process watcher dialog. Fixes #5950
2020-11-04 17:45:28 +05:30
Libor M
7648bd9646
Added missing gettext.
2020-10-27 10:51:35 +05:30
Nikhil Mohite
275d13d40f
Following issues have been resolved for the new connection feature:
...
1. Show servers with server groups in the dropdown.
2. Highlighted current selected connection in the new connection dropdown.
3. Notify the user before changing the connection.
refs #3794
2020-10-21 17:14:59 +05:30
Nikhil Mohite
18cad32bd4
Added tab title placeholder for Query Tool, View/Edit Data, and Debugger. Fixes #4232
2020-10-20 15:41:54 +05:30
Khushboo Vashi
c28509ac28
Fixed an issue where the user is unable to change the macro name. Fixes #5885
2020-10-05 14:40:21 +05:30
Khushboo Vashi
228d4bb321
Fixed SQLAlchemy operation error with the boolean value as true/false for Python version < 3.7
2020-10-01 13:29:46 +05:30
Khushboo Vashi
4616a74029
Added Macro support. Fixes #1402
2020-09-28 15:26:45 +05:30
Aditya Toshniwal
ed3c692b1f
Fixed an issue where the query tool is not fetching more than 1000 rows for the table does not have any primary key. Fixes #5845
2020-09-21 15:36:19 +05:30
Aditya Toshniwal
535739c0c7
Fixed cognitive complexity issues reported by SonarQube.
2020-09-09 11:25:43 +05:30
Khushboo Vashi
31bbdd6a12
Fixed code smell 'String literals should not be duplicated'.
2020-09-03 18:35:58 +05:30
Cyril Jouve
5a253f9053
Change the following to replace Python 2 code with Python 3:
...
1) Replace the deprecated unit test method.
2) Wraps filter usage in a list call.
3) Converts the old metaclass syntax to new.
4) Use range instead of xrange method.
5) Change Unicode to str.
6) Several other transformations.
7) Fixed change password test cases.
8) Use simplejson instead of plain JSON.
2020-08-31 16:45:31 +05:30
Yogesh Mahajan
3984544bdb
Fixed code smell 'String literals should not be duplicated'.
2020-08-28 18:17:27 +05:30
Akshay Joshi
103b08c9c5
Define constants for preferences label to fix SonarQube issues.
2020-08-20 17:58:37 +05:30
Dave Page
99a7ada58a
Cleanup a bunch of duplicated gettext calls.
2020-08-20 10:00:12 +01:00
Dave Page
79e6480513
Added SQL Formatter support in Query Tool. Fixes #2042
2020-08-20 13:05:00 +05:30
Aditya Toshniwal
d6400bbcae
Replace the generic exception class with a more specific one.
2020-08-07 12:37:00 +05:30
Yogesh Mahajan
e3dfe03a2a
Fixed an issue where the user is not able to insert the data if the table and columns name contains special characters. Fixes #4387
2020-08-06 12:30:10 +05:30
Aditya Toshniwal
aa679e06b2
Replace the generic exception class with a more specific one to fix SonarQube issues.
2020-08-05 12:41:28 +05:30
Aditya Toshniwal
536593bf8a
Fixed following SonarQube issues:
...
- Remove this assignment to the local variable, the value is never used.
- Rename local variables to match the regular expression
- Add logic to this except clause or eliminate it and rethrow the exception automatically.
- Rename fields to match the regular expression
- Extract this nested conditional expression into an independent statement.
- Change this default value to "None" and initialize this parameter inside the function/method.
- Update this function so that its implementation is not identical to __repr__
- Refactor this method to not always return the same value
- Reraise this exception to stop the application as the user expects
- Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
- Remove this redundant continue.
- Remove this unused function declaration
- Remove this identity check; it will always be False.
2020-08-03 12:59:51 +05:30
Nikhil Mohite
eb2c554601
Fixed cognitive complexity issues reported by SonarQube.
2020-08-03 12:46:34 +05:30
Aditya Toshniwal
357a9179b1
Fixed convention related issues reported by SonarQube.
2020-07-09 18:55:33 +05:30
Akshay Joshi
b1cbcc7ef6
Fixed data truncation issue when updating the data of type character with length. Fixes #5481
2020-05-25 17:05:47 +05:30
Khushboo Vashi
d68e6bd892
Remove Python2 modules.
...
refs #5443
2020-05-08 12:28:21 +05:30
Akshay Joshi
ad80217593
Remove Python2 references from the source code.
...
refs #5443
Initial patch: Neel Patel
2020-04-30 17:22:48 +05:30
Dave Page
86afec860f
Remove Python 2 support from the Python tests.
...
refs #5443
2020-04-30 12:56:45 +05:30
navnath gadakh
c76732e3e7
Ensure that default sort order should be using the primary key in View/Edit data. Fixes #5157
2020-04-22 18:47:13 +05:30
Amol Vyavahare
f282b26883
Fixed an issue when the user creates a temporary table with 'on commit drop as' clause. Fixes #4946
2020-04-20 18:22:34 +05:30
Nagesh Dhope
8bdfa18efb
Ensure that if the delimiter is set other than comma then download the file as '.txt' file. Fixes #4573
2020-04-17 17:37:02 +05:30
navnath gadakh
c0a2f1f24d
Ensure that text larger than underlying field size should not be truncated automatically. Fixes #5210
2020-04-16 14:39:31 +05:30
Libor M
94864104e4
Added and fixed gettext usage for better translation coverage. Fixes #5284
...
1) Fixed usage gettext('') instead of _('') in javascript files.
2) Fixed usage gettext('') instead of `${gettext('')}` in javascript files,
because "pybabel extract" not support extracting from this syntax.
2020-03-24 11:14:05 +05:30
Khushboo Vashi
d59816054f
Schema Diff Improvements:
...
1. Grid header should be center aligned vertically.
2. Increase the space between object counts.
3. The previous selected objects should not be re-selected on comparison.
2020-01-13 18:19:07 +05:30
Khushboo Vashi
45f2e35a99
Added Schema Diff tool to compare two schemas and generate the difference script.
...
Currently supported objects are Table, View, Materialized View, Function and Procedure.
Backend comparison of two schemas implemented by: Akshay Joshi
Fixes #3452 .
2020-01-10 15:42:09 +05:30
Dave Page
01c7636c75
Update copyright notices for 2020.
2020-01-02 14:43:50 +00:00
Aditya Toshniwal
30c7effa50
Fix the toggle case shortcut key combination. Fixes #3999
2019-11-01 12:10:14 +00:00
Akshay Joshi
051e5038b5
Fix issue where query history is not visible in the query history tab. Fixes #4777
2019-09-25 13:18:33 +05:30
Akshay Joshi
b10378fe70
Fix query history issue for Python 2.7, it is a regression of #4750 .
2019-09-17 11:01:13 +05:30
Murtuza Zabuawala
80b05973c6
Fix query history exception for Python 3.6. Fixes #4750 .
2019-09-16 19:09:22 +05:30
Aditya Toshniwal
1c2ba72f02
Add editor options for plain text mode and to disable block folding to
...
workaround rendering speed issues in CodeMirror with very large scripts.
Fixes #4631 .
Re-arrange editor options in the Preferences dialogue to tidy things up.
2019-09-04 15:46:08 +01:00
Aditya Toshniwal
47f26cc377
Fix exception in query history for python 2.7. Fixes #4663
2019-08-30 09:07:03 +05:30
Aditya Toshniwal
028473eb83
Fix an issue where oid column should not be pasted when copy/paste row is used on query output containing the oid column. Fixes #4381
2019-08-28 13:35:40 +05:30
Yosry Muhammad
f8f7d5ac6f
Ensure editable and read-only columns in Query Tool should be identified by icons and tooltips in the column header. Fixes #4667
2019-08-26 14:17:40 +05:30
Aditya Toshniwal
234efc3be7
Don't wait for the database connection before rendering the Query Tool UI, for improved UX. Fixes #4453
...
In addition, unescape HTML entities in database names in the Query Tool title bar. Fixes #4584
2019-08-23 12:14:20 +01:00
Khushboo Vashi
ed76787b76
Fix the Transaction Status failed test cases.
2019-08-20 10:22:11 +05:30
Yosry Muhammad
663e8382f3
1) Added new python test that checks the transaction status after executing queries and saving data when auto-commit is on/off.
...
2) Some refactoring of previously written python tests.
2019-08-19 11:45:36 +05:30
Yosry Muhammad
687204771c
Add support in query history to show internal queries generated by pgAdmin during save data operations. Fixes #4612
2019-08-16 17:17:12 +05:30
Yosry Muhammad
76e658ee12
Ensure command tags are shown in the messages tab of the Query Tool. Fixes #4520
2019-08-01 14:29:38 +01:00
Yosry Muhammad
7b65507533
Ensure the query tool will work with older versions of psycopg2 than we officially support, albeit without updateable resultsets. Fixes #4520
2019-08-01 13:59:53 +01:00
Yosry Muhammad
82d209946f
Added support for editing of result sets from tables with OIDs in query tool.
2019-07-29 12:26:53 +05:30
Yosry Muhammad
710d520631
Add support for editing of resultsets in the Query Tool, if the data can be identified as updatable. Fixes #1760
...
When a query is run in the Query Tool, check if the source of the columns
can be identified as being from a single table, and that we have all
columns that make up the primary key. If so, consider the resultset to
be editable and allow the user to edit data and add/remove rows in the
grid. Changes to data are saved using SAVEPOINTs as part of any
transaction that's in progress, and rolled back if there are integrity
violations, without otherwise affecting the ongoing transaction.
Implemented by Yosry Muhammad as a Google Summer of Code project.
2019-07-17 11:45:20 +01:00
Dave Page
bd0e4a5a8f
Remove some files committed in error.
2019-07-08 12:07:50 +01:00
Akshay Joshi
11a3aa56be
Use different folders for pg vs. ppas RE-SQL tests. Fall back to the tests folder without a subdirectory if neither exist.
2019-07-05 14:40:51 +01:00
Aditya Toshniwal
0340b8fb28
Add EXPLAIN options for SETTINGS and SUMMARY. Fixes #4335
...
Prevent flickering of large tooltips on the Graphical EXPLAIN canvas. Fixes #4224
EXPLAIN options should be Query Tool instance-specific. Fixes #4395
2019-07-03 13:57:56 +01:00
Aditya Toshniwal
f561c0cee6
Fix keyboard navigation in "inner" tabsets such as the Query Tool and Debugger. Fixes #4195
2019-06-10 11:10:49 +01:00
Aditya Toshniwal
dfa892d2a2
1. Added Master Password to increase the security of saved passwords. Fixes #4184
...
2. In server(web) mode, update all the saved server credentials when user password is changed. Fixes #3377
2019-05-28 12:00:18 +05:30
Dave Page
ab9a3a57ad
Make the Query Tool history persistent across sessions. Fixes #4017
2019-03-13 13:37:34 +00:00
Akshay Joshi
0aeb20ee64
Prevent auto-commit/rollback being changed mid-transaction, and make the Preferences the defaults, not the current values.
2019-03-04 10:44:31 +00:00
Akshay Joshi
38b034ec3c
Add Commit and Rollback buttons to the Query Tool. Fixes #2418
2019-02-22 14:28:05 +00:00
Akshay Joshi
5be0d17df5
Don't exclude SELECT statements from transaction management in the Query Tool in case they call data-modifying functions. Fixes #3958
2019-02-21 14:05:10 +00:00