From fd65f1b644736119a3b609303d3e7c0f30788bee Mon Sep 17 00:00:00 2001
From: Pravesh Sharma <pravesh.sharma@enterprisedb.com>
Date: Wed, 24 Apr 2024 11:27:08 +0530
Subject: [PATCH] Fixed all input boxes in pgAdmin to show browser auto-fill
 only where it is relevant. #2410

---
 web/pgadmin/about/static/js/AboutComponent.jsx                 | 2 +-
 .../browser/server_groups/servers/static/js/server.ui.js       | 3 ++-
 web/pgadmin/static/js/Dialogs/ChangePasswordContent.jsx        | 3 ++-
 web/pgadmin/static/js/Dialogs/MasterPasswordContent.jsx        | 2 +-
 web/pgadmin/static/js/components/FormComponents.jsx            | 2 +-
 5 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/web/pgadmin/about/static/js/AboutComponent.jsx b/web/pgadmin/about/static/js/AboutComponent.jsx
index 5a4aba8e0..457c54412 100644
--- a/web/pgadmin/about/static/js/AboutComponent.jsx
+++ b/web/pgadmin/about/static/js/AboutComponent.jsx
@@ -141,7 +141,7 @@ export default function AboutComponent() {
             }}>{copyText}</DefaultButton>
           </Box>
           <Box flexGrow="1" paddingTop="1px">
-            <InputText style={{height: '100%'}} controlProps={{multiline: true}} inputStyle={{resize: 'none', height: '100%'}}
+            <InputText style={{height: '100%'}} controlProps={{multiline: true, rows: 8}} inputStyle={{resize: 'none'}}
               value={aboutData.settings}/>
           </Box>
         </Box>
diff --git a/web/pgadmin/browser/server_groups/servers/static/js/server.ui.js b/web/pgadmin/browser/server_groups/servers/static/js/server.ui.js
index 3f640d457..34e3e57ff 100644
--- a/web/pgadmin/browser/server_groups/servers/static/js/server.ui.js
+++ b/web/pgadmin/browser/server_groups/servers/static/js/server.ui.js
@@ -224,7 +224,8 @@ export default class ServerSchema extends BaseUISchema {
           return state.connect_now && obj.isNew(state);
         },
         controlProps: {
-          maxLength: null
+          maxLength: null,
+          autoComplete: 'new-password'
         },
         disabled: function(state) {return state.kerberos_conn;},
       },{
diff --git a/web/pgadmin/static/js/Dialogs/ChangePasswordContent.jsx b/web/pgadmin/static/js/Dialogs/ChangePasswordContent.jsx
index f5441611e..f56e527b5 100644
--- a/web/pgadmin/static/js/Dialogs/ChangePasswordContent.jsx
+++ b/web/pgadmin/static/js/Dialogs/ChangePasswordContent.jsx
@@ -36,7 +36,8 @@ class ChangePasswordSchema extends BaseUISchema {
         id: 'password', label: gettext('Current Password'), type: 'password',
         disabled: self.isPgpassFileUsed, noEmpty: !self.isPgpassFileUsed,
         controlProps: {
-          maxLength: null
+          maxLength: null,
+          autoComplete: 'new-password'
         }
       }, {
         id: 'newPassword', label: gettext('New Password'), type: 'password',
diff --git a/web/pgadmin/static/js/Dialogs/MasterPasswordContent.jsx b/web/pgadmin/static/js/Dialogs/MasterPasswordContent.jsx
index 73d97934a..d2e62f759 100644
--- a/web/pgadmin/static/js/Dialogs/MasterPasswordContent.jsx
+++ b/web/pgadmin/static/js/Dialogs/MasterPasswordContent.jsx
@@ -91,7 +91,7 @@ export default function MasterPasswordContent({ closeModal, onResetPassowrd, onO
           </Box>
           <Box marginTop='12px'>
             <InputText inputRef={firstEleRef} type="password" value={formData['password']} maxLength={null}
-              onChange={(e) => onTextChange(e, 'password')} onKeyDown={(e) => onKeyDown(e)}/>
+              onChange={(e) => onTextChange(e, 'password')} onKeyDown={(e) => onKeyDown(e)} controlProps={{autoComplete: 'new-password'}}/>
           </Box>
           <FormFooterMessage type={MESSAGE_TYPE.ERROR} message={data.errmsg} closable={false} style={{
             position: 'unset', padding: '12px 0px 0px'
diff --git a/web/pgadmin/static/js/components/FormComponents.jsx b/web/pgadmin/static/js/components/FormComponents.jsx
index 740ac0d25..65e9c9864 100644
--- a/web/pgadmin/static/js/components/FormComponents.jsx
+++ b/web/pgadmin/static/js/components/FormComponents.jsx
@@ -394,7 +394,7 @@ export const InputText = forwardRef(({
         'aria-describedby': helpid,
         ...(type ? { pattern: !_.isUndefined(controlProps) && !_.isUndefined(controlProps.pattern) ? controlProps.pattern : patterns[type] } : {}),
         style: inputStyle || {},
-        autoComplete: _.isUndefined(controlProps?.autoComplete) ? 'nope' : controlProps?.autoComplete,
+        autoComplete: _.isUndefined(controlProps?.autoComplete) ? 'off' : controlProps?.autoComplete,
         'data-testid': 'input-text',
         title: controlProps?.title,
       }}