From f85efb27974d503bdbf027644f17f027ac3464d4 Mon Sep 17 00:00:00 2001 From: Aditya Toshniwal Date: Fri, 1 Nov 2019 12:04:40 +0000 Subject: [PATCH] Handle NULL values appropriately when sorting backgrid tables. Fixes #4242 --- docs/en_US/release_notes_4_15.rst | 1 + web/pgadmin/static/js/backgrid.pgadmin.js | 2 ++ 2 files changed, 3 insertions(+) diff --git a/docs/en_US/release_notes_4_15.rst b/docs/en_US/release_notes_4_15.rst index 80f076743..992b4d2e0 100644 --- a/docs/en_US/release_notes_4_15.rst +++ b/docs/en_US/release_notes_4_15.rst @@ -24,6 +24,7 @@ Bug fixes | `Issue #3913 `_ - Ensure the correct "running at" agent is shown when a pgAgent job is executing. | `Issue #3915 `_ - Fix an issue in the Query Tool where shortcut keys could be ignored following a query error. | `Issue #4191 `_ - Ensure comments are shown in reverse engineered SQL for table partitions. +| `Issue #4242 `_ - Handle NULL values appropriately when sorting backgrid tables. | `Issue #4341 `_ - Give appropriate error messages when the user tries to use an blank master password. | `Issue #4459 `_ - Don't quote bigints when copying them from the Query Tool results grid. | `Issue #4482 `_ - Ensure compression level is passed to pg_dump when backing up in directory format. diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js index 949c5ee0c..52bcbd9d9 100644 --- a/web/pgadmin/static/js/backgrid.pgadmin.js +++ b/web/pgadmin/static/js/backgrid.pgadmin.js @@ -161,6 +161,8 @@ define([ // compare as usual if (l === r) return 0; + else if (l === null && r != null) return -1; + else if (l != null && r === null) return 1; else if (l < r) return -1; return 1; }