From f1ef7b0346cbb06ca007bdf48f7830fbcac2b2a1 Mon Sep 17 00:00:00 2001 From: Dave Page Date: Tue, 21 May 2019 12:14:36 +0100 Subject: [PATCH] Validate permissions on the session directory itself, not it's parent, per Felix Pusch. Fixes #4276 --- web/pgadmin/setup/data_directory.py | 2 +- web/pgadmin/setup/tests/test_permissions.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/web/pgadmin/setup/data_directory.py b/web/pgadmin/setup/data_directory.py index 528bf6443..f1011ab7f 100644 --- a/web/pgadmin/setup/data_directory.py +++ b/web/pgadmin/setup/data_directory.py @@ -39,7 +39,7 @@ def create_app_data_directory(config): # Create the session directory (if not present). _create_directory_if_not_exists(config.SESSION_DB_PATH) if os.name != 'nt': - os.chmod(os.path.dirname(config.SESSION_DB_PATH), 0o700) + os.chmod(config.SESSION_DB_PATH, 0o700) # Create the storage directory (if not present). _create_directory_if_not_exists(config.STORAGE_DIR) diff --git a/web/pgadmin/setup/tests/test_permissions.py b/web/pgadmin/setup/tests/test_permissions.py index 576246976..e78abed5e 100644 --- a/web/pgadmin/setup/tests/test_permissions.py +++ b/web/pgadmin/setup/tests/test_permissions.py @@ -25,7 +25,7 @@ class PermissionsTestCase(BaseTestGenerator): path=os.path.dirname(config.TEST_SQLITE_PATH), permissions='700')), ('Check session directory', dict( - path=os.path.dirname(config.SESSION_DB_PATH), + path=config.SESSION_DB_PATH, permissions='700')) ]