diff --git a/docs/en_US/images/function_definition.png b/docs/en_US/images/function_definition.png index 353874656..169468bd9 100644 Binary files a/docs/en_US/images/function_definition.png and b/docs/en_US/images/function_definition.png differ diff --git a/docs/en_US/images/procedure_arguments.png b/docs/en_US/images/procedure_arguments.png deleted file mode 100755 index 0f09b788c..000000000 Binary files a/docs/en_US/images/procedure_arguments.png and /dev/null differ diff --git a/docs/en_US/images/procedure_definition.png b/docs/en_US/images/procedure_definition.png old mode 100755 new mode 100644 index 7bcb61eba..28b6ac552 Binary files a/docs/en_US/images/procedure_definition.png and b/docs/en_US/images/procedure_definition.png differ diff --git a/docs/en_US/procedure_dialog.rst b/docs/en_US/procedure_dialog.rst index 5f33d6e40..37befbd37 100644 --- a/docs/en_US/procedure_dialog.rst +++ b/docs/en_US/procedure_dialog.rst @@ -36,6 +36,21 @@ Use the fields in the *Definition* tab to define the procedure: * Use the drop-down listbox next to *Language* to select a language. The default is *edbspl*. +* Use the fields in the *Arguments* section to define an argument. Click *Add* to set +parameters and values for the argument: +* Use the drop-down listbox next to *Data type* to select a data type. +* Use the drop-down listbox next to *Mode* to select a mode. Select *IN* for an + input parameter; select *OUT* for an output parameter; select *INOUT* for both + an input and an output parameter; or, select *VARIADIC* to specify a VARIADIC + parameter. +* Write a name for the argument in the *Argument Name* field. +* Specify a default value for the argument in the *Default Value* field. + +Click *Add* to define another argument; to discard an argument, click the trash +icon to the left of the row and confirm deletion in the *Delete Row* popup. + +Click the *Code* tab to continue. + * Use the *Code* field to specify the code that will execute when the procedure is called. @@ -73,26 +88,6 @@ procedure: effects — it reveals no information about its arguments other than by its return value. The default is *No*. -Click the *Arguments* tab to continue. - -.. image:: images/procedure_arguments.png - :alt: Procedure dialog arguments tab - :align: center - -Use the fields in the *Arguments* tab to define an argument. Click *Add* to set -parameters and values for the argument: - -* Use the drop-down listbox next to *Data type* to select a data type. -* Use the drop-down listbox next to *Mode* to select a mode. Select *IN* for an - input parameter; select *OUT* for an output parameter; select *INOUT* for both - an input and an output parameter; or, select *VARIADIC* to specify a VARIADIC - parameter. -* Write a name for the argument in the *Argument Name* field. -* Specify a default value for the argument in the *Default Value* field. - -Click *Add* to define another argument; to discard an argument, click the trash -icon to the left of the row and confirm deletion in the *Delete Row* popup. - Click the *Parameters* tab to continue. .. image:: images/procedure_parameters.png diff --git a/docs/en_US/release_notes_4_21.rst b/docs/en_US/release_notes_4_21.rst index 9cb6d741e..73f7dfb07 100644 --- a/docs/en_US/release_notes_4_21.rst +++ b/docs/en_US/release_notes_4_21.rst @@ -56,5 +56,6 @@ Bug fixes | `Issue #5362 `_ - Fixed an issue where the identical packages and sequences visible as different in the schema diff tool. | `Issue #5366 `_ - Added alert message to Reset Layout if any of the panels from Query Tool failed to load. | `Issue #5371 `_ - Fixed tab key navigation for some dialogs. +| `Issue #5375 `_ - Fixed an issue where the Mode cell of argument grid does not appear completely in the Functions dialog. | `Issue #5383 `_ - Fixed syntax error while refreshing the existing synonyms. | `Issue #5387 `_ - Fixed an issue where the mode is not shown in the properties dialog of functions/procedures if all the arguments are "IN" arguments. \ No newline at end of file diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/function.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/function.js index 1afdecf14..e6c76eb5d 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/function.js +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/function.js @@ -58,6 +58,9 @@ define('pgadmin.node.function', [ },{ id: 'argmode', label: gettext('Mode'), type: 'options', control: 'node-ajax-options', cellHeaderClasses:'width_percent_20', + cell: 'node-ajax-options', select2: { + allowClear: false, + }, options:[ {'label': 'IN', 'value': 'IN'}, {'label': 'OUT', 'value': 'OUT'},