From e8114b5dc67b245d34ff94bae058900fb14b6eb8 Mon Sep 17 00:00:00 2001
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 26 Feb 2021 12:27:39 +0000
Subject: [PATCH] Allow underscores in the Windows installation path. Fixes
 #5467

---
 docs/en_US/release_notes_5_1.rst | 1 +
 pkg/win32/installer.iss.in       | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/en_US/release_notes_5_1.rst b/docs/en_US/release_notes_5_1.rst
index b9565d89e..ac6e310d7 100644
--- a/docs/en_US/release_notes_5_1.rst
+++ b/docs/en_US/release_notes_5_1.rst
@@ -19,5 +19,6 @@ Bug fixes
 
 | `Issue #4959 <https://redmine.postgresql.org/issues/4959>`_ -  Fixed an issue where the properties tab for collection nodes is unresponsive after switching the tabs.
 | `Issue #5073 <https://redmine.postgresql.org/issues/5073>`_ -  Fixed an issue where the Save button is enabled for functions/procedures by default when open the properties dialog.
+| `Issue #5467 <https://redmine.postgresql.org/issues/5467>`_ -  Allow underscores in the Windows installation path.
 | `Issue #6018 <https://redmine.postgresql.org/issues/6018>`_ -  Fixed encoding issue when database encoding set to SQL_ASCII and name of the column is in ASCII character.
 | `Issue #6159 <https://redmine.postgresql.org/issues/6159>`_ -  Ensure that the user should be able to kill the session from Dashboard if the user has a 'pg_signal_backend' role.
diff --git a/pkg/win32/installer.iss.in b/pkg/win32/installer.iss.in
index cd002cd22..b539970ef 100644
--- a/pkg/win32/installer.iss.in
+++ b/pkg/win32/installer.iss.in
@@ -161,7 +161,7 @@ begin
     for I := 3 to Length(Path) do
       begin
         case Path[I] of
-          '0'..'9', 'A'..'Z', '\', ' ', '.', '-', '(', ')':
+          '0'..'9', 'A'..'Z', '\', ' ', '.', '-', '_', '(', ')':
           else
           begin
             Ret := False;