From d90136d93d91e68db03f0d3e7ca19165335a0cce Mon Sep 17 00:00:00 2001 From: Aditya Toshniwal Date: Wed, 5 Jun 2019 12:00:09 +0100 Subject: [PATCH] Prevent the geometry viewer grabbing key presses when not in focus under Firefox, IE and Edge. Fixes #4255 --- docs/en_US/release_notes_4_9.rst | 1 + web/package.json | 2 +- web/pgadmin/static/js/sqleditor/geometry_viewer.js | 6 ++++++ web/yarn.lock | 14 ++++++++------ 4 files changed, 16 insertions(+), 7 deletions(-) diff --git a/docs/en_US/release_notes_4_9.rst b/docs/en_US/release_notes_4_9.rst index 6db7977e0..29e15f624 100644 --- a/docs/en_US/release_notes_4_9.rst +++ b/docs/en_US/release_notes_4_9.rst @@ -13,4 +13,5 @@ New features Bug fixes ********* +| `Bug #4255 `_ - Prevent the geometry viewer grabbing key presses when not in focus under Firefox, IE and Edge. | `Bug #4320 `_ - Fix issue where SSH tunnel connection using password is failing, it's regression of Master Password. \ No newline at end of file diff --git a/web/package.json b/web/package.json index 265a97009..ef252e8d4 100644 --- a/web/package.json +++ b/web/package.json @@ -71,7 +71,7 @@ "jquery-contextmenu": "^2.8.0", "jquery-ui": "^1.12.1", "json-bignumber": "^1.0.1", - "leaflet": "^1.4.0", + "leaflet": "^1.5.1", "moment": "^2.24.0", "moment-timezone": "^0.5.23", "mousetrap": "^1.6.3", diff --git a/web/pgadmin/static/js/sqleditor/geometry_viewer.js b/web/pgadmin/static/js/sqleditor/geometry_viewer.js index f9d8ca1fd..bd07d070b 100644 --- a/web/pgadmin/static/js/sqleditor/geometry_viewer.js +++ b/web/pgadmin/static/js/sqleditor/geometry_viewer.js @@ -45,6 +45,8 @@ let GeometryViewer = { geometry_viewer_panel.on(wcDocker.EVENT.VISIBILITY_CHANGED, function (visible) { if (visible) { self.map_component.resizeMap(); + } else { + self.map_component.loseFocus(); } }); } @@ -186,6 +188,10 @@ function initMapComponent() { vectorLayer.clearLayers(); }, + 'loseFocus': function() { + lmap.fire('blur'); + }, + 'renderMap': function (dataObj) { let geoJSONs = dataObj.geoJSONs, SRID = dataObj.selectedSRID, diff --git a/web/yarn.lock b/web/yarn.lock index 6a00fb835..2fb334202 100644 --- a/web/yarn.lock +++ b/web/yarn.lock @@ -2186,9 +2186,10 @@ code-point-at@^1.0.0: version "1.1.0" resolved "https://registry.yarnpkg.com/code-point-at/-/code-point-at-1.1.0.tgz#0d070b4d043a5bea33a2f1a40e2edb3d9a4ccf77" -codemirror@^5.44.0: - version "5.44.0" - resolved "https://registry.yarnpkg.com/codemirror/-/codemirror-5.44.0.tgz#80dc2a231eeb7aab25ec2405cdca37e693ccf9cc" +codemirror@^5.47.0: + version "5.47.0" + resolved "https://registry.yarnpkg.com/codemirror/-/codemirror-5.47.0.tgz#c13a521ae5660d3acc655af252f4955065293789" + integrity sha512-kV49Fr+NGFHFc/Imsx6g180hSlkGhuHxTSDDmDHOuyln0MQYFLixDY4+bFkBVeCEiepYfDimAF/e++9jPJk4QA== collection-visit@^1.0.0: version "1.0.0" @@ -5110,9 +5111,10 @@ lead@^1.0.0: dependencies: flush-write-stream "^1.0.2" -leaflet@^1.4.0: - version "1.4.0" - resolved "https://registry.yarnpkg.com/leaflet/-/leaflet-1.4.0.tgz#d5f56eeb2aa32787c24011e8be4c77e362ae171b" +leaflet@^1.5.1: + version "1.5.1" + resolved "https://registry.yarnpkg.com/leaflet/-/leaflet-1.5.1.tgz#9afb9d963d66c870066b1342e7a06f92840f46bf" + integrity sha512-ekM9KAeG99tYisNBg0IzEywAlp0hYI5XRipsqRXyRTeuU8jcuntilpp+eFf5gaE0xubc9RuSNIVtByEKwqFV0w== levn@^0.3.0, levn@~0.3.0: version "0.3.0"