diff --git a/docs/en_US/release_notes_3_1.rst b/docs/en_US/release_notes_3_1.rst index 9c5c1e1fe..039a6a071 100644 --- a/docs/en_US/release_notes_3_1.rst +++ b/docs/en_US/release_notes_3_1.rst @@ -14,4 +14,5 @@ Features Bug fixes ********* -| `Bug #3257 `_ - Catch errors when trying to EXPLAIN an invalid query +| `Bug #3179 `_ - Fix an error generating SQL for trigger functions +| `Bug #3257 `_ - Catch errors when trying to EXPLAIN an invalid query \ No newline at end of file diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/function/ppas/sql/default/get_definition.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/function/ppas/sql/default/get_definition.sql index 07f6a2cbc..5e5baef9f 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/function/ppas/sql/default/get_definition.sql +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/function/ppas/sql/default/get_definition.sql @@ -1,7 +1,10 @@ SELECT pg_get_functiondef({{fnid}}::oid) AS func_def, - nspname || '.' || pr.proname || '(' || COALESCE(pg_catalog.pg_get_function_identity_arguments(pr.oid), '') || ')' as name, - nspname || '.' || pr.proname || '(' || COALESCE(pg_catalog.pg_get_function_arguments(pr.oid), '') || ')' as name_with_default_args + COALESCE(pg_catalog.pg_get_function_identity_arguments(pr.oid), '') as + func_with_identity_arguments, + nspname, + pr.proname as proname, + COALESCE(pg_catalog.pg_get_function_arguments(pr.oid), '') as func_args FROM pg_proc pr JOIN diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/procedure/ppas/sql/default/get_definition.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/procedure/ppas/sql/default/get_definition.sql index 07f6a2cbc..5e5baef9f 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/procedure/ppas/sql/default/get_definition.sql +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/procedure/ppas/sql/default/get_definition.sql @@ -1,7 +1,10 @@ SELECT pg_get_functiondef({{fnid}}::oid) AS func_def, - nspname || '.' || pr.proname || '(' || COALESCE(pg_catalog.pg_get_function_identity_arguments(pr.oid), '') || ')' as name, - nspname || '.' || pr.proname || '(' || COALESCE(pg_catalog.pg_get_function_arguments(pr.oid), '') || ')' as name_with_default_args + COALESCE(pg_catalog.pg_get_function_identity_arguments(pr.oid), '') as + func_with_identity_arguments, + nspname, + pr.proname as proname, + COALESCE(pg_catalog.pg_get_function_arguments(pr.oid), '') as func_args FROM pg_proc pr JOIN diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/pg/sql/default/get_definition.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/pg/sql/default/get_definition.sql index 07f6a2cbc..5e5baef9f 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/pg/sql/default/get_definition.sql +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/pg/sql/default/get_definition.sql @@ -1,7 +1,10 @@ SELECT pg_get_functiondef({{fnid}}::oid) AS func_def, - nspname || '.' || pr.proname || '(' || COALESCE(pg_catalog.pg_get_function_identity_arguments(pr.oid), '') || ')' as name, - nspname || '.' || pr.proname || '(' || COALESCE(pg_catalog.pg_get_function_arguments(pr.oid), '') || ')' as name_with_default_args + COALESCE(pg_catalog.pg_get_function_identity_arguments(pr.oid), '') as + func_with_identity_arguments, + nspname, + pr.proname as proname, + COALESCE(pg_catalog.pg_get_function_arguments(pr.oid), '') as func_args FROM pg_proc pr JOIN diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/default/get_definition.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/default/get_definition.sql index 07f6a2cbc..5e5baef9f 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/default/get_definition.sql +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/default/get_definition.sql @@ -1,7 +1,10 @@ SELECT pg_get_functiondef({{fnid}}::oid) AS func_def, - nspname || '.' || pr.proname || '(' || COALESCE(pg_catalog.pg_get_function_identity_arguments(pr.oid), '') || ')' as name, - nspname || '.' || pr.proname || '(' || COALESCE(pg_catalog.pg_get_function_arguments(pr.oid), '') || ')' as name_with_default_args + COALESCE(pg_catalog.pg_get_function_identity_arguments(pr.oid), '') as + func_with_identity_arguments, + nspname, + pr.proname as proname, + COALESCE(pg_catalog.pg_get_function_arguments(pr.oid), '') as func_args FROM pg_proc pr JOIN