From ced296939f1231e5c1ef7bb48a2be45693609928 Mon Sep 17 00:00:00 2001 From: Aditya Toshniwal Date: Thu, 2 Jul 2020 16:06:16 +0530 Subject: [PATCH] =?UTF-8?q?Fixed=20an=20issue=20where=C2=A0the=20user=20is?= =?UTF-8?q?=20able=20to=20edit=20properties=20when=20some=20of=20the=20col?= =?UTF-8?q?lection=20nodes=20are=20selected.=20Fixes=20#5629?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- docs/en_US/release_notes_4_24.rst | 1 + web/pgadmin/browser/static/js/collection.js | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/docs/en_US/release_notes_4_24.rst b/docs/en_US/release_notes_4_24.rst index 3d4cce57e..19581cdf8 100644 --- a/docs/en_US/release_notes_4_24.rst +++ b/docs/en_US/release_notes_4_24.rst @@ -24,5 +24,6 @@ Bug fixes | `Issue #4235 `_ - Fixed tab indent issue on a selection of lines is deleting the content when 'use spaces == true' in the preferences. | `Issue #5530 `_ - Ensure that the referenced table should be displayed on foreign key constraints. | `Issue #5621 `_ - Remove extra brackets from reverse engineering SQL of RLS Policy. +| `Issue #5629 `_ - Fixed an issue where the user is able to edit properties when some of the collection nodes are selected. | `Issue #5630 `_ - Fixed an issue where installation of pgadmin4 not working on 32-bit Windows. | `Issue #5631 `_ - Fixed 'cant execute empty query' issue when remove the value of 'USING' or 'WITH CHECK' option of RLS Policy. \ No newline at end of file diff --git a/web/pgadmin/browser/static/js/collection.js b/web/pgadmin/browser/static/js/collection.js index 6be723d27..3207f7841 100644 --- a/web/pgadmin/browser/static/js/collection.js +++ b/web/pgadmin/browser/static/js/collection.js @@ -186,6 +186,10 @@ define([ headerCell: Backgrid.Extension.SelectAllHeaderCell, }); } + /* Columns should be always non-editable */ + gridSchema.columns.forEach((col)=>{ + col.disabled = true; + }); // Initialize a new Grid instance that.grid = new Backgrid.Grid({ emptyText: gettext('No data found'),