From ce31726af5badd4fbc419e157ecea7cb6de9df92 Mon Sep 17 00:00:00 2001 From: Harshal Dhumal Date: Wed, 17 Oct 2018 12:35:45 +0100 Subject: [PATCH] Fix connection garbage collector. Fixes #3700 --- docs/en_US/release_notes_3_5.rst | 1 + web/pgadmin/utils/driver/psycopg2/__init__.py | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/en_US/release_notes_3_5.rst b/docs/en_US/release_notes_3_5.rst index f5b152c17..2787bc1a0 100644 --- a/docs/en_US/release_notes_3_5.rst +++ b/docs/en_US/release_notes_3_5.rst @@ -20,3 +20,4 @@ Bug fixes | `Bug #3638 `_ - Fix syntax error when creating new pgAgent schedules with a start date/time and exception. | `Bug #3674 `_ - Cleanup session files periodically. | `Bug #3660 `_ - Rename the 'SQL Editor' section of the Preferences to 'Query Tool' as it applies to the whole tool, not just the editor. +| `Bug #3700 `_ - Fix connection garbage collector. \ No newline at end of file diff --git a/web/pgadmin/utils/driver/psycopg2/__init__.py b/web/pgadmin/utils/driver/psycopg2/__init__.py index 5fefdee7a..ad4ab7bf3 100644 --- a/web/pgadmin/utils/driver/psycopg2/__init__.py +++ b/web/pgadmin/utils/driver/psycopg2/__init__.py @@ -200,10 +200,10 @@ class Driver(BaseDriver): if sess == session.sid: sess_mgr['pinged'] = curr_time continue - if curr_time - sess_mgr['pinged'] >= session_idle_timeout: for mgr in [ - m for m in sess_mgr if isinstance(m, ServerManager) + m for m in sess_mgr.values() if isinstance(m, + ServerManager) ]: mgr.release()