From cdf49d6300f5051768311e5f56b68dd5154f138f Mon Sep 17 00:00:00 2001 From: Aditya Toshniwal Date: Tue, 30 Jan 2024 13:01:57 +0530 Subject: [PATCH] Fix failing feature tests --- web/pgadmin/misc/properties/ObjectNodeProperties.jsx | 4 ++-- .../static/js/components/QueryToolDataGrid/index.jsx | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/web/pgadmin/misc/properties/ObjectNodeProperties.jsx b/web/pgadmin/misc/properties/ObjectNodeProperties.jsx index bbcd17404..1e53706c1 100644 --- a/web/pgadmin/misc/properties/ObjectNodeProperties.jsx +++ b/web/pgadmin/misc/properties/ObjectNodeProperties.jsx @@ -216,13 +216,13 @@ export default function ObjectNodeProperties({panelId, node, treeNodeInfo, nodeD schema.filterGroups = [gettext('Security')]; } // Reset stale counter. - useEffect(()=> { + useMemo(()=> { staleCounter.current = 0; }, [nodeData?._id]); const key = useMemo(()=>{ // If node data is updated increase the counter to show updated data. - if(isStale){ + if(isStale) { staleCounter.current += 1; } if( actionType != 'properties' || isActive) { diff --git a/web/pgadmin/tools/sqleditor/static/js/components/QueryToolDataGrid/index.jsx b/web/pgadmin/tools/sqleditor/static/js/components/QueryToolDataGrid/index.jsx index d9b2f1155..f4b8840b7 100644 --- a/web/pgadmin/tools/sqleditor/static/js/components/QueryToolDataGrid/index.jsx +++ b/web/pgadmin/tools/sqleditor/static/js/components/QueryToolDataGrid/index.jsx @@ -73,12 +73,12 @@ function CustomRow(props) { const rowRef = useRef(); const dataGridExtras = useContext(DataGridExtrasContext); - const rowInfoValue = useMemo({ + const rowInfoValue = useMemo(()=>({ rowIdx: props.rowIdx, getCellElement: (colIdx)=>{ return rowRef.current?.querySelector(`.rdg-cell[aria-colindex="${colIdx+1}"]`); } - }, [props.rowIdx]); + }), [props.rowIdx]); if(!props.isRowSelected && props.selectedCellIdx > 0) { dataGridExtras.onSelectedCellChange?.([props.row, props.viewportColumns?.find(columns => columns.idx === props.selectedCellIdx)]);