From cccc6e56760317c8b046b51f5974b9cf22b32c15 Mon Sep 17 00:00:00 2001
From: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Date: Mon, 2 Dec 2019 14:15:31 +0530
Subject: [PATCH] Added role=status attribute to all the status messages for
 accessibility. Fixes #4773.

---
 docs/en_US/release_notes_4_16.rst                      |  1 +
 web/pgadmin/browser/static/js/node.js                  |  2 +-
 web/pgadmin/static/js/alertify.pgadmin.defaults.js     | 10 +++++-----
 web/pgadmin/static/js/sqleditor/filter_dialog.js       |  2 +-
 .../tools/user_management/static/js/user_management.js |  2 +-
 5 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/docs/en_US/release_notes_4_16.rst b/docs/en_US/release_notes_4_16.rst
index 74b4f7b9d..d4db6bf11 100644
--- a/docs/en_US/release_notes_4_16.rst
+++ b/docs/en_US/release_notes_4_16.rst
@@ -11,6 +11,7 @@ New features
 
 | `Issue #4396 <https://redmine.postgresql.org/issues/4396>`_ -  Warn the user on changing the definition of Materialized View about the loss of data and its dependent objects.
 | `Issue #4435 <https://redmine.postgresql.org/issues/4435>`_ -  Allow drag and drop functionality for all the nodes under the database node, excluding collection nodes.
+| `Issue #4773 <https://redmine.postgresql.org/issues/4773>`_ -  Added role="status" attribute to all the status messages for accessibility.
 
 Housekeeping
 ************
diff --git a/web/pgadmin/browser/static/js/node.js b/web/pgadmin/browser/static/js/node.js
index bad930417..fbce346f0 100644
--- a/web/pgadmin/browser/static/js/node.js
+++ b/web/pgadmin/browser/static/js/node.js
@@ -1103,7 +1103,7 @@ define('pgadmin.browser.node', [
 
       // Template function to create the status bar
       var createStatusBar = function(location) {
-          var statusBar = $('<div></div>').addClass(
+          var statusBar = $('<div role="status"></div>').addClass(
             'pg-prop-status-bar'
           ).appendTo(j);
           statusBar.css('visibility', 'hidden');
diff --git a/web/pgadmin/static/js/alertify.pgadmin.defaults.js b/web/pgadmin/static/js/alertify.pgadmin.defaults.js
index 38dc436fb..78ffb2139 100644
--- a/web/pgadmin/static/js/alertify.pgadmin.defaults.js
+++ b/web/pgadmin/static/js/alertify.pgadmin.defaults.js
@@ -127,7 +127,7 @@ define([
               alertMessage = '\
                   <div class="media text-danger text-14">\
                     <div class="media-body media-middle">\
-                      <div class="alert-text">' + promptmsg + '</div><br/>\
+                      <div class="alert-text" role="status">' + promptmsg + '</div><br/>\
                       <div class="alert-text">' + gettext('Click for details.') + '</div>\
                     </div>\
                   </div>';
@@ -172,7 +172,7 @@ define([
           var alertMessage = '\
                 <div class="media text-danger text-14">\
                   <div class="media-body media-middle">\
-                    <div class="alert-text">' + gettext('INTERNAL SERVER ERROR') + '</div><br/>\
+                    <div class="alert-text" role="status">' + gettext('INTERNAL SERVER ERROR') + '</div><br/>\
                     <div class="alert-text">' + gettext('Click for details.') + '</div>\
                   </div>\
                 </div>';
@@ -422,7 +422,7 @@ define([
         <div class="pr-2">
           <i class="fa fa-check text-success" aria-hidden="true"></i>
         </div>
-        <div class="text-body">${message}</div>
+        <div class="text-body" role="status">${message}</div>
       </div>`;
       return alertify.orig_success(alertMessage, timeout, callback);
     },
@@ -432,7 +432,7 @@ define([
         <div class="pr-2">
           <i class="fa fa-exclamation-triangle text-danger" aria-hidden="true"></i>
         </div>
-        <div class="text-body">${message}</div>
+        <div class="text-body" role="status">${message}</div>
       </div>`;
       return alertify.orig_error(alertMessage, timeout, callback);
     },
@@ -442,7 +442,7 @@ define([
         <div class="mr-3">
           <i class="fa fa-info text-primary" aria-hidden="true"></i>
         </div>
-        <div class="text-body">${message}</div>
+        <div class="text-body" role="status">${message}</div>
       </div>`;
       var alert = alertify.notify(alertMessage, timeout);
       return alert;
diff --git a/web/pgadmin/static/js/sqleditor/filter_dialog.js b/web/pgadmin/static/js/sqleditor/filter_dialog.js
index f5662ea5c..92ee6e0aa 100644
--- a/web/pgadmin/static/js/sqleditor/filter_dialog.js
+++ b/web/pgadmin/static/js/sqleditor/filter_dialog.js
@@ -128,7 +128,7 @@ let FilterDialog = {
               '      <div class="pr-2"> ' +
               '        <i class="fa fa-exclamation-triangle text-danger" aria-hidden="true"></i> ' +
               '      </div> ' +
-              '      <div class="alert-text"></div> ' +
+              '      <div class="alert-text" role="status"></div> ' +
               '    </div> ' +
               '  </div> ' +
               '</div>').appendTo($container);
diff --git a/web/pgadmin/tools/user_management/static/js/user_management.js b/web/pgadmin/tools/user_management/static/js/user_management.js
index 2423c5c61..ea65ca7ac 100644
--- a/web/pgadmin/tools/user_management/static/js/user_management.js
+++ b/web/pgadmin/tools/user_management/static/js/user_management.js
@@ -636,7 +636,7 @@ define([
                   '        <div class="pr-2"> ',
                   '          <i class="fa fa-exclamation-triangle text-danger" aria-hidden="true"></i> ',
                   '        </div> ',
-                  '        <div class="alert-text"></div> ',
+                  '        <div class="alert-text" role="status></div> ',
                   '        <div class="ml-auto close-error-bar"> ',
                   '          <a class="close-error fa fa-times text-danger"></a> ',
                   '        </div> ',