From c9500a51228f386565e2897d96314fa675d43331 Mon Sep 17 00:00:00 2001
From: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Date: Fri, 7 Feb 2020 11:13:41 +0530
Subject: [PATCH] =?UTF-8?q?Set=20proper=20focus=20on=20tab=20navigation=20?=
 =?UTF-8?q?for=20file=20manager=20dialog.=20Fixes=20#5107=C2=A0=20=20-=20S?=
 =?UTF-8?q?how=20focus=20when=20the=20Tab=20key=20is=20pressed=20=20-=20Pr?=
 =?UTF-8?q?essing=20the=20Enter=20key=20on=20C:\=20drive=20does=20not=20op?=
 =?UTF-8?q?en=20it=20on=20Windows?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 docs/en_US/release_notes.rst                  |  1 +
 docs/en_US/release_notes_4_19.rst             | 20 +++++++++++++++++++
 .../misc/file_manager/static/js/utility.js    |  4 ++--
 .../static/scss/_file_manager.scss            | 16 +++++++++++++++
 4 files changed, 39 insertions(+), 2 deletions(-)
 create mode 100644 docs/en_US/release_notes_4_19.rst

diff --git a/docs/en_US/release_notes.rst b/docs/en_US/release_notes.rst
index e1652ad9d..8641b4d90 100644
--- a/docs/en_US/release_notes.rst
+++ b/docs/en_US/release_notes.rst
@@ -11,6 +11,7 @@ notes for it.
 .. toctree::
    :maxdepth: 1
 
+   release_notes_4_19
    release_notes_4_18
    release_notes_4_17
    release_notes_4_16
diff --git a/docs/en_US/release_notes_4_19.rst b/docs/en_US/release_notes_4_19.rst
new file mode 100644
index 000000000..5cbf5b00a
--- /dev/null
+++ b/docs/en_US/release_notes_4_19.rst
@@ -0,0 +1,20 @@
+************
+Version 4.19
+************
+
+Release date: 2020-03-05
+
+This release contains a number of bug fixes and new features since the release of pgAdmin4 4.18.
+
+New features
+************
+
+
+Housekeeping
+************
+
+
+Bug fixes
+*********
+
+| `Issue #5107 <https://redmine.postgresql.org/issues/5107>`_ -  Set proper focus on tab navigation for file manager dialog.
\ No newline at end of file
diff --git a/web/pgadmin/misc/file_manager/static/js/utility.js b/web/pgadmin/misc/file_manager/static/js/utility.js
index 86d239989..2cc1aba87 100644
--- a/web/pgadmin/misc/file_manager/static/js/utility.js
+++ b/web/pgadmin/misc/file_manager/static/js/utility.js
@@ -748,8 +748,8 @@ define([
             return;
           if ($(this).find('.fa-file-text-o').length)
             $(this).click();
-          // If folder then first select and then double click to opn folder
-          else if ($(this).find('.fa-folder-open').length) {
+          // If folder then first select and then double click to open folder/drive
+          else if ($(this).find('.fa-folder-open').length || $(this).find('.fa-hdd-o').length) {
             $(this).click();
             setTimeout(() => { $(self).trigger('dblclick'); }, 10);
           }
diff --git a/web/pgadmin/misc/file_manager/static/scss/_file_manager.scss b/web/pgadmin/misc/file_manager/static/scss/_file_manager.scss
index cf6558350..24bd6c5f1 100644
--- a/web/pgadmin/misc/file_manager/static/scss/_file_manager.scss
+++ b/web/pgadmin/misc/file_manager/static/scss/_file_manager.scss
@@ -346,3 +346,19 @@ table.tablesorter {
     outline: $input-focus-border-color auto 5px !important;
   }
 }
+
+/* Specific to IE11 where we want to highlight the focus on grid/row  */
+@media all and (-ms-high-contrast: none), (-ms-high-contrast: active) {
+  table.tablesorter {
+    th:focus,
+    tr:focus {
+      border: 2px solid $input-focus-border-color !important;;
+    }
+  }
+
+  #contents {
+    li:focus {
+      border: 2px solid $input-focus-border-color !important;
+    }
+  }
+}