From c7686dee054ef8a77ace02c1c4e4eed65a475602 Mon Sep 17 00:00:00 2001 From: Surinder Kumar Date: Thu, 17 Aug 2017 16:35:42 +0530 Subject: [PATCH] Unset compression ratio if it is an empty string in Backup module. Fixes #2582 --- web/pgadmin/tools/backup/__init__.py | 4 ++++ web/pgadmin/tools/backup/static/js/backup.js | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/web/pgadmin/tools/backup/__init__.py b/web/pgadmin/tools/backup/__init__.py index cf561c3e6..6aa4e6978 100644 --- a/web/pgadmin/tools/backup/__init__.py +++ b/web/pgadmin/tools/backup/__init__.py @@ -360,6 +360,10 @@ def create_backup_objects_job(sid): else: data = json.loads(request.data, encoding='utf-8') + # Remove ratio from data in case of empty string + if 'ratio' in data and data['ratio'] == '': + data.pop("ratio") + try: backup_file = filename_with_file_manager_path(data['file']) except Exception as e: diff --git a/web/pgadmin/tools/backup/static/js/backup.js b/web/pgadmin/tools/backup/static/js/backup.js index c3fb2c6f4..2d24b8975 100644 --- a/web/pgadmin/tools/backup/static/js/backup.js +++ b/web/pgadmin/tools/backup/static/js/backup.js @@ -773,6 +773,12 @@ TODO LIST FOR BACKUP: ); } + // Remove ratio attribute from model if it has empty string. + // The valid value can be between 0 to 9. + if (_.isEmpty(this.view.model.get('ratio'))) { + this.view.model.unset('ratio'); + } + var self = this, baseUrl = url_for('backup.create_object_job', {'sid': treeInfo.server._id}), args = this.view.model.toJSON();