pgadmin-org
/
pgadmin4
mirror of https://github.com/pgadmin-org/pgadmin4.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Export job fails when deselecting all the columns. 

Select2 parameter 'first_empty' should be set to false for the controls of type array.
If it is true then on deselecting/clearing all the values, an empty entry is still there. 

Fixes #4751
pull/26/head
Akshay Joshi 2019-10-04 13:00:39 +05:30
parent 245a6e6f57
commit bf2c001c87
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/en_US/release_notes_4_14.rst
View File

@ -21,6 +21,7 @@ Bug fixes
********* *********
| `Issue #4199 <https://redmine.postgresql.org/issues/4199>`_ - Ensure that 'ENTER' key in the data filter should not run the query. | `Issue #4199 <https://redmine.postgresql.org/issues/4199>`_ - Ensure that 'ENTER' key in the data filter should not run the query.
| `Issue #4751 <https://redmine.postgresql.org/issues/4751>`_ - Fix issue where export job fails when deselecting all the columns.
| `Issue #4755 <https://redmine.postgresql.org/issues/4755>`_ - Ensure that pgAdmin should work behind reverse proxy if the inbuilt server is used as it is. | `Issue #4755 <https://redmine.postgresql.org/issues/4755>`_ - Ensure that pgAdmin should work behind reverse proxy if the inbuilt server is used as it is.
| `Issue #4756 <https://redmine.postgresql.org/issues/4756>`_ - Fix issue where pgAdmin does not load completely if loaded in an iframe. | `Issue #4756 <https://redmine.postgresql.org/issues/4756>`_ - Fix issue where pgAdmin does not load completely if loaded in an iframe.
| `Issue #4768 <https://redmine.postgresql.org/issues/4768>`_ - Ensure pgAdmin should work behind reverse proxy on a non standard port. | `Issue #4768 <https://redmine.postgresql.org/issues/4768>`_ - Ensure pgAdmin should work behind reverse proxy on a non standard port.

4
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/static/js/table.js
View File

@ -400,8 +400,8 @@ define('pgadmin.node.table', [
id: 'coll_inherits', label: gettext('Inherited from table(s)'), id: 'coll_inherits', label: gettext('Inherited from table(s)'),
url: 'get_inherits', type: 'array', group: gettext('Columns'), url: 'get_inherits', type: 'array', group: gettext('Columns'),
disabled: 'checkInheritance', deps: ['typname', 'is_partitioned'], disabled: 'checkInheritance', deps: ['typname', 'is_partitioned'],
mode: ['create', 'edit'], mode: ['create', 'edit'], first_empty: false,
select2: { multiple: true, allowClear: true, select2: { multiple: true, allowClear: true, first_empty: false,
placeholder: gettext('Select to inherit from...')}, placeholder: gettext('Select to inherit from...')},
transform: function(data, cell) { transform: function(data, cell) {
var control = cell || this, var control = cell || this,

3
web/pgadmin/tools/import_export/static/js/import_export.js
View File

@ -200,6 +200,7 @@ define([
select2: { select2: {
multiple: true, multiple: true,
allowClear: true, allowClear: true,
first_empty: false,
placeholder: gettext('Colums for exporting...'), placeholder: gettext('Colums for exporting...'),
preserveSelectionOrder: true, preserveSelectionOrder: true,
}, },
@ -251,7 +252,7 @@ define([
select2: { select2: {
multiple: true, multiple: true,
allowClear: true, allowClear: true,
first_empty: true, first_empty: false,
placeholder: gettext('Not null columns...'), placeholder: gettext('Not null columns...'),
}, },
helpMessage: gettext('Do not match the specified column values against the null string. In the default case where the null string is empty, this means that empty values will be read as zero-length strings rather than nulls, even when they are not quoted. This option is allowed only in import, and only when using CSV format.'), helpMessage: gettext('Do not match the specified column values against the null string. In the default case where the null string is empty, this means that empty values will be read as zero-length strings rather than nulls, even when they are not quoted. This option is allowed only in import, and only when using CSV format.'),