From a97e4c76e4aeac26fe9b37e0466b3d5a619bd04a Mon Sep 17 00:00:00 2001 From: Dave Page Date: Fri, 6 Apr 2018 10:06:35 +0100 Subject: [PATCH] Update developer docs to note that ES6 should be used and tests should be included. --- docs/en_US/code_review.rst | 3 +++ docs/en_US/coding_standards.rst | 3 +++ 2 files changed, 6 insertions(+) diff --git a/docs/en_US/code_review.rst b/docs/en_US/code_review.rst index 6539d1d1d..379caa4c0 100644 --- a/docs/en_US/code_review.rst +++ b/docs/en_US/code_review.rst @@ -9,6 +9,9 @@ review process for any patches submitted for inclusion in pgAdmin. * Ensure all code follows the pgAdmin :doc:`coding_standards`. +* Ensure all code has unit test coverage and API/feature test coverage where + appropriate. + * Copyright years must be correct and properly formatted (to make it easy to make bulk updates every year). The start date should always be 2013, and the end year the current year, e.g. diff --git a/docs/en_US/coding_standards.rst b/docs/en_US/coding_standards.rst index 330219b13..b4f0c6c22 100644 --- a/docs/en_US/coding_standards.rst +++ b/docs/en_US/coding_standards.rst @@ -106,6 +106,9 @@ Note the use of a descriptive function name, using the underscore character to separate words in all lower case, and short but descriptive lower case variable names. +.. note:: From version 3.0 onwards, new or refactored code should be written using + ES6 features and conventions. + C++ ---