From 97bd417ea815eafe03200a55ff5fa652126f5080 Mon Sep 17 00:00:00 2001 From: Yogesh Mahajan Date: Mon, 27 Mar 2023 11:51:28 +0530 Subject: [PATCH] Fixed intermittent failures for the role related feature tests. --- web/regression/feature_tests/xss_checks_roles_control_test.py | 3 ++- web/regression/feature_utils/pgadmin_page.py | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/web/regression/feature_tests/xss_checks_roles_control_test.py b/web/regression/feature_tests/xss_checks_roles_control_test.py index f67da1821..c9562991b 100644 --- a/web/regression/feature_tests/xss_checks_roles_control_test.py +++ b/web/regression/feature_tests/xss_checks_roles_control_test.py @@ -54,13 +54,14 @@ class CheckRoleMembershipControlFeatureTest(BaseFeatureTest): test_utils.drop_role(self.server, "postgres", self.xss_test_role) def _role_node_expandable(self, role): - retry = 3 + retry = 2 while retry > 0: if self.page.expand_server_child_node( "Server", self.server['name'], self.server['db_password'], 'Login/Group Roles'): retry = 0 else: + self.page.reset_layout() retry -= 1 role_node = self.page.check_if_element_exists_with_scroll( diff --git a/web/regression/feature_utils/pgadmin_page.py b/web/regression/feature_utils/pgadmin_page.py index e6c759733..86702d0bf 100644 --- a/web/regression/feature_utils/pgadmin_page.py +++ b/web/regression/feature_utils/pgadmin_page.py @@ -582,6 +582,7 @@ class PgadminPage: if not server_child_expanded: print("Child is not expanded after clicking ", file=sys.stderr) + return server_child_expanded else: print("The server/previous nodes not expanded", file=sys.stderr) return server_child_expanded