pgadmin-org
/
pgadmin4
mirror of https://github.com/pgadmin-org/pgadmin4.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Ensure browser should not be started by Selenium when feature tests are excluded from a test run. Fixes #4442

pull/25/head
Akshay Joshi 2019-07-08 17:38:06 +05:30
parent bd0e4a5a8f
commit 8c39b10d9c
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/en_US/release_notes_4_11.rst
View File

@ -26,4 +26,5 @@ Bug fixes
| `Issue #4393 <https://redmine.postgresql.org/issues/4393>`_ - Ensure parameter values are quoted when needed when editing roles. | `Issue #4393 <https://redmine.postgresql.org/issues/4393>`_ - Ensure parameter values are quoted when needed when editing roles.
| `Issue #4395 <https://redmine.postgresql.org/issues/4395>`_ - EXPLAIN options should be Query Tool instance-specific. | `Issue #4395 <https://redmine.postgresql.org/issues/4395>`_ - EXPLAIN options should be Query Tool instance-specific.
| `Issue #4429 <https://redmine.postgresql.org/issues/4429>`_ - Ensure drag/drop from the treeview works as expected on Firefox. | `Issue #4429 <https://redmine.postgresql.org/issues/4429>`_ - Ensure drag/drop from the treeview works as expected on Firefox.
| `Issue #4437 <https://redmine.postgresql.org/issues/4437>`_ - Fix table icon issue when updating any existing field. | `Issue #4437 <https://redmine.postgresql.org/issues/4437>`_ - Fix table icon issue when updating any existing field.
| `Issue #4442 <https://redmine.postgresql.org/issues/4442>`_ - Ensure browser should not be started by Selenium when feature tests are excluded from a test run.

4
web/regression/runtests.py
View File

@ -200,7 +200,9 @@ def get_test_modules(arguments):
if arguments['exclude'] is not None: if arguments['exclude'] is not None:
exclude_pkgs += arguments['exclude'].split(',') exclude_pkgs += arguments['exclude'].split(',')
if 'feature_tests' not in exclude_pkgs: if 'feature_tests' not in exclude_pkgs and \
(arguments['pkg'] == "all" or
arguments['pkg'] == "feature_tests"):
default_browser = 'chrome' default_browser = 'chrome'
# Check default browser provided through command line. If provided # Check default browser provided through command line. If provided