pgadmin-org
/
pgadmin4
mirror of https://github.com/pgadmin-org/pgadmin4.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed an issue when closing the view data second tab; it raises the error that the 'ViewCommand' object has no attribute 'auto_commit'. #7384

pull/7421/head
Khushboo Vashi 2024-04-23 14:45:15 +05:30
parent 3e0ade5a59
commit 84c024f6fa
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/en_US/release_notes_8_6.rst
View File

@ -36,4 +36,5 @@ Bug fixes
| `Issue #7275 <https://github.com/pgadmin-org/pgadmin4/issues/7275>`_ - Fixed an issue where debugger was not scrolling automatically on stepping. | `Issue #7275 <https://github.com/pgadmin-org/pgadmin4/issues/7275>`_ - Fixed an issue where debugger was not scrolling automatically on stepping.
| `Issue #7282 <https://github.com/pgadmin-org/pgadmin4/issues/7282>`_ - Fixed an XSS vulnerability in the /settings/store endpoint. | `Issue #7282 <https://github.com/pgadmin-org/pgadmin4/issues/7282>`_ - Fixed an XSS vulnerability in the /settings/store endpoint.
| `Issue #7294 <https://github.com/pgadmin-org/pgadmin4/issues/7294>`_ - Fixed an issue where double dollar quoted code is treated as string in syntax highlighter. | `Issue #7294 <https://github.com/pgadmin-org/pgadmin4/issues/7294>`_ - Fixed an issue where double dollar quoted code is treated as string in syntax highlighter.
| `Issue #7317 <https://github.com/pgadmin-org/pgadmin4/issues/7317>`_ - Fixed an issue where pressing backspace should remove the spaces and not the entire tab width, on enabling 'Use spaces?' in the preferences. | `Issue #7317 <https://github.com/pgadmin-org/pgadmin4/issues/7317>`_ - Fixed an issue where pressing backspace should remove the spaces and not the entire tab width, on enabling 'Use spaces?' in the preferences.
| `Issue #7384 <https://github.com/pgadmin-org/pgadmin4/issues/7384>`_ - Fixed an issue when closing the view data second tab; it raises the error that the 'ViewCommand' object has no attribute 'auto_commit'.

4
web/pgadmin/tools/sqleditor/__init__.py
View File

@ -690,7 +690,7 @@ def close_sqleditor_session(trans_id):
manager.release(did=cmd_obj.did, conn_id=cmd_obj.conn_id) manager.release(did=cmd_obj.did, conn_id=cmd_obj.conn_id)
# Close the auto complete connection # Close the auto complete connection
if cmd_obj.conn_id_ac is not None: if hasattr(cmd_obj, 'conn_id_ac') and cmd_obj.conn_id_ac is not None:
manager = get_driver( manager = get_driver(
PG_DEFAULT_DRIVER).connection_manager(cmd_obj.sid) PG_DEFAULT_DRIVER).connection_manager(cmd_obj.sid)
if manager is not None: if manager is not None:
@ -1735,7 +1735,7 @@ def check_and_upgrade_to_qt(trans_id, connect):
if 'gridData' in session and str(trans_id) in session['gridData']: if 'gridData' in session and str(trans_id) in session['gridData']:
data = pickle.loads(session['gridData'][str(trans_id)]['command_obj']) data = pickle.loads(session['gridData'][str(trans_id)]['command_obj'])
if data.object_type == 'table': if data.object_type == 'table' or data.object_type == 'view':
manager = get_driver(PG_DEFAULT_DRIVER).connection_manager( manager = get_driver(PG_DEFAULT_DRIVER).connection_manager(
data.sid) data.sid)
default_conn = manager.connection(conn_id=data.conn_id, default_conn = manager.connection(conn_id=data.conn_id,