From 60c8e5fe057571e160a511110cb34d226d921079 Mon Sep 17 00:00:00 2001 From: Aditya Toshniwal Date: Thu, 10 Jul 2025 15:35:02 +0530 Subject: [PATCH] Fixed an issue where windows installer is not signing tmp files generated by InnoSetup. #8420 Co-authored-by: stephannn --- Make.bat | 2 +- pkg/win32/installer.iss.in | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Make.bat b/Make.bat index bbc4ac4b6..8cb77563c 100644 --- a/Make.bat +++ b/Make.bat @@ -375,7 +375,7 @@ REM Main build sequence Ends :SIGN_INSTALLER ECHO Attempting to sign the installer... - CALL "%PGADMIN_SIGNTOOL_DIR%\signtool.exe" sign /fd certHash /tr http://timestamp.digicert.com /td SHA256 "%DISTROOT%\%INSTALLERNAME%" + CALL "%PGADMIN_INNOTOOL_DIR%\ISCC.exe" "%WD%\pkg\win32\installer.iss" "/Ssigntool=%PGADMIN_SIGNTOOL_DIR%\signtool.exe sign /fd certHash /tr http://timestamp.digicert.com /td SHA256 "%DISTROOT%\%INSTALLERNAME%" $f" IF %ERRORLEVEL% NEQ 0 ( ECHO. ECHO ************************************************************ diff --git a/pkg/win32/installer.iss.in b/pkg/win32/installer.iss.in index 004f1cd87..b9864369a 100644 --- a/pkg/win32/installer.iss.in +++ b/pkg/win32/installer.iss.in @@ -36,6 +36,7 @@ ArchitecturesInstallIn64BitMode={#MyAppArchitecturesMode} AllowNoIcons=yes WizardImageFile=sidebar.bmp MinVersion={#MinimumWindowsVer} +SignedUninstaller=yes [Languages] Name: "english"; MessagesFile: "compiler:Default.isl"