diff --git a/Make.bat b/Make.bat index c6e709ea3..478a5160f 100644 --- a/Make.bat +++ b/Make.bat @@ -324,11 +324,9 @@ REM Main build sequence Ends CD "%WD%\pkg\win32" ECHO Processing installer configuration script... - CALL "%PGADMIN_PYTHON_DIR%\python" "%WD%\pkg\win32\replace.py" "-i" "%WD%\pkg\win32\installer.iss.in" "-o" "%WD%\pkg\win32\installer.iss.in_stage1" "-s" MYAPP_NAME -r """%APP_NAME%""" - CALL "%PGADMIN_PYTHON_DIR%\python" "%WD%\pkg\win32\replace.py" "-i" "%WD%\pkg\win32\installer.iss.in_stage1" "-o" "%WD%\pkg\win32\installer.iss.in_stage2" "-s" MYAPP_FULLVERSION -r """%APP_VERSION%""" - CALL "%PGADMIN_PYTHON_DIR%\python" "%WD%\pkg\win32\replace.py" "-i" "%WD%\pkg\win32\installer.iss.in_stage2" "-o" "%WD%\pkg\win32\installer.iss.in_stage3" "-s" MYAPP_VERSION -r """v%APP_MAJOR%""" - CALL "%PGADMIN_PYTHON_DIR%\python" "%WD%\pkg\win32\replace.py" "-i" "%WD%\pkg\win32\installer.iss.in_stage3" "-o" "%WD%\pkg\win32\installer.iss.in_stage4" "-s" MYAPP_ARCHITECTURESMODE -r """x64""" - CALL "%PGADMIN_PYTHON_DIR%\python" "%WD%\pkg\win32\replace.py" "-i" "%WD%\pkg\win32\installer.iss.in_stage4" "-o" "%WD%\pkg\win32\installer.iss" "-s" MYAPP_VCDIST -r """%PGADMIN_VCREDIST_DIRNAME%\%VCREDIST_FILE%""" + CALL "%PGADMIN_PYTHON_DIR%\python" "%WD%\pkg\win32\replace.py" "-i" "%WD%\pkg\win32\installer.iss.in" "-o" "%WD%\pkg\win32\installer.iss.in_stage1" "-s" MYAPP_FULLVERSION -r """%APP_VERSION%""" + CALL "%PGADMIN_PYTHON_DIR%\python" "%WD%\pkg\win32\replace.py" "-i" "%WD%\pkg\win32\installer.iss.in_stage1" "-o" "%WD%\pkg\win32\installer.iss.in_stage2" "-s" MYAPP_VERSION -r """v%APP_MAJOR%""" + CALL "%PGADMIN_PYTHON_DIR%\python" "%WD%\pkg\win32\replace.py" "-i" "%WD%\pkg\win32\installer.iss.in_stage2" "-o" "%WD%\pkg\win32\installer.iss" "-s" MYAPP_VCDIST -r """%PGADMIN_VCREDIST_DIRNAME%\%VCREDIST_FILE%""" ECHO Cleaning up... DEL /s "%WD%\pkg\win32\installer.iss.in_stage*" > nul @@ -337,7 +335,7 @@ REM Main build sequence Ends CALL "%PGADMIN_INNOTOOL_DIR%\ISCC.exe" /q "%WD%\pkg\win32\installer.iss" || EXIT /B 1 ECHO Renaming installer... - MOVE "%WD%\pkg\win32\Output\Setup.exe" "%DISTROOT%\%INSTALLERNAME%" > nul || EXIT /B 1 + MOVE "%WD%\pkg\win32\Output\pgadmin4-setup.exe" "%DISTROOT%\%INSTALLERNAME%" > nul || EXIT /B 1 ECHO Location - %DISTROOT%\%INSTALLERNAME% ECHO Installer generated successfully. diff --git a/docs/en_US/release_notes_5_1.rst b/docs/en_US/release_notes_5_1.rst index ac6e310d7..678362718 100644 --- a/docs/en_US/release_notes_5_1.rst +++ b/docs/en_US/release_notes_5_1.rst @@ -20,5 +20,6 @@ Bug fixes | `Issue #4959 `_ - Fixed an issue where the properties tab for collection nodes is unresponsive after switching the tabs. | `Issue #5073 `_ - Fixed an issue where the Save button is enabled for functions/procedures by default when open the properties dialog. | `Issue #5467 `_ - Allow underscores in the Windows installation path. +| `Issue #5628 `_ - Remove the "launch now" option in the Windows installer, as UAC could cause it to run as an elevated user. | `Issue #6018 `_ - Fixed encoding issue when database encoding set to SQL_ASCII and name of the column is in ASCII character. | `Issue #6159 `_ - Ensure that the user should be able to kill the session from Dashboard if the user has a 'pg_signal_backend' role. diff --git a/pkg/win32/installer.iss.in b/pkg/win32/installer.iss.in index b539970ef..4ecdfb51c 100644 --- a/pkg/win32/installer.iss.in +++ b/pkg/win32/installer.iss.in @@ -1,11 +1,11 @@ -#define MyAppName MYAPP_NAME +#define MyAppName "pgAdmin 4" #define MyAppVersion MYAPP_VERSION #define MyAppPublisher "The pgAdmin Development Team" #define MyAppURL "www.pgadmin.org" #define MyAppExeName "pgAdmin4.exe" #define MyAppID "C14F64E7-DCB9-4DE1-8560-16F08FCFF64E" #define MyAppFullVersion MYAPP_FULLVERSION -#define MyAppArchitecturesMode MYAPP_ARCHITECTURESMODE +#define MyAppArchitecturesMode "x64" #define MyAppVCDist MYAPP_VCDIST #define MyAppInvalidPath "Please provide a valid path." #define MyAppErrorMsgIsWin32 "You already have a 32 bit installation of pgAdmin 4. Please uninstall this before installing the 64 bit version." @@ -19,12 +19,12 @@ AppPublisher={#MyAppPublisher} AppPublisherURL={#MyAppURL} AppSupportURL={#MyAppURL} AppUpdatesURL={#MyAppURL} -DefaultDirName={pf}\{#MyAppName}\{#MyAppVersion} +DefaultDirName={commonpf}\{#MyAppName}\{#MyAppVersion} DefaultGroupName={#MyAppName} DisableWelcomePage=no DisableProgramGroupPage=auto LicenseFile=Resources\license.rtf -OutputBaseFilename=setup +OutputBaseFilename=pgadmin4-setup SetupIconFile=Resources\pgAdmin4.ico Compression=lzma SolidCompression=yes @@ -55,7 +55,6 @@ Source: "..\..\win-build\*"; DestDir: "{app}"; Flags: ignoreversion recursesubdi [Run] Filename: "{app}\installer\{#MyAppVCDist}"; StatusMsg: "VC runtime redistributable package"; Parameters: "/passive /verysilent /norestart"; Check: InstallVC; -Filename: "{app}\runtime\{#MyAppExeName}"; Description: "{cm:LaunchProgram,{#StringChange(MyAppName, '&', '&&')}}"; Flags: runascurrentuser nowait postinstall skipifsilent [Registry] Root: HKLM; Subkey: "Software\{#MyAppName}\{#MyAppVersion}"; Flags: uninsdeletekeyifempty