Ensure that the tooltip is disabled for a password cell in a dialog grid. #9552

pull/9561/head
Akshay Joshi 2026-01-22 15:15:13 +05:30 committed by GitHub
parent 0cac007970
commit 31d1dbc697
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 13 additions and 5 deletions

View File

@ -26,6 +26,7 @@ Bundled PostgreSQL Utilities
New features
************
| `Issue #6451 <https://github.com/pgadmin-org/pgadmin4/issues/6451>`_ - Add new options like INHERIT and SET to the Role's membership tab.
| `Issue #8890 <https://github.com/pgadmin-org/pgadmin4/issues/8890>`_ - Add a new button in the query tool data output toolbar to get entire range of data.
| `Issue #9292 <https://github.com/pgadmin-org/pgadmin4/issues/9292>`_ - Enhance OAUTH2 and OIDC authentication support with improved claims handling and configuration options.
@ -52,3 +53,4 @@ Bug fixes
| `Issue #9380 <https://github.com/pgadmin-org/pgadmin4/issues/9380>`_ - Fixed an issue where the Query History panel would auto-scroll to the top and did not preserve the scroll bar position for the selected entry.
| `Issue #9500 <https://github.com/pgadmin-org/pgadmin4/issues/9500>`_ - Fixed an issue where connection parameters were using localized values instead of literal values, causing connection failures.
| `Issue #9518 <https://github.com/pgadmin-org/pgadmin4/issues/9518>`_ - Mask the secret key for restrict option in the process watcher when restoring plain SQL file.
| `Issue #9552 <https://github.com/pgadmin-org/pgadmin4/issues/9552>`_ - Ensure that the tooltip for the password cell is not visible.

View File

@ -98,7 +98,7 @@ export function getConnectionParameters() {
}, {
'value': 'sslkey', 'label': gettext('Client certificate key'), 'vartype': 'file'
}, {
'value': 'sslpassword', 'label': gettext('SSL password'), 'vartype': 'string',
'value': 'sslpassword', 'label': gettext('SSL password'), 'vartype': 'password',
'min_server_version': '13'
}, {
'value': 'sslrootcert', 'label': gettext('Root certificate'), 'vartype': 'file'

View File

@ -9,6 +9,7 @@
import { useContext, useMemo, useRef } from 'react';
import Draggable from 'react-draggable';
import { evalFunc } from 'sources/utils';
import { flexRender } from '@tanstack/react-table';
@ -71,9 +72,10 @@ export function DataGridRow({row, isResizing}) {
getValue: cell.getValue,
}
);
let cellObj = evalFunc(null, columnDef?.field?.cell, row.original);
return (
<PgReactTableCell cell={cell} row={row} key={cell.id}>
<PgReactTableCell cell={cell} row={row} key={cell.id}
disableTooltip={cellObj?.cell === 'password'}>
{content}
</PgReactTableCell>
);

View File

@ -167,7 +167,8 @@ export function PgReactTableCell(
row,
cell,
children,
className
className,
disableTooltip
}
) {
let classNames = ['pgrd-row-cell'];
@ -199,7 +200,9 @@ export function PgReactTableCell(
...(cell.column.columnDef.maxSize ? { maxWidth: `${cell.column.columnDef.maxSize}px` } : {})
}}
className={classNames.join(' ')}
title={typeof(cell.getValue()) === 'object' ? '' : String(cell.getValue() ?? '')}>
title={
disableTooltip ? '' : typeof(cell.getValue()) === 'object' ? '' : String(cell.getValue() ?? '')
}>
<div className='pgrd-row-cell-content'>{children}</div>
</div>
);
@ -211,6 +214,7 @@ PgReactTableCell.propTypes = {
cell: PropTypes.object,
children: CustomPropTypes.children,
className: PropTypes.any,
disableTooltip: PropTypes.bool,
};
export function PgReactTableRow (