diff --git a/docs/en_US/release_notes_8_9.rst b/docs/en_US/release_notes_8_9.rst index 6ae231291..b404f4588 100644 --- a/docs/en_US/release_notes_8_9.rst +++ b/docs/en_US/release_notes_8_9.rst @@ -35,8 +35,10 @@ Bug fixes | `Issue #7295 `_ - Fixed new line indentation in query editor and add a user preference to disable it. | `Issue #7306 `_ - Ensure that a user can connect to a server using SSL certificates and identity files from a shared storage. | `Issue #7414 `_ - Add support for comments on RLS policy object. + | `Issue #7476 `_ - Fixed an issue where changing a column name should reflect in all the constraints in table object dialog and ERD table dialog. | `Issue #7481 `_ - Fixed an issue where dark theme shows white background when all tabs are closed. | `Issue #7516 `_ - Ensure preferences can be loaded using preferences.json. | `Issue #7528 `_ - Fixed an issue where backslash breaks syntax highlighting. | `Issue #7536 `_ - Search Objects dialog should focus on search input on open. | `Issue #7555 `_ - Fixed an issue where query tool shortcuts for find/replace are not working. + | `Issue #7556 `_ - Fixed migration failure while using external database. \ No newline at end of file diff --git a/web/pgadmin/browser/server_groups/servers/databases/casts/static/js/cast.js b/web/pgadmin/browser/server_groups/servers/databases/casts/static/js/cast.js index 3a2efd655..68f7ba34f 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/casts/static/js/cast.js +++ b/web/pgadmin/browser/server_groups/servers/databases/casts/static/js/cast.js @@ -91,7 +91,7 @@ define('pgadmin.node.cast', [ resolve(data); }) .catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); } else { data = []; diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js index 782396a0e..1995428a8 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js @@ -100,7 +100,7 @@ function getRangeSchema(nodeObj, treeNodeInfo, itemNodeData) { data = res.data.data; resolve(data); }).catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); } else { resolve(data); @@ -127,7 +127,7 @@ function getRangeSchema(nodeObj, treeNodeInfo, itemNodeData) { data = res.data.data; resolve(data); }).catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); } else { resolve(data); @@ -155,7 +155,7 @@ function getRangeSchema(nodeObj, treeNodeInfo, itemNodeData) { data = res.data.data; resolve(data); }).catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); } else { resolve(data); diff --git a/web/pgadmin/browser/server_groups/servers/databases/subscriptions/static/js/subscription.js b/web/pgadmin/browser/server_groups/servers/databases/subscriptions/static/js/subscription.js index 9caddd7c0..4bbf6dc47 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/subscriptions/static/js/subscription.js +++ b/web/pgadmin/browser/server_groups/servers/databases/subscriptions/static/js/subscription.js @@ -112,7 +112,7 @@ define('pgadmin.node.subscription', [ } }) .catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); } }); diff --git a/web/pgadmin/browser/static/js/node_ajax.js b/web/pgadmin/browser/static/js/node_ajax.js index 7eb07878a..4a1fc112c 100644 --- a/web/pgadmin/browser/static/js/node_ajax.js +++ b/web/pgadmin/browser/static/js/node_ajax.js @@ -124,7 +124,7 @@ export function getNodeAjaxOptions(url, nodeObj, treeNodeInfo, itemNodeData, par otherParams.useCache && cacheNode.cache(nodeObj.type + '#' + url, treeNodeInfo, cacheLevel, data); resolve(transform(data)); }).catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error('Something went wrong')); }); } else { // To fetch only options from cache, we do not need time from 'at' diff --git a/web/pgadmin/misc/cloud/static/js/aws.js b/web/pgadmin/misc/cloud/static/js/aws.js index 509f2d708..d01fcb2ad 100644 --- a/web/pgadmin/misc/cloud/static/js/aws.js +++ b/web/pgadmin/misc/cloud/static/js/aws.js @@ -82,7 +82,7 @@ export function AwsInstanceDetails(props) { resolve(data); }) .catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); } else { resolve(options); diff --git a/web/pgadmin/misc/cloud/static/js/azure.js b/web/pgadmin/misc/cloud/static/js/azure.js index 44150ff67..a46bb0ecf 100644 --- a/web/pgadmin/misc/cloud/static/js/azure.js +++ b/web/pgadmin/misc/cloud/static/js/azure.js @@ -72,7 +72,7 @@ export function AzureCredentials(props) { }) .catch((error)=>{ clearInterval(interval); - reject(new Error(error)); + reject(error instanceof Error ? error : Error(gettext('Something went wrong'))); }); }, 1000); }); diff --git a/web/pgadmin/misc/cloud/static/js/azure_schema.ui.js b/web/pgadmin/misc/cloud/static/js/azure_schema.ui.js index 8de4e49ca..de1a059b4 100644 --- a/web/pgadmin/misc/cloud/static/js/azure_schema.ui.js +++ b/web/pgadmin/misc/cloud/static/js/azure_schema.ui.js @@ -122,7 +122,7 @@ class AzureCredSchema extends BaseUISchema { })); }) .catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); } }); @@ -152,7 +152,7 @@ class AzureCredSchema extends BaseUISchema { }); }) .catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); } }); diff --git a/web/pgadmin/misc/cloud/static/js/google.js b/web/pgadmin/misc/cloud/static/js/google.js index 094e2f30c..04ddcb981 100644 --- a/web/pgadmin/misc/cloud/static/js/google.js +++ b/web/pgadmin/misc/cloud/static/js/google.js @@ -87,7 +87,7 @@ export function GoogleCredentials(props) { }) .catch((error)=>{ clearInterval(interval); - reject(new Error(error)); + reject(error instanceof Error ? error : Error(gettext('Something went wrong'))); }); countdown = countdown - 1; }, 1000); diff --git a/web/pgadmin/misc/cloud/static/js/google_schema.ui.js b/web/pgadmin/misc/cloud/static/js/google_schema.ui.js index 0d73d576c..b6d75c60c 100644 --- a/web/pgadmin/misc/cloud/static/js/google_schema.ui.js +++ b/web/pgadmin/misc/cloud/static/js/google_schema.ui.js @@ -68,13 +68,13 @@ class GoogleCredSchema extends BaseUISchema{ resolve(); }) .catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); } }); }) .catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); } }); diff --git a/web/pgadmin/misc/properties/ObjectNodeProperties.jsx b/web/pgadmin/misc/properties/ObjectNodeProperties.jsx index 700e090e6..8b02d590e 100644 --- a/web/pgadmin/misc/properties/ObjectNodeProperties.jsx +++ b/web/pgadmin/misc/properties/ObjectNodeProperties.jsx @@ -87,7 +87,7 @@ export default function ObjectNodeProperties({panelId, node, treeNodeInfo, nodeD } else if (msg == 'CRYPTKEY_NOT_SET') { reject(new Error(gettext('The master password is not set.'))); } - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); }) @@ -116,7 +116,7 @@ export default function ObjectNodeProperties({panelId, node, treeNodeInfo, nodeD } else if (msg == 'CRYPTKEY_NOT_SET') { reject(new Error(gettext('The master password is not set.'))); } - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); }); }); @@ -133,7 +133,7 @@ export default function ObjectNodeProperties({panelId, node, treeNodeInfo, nodeD resolve(res.data.data); }).catch((err)=>{ onError(err); - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); }); }; diff --git a/web/pgadmin/preferences/static/js/components/PreferencesComponent.jsx b/web/pgadmin/preferences/static/js/components/PreferencesComponent.jsx index 440395e4b..085eb32a0 100644 --- a/web/pgadmin/preferences/static/js/components/PreferencesComponent.jsx +++ b/web/pgadmin/preferences/static/js/components/PreferencesComponent.jsx @@ -114,7 +114,7 @@ function RightPanel({ schema, ...props }) { try { resolve(props.initValues); } catch (error) { - reject(new Error(error)); + reject(error instanceof Error ? error : Error(gettext('Something went wrong'))); } }); diff --git a/web/pgadmin/static/js/Dialogs/index.jsx b/web/pgadmin/static/js/Dialogs/index.jsx index 4b97234da..81e17042f 100644 --- a/web/pgadmin/static/js/Dialogs/index.jsx +++ b/web/pgadmin/static/js/Dialogs/index.jsx @@ -210,7 +210,7 @@ export function showChangeServerPassword() { onClose(); }) .catch((error)=>{ - reject(new Error(error)); + reject(error instanceof Error ? error : Error(gettext('Something went wrong'))); }); }); }} @@ -237,7 +237,7 @@ export function showChangeUserPassword(url) { resolve(res.data); }) .catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); }); }} @@ -263,7 +263,7 @@ export function showChangeUserPassword(url) { onClose(); pgAdmin.Browser.notifier.success(res.data.info); }).catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); }); }} @@ -336,7 +336,7 @@ export function showChangeOwnership() { resolve(respData.data); }) .catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); } }); diff --git a/web/pgadmin/static/js/UtilityView.jsx b/web/pgadmin/static/js/UtilityView.jsx index a0ff82a0e..000d7d427 100644 --- a/web/pgadmin/static/js/UtilityView.jsx +++ b/web/pgadmin/static/js/UtilityView.jsx @@ -95,7 +95,7 @@ function UtilityViewContent({panelId, schema, treeNodeInfo, actionType, formType onSave?.(res.data); onClose(); }).catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); }); @@ -111,7 +111,7 @@ function UtilityViewContent({panelId, schema, treeNodeInfo, actionType, formType resolve(res.data.data); }).catch((err)=>{ onError(err); - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); }); }; @@ -161,7 +161,7 @@ function UtilityViewContent({panelId, schema, treeNodeInfo, actionType, formType } else if(err.message){ console.error('error msg', err.message); } - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); } diff --git a/web/pgadmin/static/js/csrf.js b/web/pgadmin/static/js/csrf.js index 7818f06d1..e1ff53702 100644 --- a/web/pgadmin/static/js/csrf.js +++ b/web/pgadmin/static/js/csrf.js @@ -22,7 +22,7 @@ export function setPGCSRFToken(header, token) { return config; }, function (error) { - return Promise.reject(new Error(error)); + return Promise.reject(error instanceof Error ? error : Error('Something went wrong')); }); } diff --git a/web/pgadmin/static/js/socket_instance.js b/web/pgadmin/static/js/socket_instance.js index 292b621fc..512368511 100644 --- a/web/pgadmin/static/js/socket_instance.js +++ b/web/pgadmin/static/js/socket_instance.js @@ -27,10 +27,10 @@ export function openSocket(namespace, options) { resolve(socketObj); }); socketObj.on('connect_error', (err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); socketObj.on('disconnect', (err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); }); } diff --git a/web/pgadmin/tools/backup/static/js/backup.js b/web/pgadmin/tools/backup/static/js/backup.js index e046df650..8c47a3dd4 100644 --- a/web/pgadmin/tools/backup/static/js/backup.js +++ b/web/pgadmin/tools/backup/static/js/backup.js @@ -265,7 +265,7 @@ define([ }).then((response)=> { resolve(response.data.data); }).catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); }); }} diff --git a/web/pgadmin/tools/debugger/static/js/components/DebuggerArgumentComponent.jsx b/web/pgadmin/tools/debugger/static/js/components/DebuggerArgumentComponent.jsx index 8b7f4aef7..f537b2b68 100644 --- a/web/pgadmin/tools/debugger/static/js/components/DebuggerArgumentComponent.jsx +++ b/web/pgadmin/tools/debugger/static/js/components/DebuggerArgumentComponent.jsx @@ -429,7 +429,7 @@ export default function DebuggerArgumentComponent({ debuggerInfo, restartDebug, try { resolve(debuggerArgsData.current); } catch (error) { - reject(new Error(error)); + reject(error instanceof Error ? error : Error(gettext('Something went wrong'))); } }); diff --git a/web/pgadmin/tools/erd/static/js/erd_tool/components/ERDTool.jsx b/web/pgadmin/tools/erd/static/js/erd_tool/components/ERDTool.jsx index c3c85d010..df43cee5a 100644 --- a/web/pgadmin/tools/erd/static/js/erd_tool/components/ERDTool.jsx +++ b/web/pgadmin/tools/erd/static/js/erd_tool/components/ERDTool.jsx @@ -486,7 +486,7 @@ export default class ERDTool extends React.Component { }) .catch((err)=>{ console.error(err); - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); }); const {x, y} = this.diagram.getEngine().getRelativeMousePoint(e); diff --git a/web/pgadmin/tools/search_objects/static/js/SearchObjects.jsx b/web/pgadmin/tools/search_objects/static/js/SearchObjects.jsx index d42bd7aed..77182d157 100644 --- a/web/pgadmin/tools/search_objects/static/js/SearchObjects.jsx +++ b/web/pgadmin/tools/search_objects/static/js/SearchObjects.jsx @@ -388,11 +388,11 @@ export default function SearchObjects({nodeData}) { }) .catch((err)=>{ pgAdmin.Browser.notifier.error(parseApiError(err)); - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); } catch (error) { pgAdmin.Browser.notifier.error(parseApiError(error)); - reject(new Error(error)); + reject(error instanceof Error ? error : Error(gettext('Something went wrong'))); } }); }; diff --git a/web/pgadmin/tools/sqleditor/static/js/components/QueryToolComponent.jsx b/web/pgadmin/tools/sqleditor/static/js/components/QueryToolComponent.jsx index c53501a45..8370672f6 100644 --- a/web/pgadmin/tools/sqleditor/static/js/components/QueryToolComponent.jsx +++ b/web/pgadmin/tools/sqleditor/static/js/components/QueryToolComponent.jsx @@ -721,7 +721,7 @@ export default function QueryToolComponent({params, pgWindow, pgAdmin, selectedN }); } else { selectConn(currSelectedConn, currConnected, false); - reject(new Error(error)); + reject(error instanceof Error ? error : Error(gettext('Something went wrong'))); } }); }); @@ -763,7 +763,7 @@ export default function QueryToolComponent({params, pgWindow, pgAdmin, selectedN } updateQueryToolConnection(connectionData, true) .catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }).then(()=>{ resolve(); onClose(); diff --git a/web/pgadmin/tools/sqleditor/static/js/components/dialogs/FilterDialog.jsx b/web/pgadmin/tools/sqleditor/static/js/components/dialogs/FilterDialog.jsx index fa7fbee78..f923459c8 100644 --- a/web/pgadmin/tools/sqleditor/static/js/components/dialogs/FilterDialog.jsx +++ b/web/pgadmin/tools/sqleditor/static/js/components/dialogs/FilterDialog.jsx @@ -88,7 +88,7 @@ export default function FilterDialog({onClose, onSave}) { filterSchemaObj.setColumnOptions((columns||[]).map((c)=>({label: c, value: c}))); resolve(filterData); } catch (error) { - reject(new Error(error)); + reject(error instanceof Error ? error : Error(gettext('Something went wrong'))); } }; getFilterData(); @@ -109,7 +109,7 @@ export default function FilterDialog({onClose, onSave}) { reject(new Error(respData.data.result)); } } catch (error) { - reject(new Error(error)); + reject(error instanceof Error ? error : Error(gettext('Something went wrong'))); } }; setFilterData(); diff --git a/web/pgadmin/tools/sqleditor/static/js/components/dialogs/MacrosDialog.jsx b/web/pgadmin/tools/sqleditor/static/js/components/dialogs/MacrosDialog.jsx index 796d5f42b..bea41a229 100644 --- a/web/pgadmin/tools/sqleditor/static/js/components/dialogs/MacrosDialog.jsx +++ b/web/pgadmin/tools/sqleditor/static/js/components/dialogs/MacrosDialog.jsx @@ -169,7 +169,7 @@ export default function MacrosDialog({onClose, onSave}) { onSave(respData.filter((m) => Boolean(m.name))); onClose(); } catch (error) { - reject(new Error(error)); + reject(error instanceof Error ? error : Error(gettext('Something went wrong'))); } }; setMacros(); diff --git a/web/pgadmin/tools/sqleditor/static/js/components/dialogs/NewConnectionDialog.jsx b/web/pgadmin/tools/sqleditor/static/js/components/dialogs/NewConnectionDialog.jsx index 1f406bbef..64ae997c2 100644 --- a/web/pgadmin/tools/sqleditor/static/js/components/dialogs/NewConnectionDialog.jsx +++ b/web/pgadmin/tools/sqleditor/static/js/components/dialogs/NewConnectionDialog.jsx @@ -75,7 +75,7 @@ class NewConnectionSchema extends BaseUISchema { resolve(groupedOptions); }) .catch((error)=>{ - reject(new Error(error)); + reject(error instanceof Error ? error : Error(gettext('Something went wrong'))); }); }); } @@ -97,7 +97,7 @@ class NewConnectionSchema extends BaseUISchema { resolve(respData.data.result.data); }) .catch((error)=>{ - reject(new Error(error)); + reject(error instanceof Error ? error : Error(gettext('Something went wrong'))); }); }); } diff --git a/web/pgadmin/tools/sqleditor/static/js/components/sections/Query.jsx b/web/pgadmin/tools/sqleditor/static/js/components/sections/Query.jsx index ab8c4c410..178c011ad 100644 --- a/web/pgadmin/tools/sqleditor/static/js/components/sections/Query.jsx +++ b/web/pgadmin/tools/sqleditor/static/js/components/sections/Query.jsx @@ -50,7 +50,7 @@ async function registerAutocomplete(editor, api, transId) { }) .catch((err) => { onAvailable(); - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); }); }); diff --git a/web/pgadmin/tools/user_management/static/js/UserManagementDialog.jsx b/web/pgadmin/tools/user_management/static/js/UserManagementDialog.jsx index 6ea2f6ea8..d9bc27e7a 100644 --- a/web/pgadmin/tools/user_management/static/js/UserManagementDialog.jsx +++ b/web/pgadmin/tools/user_management/static/js/UserManagementDialog.jsx @@ -364,7 +364,7 @@ function UserManagementDialog({onClose}) { onClose(); }) .catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); } catch (error) { reject(parseApiError(error)); @@ -402,7 +402,7 @@ function UserManagementDialog({onClose}) { resolve({userManagement:res.data}); }) .catch((err)=>{ - reject(new Error(err)); + reject(err instanceof Error ? err : Error(gettext('Something went wrong'))); }); }); }} schema={new UserManagementSchema(authSourcesOptions, roleOptions)}