diff --git a/docs/en_US/release_notes_4_1.rst b/docs/en_US/release_notes_4_1.rst index 600f3e061..e34536bcc 100644 --- a/docs/en_US/release_notes_4_1.rst +++ b/docs/en_US/release_notes_4_1.rst @@ -14,6 +14,7 @@ Features Bug fixes ********* +| `Bug #3505 `_ - Fix SQL generated for tables with inherited columns. | `Bug #3575 `_ - Ensure the context menu works after a server is renamed. | `Bug #3836 `_ - Fix ordering of VACUUM options which changed in PG11. | `Bug #3842 `_ - Don't show system catalogs in the schemas property list unless show system objects is enabled. diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/default/create.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/default/create.sql index 8ea1b762b..82501a914 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/default/create.sql +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/default/create.sql @@ -41,10 +41,10 @@ CREATE {% if data.relpersistence %}UNLOGGED {% endif %}TABLE {{conn|qtIdent(data {### Add columns ###} {% if data.columns and data.columns|length > 0 %} {% for c in data.columns %} -{% if c.name and c.cltype %} -{% if loop.index != 1 %}, -{% endif %} +{% if c.name and c.cltype and not c.inheritedfrom %} {{conn|qtIdent(c.name)}} {% if is_sql %}{{c.displaytypname}}{% else %}{{ GET_TYPE.CREATE_TYPE_SQL(conn, c.cltype, c.attlen, c.attprecision, c.hasSqrBracket) }}{% endif %}{% if c.collspcname %} COLLATE {{c.collspcname}}{% endif %}{% if c.attnotnull %} NOT NULL{% endif %}{% if c.defval %} DEFAULT {{c.defval}}{% endif %} +{% if not loop.last %}, +{% endif %} {% endif %} {% endfor %} {% endif %} diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/default/sql.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/default/sql.sql deleted file mode 100644 index 17b35aede..000000000 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/default/sql.sql +++ /dev/null @@ -1 +0,0 @@ -TAKE ASHESH'S HELP ON THIS TASK :-) \ No newline at end of file diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/gpdb_5.0_plus/create.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/gpdb_5.0_plus/create.sql index 61e4e1e11..c82e72cc1 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/gpdb_5.0_plus/create.sql +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/gpdb_5.0_plus/create.sql @@ -41,10 +41,10 @@ CREATE {% if data.relpersistence %}UNLOGGED {% endif %}TABLE {{conn|qtIdent(data {### Add columns ###} {% if data.columns and data.columns|length > 0 %} {% for c in data.columns %} -{% if c.name and c.cltype %} -{% if loop.index != 1 %}, -{% endif %} +{% if c.name and c.cltype and not c.inheritedfrom %} {{conn|qtIdent(c.name)}} {% if is_sql %}{{c.displaytypname}}{% else %}{{ GET_TYPE.CREATE_TYPE_SQL(conn, c.cltype, c.attlen, c.attprecision, c.hasSqrBracket) }}{% endif %}{% if c.collspcname %} COLLATE {{c.collspcname}}{% endif %}{% if c.attnotnull %} NOT NULL{% endif %}{% if c.defval %} DEFAULT {{c.defval}}{% endif %} +{% if not loop.last %}, +{% endif %} {% endif %} {% endfor %} {% endif %}