diff --git a/docs/en_US/release_notes_4_18.rst b/docs/en_US/release_notes_4_18.rst index e0ede32da..3f55f27e7 100644 --- a/docs/en_US/release_notes_4_18.rst +++ b/docs/en_US/release_notes_4_18.rst @@ -13,6 +13,9 @@ New features | `Issue #3452 `_ - Added a Schema Diff tool to compare two schemas and generate a diff script. | `Issue #4762 `_ - Allow screen-reader to read label & description of non-textable elements. | `Issue #4763 `_ - Allow screen-reader to identify the alert errors. +| `Issue #4770 `_ - Added labels and titles after parsing and validating all the pgAdmin4 web pages for accessibility. +| `Issue #4993 `_ - Set input controls as read-only instead of disabled will allow tab navigation in the properties tab and also allow screen readers to read it. + Housekeeping ************ @@ -30,11 +33,11 @@ Bug fixes | `Issue #4410 `_ - Fixed an issue while editing char[] or character varying[] column from View/Edit data throwing an error. | `Issue #4511 `_ - Fixed an issue where Grant wizard unable to handle multiple objects when the query string parameter exceeds its limit. | `Issue #4827 `_ - Fix column resizable issue in the file explorer dialog. -| `Issue #4993 `_ - Set input controls as read-only instead of disabled will allow tab navigation in the properties tab and also allow screen readers to read it. | `Issue #5000 `_ - Logout the pgAdmin session when no user activity of mouse move, click or keypress. | `Issue #5025 `_ - Fix an issue where setting STORAGE_DIR to empty should show all the volumes on Windows in server mode. | `Issue #5065 `_ - Updated the incorrect icon used for the cast node on refresh. | `Issue #5066 `_ - Fix an issue where refreshing a package results in the change in the object completely. | `Issue #5074 `_ - Fix an issue where select, insert and update scripts on tables throwing an error. | `Issue #5076 `_ - Ensure Postfix starts in the container, now it runs as non-root by default. -| `Issue #5107 `_ - Set proper focus on tab navigation for file manager dialog. \ No newline at end of file +| `Issue #5107 `_ - Set proper focus on tab navigation for file manager dialog. +| `Issue #5116 `_ - Fixed an issue where Save Password control disappears after clicking on it while creating a server. \ No newline at end of file diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/static/js/schema.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/static/js/schema.js index 8685bb5cd..23d02ca83 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/static/js/schema.js +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/static/js/schema.js @@ -71,7 +71,7 @@ define('pgadmin.node.schema', [ var gridHeader = _.template([ '
', - ' ', + ' <%-label%>', '
'].join('\n')), gridBody = $('
').append( gridHeader(attributes) diff --git a/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js b/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js index 1fa0ed2f7..317a83913 100644 --- a/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js +++ b/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js @@ -89,7 +89,7 @@ define('pgadmin.node.role', [ template: _.template([ '', '
', - ' multiple="multiple" style="width:100%;" class="pgadmin-controls <%=extraClasses.join(\' \')%>" name="<%=name%>" value="<%-JSON.stringify(value)%>" <%=disabled ? "disabled" : ""%> <%=required ? "required" : ""%>>', ' <% for (var i=0; i < options.length; i++) { %>', ' <% var option = options[i]; %>', ' ', diff --git a/web/pgadmin/browser/server_groups/servers/static/js/variable.js b/web/pgadmin/browser/server_groups/servers/static/js/variable.js index 5d47ff0b3..329967e08 100644 --- a/web/pgadmin/browser/server_groups/servers/static/js/variable.js +++ b/web/pgadmin/browser/server_groups/servers/static/js/variable.js @@ -337,8 +337,8 @@ function(gettext, _, $, Backbone, Backform, Backgrid, Alertify, pgAdmin, pgNode) var self = this, titleTmpl = _.template([ '
', - '', - '', + '<%-label%>', + '', '
'].join('\n')), $gridBody = $('
').append( diff --git a/web/pgadmin/browser/static/js/browser.js b/web/pgadmin/browser/static/js/browser.js index c468e7ecb..64e949b14 100644 --- a/web/pgadmin/browser/static/js/browser.js +++ b/web/pgadmin/browser/static/js/browser.js @@ -226,7 +226,7 @@ define('pgadmin.browser', [ width: 500, isCloseable: false, isPrivate: true, - content: '
', + content: '
', }), // Dependencies of the object 'dependencies': new pgAdmin.Browser.Panel({ diff --git a/web/pgadmin/browser/static/js/collection.js b/web/pgadmin/browser/static/js/collection.js index 951106886..89beb6ca1 100644 --- a/web/pgadmin/browser/static/js/collection.js +++ b/web/pgadmin/browser/static/js/collection.js @@ -99,7 +99,7 @@ define([ '', + '<% if (label != "") { %> <%-label%><% } %><%-tooltip%>', ].join(' ')); if (location == 'header') { btnGroup.appendTo(that.header); @@ -165,9 +165,9 @@ define([ // canDrop can be set to false for individual row from the server side to disable the checkbox if ('canDrop' in model && model.canDrop === false) - this.$el.empty().append(''); + this.$el.empty().append(''); else - this.$el.empty().append(''); + this.$el.empty().append(''); this.delegateEvents(); return this; diff --git a/web/pgadmin/browser/static/js/menu.js b/web/pgadmin/browser/static/js/menu.js index f40c06e30..e716b1e86 100644 --- a/web/pgadmin/browser/static/js/menu.js +++ b/web/pgadmin/browser/static/js/menu.js @@ -208,7 +208,7 @@ define([ pgAdmin.Browser.MenuGroup = function(opts, items, prev, ctx) { var template = _.template([ '<% if (above) { %><% } %>', - '