From 0f62fecca2f581c7da9fcca625dc8a7d57edebd4 Mon Sep 17 00:00:00 2001 From: Akshay Joshi Date: Tue, 9 Mar 2021 14:32:16 +0530 Subject: [PATCH] Fixed an issue where the dependent tab throwing an error when selecting any login/group role. Fixes #6294 --- docs/en_US/release_notes_5_1.rst | 1 + web/pgadmin/browser/server_groups/servers/databases/__init__.py | 2 +- web/pgadmin/browser/server_groups/servers/roles/__init__.py | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/en_US/release_notes_5_1.rst b/docs/en_US/release_notes_5_1.rst index 314d2fa89..48c01cf3b 100644 --- a/docs/en_US/release_notes_5_1.rst +++ b/docs/en_US/release_notes_5_1.rst @@ -39,3 +39,4 @@ Bug fixes | `Issue #6279 `_ - Ensure that the venv activation scripts have the correct path in them on Linux. | `Issue #6281 `_ - Fixed an issue where schema diff showing wrong SQL when comparing triggers with different when clause. | `Issue #6286 `_ - Ensure that the template database should be visible while creating the database. +| `Issue #6294 `_ - Fixed an issue where the dependent tab throwing an error when selecting any login/group role. diff --git a/web/pgadmin/browser/server_groups/servers/databases/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/__init__.py index 55e00898e..60af1de42 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/__init__.py +++ b/web/pgadmin/browser/server_groups/servers/databases/__init__.py @@ -375,7 +375,7 @@ class DatabaseView(PGChildNodeView): if self.manager.db == db: connected = True else: - conn = self.manager.connection(row['name']) + conn = self.manager.connection(database=row['name']) connected = conn.connected() icon_css_class = "pg-icon-database" if not connected: diff --git a/web/pgadmin/browser/server_groups/servers/roles/__init__.py b/web/pgadmin/browser/server_groups/servers/roles/__init__.py index b62e7fe38..ca08b9791 100644 --- a/web/pgadmin/browser/server_groups/servers/roles/__init__.py +++ b/web/pgadmin/browser/server_groups/servers/roles/__init__.py @@ -1106,7 +1106,7 @@ rolmembership:{ # a new connection to run the query and fetch the dependents. is_connected = True try: - temp_conn = manager.connection(db_row['datname']) + temp_conn = manager.connection(database=db_row['datname']) is_connected = temp_conn.connected() if not is_connected: temp_conn.connect()