pgadmin-org
/
pgadmin4
mirror of https://github.com/pgadmin-org/pgadmin4.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

1) Fixed an issue where the Cancel button did not work when attempting to delete a user from the User Management. 

2) Fixed an issue where automatic user creation via LDAP failed if an existing Internal user with the same username was already present.
pull/8682/head
Akshay Joshi 2025-05-09 13:28:23 +05:30
parent 97984eb3ec
commit 0403079a4b
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/en_US/release_notes_9_4.rst
View File

@ -31,6 +31,7 @@ Bug fixes
********* *********
| `Issue #6564 <https://github.com/pgadmin-org/pgadmin4/issues/6564>`_ - Fix the issue where an error is displayed when a table is dropped while a query is running. | `Issue #6564 <https://github.com/pgadmin-org/pgadmin4/issues/6564>`_ - Fix the issue where an error is displayed when a table is dropped while a query is running.
| `Issue #8595 <https://github.com/pgadmin-org/pgadmin4/issues/8595>`_ - Enhance contrast for selected and hovered items in the Object Explorer to improve visibility and accessibility.
| `Issue #8607 <https://github.com/pgadmin-org/pgadmin4/issues/8607>`_ - Fixed an issue where the query tool returns "cannot unpack non-iterable Response object" when running any query with a database name change. | `Issue #8607 <https://github.com/pgadmin-org/pgadmin4/issues/8607>`_ - Fixed an issue where the query tool returns "cannot unpack non-iterable Response object" when running any query with a database name change.
| `Issue #8668 <https://github.com/pgadmin-org/pgadmin4/issues/8668>`_ - Implement API fetch error display for select dropdown. | `Issue #8668 <https://github.com/pgadmin-org/pgadmin4/issues/8668>`_ - Implement API fetch error display for select dropdown.
| `Issue #8713 <https://github.com/pgadmin-org/pgadmin4/issues/8713>`_ - Fixed issues related to column range selection using shift + click. | `Issue #8713 <https://github.com/pgadmin-org/pgadmin4/issues/8713>`_ - Fixed issues related to column range selection using shift + click.

8
web/pgadmin/authenticate/ldap.py
View File

@ -187,11 +187,11 @@ class LDAPAuthentication(BaseAuthentication):
"""Add the ldap user to the internal SQLite database.""" """Add the ldap user to the internal SQLite database."""
if config.LDAP_AUTO_CREATE_USER: if config.LDAP_AUTO_CREATE_USER:
if config.LDAP_DN_CASE_SENSITIVE: if config.LDAP_DN_CASE_SENSITIVE:
user = User.query.filter_by(username=self.username).first() user = User.query.filter_by(username=self.username,
auth_source=LDAP).first()
else: else:
user = User.query.filter( user = User.query.filter_by(username=func.lower(self.username),
func.lower(User.username) == func.lower( auth_source=LDAP).first()
self.username)).first()
if user is None: if user is None:
create_msg = ("Creating user {0} with email {1} " create_msg = ("Creating user {0} with email {1} "

2
web/pgadmin/static/js/helpers/ModalProvider.jsx
View File

@ -106,7 +106,7 @@ function confirmDelete(title, text, onDeleteClick, onCancelClick, deleteLabel =
title, title,
(closeModal)=>{ (closeModal)=>{
const handleOkClose = (callback) => { const handleOkClose = (callback) => {
callback(); callback?.();
closeModal(); closeModal();
}; };
return ( return (