mirror of https://github.com/milvus-io/milvus.git
### Summary Follow-up to #48152 which applied denylist retry to parquet/json/csv imports but missed two other paths. - **fix(High)**: `pack_writer.go` `writeLog` now skips retry only for non-retryable errors (permission denied, bucket not found, invalid credentials, etc.), matching the denylist strategy in `retryable_reader.go`. - **fix(Medium)**: Binlog import's `WithDownloader` callbacks now use `multiReadWithRetry`, skipping retry only for non-retryable errors. Previously all transient failures were not retried. - **fix(Low)**: `IsMilvusError` in `merr/utils.go` switched from `errors.Cause` (root only) to `errors.As` (full chain traversal). ### Out of Scope - `pack_writer_v2.go` / `pack_writer_v3.go` — same retry pattern but different code path (multi-part upload); separate fix. - `writeDelta` — no retry wrapper; separate concern. issue: #48153 --------- Signed-off-by: Yihao Dai <yihao.dai@zilliz.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| errors.go | ||
| errors_test.go | ||
| utils.go | ||
| utils_test.go | ||