mirror of https://github.com/milvus-io/milvus.git
4fd56e4773
issue: #39001 pr: #39000 Background: Segment Load Version: Each segment load request assigns a timestamp as its version. When multiple copies of a segment are loaded on different QueryNodes, the leader checker uses this version to identify the latest copy and updates the routing table in the leader view to point to it. Delegator Router Version: When a delegator builds a route to a QueryNode that has loaded a segment, it also records the segment's version. Router Table Update Logic: If the leader checker detects that the version of a segment in the routing table does not match the version in the worker, it updates the routing table to point to the QueryNode with the latest version. Additionally, it updates the segment's load version in the QueryNode during this process. Issue: When a channel is undergoing load balancing, the leader checker may sync the routing table to a new delegator. This sync operation modifies the segment's load version, which invalidates the routing in the old delegator. Subsequently, the leader checker updates the routing table in the old delegator, breaking the routing in the new delegator. This cycle continues, causing repeated updates and inconsistencies. Fix: This PR introduces two changes to address the issue: 1. Use NodeID to verify whether the delegator's routing table needs an update, avoiding unnecessary modifications. 2. Ensure compatibility by using the latest segment's load version as the version recorded in the routing table. These changes resolve the cyclic updates and prevent the leader checker from generating excessive duplicate tasks, ensuring routing stability across delegators during load balancing. Signed-off-by: Wei Liu <wei.liu@zilliz.com> |
||
|---|---|---|
| .. | ||
| OWNERS | ||
| balance_checker.go | ||
| balance_checker_test.go | ||
| channel_checker.go | ||
| channel_checker_test.go | ||
| checker.go | ||
| controller.go | ||
| controller_base_test.go | ||
| controller_test.go | ||
| index_checker.go | ||
| index_checker_test.go | ||
| leader_checker.go | ||
| leader_checker_test.go | ||
| segment_checker.go | ||
| segment_checker_test.go | ||