Commit Graph

8116 Commits (c5212a42b645c38096fd12be143167ae970c6b73)

Author SHA1 Message Date
Gao 0a122533d0
enhance: change autoindex default metric type (#34328)
issue: #34304 
pr: #34261

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2024-08-02 16:22:20 +08:00
chyezh 923278b75d
enhance: the datacoord gc should fast quitable (#35057)
issue: #35049
pr: #35050

Signed-off-by: chyezh <chyezh@outlook.com>
2024-08-01 14:32:13 +08:00
yihao.dai 289336a617
enhance: Avoid panic due to nil schema (#35063) (#35065)
/kind improvement

issue: https://github.com/milvus-io/milvus/discussions/25620

pr: https://github.com/milvus-io/milvus/pull/35063

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-07-30 20:19:49 +08:00
Jiquan Long 256817da2d
feat: record the number of times milvus turns into force-deny-writing states (#34960) (#34990)
/kind improvement
fix: https://github.com/milvus-io/milvus/issues/34961
pr: #34960

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-07-25 15:45:46 +08:00
zhagnlu a6c3056df3
fix: fix parse plan proto failed for search type (#34945)
pr: #34944

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-07-24 14:59:45 +08:00
SimFG fe786fff57
enhance: [2.3] init the hook when creating the proxy object (#34936)
- issue: #34885
- pr: #34887

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-07-24 13:11:43 +08:00
wei liu 193669b55f
fix: Segment may bounce between delegator and worker (#34889)
issue: #34595
pr: #34830

pr#34596 to we add an overloaded factor to segment in delegator, which
cause same segment got different score in delegator and worker. which
may cause segment bounce between delegator and worker.

This PR use average score to compute the delegator overloaded factor, to
avoid segment bounce between delegator and worker.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-07-23 10:47:44 +08:00
wei liu acee8cfa92
fix: Avoid generate reduce channel task before balance channel finish (#34721)
relate: #29841 #29838
pr: #30087

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-07-23 10:33:45 +08:00
wei liu 464a667e8a
fix: Avoid segment lack caused by deduplicate segment task (#34882)
issue: #34781
pr: #34782
when balance segment hasn't finished yet, query coord may found 2 loaded
copy of segment, then it will generate task to deduplicate, which may
cancel the balance task. then the old copy has been released, and the
new copy hasn't be ready yet but canceled, then search failed by segment
lack.

this PR set deduplicate segment task's proirity to low, to avoid balance
segment task canceled by deduplicate task.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-07-22 16:05:42 +08:00
foxspy 910af16d33
enhance: Update Knowhere version (#34825)
/kind branch-feature

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
2024-07-22 10:17:43 +08:00
Jiquan Long 08c6ab8cfb
feat: record the duration waiting in the proxy queue (#34744) (#34791)
fix: https://github.com/milvus-io/milvus/issues/34743
pr: https://github.com/milvus-io/milvus/pull/34744

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-07-19 15:39:41 +08:00
yihao.dai 3d9ec2ab23
fix: Discard compaction plan when closing dataSyncService (#34737)
issue: https://github.com/milvus-io/milvus/issues/34736

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-07-17 09:49:42 +08:00
xige-16 8e34c4cf8f
fix:[cherry-pick] Fix compatible ascending index typo (#34712)
issue: https://github.com/milvus-io/milvus/issues/34707
pr: https://github.com/milvus-io/milvus/pull/34708

/kind bug

Signed-off-by: xige-16 <xige2016@gmail.com>
2024-07-16 18:55:38 +08:00
wei liu 79c0c78a07
enhance: Preserve fixed-size memory in delegator node for growing segment (#34602)
issue: #34595
pr: #34596

When consuming insert data on the delegator node, QueryCoord will move
out some sealed segments to manage its memory usage. After the growing
segment gets flushed, some sealed segments from other workers will be
moved back to the delegator node. To avoid the frequent movement of
segments, we estimate the maximum growing row count and preserve a
fixed-size memory in the delegator node.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-07-13 10:25:40 +08:00
cai.zhang b5ba5832d3
fix: [cherry-pick] Remove flushed segment in segment manager generated through import (#34650)
issue: #34648 

master pr: #34649

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-07-12 23:15:14 +08:00
congqixia 3c44248105
fix: [2.3] support set up knowhere-build-pool-size on querynode (#34647)
Cherry-pick from master
pr: #30922
Related: #29650

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Co-authored-by: MrPresent-Han <chun.han@zilliz.com>
2024-07-12 19:27:36 +08:00
wei liu d3d192064f
enhance: Avoid assign too much segment/channels to new querynode (#34096) (#34461)
issue: #34095
pr: #34096

When a new query node comes online, the segment_checker,
channel_checker, and balance_checker simultaneously attempt to allocate
segments to it. If this occurs during the execution of a load task and
the distribution of the new query node hasn't been updated, the query
coordinator may mistakenly view the new query node as empty. As a
result, it assigns segments or channels to it, potentially overloading
the new query node with more segments or channels than expected.

This PR measures the workload of the executing tasks on the target query
node to prevent assigning an excessive number of segments to it.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-07-10 14:22:15 +08:00
wei liu 0bfa1a72bb
fix: Indexnode stuck at stopping progress cause by wrong lifetime control (#34560)
issue: #34557
pr: #34558

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-07-10 13:46:13 +08:00
PowderLi cfb5390201
fix: [cherry-pick] [restful v2] count(*) & hook (#34447)
issue: #31224 #34374
pr: #34369(master) #34433(2.4) #34444(2.4.5)

for query api:

1. param filter is not requried
2. param limit is useless while outputFields = [count(*)]

add hook about grpc call

---------

Signed-off-by: PowderLi <min.li@zilliz.com>
2024-07-08 10:40:13 +08:00
congqixia a85e067099
fix: [2.3] Check partition in current target when observing partition load status (#34282) (#34321)
Cherry-pick from master
pr: #34282
See also #34234

`LoadPartitions` does not guarantee the current target has loading
partitions if there are some partitions already loaded before.

This PR check current target contains the partition to load when
advancing loading percentage to 100.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-02 15:54:08 +08:00
congqixia dbbddca582
enhance: [2.3] Refine max length exceeded error message (#34300) (#34324)
Cherry-pick from master
pr: #34300
This PR make varchar & string array field max length exceeded error
message clearer. Also fixed a minor issue that error string format and
argument number not match.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-02 15:30:16 +08:00
congqixia 252cf97e6d
fix: [2.3] Implement singleflight for segcore ChunkCache (#34250) (#34284)
Cherry-pick from master
pr: #34250
See also #34249

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-02 10:30:08 +08:00
wei liu 7a441c39cd
enhance: Optimize grow slice cost during query (#34256)
issue: #32252
pr: #34253

This PR try to pre-allocate FieldData for Reduce operations in the Query
chain using typeutil.PrepareResultFieldData to avoid the overhead of
dynamically growing the slice during appendFieldData process.

Additionally, Upgrade google.golang.org/protobuf from version 1.31 to
1.33 to address the growing slice overhead during the proto unmarshal
repeated field process, as referenced in
[#protobuffer/protobuf-go/](86bdc4705a).

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-07-01 16:46:08 +08:00
xige-16 9de5b15cbb
fix: [cherry-pick]Fix datacoord's properties overwriten (#34147)
issue: #34144 
pr: #34146 
/kind bug

Signed-off-by: xige-16 <xige2016@gmail.com>
2024-06-27 14:04:05 +08:00
xige-16 c566edc053
fix: Fix backup channel meta is empty (#34115)
issue: https://github.com/milvus-io/milvus/issues/34061
pr: https://github.com/milvus-io/milvus/pull/32044
/kind bug

Signed-off-by: xige-16 <xige2016@gmail.com>
2024-06-25 11:48:03 +08:00
aoiasd bff0bd74b0
enhance:[Cherry-Pick] Refine varchar length exceeds max length error message (#31521) (#34034)
pr: https://github.com/milvus-io/milvus/pull/31521

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-06-24 14:50:03 +08:00
SimFG 00b02ee6ae
enhance: [2.3] try to speed up the loading of small collections (#33863)
- issue: #33569
- pr: #33570

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-06-22 11:46:04 +08:00
congqixia ce7bceece9
fix: [2.3] Check nodeID wildcard when removing pkOracle (#33895) (#34022)
Cherry-pick from master
pr: #33895
See also #33894

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-21 17:08:02 +08:00
congqixia 9157980232
fix: [2.3] Return record with largest timestamp for entires with same PK(#33936) (#34026)
Cherry-pick from master
pr: #33936
See also #33883

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-20 19:56:00 +08:00
wei liu ae6d95475d
enhance: Refine name rule check error msg (#33815) (#33901)
pr: #33815

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-06-19 10:58:00 +08:00
congqixia aea3cfefce
fix: [2.3] Prevent use captured iteration variable partitionID (#33912)
Cherry-pick from master
pr: #33906
See also #33902

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-17 23:14:00 +08:00
Min Tian 2e01ae9141
fix: filter results less than topk (#33930)
issue: #33933

Signed-off-by: min.tian <min.tian.cn@gmail.com>
2024-06-17 22:54:01 +08:00
wei liu deb2c7854d
enhance: add restful api to trigger component stop (#32076) (#33798)
issue: #32698
pr: #32076
This PR add two rest api for component stop and status check:
1. `/management/stop?role=querynode` can stop the specified component
2. `/management/check/ready?role=rootcoord` can check whether the target
component is serviceable

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-06-17 20:46:01 +08:00
xige-16 518c86236b
fix: Fix insert not limited when set collection.insertRate.max.mb=0 (#33725)
issue: #33722 
pr: #31070 
/kind bug

---------

Signed-off-by: xige-16 <xige2016@gmail.com>
Signed-off-by: gexi <gexi@didiglobal.com>
Co-authored-by: gexi <gexi@didiglobal.com>
2024-06-17 20:07:59 +08:00
aoiasd 963f601a96
enhance:[Cherry-pick] Check by proxy rate limiter when delete get data by query. (#30891) (#33794)
relate: https://github.com/milvus-io/milvus/issues/30927
pr: https://github.com/milvus-io/milvus/pull/30891

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-06-17 19:36:00 +08:00
wei liu 284e79cf3a
enhance: Execute bloom filter apply in parallel to speed up process delete (#33870)
issue: #33610
pr: #33611 #33793

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-06-17 12:06:04 +08:00
congqixia c62e092463
enhance: [2.3] Make applyDelete work in paralell in segment level (#32291) (#33841)
Cherry-pick from master
pr: #32291
`applyDelete` used to be serial for delete entries on each segments.
This PR make it work in parallel with errgroup to improve performance

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-13 23:09:56 +08:00
congqixia 9d6af07107
fix: [2.3] Write back dbid modification for nonDB id collection (#33641) (#33695)
Cherry-pick from master
pr: #33641
See also #33608

Make `fixDefaultDBIDConsistency` also write back collection dbid
modification when nonDB id collection is found.

This fix shall prevent dropped collections of this kind show up again
after dropping and restart.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-11 10:38:01 +08:00
congqixia 636be02777
enhance: [2.3] Print UseDefaultConsistency param in read requests (#33617) (#33645)
Cherry-pick from master
pr: #33617
`UseDefaultConsistency` param is crucial for debugging slow query
problems. It could be confusing when guarantee timestamp is 1 while this
param is not logged

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-06 14:19:56 +08:00
congqixia 168724b2cd
fix: [2.3] Use milliseconds in apply pk latency metrics for upsert (#33580)
Cherry pick from master
pr: #29987

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-04 16:43:47 +08:00
yihao.dai 6d0e167f69
fix: Fix exception info is missing (#33393) (#33395)
Replace based std::exception to prevent "object slicing"

issue: https://github.com/milvus-io/milvus/issues/33392

pr: https://github.com/milvus-io/milvus/pull/33393

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-06-04 15:19:47 +08:00
Chun Han 0d4ee287e1
fix: query iterator lack results(#33137) (#33468)
related: #33137
pr: https://github.com/milvus-io/milvus/pull/33422

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2024-05-31 13:54:07 +08:00
wayblink d40929857c
fix:[cherry-pick]Panic if ProcessActiveStandBy returns error (#33371)
pr:#33369
issue:#33368

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2024-05-27 10:13:41 +08:00
PowderLi 078f252aa9
fix: [cherry-pick][restful v2]role operations need dbName (#33292)
issue: #33220
master pr: #33283
2.4 pr: #33291

use dbName as part of privilege entity, so
1. grant / revoke a privilege need dbName
2. we can describe the privileges of the role which belong to one
special database

Signed-off-by: PowderLi <min.li@zilliz.com>
2024-05-23 09:57:41 +08:00
cai.zhang 653af7108c
fix: Break the dead loop of downloading binlog during compaction (#33246)
issue: #33245

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-05-22 17:29:40 +08:00
SimFG 1007e6d562
enhance: [2.3] check the auth in some rest v2 api (#33254)
/kind improvement
pr: #33256
link 2.3 proto:
https://github.com/milvus-io/milvus-proto/blob/2.3/proto/milvus.proto

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-05-22 14:43:39 +08:00
Gao eb98f20316
enhance: update knowhere version (#33215)
/kind branch-feature

Fix diskann PQ train dead loop

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2024-05-21 16:37:44 +08:00
Jiquan Long 76b7c23a66
fix: try best to get enough query results (#33177)
issue: https://github.com/milvus-io/milvus/issues/33137
pr: https://github.com/milvus-io/milvus/pull/32567
Co-authored-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: MrPresent-Han <chun.han@zilliz.com>

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-05-21 14:07:45 +08:00
zhenshan.cao 23e7155a48
fix: avoid memoryleak in rendezvousFlushManager (#33112)
issue: https://github.com/milvus-io/milvus/issues/33110

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-05-20 22:19:40 +08:00
Bingyi Sun b073407119
fix: check array field data is nil before getting the type (#33119)
issue: https://github.com/milvus-io/milvus/issues/33074

---------

Signed-off-by: sunby <sunbingyi1992@gmail.com>
2024-05-18 17:18:49 +08:00