Commit Graph

18881 Commits (c46fccb3e9bba54f8f30413de1a0d830ac81e5cd)

Author SHA1 Message Date
zhenshan.cao a689ea3228
feat: Add RBAC functionality to alias (#29885) (#29947)
issue: https://github.com/milvus-io/milvus/issues/29781
issue: https://github.com/milvus-io/milvus-proto/issues/237
pr : https://github.com/milvus-io/milvus/pull/29885

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-01-12 23:36:52 +08:00
jaime fb956536b9
fix: remove checking if running inside container (#29941)
issue: https://github.com/milvus-io/milvus/issues/29846
pr: #29940

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-01-12 21:12:52 +08:00
congqixia 6d8146a09a
enhance: bump milvus & proto version to 2.3.5 (#29946)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-12 20:54:51 +08:00
congqixia 227071a754
enhance: [cherry-pick] reduce delete detail log to delete range (#29916) (#29930)
Cherry-pick from master
pr: #29916
Delete detail log will be large and hard to read when log level is
debug. This PR change the log to stringer and print only pk range,
number.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-12 20:18:51 +08:00
congqixia c21229b7bb
enhance: [cherry-pick] add trace span for wait tsafe (#29911) (#29929)
Cherry-pick from master
pr: #29911 
Add tracing span for search/query operation waiting tsafe duration

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-12 20:17:01 +08:00
aoiasd 128f197797
enhance: [Cherry-Pick] support access log print cluster prefix (#29646) (#29831)
relate: https://github.com/milvus-io/milvus/issues/29645
pr: https://github.com/milvus-io/milvus/pull/29646

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-01-12 18:58:52 +08:00
wei liu 86cddd24b5
enhance: Add ctx for load index logs (#29686) (#29905)
pr: #29686
This PR add ctx for load index logs

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-01-12 18:56:58 +08:00
SimFG d573f0ec1a
fix: [2.3] the delete msg disorder issue (#29917)
/kind improvement
pr: #29915

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-01-12 18:04:50 +08:00
wayblink e1446da83c
feat: [Cherry-pick] Implement DescribeAlias and ListAliases interfaces (#29896)
#22882
pr: #29641

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2024-01-12 16:30:51 +08:00
congqixia c56622dea7
enhance: move confusing warning log to error branch (#29891)
`flushInsertData` & `flushDeleteData` prints WARNING log even there is
no error returned. So move error branch into if block.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-12 15:50:52 +08:00
wei liu 16e7f51033
fix: Dynamic update rate limit config with wrong value (#29902)
pr: #29901 
when apply dynamic config changes, we should format the value to proper
unit
This PR fix update rate limit config with wrong value.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-01-12 15:10:51 +08:00
chyezh 98aae10273
fix: compact operation on datacoord meta should preform as a transcation (#29776)
issue: #29691
pr: #29775

Signed-off-by: chyezh <ye.zhen@zilliz.com>
2024-01-12 14:54:52 +08:00
chyezh 7d3ec9f869
fix: unhealthy datacoord started with unhealthy channel manager (#29849)
issue: #29818
pr: #29848

Signed-off-by: chyezh <ye.zhen@zilliz.com>
2024-01-12 14:24:54 +08:00
wei liu 5520bfbb05
enhance: Change some frequency log to rated level (#29720) (#29903)
pr: #29720
This PR change some frequency log to rated level

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-01-12 11:46:52 +08:00
yah01 4edcd4d22b
fix: the insert count is zero after set the pointer to nil (#29870) (#29881)
this leads to the EntitiesNum metric would be never reduced

fix: #29766
pr: #29870

Signed-off-by: yah01 <yang.cen@zilliz.com>
2024-01-12 10:20:51 +08:00
chyezh f0db26107c
fix: panic caused by type assert LocalSegment on Segment (#29018) (#29900)
- Make implementation of LocalWorker and RemoteWorker same.

issue: #29017, #29899
pr: #29018

Signed-off-by: yah01 <yah2er0ne@outlook.com>
Co-authored-by: yah01 <yah2er0ne@outlook.com>
2024-01-12 10:08:50 +08:00
sre-ci-robot ef7e4aea43
[automated] Update Pytest image changes (#29865)
Update Pytest image changes
See changes:
b580aef4dc
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-01-12 09:46:58 +08:00
sre-ci-robot 4e928e5093
[automated] Update Builder gpu image changes (#29877)
Update Builder gpu image changes
See changes:
b580aef4dc
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-01-12 09:45:05 +08:00
jaime c0b711e9fb
enhance: Support read hardware metrics for cgroupv2 (#29847)
issue: #29846
pr: #29850

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-01-11 19:20:57 +08:00
congqixia 00c0a5a2ab
enhance: [Cherry-pick] make Load process traceable in querycoord (#29806) (#29869)
Cherry-pick from master
pr: #29806
See also #29803

This PR:
- Add trace span for collection/partition load
- Use TraceSpan to generate Segment/ChannelTasks when loading
- Refine BaseTask trace tag usage

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-11 18:00:52 +08:00
congqixia cd93954214
enhance: [Cherry-pick] pre-allocate result FieldData space to reduce growslice (#29726) (#29866)
Cherry-pick from master
pr: #29726

See also: #29113

Add a new utitliy function in `pkg/util/typetuil` to pre-allocate field
data slice capacity acoording to search limit. This shall avoid copying
the data during `AppendFieldData` when previous slice is out of space.
And shall also save CPU time during high paylog.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-11 17:59:01 +08:00
wei liu 603cd1fb3f
fix: Drop segment meta info with prefix (#29857)
pr: #29856
If segment has more than 128 log fils, drop segment will exceed etcd txn
ops limit, which will failed the drop segment request
This PR drop segment meta info with prefix, to avoid drop segment meta
failed

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-01-11 15:02:50 +08:00
wei liu 322e9f39a3
fix: Remove Unnecessary lock in config manager (#29855)
issue: #29709 #291712
pr: #29836
to avoid concurrent recursive RLock and Lock cause deadlock, This PR
remove the unnecessary lock in config manager

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-01-11 15:01:01 +08:00
zhenshan.cao 7cf2be09b5
fix: Restore the MVCC functionality. (#29749) (#29802)
When the TimeTravel functionality was previously removed, it
inadvertently affected the MVCC functionality within the system. This PR
aims to reintroduce the internal MVCC functionality as follows:

1. Add MvccTimestamp to the requests of Search/Query and the results of
Search internally.
2. When the delegator receives a Query/Search request and there is no
MVCC timestamp set in the request, set the delegator's current tsafe as
the MVCC timestamp of the request. If the request already has an MVCC
timestamp, do not modify it.
3. When the Proxy handles Search and triggers the second phase ReQuery,
divide the ReQuery into different shards and pass the MVCC timestamp to
the corresponding Query requests.

issue: #29656
pr: #29749

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-01-11 14:42:49 +08:00
yah01 e7e4561da8
fix: the entities num metric may be contributed more than once (#29767) (#29825)
the growing segments contribute to this metric while inserting and
putting into the manager, but the current impl inserts data before
putting the segments into manager, which leads to double contributions

fix: #29766
pr: #29767

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2024-01-11 10:24:51 +08:00
sammy.huang b580aef4dc
enhance: [skip e2e]We aim to cancel the previously initiated job exclusively during PR (#29859)
PR: https://github.com/milvus-io/milvus/pull/29797
 
enhance: We aim to cancel the previously initiated job or workflow
exclusively during the Pull Request (PR) stage

Signed-off-by: Sammy Huang <sammy.huang@zilliz.com>
2024-01-11 10:00:51 +08:00
XuanYang-cn 1128b1dd67
fix: [cherry-pick]Save lite WatchInfo into etcd in DataNode (#29751)
See also: #29689
pr: #29687

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-01-10 20:48:50 +08:00
zhenshan.cao 9d2847ef2b
enhance: update milvus-proto to support rbac for alias (#29798)
issue: https://github.com/milvus-io/milvus/issues/29781
issue: https://github.com/milvus-io/milvus-proto/issues/237
Update the protocol to support the RBAC functionality for aliases

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-01-10 10:12:50 +08:00
congqixia 6c9a5e347e
fix: [cherry-pick] Assertion all async invocations in test case (#29737) (#29782)
Cherry-pick from master
pr: #29737
Resolves: #29736

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-09 17:48:49 +08:00
yah01 38c61594c0
enhance: use GPU pool for gpu tasks (#29678) (#29706)
- this much improve the performance for GPU index
- this also reduce 1x copy while parsing index meta
pr: #29678

Signed-off-by: yah01 <yang.cen@zilliz.com>
2024-01-09 14:04:48 +08:00
zhenshan.cao 8c2ca3fb79
feat: Authorize users to query grant info of their roles (#29747) (#29762)
Once a role is granted to a user, the user should automatically possess
the privilege information associated with that role.

issue: #29710
pr: #29747

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-01-08 18:06:49 +08:00
congqixia 0c83440f99
enhance: [Cherry-pick] cache collection schema attributes to reduce proxy cpu (#29668) (#29692)
Cherry-pick from master
pr: #29668

See also #29113

The collection schema is crucial when performing search/query but some
of the information is calculated for every request.

This PR change schema field of cached collection info into a utility
`schemaInfo` type to store some stable result, say pk field,
partitionKeyEnabled, etc. And provided field name to id map for
search/query services.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-07 22:36:48 +08:00
Jiquan Long 03a375ac82
enhance: [skip-e2e] auto cancel stale workflows (#29145) (#29193)
/kind improvement
pr: #29145

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-01-07 20:06:51 +08:00
PowderLi 9e7974a2c6
fix:[CHERRY_PICK] link with install path's libblob-chunk-manager (#29731)
issue: #29494
pr: #29496


1. link with install path's libblob-chunk-manager
2. performance of `ShouldBindWith` is better than `ShouldBindBodyWith`
3. the middleware shouldn't read the unrefreshed parameter repeatly
4. diff from old restful, named HandlersV1

Signed-off-by: PowderLi <min.li@zilliz.com>
2024-01-07 19:52:49 +08:00
yah01 58410d8b62
enhance: skip loading duplicated index (#29715) (#29716)
this protect the loading index from failure, and speed up the loading
progress
pr: #29715

Signed-off-by: yah01 <yang.cen@zilliz.com>
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2024-01-07 17:00:48 +08:00
wei liu 4088b00602
enhance: Rewrite gen segment plan based on assign segment (#29574) (#29684)
issue: #29582
pr: #29574
This PR rewrite gen segment plan logic based on assign segment in
`score_based_balancer`

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-01-06 09:58:49 +08:00
PowderLi cb355cacce
enhance: get a blob to check object storage config (#29705)
issue: #29672
master pr: #29703

the storage account need privileges of actions
`Microsoft.Storage/storageAccounts/blobServices/containers/blobs/*` at
least

Signed-off-by: PowderLi <min.li@zilliz.com>
2024-01-05 18:02:47 +08:00
smellthemoon fcd23e2ec2
enhance:Add upsert vector metrics(#29226) (#29674)
pr: https://github.com/milvus-io/milvus/pull/29226

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-01-05 15:44:47 +08:00
congqixia fc65f01ddd
enhance: [Cherry-pick] Cache segment row num, size, and insert count to reduce CGO calls (#28007) (#29679)
Cherry pick from master
pr: #28007
See also #29650

Signed-off-by: yah01 <yah2er0ne@outlook.com>
Co-authored-by: yah01 <yah2er0ne@outlook.com>
2024-01-04 23:04:47 +08:00
cai.zhang 2d64cd780c
enhance: Read azure file without ReadAll (#29604)
issue: #29292 
master pr: #29602

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-01-04 20:52:48 +08:00
yah01 3c3fc160e9
fix: make the entity num metric accurate (#29643) (#29644)
fix https://github.com/milvus-io/milvus/issues/29642
pr: #29643

Signed-off-by: yah01 <yang.cen@zilliz.com>
2024-01-04 19:26:47 +08:00
congqixia cf228c2f1c
fix: Print number of pks instead of delete pk val (#29653)
See also #29445

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-04 10:02:46 +08:00
zhuwenxing 6bf46c6fac
test: update bulk insert bench test (#29535)
update bulk insert bench test
cherry-pick from master
pr: https://github.com/milvus-io/milvus/pull/29534

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-01-03 19:16:55 +08:00
nico b07dbea7fb
enhance: update pymilvus version (#29600)
Signed-off-by: nico <cheng.yuan@zilliz.com>
2024-01-03 15:30:48 +08:00
SimFG a2365e4b2a
enhance: [2.3] Add concurrency for datacoord segment GC (#29557)
issue: #29553
pr: https://github.com/milvus-io/milvus/pull/29561
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-01-03 13:16:57 +08:00
foxspy 66c84655d8
fix: [Cherry-pick] throw exception when upload file failed for DiskIndex (#29628)
Cherry pick from master
pr: #29627 
related to: #29417

Signed-off-by: xianliang <xianliang.li@zilliz.com>
2024-01-03 11:10:47 +08:00
MrPresent-Han 757834602a
enhance: add param for bloomfilter(#29388) (#29614)
related: https://github.com/milvus-io/milvus/issues/29388
pr: https://github.com/milvus-io/milvus/pull/29490

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2024-01-02 18:58:47 +08:00
Jiquan Long 7a373bec46
enhance: print total memory when milvus starts (#29351) (#29352)
issue: #29349 
pr: #29351

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-12-31 17:42:47 +08:00
cai.zhang 0902e5aada
enhance: [Pick]Support azurite docker for develope env (#29140)
master pr: #29021

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-12-31 17:18:37 +08:00
sammy.huang ac1b1b01d1
enhance: [skip e2e][automated] Bump milvus version to v2.3.4 (#29605)
Signed-off-by: Sammy Huang <sammy.huang@zilliz.com>
2023-12-30 07:38:45 +08:00