Commit Graph

19817 Commits (be87ae6424242c10621fb9ada183d401a3d7c8be)

Author SHA1 Message Date
aoiasd d0ffb71a17
enhance: forbid delete with always true expression (#32472)
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-04-22 11:09:23 +08:00
congqixia d7ff1bbe5c
enhance: Make querycoordv2 collection observer task driven (#32441)
See also #32440

- Add loadTask in collection observer
- For load collection/partitions, load task shall timeout as a whole
- Change related constructor to load jobs

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-22 10:39:22 +08:00
zhuwenxing 8442098457
test: skip index if it already created (#32402)
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-04-22 10:37:22 +08:00
Cai Yudong 5fc439c600
feat: Bulk insert support fp16/bf16 (#32157)
Issue: #22837

Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
2024-04-22 10:05:22 +08:00
yiwangdr 037de8e4d3
enhance: speed up minor functions calls in datacoord (#32389)
Related to https://github.com/milvus-io/milvus/issues/32165

1. nodeid based channel store access should use map access instead of
iteration.

2. The join-ish functions calls are slow when # collections/segments
increases (e.g. 10k).
e.g.
getNumRowsOfCollectionUnsafe is O(num_segments); GetAllCollectionNumRows
is of O(num_collections*num_segments).

Signed-off-by: yiwangdr <yiwangdr@gmail.com>
2024-04-20 07:55:21 +08:00
zhagnlu 93f0c262c1
fix: add bitset sve support macro protect (#32463)
#32137

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-04-19 18:05:21 +08:00
Ted Xu 744a54a534
enhance: enforce milvus.yaml assertion in UT (#32357)
See #32168

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
2024-04-19 16:47:20 +08:00
XuanYang-cn 7e830f6185
fix: [skip-e2e] TestAvgReassignPolicy ut (#32450)
See also: #32448

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-04-19 15:11:20 +08:00
congqixia 01c16fe6e3
enhance: Manual release pool after save targets (#32358)
See also #31632

Release conc.Pool after usage to clean worker and stop background purge
and ticktock.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-19 13:51:21 +08:00
SimFG 8594b55ad5
enhance: add `max insert request size` and `must use partition key` configs (#32433)
issue: https://github.com/milvus-io/milvus/issues/30577
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-04-19 10:31:20 +08:00
SimFG 31a29a2451
enhance: avoid the repeated metric info in the proxy (#32380)
issue: #30577

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-04-19 10:21:20 +08:00
jaime 18c3cbe46d
enhance: Update tls user doc (#32353)
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-04-18 21:07:23 +08:00
zhuwenxing 109cd0402f
test: fix delete expr (#32377)
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-04-18 17:25:20 +08:00
zhuwenxing 2cff65511c
test: use float32 to do import (#32276)
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-04-18 17:23:27 +08:00
sammy.huang 2a4dfde2de
enhance: revert [skip e2e] use pull_request_target event instead (#32426)
This reverts commit ab6ddf6929.

Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
2024-04-18 17:15:37 +08:00
nico e83651def4
test: update test cases (#32396)
Signed-off-by: nico <cheng.yuan@zilliz.com>
2024-04-18 16:15:25 +08:00
sammy.huang 66fae53cd2
enhance: hotfix HOME variable (#32411)
Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
2024-04-18 14:49:26 +08:00
PowderLi a0a23d0666
fix: [restful]use default search parameter `nq: 0` (#32355)
issue: #32225 #31978 #32360

1. v1 can only accept one vector, but v2 accept list of vectors #32225
2. cannot get dbName from AliasReq #31978
3. enhance: [restful v2]support config DB-Name in the http header #32360

---------

Signed-off-by: PowderLi <min.li@zilliz.com>
2024-04-18 14:41:20 +08:00
zhagnlu e2c38750c7
fix: modify retry error (#32351)
#32322

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-04-18 14:25:14 +08:00
sammy.huang 70beec3e47
enhance: hotfix HOME variable (#32405)
Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
2024-04-18 13:08:32 +08:00
sammy.huang d343d2f3fc
enhance: add vcpkg for rockylinux8 (#32300)
issues:#32299

Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
2024-04-18 11:05:20 +08:00
presburger e2541f04eb
fix: crash on arm64 (#31951) (#31980)
issue: #31953

Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>
2024-04-17 18:03:20 +08:00
zhenshan.cao 02f17b842a
fix: fix incomplete hybrid search result when nq > 1 (#32177)
issue: https://github.com/milvus-io/milvus/issues/25639

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-04-17 17:09:32 +08:00
Jiquan Long 7add7248e2
fix: remove useless log of quota center (#32307)
/kind improvement
issue: #31272

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-04-17 16:17:19 +08:00
chyezh a8c8a6bb0f
fix: parameter check of TransferReplica and TransferNode (#32297)
issue: #30647 

- Same dst and src resource group should not be allowed in
`TransferReplica` and `TransferNode`.

-  Remove redundant parameter check.

Signed-off-by: chyezh <chyezh@outlook.com>
2024-04-17 15:27:19 +08:00
zhuwenxing 3e2314ebee
test: add negative import testcase (#32163)
add negative import testcase

---------

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-04-17 10:59:31 +08:00
smellthemoon d1ef0a81ee
enhance: [skip e2e] change some long logs (#32309)
<img width="1042" alt="image"
src="https://github.com/milvus-io/milvus/assets/64083300/8daa9ab9-1988-4398-a92a-7d2dac2cd8cd">
change this log

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-04-17 10:25:19 +08:00
yiwangdr 7deda4d5e9
enhance: speed up GetByCollectionAndNode (#32232)
Related to https://github.com/milvus-io/milvus/issues/32165

Avoid iterating through all replicas/collections if possible. Iteration
is expensive when there are large number of replicas/collections.

Signed-off-by: yiwangdr <yiwangdr@gmail.com>
2024-04-17 10:23:25 +08:00
sre-ci-robot f0f2f11189 Update all contributors
Signed-off-by: sre-ci-robot <sre-ci-robot@zilliz.com>
2024-04-17 00:01:28 +00:00
zhagnlu 4586bcef9f
fix: correct AssignSegmentID return and add retry for loadCollectionF… (#32335)
#32322
#31942

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-04-16 10:20:10 -07:00
madogar 919df4cd02
enhance: changes to propagate traceid from client (#32264)
https://github.com/milvus-io/milvus/issues/32321

Issue Description:
Tracing is an important means of identifying bottleneck points in a
system and is crucial for debugging production issues. Milvus(or any DB)
is generally the most downstream system for an user call -- a user call
can originate from UI and pass through multiple components, in
micro-services architecture, before reaching Milvus.
So, when an user experiences a glitch, one would debug the call trace
via logs using a common trace id. As of now, Milvus generates a new
trace id for every call and this request is to make sure client can pass
the trace id which will be used for all the logs across the Milvus
sub-components so that one can fetch logs for a user call across the
components -- including Milvus.

Signed-off-by: Shreesha Srinath Madogaran <smadogaran@salesforce.com>
Co-authored-by: Shreesha Srinath Madogaran <smadogaran@salesforce.com>
2024-04-17 01:13:20 +08:00
zhuwenxing 84c69f59a3
test: add retry for restful testcases (#32318)
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-04-16 23:03:21 +08:00
sammy.huang 184d8000a9
enhance: hotfix for pipeline (#32339)
pr: #32338

Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
2024-04-16 22:58:42 +08:00
zhuwenxing ae5e3a4fe3
test:[skip e2e]update script to get image tag (#32334)
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-04-16 20:29:19 +08:00
nico f0caf3a2da
test: update some cases (#32323)
Signed-off-by: nico <cheng.yuan@zilliz.com>
2024-04-16 20:27:32 +08:00
sammy.huang 15b9319523
enhance: hot fix publish pipeline (#32330)
Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
2024-04-16 19:48:15 +08:00
congqixia 72c172a7d7
enhance: Remove duplicated collectionID label for task latency (#32308)
`CollectionID` already exists in channel name, so remove it to save
metrics traffic.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-16 18:55:19 +08:00
SimFG 84f05ba66e
enhance: make the auth error message more suitable (#32253)
/issue: #32252
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-04-16 16:47:19 +08:00
Ted Xu 78d32bd8b2
enhance: update milvus.yaml (#31832)
See #32168

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
2024-04-16 16:17:19 +08:00
congqixia 83da08c388
enhance: Use map instead of slice to maintain channel info (#32273)
See also #32165

`ChannelManager.Match` is a frequent operation for datacoord. When the
collection number is large, iteration over all channels will cost lots
of CPU time and time consuming.

This PR change the data structure storing datanode-channel info to map
avoiding this iteration when checking channel existence.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-16 15:57:19 +08:00
zhuwenxing 520a302f3a
test:[skip e2e]fix get image tag (#32306)
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-04-16 15:53:19 +08:00
zhagnlu 9248a6a149
fix: remove sve flags (#32270)
#32129

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-04-16 15:21:19 +08:00
yihao.dai 558feed5ed
fix: Use pk from binlog during import (#32118)
During binlog import, even if the primary key's autoID is set to true,
the primary key from the binlog should be used instead of being
reassigned.

issue: https://github.com/milvus-io/milvus/discussions/31943,
https://github.com/milvus-io/milvus/issues/28521

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-04-16 14:51:20 +08:00
chyezh e19d17076f
fix: delete may lost when enable lru cache, some field should be reset when ReleaseData (#32012)
issue: #30361

- Delete may be lost when segment is not data-loaded status in lru
cache. skip filtering to fix it.

- `stats_` and `variable_fields_avg_size_` should be reset when
`ReleaseData`

- Remove repeat load delta log operation in lru.

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2024-04-16 11:17:20 +08:00
Gao 55d894bd5e
enhance: support disable search optimization (#32141)
Signed-off-by: chasingegg <chao.gao@zilliz.com>
2024-04-16 10:51:20 +08:00
SimFG 1af084ea6b
enhance: Make datanode exit and case `TestProxy` faster (#32218)
/kind improvement
issue: #32219

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-04-16 10:49:20 +08:00
nico 7f0c56ad0a
test: update some cases (#32018)
fix: #31958

Signed-off-by: nico <cheng.yuan@zilliz.com>
2024-04-16 10:17:20 +08:00
sammy.huang df2ca7f312
enhance: use openblas-devel instead (#32284)
Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
2024-04-15 22:14:43 +08:00
sammy.huang 053347637b
enhance: add openblas-devel (#32049)
Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
2024-04-15 19:47:20 +08:00
binbin 6db4565656
test: enable bf16/f16 test cases for DISKANN index (#32257)
issue: #30793

Signed-off-by: binbin lv <binbin.lv@zilliz.com>
2024-04-15 19:41:19 +08:00